From patchwork Tue Oct 20 12:03:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 81591 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD92EA04DC; Tue, 20 Oct 2020 14:03:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13A44BAD6; Tue, 20 Oct 2020 14:03:15 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 139E6BAD4 for ; Tue, 20 Oct 2020 14:03:12 +0200 (CEST) IronPort-SDR: sP0UODxM9NSosWXGJ24JRTW0enMsFd8JEl8Rb3kq/3gywzIXuBFcrU4Np6T68FQd/cxpUaplmc GmOwuE5l+edw== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="167284965" X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="167284965" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 05:03:10 -0700 IronPort-SDR: UaBUwpjz3MelgAZKZWY9yNbxGkOA7ULWC/WrDTcLOqdRi5/i1Q870++Gpo55J54sUQIhzwYXIb VjE5snw4+nAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="359155464" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga007.jf.intel.com with ESMTP; 20 Oct 2020 05:03:07 -0700 From: Ferruh Yigit To: Ray Kinsella , Neil Horman Cc: Ferruh Yigit , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Konstantin Ananyev , Matan Azrad , Olivier Matz , Jerin Jacob Date: Tue, 20 Oct 2020 13:03:05 +0100 Message-Id: <20201020120305.1516513-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [dpdk-dev] [RFC] doc: announce max Rx packet len field deprecation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Ferruh Yigit Acked-by: Konstantin Ananyev --- Cc: Thomas Monjalon Cc: Andrew Rybchenko Cc: Konstantin Ananyev Cc: Matan Azrad Cc: Olivier Matz Cc: Jerin Jacob --- doc/guides/rel_notes/deprecation.rst | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 8ceb385141..d4a31392d3 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -149,6 +149,31 @@ Deprecation Notices will be limited to maximum 256 queues. Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. +* ethdev: In ``struct rte_eth_rxmode``, ``uint32_t max_rx_pkt_len`` will be + replaced by a new ``uint32_t mtu`` in v21.11. + The new ``mtu`` field will be used to configure the initial device MTU via + ``rte_eth_dev_configure()`` API. + Later MTU can be changed by ``rte_eth_dev_set_mtu()`` API as done now. + The existing ``(struct rte_eth_dev)->data->mtu`` variable will be used to store + the configured ``mtu`` value, + and this new ``(struct rte_eth_dev)->data->dev_conf.rxmode.mtu`` variable will + be used to store the user configuration request. + Unlike ``max_rx_pkt_len``, which was valid only when ``JUMBO_FRAME`` enabled, + ``mtu`` field will be always valid. + When ``mtu`` config is not provided by the application, default ``RTE_ETHER_MTU`` + value will be used. + Driver is responsible from updating ``(struct rte_eth_dev)->data->mtu`` after MTU + set successfully, either by ``rte_eth_dev_configure()`` or ``rte_eth_dev_set_mtu()``. + + Application may need to configure device for a specific Rx packet size, like for + cases ``DEV_RX_OFFLOAD_SCATTER`` is not supported and device received packet size + can't be bigger than Rx buffer size. + To cover these cases application needs to know the device packet overhead to be + able to calculate the ``mtu`` corresponding to a Rx buffer size, for this + ``(struct rte_eth_dev_info).max_rx_pktlen`` will be kept, + the device packet overhead can be calculated as: + ``(struct rte_eth_dev_info).max_rx_pktlen - (struct rte_eth_dev_info).max_mtu`` + * cryptodev: support for using IV with all sizes is added, J0 still can be used but only when IV length in following structs ``rte_crypto_auth_xform``, ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal