From patchwork Thu Oct 8 18:48:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 80074 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6F4FA04BC; Thu, 8 Oct 2020 20:49:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 84A7F1B69F; Thu, 8 Oct 2020 20:49:22 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 8A8111B67B for ; Thu, 8 Oct 2020 20:49:21 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 098IULRm004200 for ; Thu, 8 Oct 2020 11:49:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=pfpt0220; bh=JaucPTJDx1Kx6zc4z+XlwynHa4qo9xPtgUEPdvqTCeI=; b=SzQAYrMLPN96kzsAVp2ukeQqjFo3OFhWzhwTdh1Tny0qQ1OzzRMBdEsk4Ij0/kSVkWTl j0Kcc/iK1rcMFqcCxtQOy9LZ2GUtnuRV1A8pRWLfiw2fu18zYU5Uyxmy8q3c1SgQTZTc oWUuoz41SNV6awNCrjVgF7pV5gTguY8/CzVHROfymAu81edQyUueAB0/SnfUApEr0e+t UdZeo6eAN6xQNA1oDGZABtjVkHovg0+budDyONQdxQOpUx/s6272o4GQVXiMOrMvJYhY ynJ7NBOz56Fte+vSysusi8kxkiGuhCWN31QU/mP0oE68YEJ4JeXX5Fx/NbVdI8ThZ5Pp rg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 33xpnq23tx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 08 Oct 2020 11:49:19 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 8 Oct 2020 11:49:18 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 8 Oct 2020 11:49:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G51LJcrLrfRjjVBuGCVDZNrmOpUTW4o+x2Vab/zib5v0HlK6Fmj7IDfVUp7HW9JoC1hgoaxfTr5b+KSBPwUOiWc9P679b0KwzBYGzmHOXE4oqtEYjuD+sNqLo9/zduMeP+2bRGcrWY7+DZ4sSsCEIievkx/+bHic6GVmW8rO73cSImzTjd9pyGFIYbQWuY1BJtW+RsWWq1gsZIibIfx28K5eIuKi8PMTxGpL6Zn65ZmMASvsbrZy7PTNXBT/2XuWXAwNo3oFMQQ0W4TZDRmV7FN8VDvmRvSSzWquRwk7BGIpgb4o+SXl8sztHL/KqbV/4D/UuTDsv+Xa6TG2J1CPuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JaucPTJDx1Kx6zc4z+XlwynHa4qo9xPtgUEPdvqTCeI=; b=BtC8flj1l6sUqyHwjo//yPqzF0mQHMRuaJ2xbEqA7B/cscIRy9HBtDitt4soWIgA3Yo8PSVpN9SpcwD4YWjzQU9mYcqceKjc2dvJj3BWK1JDoneP/H5SK33Vc3VEOhVZ7HOU7AsFwRUuM6PcLvn7BJjvhFcSSTuOxY2zrJuOhd2AeyGZ+GsctwACxuaU1REe+w8TgeGQeR2ed92ntzJAq5Q/QSHRicz+pn9u44QMuYNbo1zuaqSQDyl9925gQpW30ox7vP8Dr1bngkUlC4G2xMusyWneDy93Nxa/5UMbO+nU+x/EMctswMD2sZuS4hcl5t7aUWGgK1tnnYFY9SPQVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JaucPTJDx1Kx6zc4z+XlwynHa4qo9xPtgUEPdvqTCeI=; b=Xsr6JqL7TinIHQaEMSsQwrga+H5adQQEqMUW86kobMgVSceVVC8l5S7PIQwpOu1DM1Xz/jyt6Bwfrqa07JMxsU4MfdD2lzSF7CMO1/j0OUl+Hp6yuk81uksn/muMGMxYreUaI0p5SDxr94f6nwVXPtS1J4mXJFAR3QPnlLr5n4o= Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MW2PR18MB2169.namprd18.prod.outlook.com (2603:10b6:907:5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Thu, 8 Oct 2020 18:49:14 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19%7]) with mapi id 15.20.3455.023; Thu, 8 Oct 2020 18:49:14 +0000 From: Harman Kalra To: Pavan Nikhilesh , Jerin Jacob CC: Date: Fri, 9 Oct 2020 00:18:43 +0530 Message-ID: <1602182927-18254-1-git-send-email-hkalra@marvell.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from hkarlara-OptiPlex-3046.marvell.com (1.6.215.26) by BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3455.21 via Frontend Transport; Thu, 8 Oct 2020 18:49:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f4a0cac-0c76-4ea6-b61d-08d86bbada00 X-MS-TrafficTypeDiagnostic: MW2PR18MB2169: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YYOCUfqr6vo/Y/c+0vVbPek/bj1BRQaNMLSd7aYI1ROJChzOZC39HUaK4YWWT9hCitqZiWX/7c8Q2cmxDyxj3HH88oYzx8vEMtZ7Q/6hPK+ARiuUbeTq+YzmNZasAGTpCOa6tWC4Cy91F647cQsLHxGDa6FYE0KY4L6RVWCWz6XAdQKJWTo3BVljilhoLIEcfENma7+dTxnQZtMzxkMCTgOy66CsnSIfW7axnCcrS7Jzo49iVpkGzUo1baWpXkBoXZF5ggs2GJrUC/d0FvLUvJM26K5A0ivEclJOsY7xfqdoiXTJwGLQ4wZ4SCqMN8I/u1uz4QFpjiuZl78xlgWq0bP7YMnYsEE0VH2Sw1QUeuMD9MfqcCcVpiMj/3Gsr4UNZrZFsq9bng4wKURKuQA3SQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(956004)(6636002)(8936002)(86362001)(6486002)(2616005)(478600001)(8676002)(83380400001)(4326008)(7696005)(2906002)(316002)(110136005)(6666004)(52116002)(1006002)(66946007)(26005)(186003)(36756003)(66476007)(66556008)(16526019)(5660300002)(36456003)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 77tNlgM/bjj0ClJQZm1hOI/SGcJUBD8T0JTj1VdlJD+jIIFivX0C1ktqJiLiBiN8awmDy+bCqYVL3Udi4arYuDiHTNvlvHZHpZ4mwIIbHTPB00ZbmeoTgJytP4i5hYLpgAfeQ1vQRPW2ZneF1tezZnCukpPV4SyNh4j8sUyaoU8UEA6E9NrjbIKf/9HxIWppC/T/DPeGSysPqFj60y8hoTywM9dbGkYrzUIWzwrkra8WXZCxZsljuVJVFEbdevxRolNYF9gVCesNS3mf29W+f5e7GnuJsFx3HzM8APNpgepcMgxNwCzWNHHURSJE5QemcDc0zesbSlxWQ6hp5WO4OpejiuCYBCJOHs4P9/y68Da/QZLHyqMpFLD3KqGTRw2yTaxeoNwHM1KPMy6zQp0z9g1LO9fMOSqPG9Hx9cMTg7jnTAXlyYMEaGFZEbk6LeYHE0WfMYqFQKzv2zdSn8YH4hmXaVlPx+0Imz27SjK+4/Yydr/baB0RwNPlaqIqkXtRq4wSw0b3MWVRAfvDfw/IWZa/Ts9fa9KgYckrcd+2qH+BzXqZcomqVOLy7YvrscFH+NhA4vMPlNVISaQWFkWBQ+umAxlPMOhzA3qSwMQ2wfxj43C6sowOPDhWkA1bQ7FsxeDEXTtMxnau3uE6VOYfqQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 9f4a0cac-0c76-4ea6-b61d-08d86bbada00 X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2020 18:49:14.0753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OsRerxcJJgVK96OPoTQTbOZErN1i+6mdPU0VgfL0OLEk2z6IvPrbMXo9LeLP8ot9O8E1bLafVj+DRAc45k9p9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2169 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-08_12:2020-10-08, 2020-10-08 signatures=0 Subject: [dpdk-dev] [PATCH v2 1/4] event/octeontx2: add switch tag flush op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh Add SWTAG flush operation at the end of transmit sequence to immediately release the tag held by the core. Reuse Tag address to check SWTAG completion status. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 2 +- drivers/event/octeontx2/otx2_evdev.h | 18 +++++++++--------- drivers/event/octeontx2/otx2_worker.h | 27 +++++++++++++-------------- 3 files changed, 23 insertions(+), 24 deletions(-) diff --git a/drivers/event/octeontx2/otx2_evdev.c b/drivers/event/octeontx2/otx2_evdev.c index b8b57c388..faf8a5f17 100644 --- a/drivers/event/octeontx2/otx2_evdev.c +++ b/drivers/event/octeontx2/otx2_evdev.c @@ -771,7 +771,7 @@ sso_set_port_ops(struct otx2_ssogws *ws, uintptr_t base) ws->tag_op = base + SSOW_LF_GWS_TAG; ws->wqp_op = base + SSOW_LF_GWS_WQP; ws->getwrk_op = base + SSOW_LF_GWS_OP_GET_WORK; - ws->swtp_op = base + SSOW_LF_GWS_SWTP; + ws->swtag_flush_op = base + SSOW_LF_GWS_OP_SWTAG_FLUSH; ws->swtag_norm_op = base + SSOW_LF_GWS_OP_SWTAG_NORM; ws->swtag_desched_op = base + SSOW_LF_GWS_OP_SWTAG_DESCHED; } diff --git a/drivers/event/octeontx2/otx2_evdev.h b/drivers/event/octeontx2/otx2_evdev.h index 873724dd4..9577d867d 100644 --- a/drivers/event/octeontx2/otx2_evdev.h +++ b/drivers/event/octeontx2/otx2_evdev.h @@ -162,15 +162,15 @@ struct otx2_sso_evdev { struct otx2_timesync_info *tstamp; } __rte_cache_aligned; -#define OTX2_SSOGWS_OPS \ - /* WS ops */ \ - uintptr_t getwrk_op; \ - uintptr_t tag_op; \ - uintptr_t wqp_op; \ - uintptr_t swtp_op; \ - uintptr_t swtag_norm_op; \ - uintptr_t swtag_desched_op; \ - uint8_t cur_tt; \ +#define OTX2_SSOGWS_OPS \ + /* WS ops */ \ + uintptr_t getwrk_op; \ + uintptr_t tag_op; \ + uintptr_t wqp_op; \ + uintptr_t swtag_flush_op; \ + uintptr_t swtag_norm_op; \ + uintptr_t swtag_desched_op; \ + uint8_t cur_tt; \ uint8_t cur_grp /* Event port aka GWS */ diff --git a/drivers/event/octeontx2/otx2_worker.h b/drivers/event/octeontx2/otx2_worker.h index cde1288d9..80dfe3e73 100644 --- a/drivers/event/octeontx2/otx2_worker.h +++ b/drivers/event/octeontx2/otx2_worker.h @@ -190,8 +190,7 @@ otx2_ssogws_swtag_untag(struct otx2_ssogws *ws) static __rte_always_inline void otx2_ssogws_swtag_flush(struct otx2_ssogws *ws) { - otx2_write64(0, OTX2_SSOW_GET_BASE_ADDR(ws->getwrk_op) + - SSOW_LF_GWS_OP_SWTAG_FLUSH); + otx2_write64(0, ws->swtag_flush_op); ws->cur_tt = SSO_SYNC_EMPTY; } @@ -208,20 +207,18 @@ otx2_ssogws_swtag_wait(struct otx2_ssogws *ws) #ifdef RTE_ARCH_ARM64 uint64_t swtp; - asm volatile ( - " ldr %[swtb], [%[swtp_loc]] \n" - " cbz %[swtb], done%= \n" - " sevl \n" - "rty%=: wfe \n" - " ldr %[swtb], [%[swtp_loc]] \n" - " cbnz %[swtb], rty%= \n" - "done%=: \n" - : [swtb] "=&r" (swtp) - : [swtp_loc] "r" (ws->swtp_op) - ); + asm volatile(" ldr %[swtb], [%[swtp_loc]] \n" + " tbz %[swtb], 62, done%= \n" + " sevl \n" + "rty%=: wfe \n" + " ldr %[swtb], [%[swtp_loc]] \n" + " tbnz %[swtb], 62, rty%= \n" + "done%=: \n" + : [swtb] "=&r" (swtp) + : [swtp_loc] "r" (ws->tag_op)); #else /* Wait for the SWTAG/SWTAG_FULL operation */ - while (otx2_read64(ws->swtp_op)) + while (otx2_read64(ws->tag_op) & BIT_ULL(62)) ; #endif } @@ -309,6 +306,8 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[], otx2_nix_xmit_one(cmd, txq->lmt_addr, txq->io_addr, flags); } + otx2_write64(0, ws->swtag_flush_op); + return 1; } From patchwork Thu Oct 8 18:48:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 80075 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C693A04BC; Thu, 8 Oct 2020 20:49:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4103F1B870; Thu, 8 Oct 2020 20:49:27 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 70D561B868 for ; Thu, 8 Oct 2020 20:49:25 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 098IUxYg023886 for ; Thu, 8 Oct 2020 11:49:23 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=pfpt0220; bh=o7aKn2WQ2tU1xRIFtULSR/JlRr+YAghH1TLndeG89Ms=; b=GmsA+XmT7hv/N1t65yxofhjg1ODmnXb2paXuK7y2PMT52Gel6/eeHPUVZOS+17WlW/KS fbrOFKySrPPDeBYI6czNI04arH7mu33lMDZn+tnRiYQx8WytGGnThki6cA3aZlOADrnc d7IgIZ4d2gv/nZAim9XLwt+ifedotz4ET9FjgXA9LyfrAJXpFUOCrzTSVhDOV4f55xLd G9QO3mbmvi8vzZJqaonfmMQ2z6M+qJFfQ7zULKUN3/xIK/CD5vHcFRJZSfI9WUPu1iFf J2Xc+emNEgvSV5w/tBR2y27hE74jogdUcHssRaI6IZNiyxurTAVpFwWjpLgaR3E2atQj nA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 33xrtns6k1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 08 Oct 2020 11:49:23 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 8 Oct 2020 11:49:21 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 8 Oct 2020 11:49:21 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 8 Oct 2020 11:49:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=flCPPXHFY6YBacVMe9102eQhIuC5jKHRrXvFppLs79VRCiZwE638tMGvMqySMf35bxef6YzUVWQjl45CXw5vmP42UVa5xLINBlGHu0Z0NI9ZHUj6PiNxpeSRNIsD0lvPBypoFiYmhXc5f2RcOzpJdJn0GEnyK926t2vQkZo0PeBCYNfN3UUhh33afaWZsDIhXo+1br/onM4jZSeVkMC6kOWySRgRY1bP8Sz6VlD7VDkyaEcp/6phYOHWHouyEXLFwtossAOmjdflHnM0fcEmhcjgDprAPilS5nzZRttG0naQlblneduwhCEirmsq1G1bF6za+rc3Iky+X5bLapNfrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o7aKn2WQ2tU1xRIFtULSR/JlRr+YAghH1TLndeG89Ms=; b=iFljDzjXO4pr3O1klfsaRMUQbEe2kJ0WLdOd/Z7Y/Q8MF3fyuFLPxaH4Ps9YF0Q5FvRjqblc5j2Z+Yby8L/wveidhTvvXQslZv+Gvoz5e1t8hqubUXIEd/s3BtmM112H4pBYfSehfosjM4wA4mOHeqFUef3+YRrPtxwX6va0eNSsANoFfncViIrFXSVEWZgvZ+G3evvYNsxtTeEfpls2r0Psm7KOBbZ4g82poHd0wTLvHgcqeynGFPA5xIAEYb5pV4B63ajkIxZoOnV/Q6mJMEU8HUyQqyAEJul924RSmDzeFrN7ZfRq2jR4Zv5YTtSW/prQq7DYxQSDbUncZPcuqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o7aKn2WQ2tU1xRIFtULSR/JlRr+YAghH1TLndeG89Ms=; b=gKStEh9Bp0kaAI0enAMBV4ix5a5vvPtcOmpYsxi3miS9GL8m0fwUbYcQE6nIYI0hRyRMtnp0N4XBIZhnJRXIuHixgggy+TlDdY5BVbgqyt7DzZvicumdZOyuKyJLExhTSXIY/w0LRlkiWvSZgNbs0JCeredB8szurmhlBJNhDWM= Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MW2PR18MB2169.namprd18.prod.outlook.com (2603:10b6:907:5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Thu, 8 Oct 2020 18:49:19 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19%7]) with mapi id 15.20.3455.023; Thu, 8 Oct 2020 18:49:19 +0000 From: Harman Kalra To: Pavan Nikhilesh , Jerin Jacob , Nithin Dabilpuram , "Kiran Kumar K" CC: Date: Fri, 9 Oct 2020 00:18:44 +0530 Message-ID: <1602182927-18254-2-git-send-email-hkalra@marvell.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1602182927-18254-1-git-send-email-hkalra@marvell.com> References: <1602182927-18254-1-git-send-email-hkalra@marvell.com> X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from hkarlara-OptiPlex-3046.marvell.com (1.6.215.26) by BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3455.21 via Frontend Transport; Thu, 8 Oct 2020 18:49:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d86e6272-9894-4e4c-8129-08d86bbadd15 X-MS-TrafficTypeDiagnostic: MW2PR18MB2169: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: moUL5ZEA0Pxokw7jHsN6tOUGPArmd/Mn8ijFqAUdRsTdsw1cV6VOrfsBdWcC1DsfzSFEsmfMPPzSkeajaFf9IJGnGc69OkwB09BILIlXJs6b+C7/BfYlkDQjLbo8kfFfl1OQaho4Z/7zHGKVLVE5UodQAJx8VDJudCMQrTcOqr4TgWhJlPVUim98CZdh8OCup7QdkFL9xqz8PZveQKfQMHyMVRZiylw0ZBtsXN7EvUIJKS261ttWFCQRhjInDHQ9bvCj7E9CqZodQfrYn/QL5AhBtJtrY1+I22GP1PK3mix/csedx3lr2wtnsuu0dF7qZum+QQbzLx4BowjemgqD9Q0OJlRNFIHI8XD0pPHgaQvANMpO/23KwjoVUDBS2avhXRISF/FMQK/5Oxsp3OvFPg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(956004)(6636002)(8936002)(86362001)(6486002)(2616005)(478600001)(8676002)(83380400001)(4326008)(7696005)(2906002)(316002)(110136005)(6666004)(52116002)(1006002)(66946007)(26005)(186003)(36756003)(66476007)(66556008)(16526019)(5660300002)(36456003)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ZwpWK0tegzLaaoE4n5gQyQkM+rZe9GLNlvYujcbw6bztE1H5X1UywetEvX3LR0/3lUfhmSi+8L4VhKZcbXGcF7gP51+e8DiHvU6XASQR/eGLWYk0ln0OrFxi58Qz5g4IZtK428RhFzBPvWkTSsy1sNAQBmaKx/yvJ5BNjc+wZI/GoTzRlCcxOaS6DOtiP5aJLbGmcFsm1ApwSEFSp9uC0ShdYFlNUcQNMtnG0EsGVVJzn/hQLh7j+qJ3rQftw62da3lo0g6zrZ/MpUYJbA0jpM0I5Uq3XC6Nvlo4951hNbpvFXPFMlSbm3J7fjnwU4dG5NQEssgj0MXxT9jQ7Yc2bRNOFyQ8Xy0yKhwpGJjy5IXrGSOwFWhI2iIFo6jCi9mG553nDO9e6IqjrqAPw+PMGdS6RbNzvnP48K3GNjSakNKu+ygMIRPWKPxSxNUJkwfk38p0LrjlRG3Vlzj+TaXCMrVGJdaSC2muC+JJTNAtC/VF0Bp3DNBo79f363+m2o0fjxNPiiSWuugunBH2FlzR3DWqmHsOKLd0jLN5ZAoFMKy2edvy2S9kZN/Hk29zDDQNK8kVqZUlnUOYORpjdrlUgoohz5gZ9eOqQMm4/8smtw50JujuS94W/ltOGkB9E2OJLJWcI2YfspGgTiMsOI2fmQ== X-MS-Exchange-CrossTenant-Network-Message-Id: d86e6272-9894-4e4c-8129-08d86bbadd15 X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2020 18:49:19.1731 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fxXZAcD4GhDbsDj1pTQOqmQcU3PJD5Pp7VduMfsR19pg+Y7KHLeiornI6Zw1pQHbTHCvxLH9bFY1xVCyjkv8QA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2169 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-08_12:2020-10-08, 2020-10-08 signatures=0 Subject: [dpdk-dev] [PATCH v2 2/4] event/octeontx2: improve single flow performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh Improve single flow performance by moving the point of coherence to the end of transmit sequence. Signed-off-by: Pavan Nikhilesh --- V2: * replace rte_cio_wmb with rte_io_wmb drivers/event/octeontx2/otx2_worker.h | 35 +++++++++++++++++---------- drivers/net/octeontx2/otx2_tx.h | 18 ++++++++++++++ 2 files changed, 40 insertions(+), 13 deletions(-) diff --git a/drivers/event/octeontx2/otx2_worker.h b/drivers/event/octeontx2/otx2_worker.h index 80dfe3e73..757fa6fe5 100644 --- a/drivers/event/octeontx2/otx2_worker.h +++ b/drivers/event/octeontx2/otx2_worker.h @@ -247,15 +247,6 @@ otx2_ssogws_head_wait(struct otx2_ssogws *ws) #endif } -static __rte_always_inline void -otx2_ssogws_order(struct otx2_ssogws *ws, const uint8_t wait_flag) -{ - if (wait_flag) - otx2_ssogws_head_wait(ws); - - rte_io_wmb(); -} - static __rte_always_inline const struct otx2_eth_txq * otx2_ssogws_xtract_meta(struct rte_mbuf *m, const uint64_t txq_data[][RTE_MAX_QUEUES_PER_PORT]) @@ -287,10 +278,9 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[], return otx2_sec_event_tx(ws, ev, m, txq, flags); } - rte_prefetch_non_temporal(&txq_data[m->port][0]); /* Perform header writes before barrier for TSO */ otx2_nix_xmit_prepare_tso(m, flags); - otx2_ssogws_order(ws, !ev->sched_type); + rte_io_wmb(); txq = otx2_ssogws_xtract_meta(m, txq_data); otx2_ssogws_prepare_pkt(txq, m, cmd, flags); @@ -298,12 +288,31 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[], const uint16_t segdw = otx2_nix_prepare_mseg(m, cmd, flags); otx2_nix_xmit_prepare_tstamp(cmd, &txq->cmd[0], m->ol_flags, segdw, flags); - otx2_nix_xmit_mseg_one(cmd, txq->lmt_addr, txq->io_addr, segdw); + if (!ev->sched_type) { + otx2_nix_xmit_mseg_prep_lmt(cmd, txq->lmt_addr, segdw); + otx2_ssogws_head_wait(ws); + if (otx2_nix_xmit_submit_lmt(txq->io_addr) == 0) + otx2_nix_xmit_mseg_one(cmd, txq->lmt_addr, + txq->io_addr, segdw); + } else { + otx2_nix_xmit_mseg_one(cmd, txq->lmt_addr, txq->io_addr, + segdw); + } } else { /* Passing no of segdw as 4: HDR + EXT + SG + SMEM */ otx2_nix_xmit_prepare_tstamp(cmd, &txq->cmd[0], m->ol_flags, 4, flags); - otx2_nix_xmit_one(cmd, txq->lmt_addr, txq->io_addr, flags); + + if (!ev->sched_type) { + otx2_nix_xmit_prep_lmt(cmd, txq->lmt_addr, flags); + otx2_ssogws_head_wait(ws); + if (otx2_nix_xmit_submit_lmt(txq->io_addr) == 0) + otx2_nix_xmit_one(cmd, txq->lmt_addr, + txq->io_addr, flags); + } else { + otx2_nix_xmit_one(cmd, txq->lmt_addr, txq->io_addr, + flags); + } } otx2_write64(0, ws->swtag_flush_op); diff --git a/drivers/net/octeontx2/otx2_tx.h b/drivers/net/octeontx2/otx2_tx.h index 3c4317092..caf170fd1 100644 --- a/drivers/net/octeontx2/otx2_tx.h +++ b/drivers/net/octeontx2/otx2_tx.h @@ -383,6 +383,18 @@ otx2_nix_xmit_one(uint64_t *cmd, void *lmt_addr, } while (lmt_status == 0); } +static __rte_always_inline void +otx2_nix_xmit_prep_lmt(uint64_t *cmd, void *lmt_addr, const uint32_t flags) +{ + otx2_lmt_mov(lmt_addr, cmd, otx2_nix_tx_ext_subs(flags)); +} + +static __rte_always_inline uint64_t +otx2_nix_xmit_submit_lmt(const rte_iova_t io_addr) +{ + return otx2_lmt_submit(io_addr); +} + static __rte_always_inline uint16_t otx2_nix_prepare_mseg(struct rte_mbuf *m, uint64_t *cmd, const uint16_t flags) { @@ -453,6 +465,12 @@ otx2_nix_prepare_mseg(struct rte_mbuf *m, uint64_t *cmd, const uint16_t flags) return segdw; } +static __rte_always_inline void +otx2_nix_xmit_mseg_prep_lmt(uint64_t *cmd, void *lmt_addr, uint16_t segdw) +{ + otx2_lmt_mov_seg(lmt_addr, (const void *)cmd, segdw); +} + static __rte_always_inline void otx2_nix_xmit_mseg_one(uint64_t *cmd, void *lmt_addr, rte_iova_t io_addr, uint16_t segdw) From patchwork Thu Oct 8 18:48:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 80077 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F4E4A04BC; Thu, 8 Oct 2020 20:50:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D74B1B9EC; Thu, 8 Oct 2020 20:49:34 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 8D56A1B96F; Thu, 8 Oct 2020 20:49:30 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 098IUxYh023886; Thu, 8 Oct 2020 11:49:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=pfpt0220; bh=1qzJ/lVdLwgO0SZO+HHFkk+ZM9ek8PvqHql9dCS+buQ=; b=bDAnGsF9/s0flmabEOo2yfrUyZWTlcf32XrCA3G4DRDFPBFCC+OJWDxtY96+M/B+793q oLNt/TsGBVWTI9fXSfb3SDUg3fEjctYIvQ8JWczV0DUfeEMuJs7JjGVeOXYSb0pjTwdU 6mc5dWqXu8WrBw9Qe2Fxjo9+l6vsz95Ne61J7E93hSQQfgavDSL/nTVKR9dh5XXY9lnZ nyWkdxtixX+a7TFOXHVWPyr9bQ5HERAxnjR5kZxdrIOgGO77mlb355mqCpuTBzdADLrC ERjhXceU+a4NM6/DUSk1uecitc3nrF9znFg0ML/6wGeJjsGesddMirFmFpIjxq6aXsR9 lA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 33xrtns6k4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 08 Oct 2020 11:49:28 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 8 Oct 2020 11:49:27 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 8 Oct 2020 11:49:26 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.59) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 8 Oct 2020 11:49:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DWvOXhRgyT+TvXxvJioGjYASFgHuDlBYB+yAJb6nHcVDYfZAWyD/zXc4KZqTfe0A8D2qFiTTesSVpxDEiTjFN641AxIyxImhFJM4Z0R4JPjHxr/ckxgDiVPRHeKuSi/RjFaHS4Iq+st2i1xuuiiTNB7v+AgvvtfOLqMHZbATfQtyuBMDkz6XphpyBMgSzeueT6/Z3UbTIvgyTg0cH0D+qGB1DTE5Oh2c/vvpAcRSXrchbTD6kY36QdDZWSMcIsKDn30sPQwHurKjvGhjzYAjhTu03DI0zEpvQJxXbhtAgKp1kO7eildNPHAgooF4YTOfUK/KSwVT2/EWghA2Ddx4hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1qzJ/lVdLwgO0SZO+HHFkk+ZM9ek8PvqHql9dCS+buQ=; b=aYRbVzZz71WZsD3y7t+9Rp7xR55iAlNsjmcp6/lAaITrBvDYp8GEo+WfddGg5SgLUGNCaI0zKhdxzxdHBCppp18vqlyltQZZVbL0VeucdqvRj6BTOHsbArqa152RqsSHGYL6+UVKxPfZc1VSSOKCEz1FjrvxTVQD6crDbc3ai6cfzNGto5F1C/iZDbW09svY/ErrtIXrPhDbUS+e2EnjJRQHVRoDslMRzSKzZgJRSUMkGjpDFivo89RLtXUMj5KF6/HQ/dz1yJ469+qHcOd2cn4ndt+0iU/AxOxWDAM3uDXyyefvesiP9gV0kwMIuSC5fsOb/hzsL4h861t5QtGF3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1qzJ/lVdLwgO0SZO+HHFkk+ZM9ek8PvqHql9dCS+buQ=; b=YOD4u3GhRQszZd3G/asMWm1LpvLzWbVYosceu57iopr1STW+dUj+rdmohtTzf2R1jSMBj1j8xwU8+lQdBt6c7jb6WUgyIaDDU8tiFZ5pI51H1RaF3Q0KMHUFh1IIlvD7x37s15XiE513t6MQFe5LLBqfPqSkMmb5vJmIA1i5vpI= Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MW2PR18MB2169.namprd18.prod.outlook.com (2603:10b6:907:5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Thu, 8 Oct 2020 18:49:23 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19%7]) with mapi id 15.20.3455.023; Thu, 8 Oct 2020 18:49:23 +0000 From: Harman Kalra To: Jerin Jacob , Nithin Dabilpuram , Pavan Nikhilesh , "Kiran Kumar K" CC: , Harman Kalra , Date: Fri, 9 Oct 2020 00:18:45 +0530 Message-ID: <1602182927-18254-3-git-send-email-hkalra@marvell.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1602182927-18254-1-git-send-email-hkalra@marvell.com> References: <1602182927-18254-1-git-send-email-hkalra@marvell.com> X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from hkarlara-OptiPlex-3046.marvell.com (1.6.215.26) by BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3455.21 via Frontend Transport; Thu, 8 Oct 2020 18:49:21 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 03e930ac-bb64-4b21-6f32-08d86bbadfb2 X-MS-TrafficTypeDiagnostic: MW2PR18MB2169: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:517; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ee6RWGQ2EtZBEcdyG+fZHtVxQL5/Tk20wIxzXsezjMv33Rb4DdhMNTs7/GjgVJ3qDtTh8jJ/ndsjWVHS1PpXfrf6MJ0pU9oc39cUMWOOZo/MZYXXoyH406befSvtajzVtApYFVeT/BpaixqbFrykr7JYnAoYyDT5KvfYdbak6WCYGoYaPCH9zgsYXklBFuAcwM48x7hjSiYCN5WPS4rVbK4KgaFpeupzpAPe2J28974vop7jmiBakpvje4DZtDnK5xOLbncy/NOXPoxCP91uwj7iAZVE730Hrv2SvWwP+eKQU4chhNOHSJEPsrXK9b3fj8b0wv8QWoO7JEOgWTg3SS1q5Uqk8vdoXkIN+bYgci/kYaMMcQ680ZXDN4r6TjD6Q442fGGEXrqNa9kE7gI6UA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(956004)(6636002)(8936002)(86362001)(6486002)(2616005)(478600001)(8676002)(83380400001)(4326008)(7696005)(2906002)(316002)(110136005)(6666004)(52116002)(1006002)(66946007)(26005)(186003)(36756003)(66476007)(66556008)(450100002)(16526019)(5660300002)(36456003)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: TrA54EifbfTCdJpAG0Dw3oMhrV6w33qOThNQOV7OTtHCRxezjoAeXkNFzpuC3AMmv1hJKHLLduH7Q/legutpHvP8qahuyEzGOyQhy65trqiBgiTrrOrSOiQF54L9Ltpnka1U/Vd7fOt2eo4fdAplldIaRQ7Mq/OKra+Im9NQcolJLIFvW5pyeVi7HqtLe1n3lgBaTPh+lLdJYVvC9Pa3XvVfTibLBaKM2LpeuLbmsBU8vwYUdT5WYFvK5i0c+PMboFMUrAW7p9Nxgivz8atUR2UvlLQa4W7Wzj50r6Zol81+VhAzuRsoGCBxED78VVZMc1Omdrh6pIqHXMUfw76Na/s4SwihJX5AcVmMLDY8E+PzpcnCgnzkROpx/AjOLGPPT4BldsCYkX2PjEFXWQdL1eLogE6bKH8x2zxs6vshoxpbv0BQsPhV6NpKwwDARj5hRbpBAYNJ0ikZ1f08a1CX2jFebKoGq8B/+lN5FcnBkdLTqH2NhJ5mkUeAh0zMGQ4/vthI/n0wGSWEpT5w74Rkssyuv1I2dhXNyH80OOcV25Ke+M4I817FizyU//mF5zGMpFSVJ4OABkO+nePENHFKhTrDFMiQPIC0qbMb1go2dVAtcAcgWTnUfGence/IL11qa86tDL42+ME8e8kL4uDlig== X-MS-Exchange-CrossTenant-Network-Message-Id: 03e930ac-bb64-4b21-6f32-08d86bbadfb2 X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2020 18:49:23.5859 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 90rGMd9HxVuzys/TuqlHU/Zey+lQxS4XsYRkpFXmXqHjAJ1ISgBlf/bGx51autbCskudEdOG+YhIcDPzjzpmLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2169 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-08_12:2020-10-08, 2020-10-08 signatures=0 Subject: [dpdk-dev] [PATCH v2 3/4] net/octeontx2: fix jumbo frame crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Issue has been observed in case of multi segments where mbuf data gets corrupted due to missing barriers. Changes made to mbuf just before LMTST by one core gets updatded when the same mbuf is in use by another core, leading to corruption. It should be ensured that all changes made to mbuf should be written before LMTST. Fixes: cbd5710db48d ("net/octeontx2: add Tx multi segment version") Cc: stable@dpdk.org Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram Signed-off-by: Harman Kalra --- V2: * replace rte_cio_wmb with rte_io_wmb drivers/common/octeontx2/otx2_io_arm64.h | 12 ++++++++++ drivers/common/octeontx2/otx2_io_generic.h | 16 +++++++++++--- drivers/event/octeontx2/otx2_worker.h | 20 +++++++++++++---- drivers/mempool/octeontx2/otx2_mempool_ops.c | 4 ++++ drivers/net/octeontx2/otx2_tx.c | 23 ++++++++++++++------ drivers/net/octeontx2/otx2_tx.h | 23 ++++++++++++++++++++ 6 files changed, 84 insertions(+), 14 deletions(-) diff --git a/drivers/common/octeontx2/otx2_io_arm64.h b/drivers/common/octeontx2/otx2_io_arm64.h index 7e45329b3..b5c85d9a6 100644 --- a/drivers/common/octeontx2/otx2_io_arm64.h +++ b/drivers/common/octeontx2/otx2_io_arm64.h @@ -63,6 +63,18 @@ otx2_lmt_submit(rte_iova_t io_address) return result; } +static __rte_always_inline uint64_t +otx2_lmt_submit_release(rte_iova_t io_address) +{ + uint64_t result; + + asm volatile ( + ".cpu generic+lse\n" + "ldeorl xzr,%x[rf],[%[rs]]" : + [rf] "=r"(result) : [rs] "r"(io_address)); + return result; +} + static __rte_always_inline void otx2_lmt_mov(void *out, const void *in, const uint32_t lmtext) { diff --git a/drivers/common/octeontx2/otx2_io_generic.h b/drivers/common/octeontx2/otx2_io_generic.h index b1d754008..da64c9b31 100644 --- a/drivers/common/octeontx2/otx2_io_generic.h +++ b/drivers/common/octeontx2/otx2_io_generic.h @@ -45,12 +45,22 @@ otx2_lmt_submit(uint64_t io_address) return 0; } +static inline int64_t +otx2_lmt_submit_release(uint64_t io_address) +{ + RTE_SET_USED(io_address); + + return 0; +} + static __rte_always_inline void otx2_lmt_mov(void *out, const void *in, const uint32_t lmtext) { - RTE_SET_USED(out); - RTE_SET_USED(in); - RTE_SET_USED(lmtext); + /* Copy four words if lmtext = 0 + * six words if lmtext = 1 + * eight words if lmtext =2 + */ + memcpy(out, in, (4 + (2 * lmtext)) * sizeof(uint64_t)); } static __rte_always_inline void diff --git a/drivers/event/octeontx2/otx2_worker.h b/drivers/event/octeontx2/otx2_worker.h index 757fa6fe5..5eb83435e 100644 --- a/drivers/event/octeontx2/otx2_worker.h +++ b/drivers/event/octeontx2/otx2_worker.h @@ -280,7 +280,19 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[], /* Perform header writes before barrier for TSO */ otx2_nix_xmit_prepare_tso(m, flags); - rte_io_wmb(); + /* Lets commit any changes in the packet here in case of single seg as + * no further changes to mbuf will be done. + * While for multi seg all mbufs used are set to NULL in + * otx2_nix_prepare_mseg() after preparing the sg list and these changes + * should be committed before LMTST. + * Also in no fast free case some mbuf fields are updated in + * otx2_nix_prefree_seg + * Hence otx2_nix_xmit_submit_lmt_release/otx2_nix_xmit_mseg_one_release + * has store barrier for multiseg. + */ + if (!(flags & NIX_TX_MULTI_SEG_F) && + !(flags & NIX_TX_OFFLOAD_MBUF_NOFF_F)) + rte_io_wmb(); txq = otx2_ssogws_xtract_meta(m, txq_data); otx2_ssogws_prepare_pkt(txq, m, cmd, flags); @@ -291,12 +303,12 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[], if (!ev->sched_type) { otx2_nix_xmit_mseg_prep_lmt(cmd, txq->lmt_addr, segdw); otx2_ssogws_head_wait(ws); - if (otx2_nix_xmit_submit_lmt(txq->io_addr) == 0) + if (otx2_nix_xmit_submit_lmt_release(txq->io_addr) == 0) otx2_nix_xmit_mseg_one(cmd, txq->lmt_addr, txq->io_addr, segdw); } else { - otx2_nix_xmit_mseg_one(cmd, txq->lmt_addr, txq->io_addr, - segdw); + otx2_nix_xmit_mseg_one_release(cmd, txq->lmt_addr, + txq->io_addr, segdw); } } else { /* Passing no of segdw as 4: HDR + EXT + SG + SMEM */ diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c index 5229a7cfb..9ff71bcf6 100644 --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c @@ -15,6 +15,10 @@ otx2_npa_enq(struct rte_mempool *mp, void * const *obj_table, unsigned int n) const uint64_t addr = npa_lf_aura_handle_to_base(aura_handle) + NPA_LF_AURA_OP_FREE0; + /* Ensure mbuf init changes are written before the free pointers + * are enqueued to the stack. + */ + rte_io_wmb(); for (index = 0; index < n; index++) otx2_store_pair((uint64_t)obj_table[index], reg, addr); diff --git a/drivers/net/octeontx2/otx2_tx.c b/drivers/net/octeontx2/otx2_tx.c index 1b75cd559..4458d8bca 100644 --- a/drivers/net/octeontx2/otx2_tx.c +++ b/drivers/net/octeontx2/otx2_tx.c @@ -38,8 +38,11 @@ nix_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, otx2_nix_xmit_prepare_tso(tx_pkts[i], flags); } - /* Lets commit any changes in the packet */ - rte_io_wmb(); + /* Lets commit any changes in the packet here as no further changes + * to the packet will be done unless no fast free is enabled. + */ + if (!(flags & NIX_TX_OFFLOAD_MBUF_NOFF_F)) + rte_io_wmb(); for (i = 0; i < pkts; i++) { otx2_nix_xmit_prepare(tx_pkts[i], cmd, flags); @@ -74,12 +77,11 @@ nix_xmit_pkts_mseg(void *tx_queue, struct rte_mbuf **tx_pkts, otx2_nix_xmit_prepare_tso(tx_pkts[i], flags); } - /* Lets commit any changes in the packet */ - rte_io_wmb(); - for (i = 0; i < pkts; i++) { otx2_nix_xmit_prepare(tx_pkts[i], cmd, flags); segdw = otx2_nix_prepare_mseg(tx_pkts[i], cmd, flags); + /* Lets commit any changes in the packet */ + rte_io_wmb(); otx2_nix_xmit_prepare_tstamp(cmd, &txq->cmd[0], tx_pkts[i]->ol_flags, segdw, flags); @@ -127,8 +129,11 @@ nix_xmit_pkts_vector(void *tx_queue, struct rte_mbuf **tx_pkts, /* Reduce the cached count */ txq->fc_cache_pkts -= pkts; - /* Lets commit any changes in the packet */ - rte_io_wmb(); + /* Lets commit any changes in the packet here as no further changes + * to the packet will be done unless no fast free is enabled. + */ + if (!(flags & NIX_TX_OFFLOAD_MBUF_NOFF_F)) + rte_io_wmb(); senddesc01_w0 = vld1q_dup_u64(&txq->cmd[0]); senddesc23_w0 = senddesc01_w0; @@ -221,6 +226,10 @@ nix_xmit_pkts_vector(void *tx_queue, struct rte_mbuf **tx_pkts, 1, 0); senddesc01_w0 = vorrq_u64(senddesc01_w0, xmask01); senddesc23_w0 = vorrq_u64(senddesc23_w0, xmask23); + /* Ensuring mbuf fields which got updated in + * otx2_nix_prefree_seg are written before LMTST. + */ + rte_io_wmb(); } else { struct rte_mbuf *mbuf; /* Mark mempool object as "put" since diff --git a/drivers/net/octeontx2/otx2_tx.h b/drivers/net/octeontx2/otx2_tx.h index caf170fd1..d6ea3b487 100644 --- a/drivers/net/octeontx2/otx2_tx.h +++ b/drivers/net/octeontx2/otx2_tx.h @@ -363,6 +363,10 @@ otx2_nix_xmit_prepare(struct rte_mbuf *m, uint64_t *cmd, const uint16_t flags) * DF bit = 0 otherwise */ send_hdr->w0.df = otx2_nix_prefree_seg(m); + /* Ensuring mbuf fields which got updated in + * otx2_nix_prefree_seg are written before LMTST. + */ + rte_io_wmb(); } /* Mark mempool object as "put" since it is freed by NIX */ if (!send_hdr->w0.df) @@ -395,6 +399,12 @@ otx2_nix_xmit_submit_lmt(const rte_iova_t io_addr) return otx2_lmt_submit(io_addr); } +static __rte_always_inline uint64_t +otx2_nix_xmit_submit_lmt_release(const rte_iova_t io_addr) +{ + return otx2_lmt_submit_release(io_addr); +} + static __rte_always_inline uint16_t otx2_nix_prepare_mseg(struct rte_mbuf *m, uint64_t *cmd, const uint16_t flags) { @@ -483,6 +493,19 @@ otx2_nix_xmit_mseg_one(uint64_t *cmd, void *lmt_addr, } while (lmt_status == 0); } +static __rte_always_inline void +otx2_nix_xmit_mseg_one_release(uint64_t *cmd, void *lmt_addr, + rte_iova_t io_addr, uint16_t segdw) +{ + uint64_t lmt_status; + + rte_io_wmb(); + do { + otx2_lmt_mov_seg(lmt_addr, (const void *)cmd, segdw); + lmt_status = otx2_lmt_submit(io_addr); + } while (lmt_status == 0); +} + #define L3L4CSUM_F NIX_TX_OFFLOAD_L3_L4_CSUM_F #define OL3OL4CSUM_F NIX_TX_OFFLOAD_OL3_OL4_CSUM_F #define VLAN_F NIX_TX_OFFLOAD_VLAN_QINQ_F From patchwork Thu Oct 8 18:48:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 80076 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28DC8A04BC; Thu, 8 Oct 2020 20:50:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C50D71B9CE; Thu, 8 Oct 2020 20:49:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 60E891B9CE for ; Thu, 8 Oct 2020 20:49:31 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 098IULRn004200 for ; Thu, 8 Oct 2020 11:49:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-type : mime-version; s=pfpt0220; bh=zqwg3rp2XgRxgaLM7dVhhflEDvBRvZXw0yGrV9tkoUA=; b=DfoPBW0mOkGvqfGO7R2qPq5cYQRxGSaENn6iXFj0utifrvlb03R7NNABf1WMOm4Ma23Q 1yGve9uWL7j0SPRFc9VMLHWpJ7XOc7OEKFNHJLjF/sTrKQjVYQ4c/3v6kq7t/Wq5aKy6 QAfKu1c69bjzsEBmV70VODO3H/TQaULACrKvIyImDrKSTjxirf6VwQs3mng1GkFZjNoG CENrzxKtOaIg/iu3QrcyD0ghUxFzxmyuVwGbg8NO8wV9YO41Ej4Xjetpo5sNgZM6YHAc QRF4RHdsuS8CiDXtL8ezI1bChvIIe1et0qCkJ4FwBeaYZcey1qjkms5t0DrpBUzWog1m CQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 33xpnq23u4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 08 Oct 2020 11:49:29 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 8 Oct 2020 11:49:28 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.56) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 8 Oct 2020 11:49:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y2dQrYBP4ncDrxZTJjL+V/0WeVcPl36HPiPT7hY1lxODHhrM3k8Vt3tKDo6oVdyqiuxzyqp2EnOpqjt5I+JS8ogQdtL+CDpudX/yDHXezdCOcFxXAQpb/CBqqwxp16zGVvs7d4vRq8ByCFADj9PXoviTbnMmuHmnQ/H27evNAr7+fGfQjVxcWvEYHX/RT0k92rg+OoA6kBuHZ7TYxcvVV4ziJZVaEqoszkxlVWFHxPOZ4EbEXLBt5aJ3LKGAbeY+duiaWKCkGksFb3M3JsWUJoXfwQZp9tbRTtTkml++lddNgCuCTK1mbGkKhHMagAR/t7RdnJOTMbzQZ7XrVvQaow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zqwg3rp2XgRxgaLM7dVhhflEDvBRvZXw0yGrV9tkoUA=; b=e1RQHjFjqq3X7hD5PqSsGkqZR0XskOj0nbplkc/iqAa8goonSS+Idmfd9pVfVcv4O/MhTLwQ41qz83eppp0mZ/dJRpmul/9l1CnprPRLq0rdeXsjX8TTZ14gk67gjBrRLNzbo8UZfW8dc5XOH50mV34LJ+ox/vzkiUADhDi+iAa1HE2WMj9x1qDCxmbFcrCcP1RyW2x1sOCIQZga123lfAHPX9dp+w/3HFwn4EKuxGH53AIYBc3Y/UJXEwpu8+2TbOheDKbKon+iqAoCqdntoQJVZKhljP5EMCLoK4N5wGrf2+Pqfo55QXDs8QtDUgIcBVEXRh7jgVQqA2Yc/qSKCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zqwg3rp2XgRxgaLM7dVhhflEDvBRvZXw0yGrV9tkoUA=; b=pGvt1fXDE9bXcxCI+tFC4oewkze5x9DX3Ij+NjTr+rzKSvgB7wxuWRIct6Ywmdrd1VzvUicUZL5KT8LCGIPw8+CMAiM+o2Eo8g8PEfQgGJsS+H7NyflNWyRIX2rtSZ7WNwkQ+Kz6Fsdh6N6oM4nYw2qamRlYLk2uDEGN7j4x+gQ= Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MW2PR18MB2169.namprd18.prod.outlook.com (2603:10b6:907:5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Thu, 8 Oct 2020 18:49:27 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19%7]) with mapi id 15.20.3455.023; Thu, 8 Oct 2020 18:49:27 +0000 From: Harman Kalra To: Jerin Jacob CC: , Harman Kalra Date: Fri, 9 Oct 2020 00:18:46 +0530 Message-ID: <1602182927-18254-4-git-send-email-hkalra@marvell.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1602182927-18254-1-git-send-email-hkalra@marvell.com> References: <1602182927-18254-1-git-send-email-hkalra@marvell.com> X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from hkarlara-OptiPlex-3046.marvell.com (1.6.215.26) by BMXPR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3455.21 via Frontend Transport; Thu, 8 Oct 2020 18:49:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4eb0f0c-6330-45c6-f369-08d86bbae194 X-MS-TrafficTypeDiagnostic: MW2PR18MB2169: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uh6L2NMBYrpfOI1N7++v43C6YstbLW1EXmZRRUfwpDu4BwNS4iRD9bMZuXr0y28wqp+YRZEXQdMszT7Y5VMZBzHqgbkCZeA5IyYpvYc9eQCFprzjGPAVHCMUXBtpicfNFicFDw8nHW6zv2eS8qSomkhbJF6NkWjFbSigBckenwyK9hy4JZ2dCGN5TUBMMgy+1+mrOD54DhfSpsdHpPYSQJEc77rfjbiSQ7yS5+Knhk2e8WB9r3VOsmbTAYLlwJQVGIsszFkCtVficZPnladWCAy+ru9/yEy0UxcDEvfPTXa6OiwgkDhFuc4e1pY++JoEAeNokwyzzUmHusBK8O+bkq3nfMi1et8mB0SAcNabnqqkUGNonr/+JrQnXYguOfG1cn6jG6B/DZP5qbj74A14qg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(4744005)(956004)(6636002)(8936002)(86362001)(6486002)(6862004)(107886003)(2616005)(478600001)(8676002)(4326008)(7696005)(2906002)(316002)(37006003)(6666004)(52116002)(1006002)(66946007)(26005)(186003)(36756003)(66476007)(66556008)(16526019)(5660300002)(36456003)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ar4LQDwHkxzlxja0wGKTK47aUgr0Vva38lpFEOxmfOLHdKy2Lt/eYUGVu4jSj2/wYxffYjk4d3FY6mot1CpaOT+FKSihvTSVTaZjP+8+88uxLAIh411tQ+fVGlL/JEqtiDxjJctA5rsBQvGaDf3T497GJxaREfiCHHpu+dtlk+Ih7qInZyUj/6ktM5skMpSbg4PAao0BN7OjpLAXCvwV3ZehexToriWBqVEXobZ+Gb7G8lPkCz/IlMSYSgrIm4N3PG3h+3PMTVVkr9KuHvOLhZj/FZv7GbQK7wO/LrHqAD+WOPlcLK/zN7ykd76lBuB9ICjfS491nH53QzMX4nrQ5CrsPIz+UysqmZJt2TJ4yMkRDyabAAAQxfrzSrwnNEk+Jy6FLUHa2t4oifLgAxXJZ1cQKM98rNlTov+ZSMgN6a+FAS2sc3Gjxyk7VdAhpSN/4DQDU0VNGODvAJXIMPWFBHa3oDyplUCQbqfpCZ7kdrNTE4p93UFHHbJgc6MLPndX2EDafnSmKyh+5+8ABEYzdd+BBV3or5vozranqjbNiOLqomqlVN4klU1N9ztQD1ELHMBbg0wf1TSBA50DYohncKUGYNsf/lV/k7wyDDe7+wRS8LuPBrnhnzl3P/zCFQTRB27bSY1USPtyIiC0cFHW6Q== X-MS-Exchange-CrossTenant-Network-Message-Id: d4eb0f0c-6330-45c6-f369-08d86bbae194 X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2020 18:49:26.9662 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vXH5Cmjd1J6wrOA8Gc8VGh1Es6S2OlAvevJukcDr0ZLN88sJfWfY9qQWMPnaLS/gvdCZDJ26frHXYLvgFtgCSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2169 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-08_12:2020-10-08, 2020-10-08 signatures=0 Subject: [dpdk-dev] [PATCH v2 4/4] app/eventdev: enable fast free offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since we are not holding the mbufs or creating any references in the app, hence mbuf fast free offload can be enabled. Signed-off-by: Harman Kalra Acked-by: Jerin Jacob --- app/test-eventdev/test_pipeline_common.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index 17088b1b4..f0c0ffea7 100644 --- a/app/test-eventdev/test_pipeline_common.c +++ b/app/test-eventdev/test_pipeline_common.c @@ -219,6 +219,11 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) return ret; } + /* Enable mbuf fast free if PMD has the capability. */ + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) + local_port_conf.txmode.offloads |= + DEV_TX_OFFLOAD_MBUF_FAST_FREE; + rx_conf = dev_info.default_rxconf; rx_conf.offloads = port_conf.rxmode.offloads;