From patchwork Sun Sep 27 08:25:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhou, JunX W" X-Patchwork-Id: 78915 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12E1DA04BC; Sun, 27 Sep 2020 10:25:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D73C01D8EA; Sun, 27 Sep 2020 10:25:30 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 98B7D1D8E8 for ; Sun, 27 Sep 2020 10:25:27 +0200 (CEST) IronPort-SDR: eCxgULbAc2srYXhuBjmGuN3NZ0IUMdfLvk08yiXHk0ISie9rq9isOjIHjlZXcN7VSHmWINZgao yQXjuZmvHAvw== X-IronPort-AV: E=McAfee;i="6000,8403,9756"; a="161911866" X-IronPort-AV: E=Sophos;i="5.77,309,1596524400"; d="scan'208";a="161911866" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2020 01:25:25 -0700 IronPort-SDR: iWvQ53D9BS0mL1x7rW4ovny9DYimE7+rCSe7rHNpk5f52BOdKUEWetu51/stbxH2VjDuYx4n52 H3TY1U4eI9AA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,309,1596524400"; d="scan'208";a="414669738" Received: from unknown (HELO localhost.localdomain) ([10.240.183.80]) by fmsmga001.fm.intel.com with ESMTP; 27 Sep 2020 01:25:23 -0700 From: "Zhou, Junx" To: dts@dpdk.org Cc: Zhou jun Date: Sun, 27 Sep 2020 16:25:47 +0800 Message-Id: <20200927082547.895-1-junx.w.zhou@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dts] [PATCH V1] tests/TestSuite_generic_flow_api: put validate rule after create rule X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" From: Zhou jun it's not work if execute validate rule before execute create rule, so put validate after create rule. Signed-off-by: Zhou jun Tested-by: Zhou, Jun Signed-off-by: Zhou jun --- tests/TestSuite_generic_flow_api.py | 70 ++++++++++++++++++------------------- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/tests/TestSuite_generic_flow_api.py b/tests/TestSuite_generic_flow_api.py index da061fe..14b5713 100644 --- a/tests/TestSuite_generic_flow_api.py +++ b/tests/TestSuite_generic_flow_api.py @@ -1385,22 +1385,6 @@ class TestGeneric_flow_api(TestCase): time.sleep(2) # create the flow rules basic_flow_actions = [ - {'create': 'validate', 'flows': ['vlan', 'ipv4'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv4', 'udp'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv4', 'tcp'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv4', 'vf0'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp', 'vf1'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp'], 'actions': ['drop']}, - {'create': 'validate', 'flows': ['vlan', 'ipv4', 'udp', 'vf1'], 'actions': ['drop']}, - {'create': 'validate', 'flows': ['vlan', 'ipv6'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv6', 'udp'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv6', 'sctp'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv6', 'vf0'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['queue']}, - {'create': 'validate', 'flows': ['vlan', 'ipv6', 'sctp'], 'actions': ['drop']}, - {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['drop']}, {'create': 'create', 'flows': ['vlan', 'ipv4'], 'actions': ['queue']}, {'create': 'create', 'flows': ['vlan', 'ipv4', 'udp'], 'actions': ['queue']}, {'create': 'create', 'flows': ['vlan', 'ipv4', 'tcp'], 'actions': ['queue']}, @@ -1416,7 +1400,23 @@ class TestGeneric_flow_api(TestCase): {'create': 'create', 'flows': ['vlan', 'ipv6', 'vf0'], 'actions': ['queue']}, {'create': 'create', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['queue']}, {'create': 'create', 'flows': ['vlan', 'ipv6', 'sctp'], 'actions': ['drop']}, - {'create': 'create', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['drop']} + {'create': 'create', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['drop']}, + {'create': 'validate', 'flows': ['vlan', 'ipv4'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv4', 'udp'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv4', 'tcp'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv4', 'vf0'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp', 'vf1'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp'], 'actions': ['drop']}, + {'create': 'validate', 'flows': ['vlan', 'ipv4', 'udp', 'vf1'], 'actions': ['drop']}, + {'create': 'validate', 'flows': ['vlan', 'ipv6'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv6', 'udp'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv6', 'sctp'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv6', 'vf0'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['queue']}, + {'create': 'validate', 'flows': ['vlan', 'ipv6', 'sctp'], 'actions': ['drop']}, + {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['drop']} ] extrapkt_rulenum = self.all_flows_process(basic_flow_actions) extra_packet = extrapkt_rulenum['extrapacket'] @@ -2264,17 +2264,6 @@ class TestGeneric_flow_api(TestCase): # create the flow rules basic_flow_actions = [ - {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth'], 'actions': ['pf', 'queue']}, - {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth'], 'actions': ['pf', 'queue']}, - {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth', 'invlan'], 'actions': ['pf', 'queue']}, - {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth', 'invlan'], - 'actions': ['pf', 'queue']}, - {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'udp', 'vxlan', 'vni', 'ineth'], - 'actions': ['pf', 'queue']}, - {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth', 'invlan'], - 'actions': ['vf0', 'queue']}, - {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'udp', 'vxlan', 'vni', 'ineth'], - 'actions': ['vf1', 'queue']}, {'create': 'create', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth'], 'actions': ['pf', 'queue']}, {'create': 'create', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth'], 'actions': ['pf', 'queue']}, {'create': 'create', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth', 'invlan'], 'actions': ['pf', 'queue']}, @@ -2286,6 +2275,17 @@ class TestGeneric_flow_api(TestCase): 'actions': ['vf0', 'queue']}, {'create': 'create', 'flows': ['dst_mac', 'ipv4', 'udp', 'vxlan', 'vni', 'ineth'], 'actions': ['vf1', 'queue']}, + {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth'], 'actions': ['pf', 'queue']}, + {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth'], 'actions': ['pf', 'queue']}, + {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth', 'invlan'], 'actions': ['pf', 'queue']}, + {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth', 'invlan'], + 'actions': ['pf', 'queue']}, + {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'udp', 'vxlan', 'vni', 'ineth'], + 'actions': ['pf', 'queue']}, + {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth', 'invlan'], + 'actions': ['vf0', 'queue']}, + {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'udp', 'vxlan', 'vni', 'ineth'], + 'actions': ['vf1', 'queue']} ] extrapkt_rulenum = self.all_flows_process(basic_flow_actions) extra_packet = extrapkt_rulenum['extrapacket'] @@ -2338,13 +2338,6 @@ class TestGeneric_flow_api(TestCase): # create the flow rules basic_flow_actions = [ - {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'ineth'], 'actions': ['pf', 'queue']}, - {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']}, - {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'ineth', 'invlan'], 'actions': ['pf', 'queue']}, - {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth', 'invlan'], 'actions': ['pf', 'queue']}, - {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']}, - {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth', 'invlan'], 'actions': ['vf0', 'queue']}, - {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['vf1', 'queue']}, {'create': 'create', 'flows': ['ipv4', 'nvgre', 'ineth'], 'actions': ['pf', 'queue']}, {'create': 'create', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']}, {'create': 'create', 'flows': ['ipv4', 'nvgre', 'ineth', 'invlan'], 'actions': ['pf', 'queue']}, @@ -2352,6 +2345,13 @@ class TestGeneric_flow_api(TestCase): {'create': 'create', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']}, {'create': 'create', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth', 'invlan'], 'actions': ['vf0', 'queue']}, {'create': 'create', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['vf1', 'queue']}, + {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'ineth'], 'actions': ['pf', 'queue']}, + {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']}, + {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'ineth', 'invlan'], 'actions': ['pf', 'queue']}, + {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth', 'invlan'], 'actions': ['pf', 'queue']}, + {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']}, + {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth', 'invlan'], 'actions': ['vf0', 'queue']}, + {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['vf1', 'queue']} ] extrapkt_rulenum = self.all_flows_process(basic_flow_actions) extra_packet = extrapkt_rulenum['extrapacket']