From patchwork Mon Sep 21 21:44:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Wojciechowski X-Patchwork-Id: 78218 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73A17A04DD; Mon, 21 Sep 2020 23:44:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD7391DA56; Mon, 21 Sep 2020 23:44:30 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1024E1D8DD for ; Mon, 21 Sep 2020 23:44:28 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200921214428euoutp02fb19b3de71ed30ed92acf33a44588319~26prVah4H2536125361euoutp02O for ; Mon, 21 Sep 2020 21:44:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200921214428euoutp02fb19b3de71ed30ed92acf33a44588319~26prVah4H2536125361euoutp02O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600724668; bh=vfeYoiG0jgZApBRuGB3v7MkaBuCK0XFA/Xy5b+Vu0vQ=; h=From:To:Cc:Subject:Date:References:From; b=aY812HywZ0F7vkuppbQ/5GbDtbAlPk8HpD+Z9HwTrJMD9/Errv5ILUECFCGokX8Nm ZWKncLYcGRXKbBkA4Sgx8GzTLBCdqZCTqfrUI2NJ50pKC7aTIgVHnTHd4k9sLiF7GV 3f2VH0CI/RNMonx/tZ4llxeut1PlXxHp0gNBvKok= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200921214427eucas1p257e03f59c36d0ae926de8566454e0854~26pqR-EZY3219632196eucas1p2v; Mon, 21 Sep 2020 21:44:27 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 09.3F.06318.BBE196F5; Mon, 21 Sep 2020 22:44:27 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200921214426eucas1p1780728815bcc17e96102cb1f43df0195~26pp3BgrR2057520575eucas1p1d; Mon, 21 Sep 2020 21:44:26 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200921214426eusmtrp2292923a2f23616feae31197993d98518~26pp2c1gj2051820518eusmtrp2x; Mon, 21 Sep 2020 21:44:26 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-be-5f691ebb49aa Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 49.17.06314.ABE196F5; Mon, 21 Sep 2020 22:44:26 +0100 (BST) Received: from Padamandas.fritz.box (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200921214426eusmtip20f0bb3f484b22ee35b7900e96e250878~26ppNtOX13136931369eusmtip2Q; Mon, 21 Sep 2020 21:44:25 +0000 (GMT) From: Lukasz Wojciechowski To: Nipun Gupta , Hemant Agrawal , Shreyansh Jain Cc: dev@dpdk.org, l.wojciechow@partner.samsung.com, stable@dpdk.org Date: Mon, 21 Sep 2020 23:44:19 +0200 Message-Id: <20200921214420.29171-1-l.wojciechow@partner.samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsWy7djPc7q75TLjDS4eYbN492k7k8XKxxvZ LJ71rGO0OHf8NKPFv/cdbBb/Ov6wO7B5/FqwlNVj47sdTB4H3+1hCmCO4rJJSc3JLEst0rdL 4Mr481CyoI+z4v2bD4wNjBfZuxg5OSQETCQapn5n7mLk4hASWMEocannNyOE84VR4uS+ZawQ zmdGiZdvZjDDtPROfcAEkVjOKDGh5Qs7hPOJUWL+jRNgVWwCthJHZn5lBbFFBCol7pzezdLF yMHBLOAs8eQrG0hYWMBJYsn5xYwgNouAqsS1F1+ZQGxeAVeJk8/fMUEsk5dYveEA2H0SAgfY JP4sPMcKkXCRuHBnNRuELSzx6vgWqIdkJP7vnM8E0bCNUeLq75+MEM5+RonrvSugqqwlDv/7 zQZxkabE+l36EGFHidZ9z5lBwhICfBI33gqChJmBzEnbpkOFeSU62oQgqvUknvZMZYRZ+2ft ExYI20Niys35YGcKCcRKzGs6wTqBUW4Wwq4FjIyrGMVTS4tz01OLjfNSy/WKE3OLS/PS9ZLz czcxAuP99L/jX3cw7vuTdIhRgINRiYf3wNSMeCHWxLLiytxDjBIczEoivE5nT8cJ8aYkVlal FuXHF5XmpBYfYpTmYFES5zVe9DJWSCA9sSQ1OzW1ILUIJsvEwSnVwGiou4SxW1GLP1D5Vjp3 xanSY+ceznFeUc1x+9U8X8aFaRmmbfbzDzbvU5u8PbUggX228uNTvyv1ylfdnufzROfUf4HP i09Zs3Da2Rr8T9kkqawwZ87Bvg8JCnN7YuqlboVJOTxtjl1vu2/TSn9WJo33stsVGP2ZBa1u 3+HYXHi+KM+partFphJLcUaioRZzUXEiAAAxGVPzAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKLMWRmVeSWpSXmKPExsVy+t/xe7q75DLjDTpOa1m8+7SdyWLl441s Fs961jFanDt+mtHi3/sONot/HX/YHdg8fi1Yyuqx8d0OJo+D7/YwBTBH6dkU5ZeWpCpk5BeX 2CpFG1oY6RlaWugZmVjqGRqbx1oZmSrp29mkpOZklqUW6dsl6GX8eShZ0MdZ8f7NB8YGxovs XYycHBICJhK9Ux8wdTFycQgJLGWUmPlrAWMXIwdQQkbiwyUBiBphiT/Xutggaj4wSrybMo0J JMEmYCtxZOZXVhBbRKBaYmLvDUYQm1nAXWLL4qnMILawgJPEkvOLweIsAqoS1158BevlFXCV OPn8HRPEAnmJ1RsOME9g5FnAyLCKUSS1tDg3PbfYUK84Mbe4NC9dLzk/dxMjMMi2Hfu5eQfj pY3BhxgFOBiVeHgPTM2IF2JNLCuuzD3EKMHBrCTC63T2dJwQb0piZVVqUX58UWlOavEhRlOg 5ROZpUST84ERkFcSb2hqaG5haWhubG5sZqEkztshcDBGSCA9sSQ1OzW1ILUIpo+Jg1OqgZHh wHbG64XSW3j+fteuVrrNFmn0jnFNz0NRjYznB18+UzSL+/jtlGb/pCuX66tWHGoRZklLDj7v +1frTkjNVsXlDw47xS900WW18323NzL1wC2v4Ngtjir1JbanCgVbWMQeF7NLzeVmS/vx87Z6 jf3dwqUhhQpvuyM/Lv+c725zPWrxkiChO0osxRmJhlrMRcWJAFndIk1IAgAA X-CMS-MailID: 20200921214426eucas1p1780728815bcc17e96102cb1f43df0195 X-Msg-Generator: CA X-RootMTR: 20200921214426eucas1p1780728815bcc17e96102cb1f43df0195 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200921214426eucas1p1780728815bcc17e96102cb1f43df0195 References: Subject: [dpdk-dev] [PATCH v1 1/2] raw/skeleton: reset rawdev test statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Statistics: passed, failed, unsupported and total are kept in global static variables. As global variables they are initiated with zeroes. However running test multiple times cumulates results from previous calls. This patch resets statistics with zeroes in testsuite_setup(). To reproduce issue fixed by this patch, run rawdev_autotest command in dpdk-test app multiple times. Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") Cc: shreyansh.jain@nxp.com Cc: stable@dpdk.org Signed-off-by: Lukasz Wojciechowski Acked-by: Hemant Agrawal Acked-by: Hemant Agrawal --- drivers/raw/skeleton/skeleton_rawdev_test.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c index bb4b6efe4..1405df080 100644 --- a/drivers/raw/skeleton/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton/skeleton_rawdev_test.c @@ -42,6 +42,12 @@ static int testsuite_setup(void) { uint8_t count; + + total = 0; + passed = 0; + failed = 0; + unsupported = 0; + count = rte_rawdev_count(); if (!count) { SKELDEV_TEST_INFO("\tNo existing rawdev; " From patchwork Mon Sep 21 21:44:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Wojciechowski X-Patchwork-Id: 78217 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA503A04DD; Mon, 21 Sep 2020 23:44:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 725B21D974; Mon, 21 Sep 2020 23:44:29 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 153CA1D974 for ; Mon, 21 Sep 2020 23:44:28 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200921214428euoutp028fdf130a8a1a0cdef8b1f88577f25b1f~26prf-KeS2583425834euoutp02H for ; Mon, 21 Sep 2020 21:44:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200921214428euoutp028fdf130a8a1a0cdef8b1f88577f25b1f~26prf-KeS2583425834euoutp02H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600724668; bh=Przc74oN7326C6PmvbUGBD7HgSxOZKyI0KOEHxowJPs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vU8w5HAcOm6beheq4VFx5IY/jBr3vOcbjNmZjZr+gOiyyzWedHol1iWqBqTZ1Fmhj fBdrEopf0IAz9u+ESH/uqAP4nZ2VSFgBWRbbcCBWJiVS2lCMJJ8uJGHQAz/zXwR6lA NA/4cxIhIFL2zUF1J3ARktBc6D97QXSASVtOYfuU= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200921214428eucas1p197672e130e0b050fcfac6507ff4ff183~26prTrDva2047720477eucas1p1p; Mon, 21 Sep 2020 21:44:28 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id DF.BE.06456.CBE196F5; Mon, 21 Sep 2020 22:44:28 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200921214427eucas1p1f55e4da85bf76c8f73a840b47e01b04d~26pquVe5n1835318353eucas1p1b; Mon, 21 Sep 2020 21:44:27 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200921214427eusmtrp1fed08a88126cb90eac1d7e9104ba2a8b~26pqtyD-_0669006690eusmtrp1N; Mon, 21 Sep 2020 21:44:27 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-67-5f691ebcebe4 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B2.E6.06017.BBE196F5; Mon, 21 Sep 2020 22:44:27 +0100 (BST) Received: from Padamandas.fritz.box (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200921214426eusmtip2fb37240eb082831e40dd93e2d18d3a6b~26pqA_PEP3136931369eusmtip2R; Mon, 21 Sep 2020 21:44:26 +0000 (GMT) From: Lukasz Wojciechowski To: Nipun Gupta , Hemant Agrawal , Shreyansh Jain Cc: dev@dpdk.org, l.wojciechow@partner.samsung.com, stable@dpdk.org Date: Mon, 21 Sep 2020 23:44:20 +0200 Message-Id: <20200921214420.29171-2-l.wojciechow@partner.samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200921214420.29171-1-l.wojciechow@partner.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWy7djPc7p75DLjDWY08Fq8+7SdyWLl441s Fs961jFanDt+mtHi3/sONot/HX/YHdg8fi1Yyuqx8d0OJo+D7/YwBTBHcdmkpOZklqUW6dsl cGU87WtjLJjKW7H4yAXWBsY27i5GTg4JAROJO1fmMnUxcnEICaxglHiw/BArSEJI4AujxM4l 1RCJz4wSS1cdZ4fpuH/3AFTHckaJK6tPs0M4nxglmo5PYQKpYhOwlTgy8yvYKBGBSok7p3ez dDFycDALOEs8+coGEhYW8JTYe/07WDmLgKrEwR/TGUFsXgFXiW9H77FBLJOXWL3hADOIzSng JjHhTB8byC4JgftsEp//PGaEKHKR2LS3iwnCFpZ4dXwL1KUyEqcn97BANGxjlLj6+ycjhLOf UeJ67wqoKmuJw/9+s0Fcpymxfpc+RNhRYsvLBawgYQkBPokbbwVBwsxA5qRt05khwrwSHW1C ENV6Ek97pjLCrP2z9gkLhO0hsePdVzZI+MxklHh1dyX7BEb5WQjLFjAyrmIUTy0tzk1PLTbM Sy3XK07MLS7NS9dLzs/dxAhMBKf/Hf+0g/HrpaRDjAIcjEo8vAemZsQLsSaWFVfmHmKU4GBW EuF1Ons6Tog3JbGyKrUoP76oNCe1+BCjNAeLkjiv8aKXsUIC6YklqdmpqQWpRTBZJg5OqQZG 7TWhHStkHbam6Cz8cEY9ZKcSY2b9xfe3cxquWKa++fF5ufpuLcmDa8/ZarzQTHl64uOiZZF2 Pf09H3WLTy252bRUpl7R5emtf3tDfXfcbjRZ1smkvc/4k/5KIbvfZq8Fbqj1+xhbPj0jEKP8 UKmJ7wz3xyDrW1qXw+dKzT/vfm/3mXkf2iaLKLEUZyQaajEXFScCAL/eWBUAAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLLMWRmVeSWpSXmKPExsVy+t/xe7q75TLjDSZfULB492k7k8XKxxvZ LJ71rGO0OHf8NKPFv/cdbBb/Ov6wO7B5/FqwlNVj47sdTB4H3+1hCmCO0rMpyi8tSVXIyC8u sVWKNrQw0jO0tNAzMrHUMzQ2j7UyMlXSt7NJSc3JLEst0rdL0Mt42tfGWDCVt2LxkQusDYxt 3F2MnBwSAiYS9+8eYOpi5OIQEljKKLHwyG/2LkYOoISMxIdLAhA1whJ/rnWxQdR8AKp51M0M kmATsJU4MvMrK4gtIlAtMbH3BiOIzSzgLrFl8VSwGmEBT4m9178zgdgsAqoSB39MB6vhFXCV +Hb0HhvEAnmJ1RsOgNVzCrhJTDjTxwZygxBQzdnnahMY+RYwMqxiFEktLc5Nzy020itOzC0u zUvXS87P3cQIDMptx35u2cHY9S74EKMAB6MSD++BqRnxQqyJZcWVuYcYJTiYlUR4nc6ejhPi TUmsrEotyo8vKs1JLT7EaAp000RmKdHkfGDE5JXEG5oamltYGpobmxubWSiJ83YIHIwREkhP LEnNTk0tSC2C6WPi4JRqYEz22ni0JGtrxumXqy90asVbBAXUti7edPTXel3DDdP5t5S9Xyv/ 9HONpuWazJu34kpe1rw0evuJNXD5hKCp0q3fdiQmzj9/xOSJwHZFs7ubdkoukTl0auKfHimD kAONH8ynvUreUnF4+dUG5tCS5A9enGvPmLt72Ol2+h3P+rm+3vvxUX2RGdlKLMUZiYZazEXF iQA2tYjlYAIAAA== X-CMS-MailID: 20200921214427eucas1p1f55e4da85bf76c8f73a840b47e01b04d X-Msg-Generator: CA X-RootMTR: 20200921214427eucas1p1f55e4da85bf76c8f73a840b47e01b04d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200921214427eucas1p1f55e4da85bf76c8f73a840b47e01b04d References: <20200921214420.29171-1-l.wojciechow@partner.samsung.com> Subject: [dpdk-dev] [PATCH v1 2/2] raw/skeleton: allow closing already closed rawdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch return OK code (0) from skeleton_rawdev_close function if firmware is in SKELETON_FW_READY state. Formerly it returned -EINVAL error code. Returning an error here is troublesome as it disallows proper release of the rawdev. The rte_rawdev_pmd_release function from librte_rawdev library calls drivers' rawdev_close handler and continues execution only in case of errorless call. (see lib/librte_rawdev/rte_rawdev.c:540) The SKELETON_FW_READY state is reached after creation, reset, unload or close of the device. The device should be ok to be released in such situations. To reproduce issue fixed by this patch, call rawdev_autotest from dpdk-test app for few times. As the device is not properly released, the next calls will fail. Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver") Cc: shreyansh.jain@nxp.com Cc: stable@dpdk.org Signed-off-by: Lukasz Wojciechowski --- drivers/raw/skeleton/skeleton_rawdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c index f8b47a391..aa3beaad1 100644 --- a/drivers/raw/skeleton/skeleton_rawdev.c +++ b/drivers/raw/skeleton/skeleton_rawdev.c @@ -190,9 +190,11 @@ static int skeleton_rawdev_close(struct rte_rawdev *dev) } break; case SKELETON_FW_READY: + SKELETON_PMD_DEBUG("Device already in stopped state"); + break; case SKELETON_FW_ERROR: default: - SKELETON_PMD_DEBUG("Device already in stopped state"); + SKELETON_PMD_DEBUG("Device in impossible state"); ret = -EINVAL; break; }