From patchwork Fri Sep 11 02:40:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shougang Wang X-Patchwork-Id: 77310 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E9E7A04B5; Fri, 11 Sep 2020 05:04:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 273E68F96; Fri, 11 Sep 2020 05:04:56 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 6DDA7255; Fri, 11 Sep 2020 05:04:54 +0200 (CEST) IronPort-SDR: XyootHnomvOwW573GqePJGAhiWu8YyQZ1cseH9kvRtIlagzuA0nfIJ1WcrS7Ta3HuwB4Y5xVxb AkmjzpMeLrBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="146406614" X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="146406614" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 20:04:53 -0700 IronPort-SDR: 5BK05R9PTaFjdWujVtZqNhOaPz7M7Yp2ViTY7Z+IfVHDtIfY8oJwroroMhZvdouh/LcwD6iUUF u1H1voeihvWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="318136556" Received: from intel.sh.intel.com ([10.239.255.13]) by orsmga002.jf.intel.com with ESMTP; 10 Sep 2020 20:04:51 -0700 From: Shougang Wang To: dev@dpdk.org Cc: qiming.yang@intel.com, qi.z.zhang@intel.com, Shougang Wang , stable@dpdk.org Date: Fri, 11 Sep 2020 02:40:41 +0000 Message-Id: <20200911024041.50817-1-shougangx.wang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200806082519.71727-1-shougangx.wang@intel.com> References: <20200806082519.71727-1-shougangx.wang@intel.com> Subject: [dpdk-dev] [PATCH v3] net/ice: fix incorrect firmware version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Kernel driver shows firmware version as hex but ice PMD shows as decimal. This patch fixes the issue to make consistent with kernel driver. Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool") Cc: stable@dpdk.org Signed-off-by: Shougang Wang Acked-by: Qiming Yang --- v3: code rebase v2: corrected fixes version --- drivers/net/ice/ice_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index ca1f7d42e..4170a5446 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -4415,7 +4415,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size) build = hw->flash.orom.build; ret = snprintf(fw_version, fw_size, - "%d.%d 0x%08x %d.%d.%d", + "%x.%02x 0x%08x %d.%d.%d", hw->flash.nvm.major, hw->flash.nvm.minor, hw->flash.nvm.eetrack,