From patchwork Wed Sep 2 08:34:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 76296 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8A18A04B7; Wed, 2 Sep 2020 10:35:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E09831C0AF; Wed, 2 Sep 2020 10:35:17 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id F00511C07E for ; Wed, 2 Sep 2020 10:35:15 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from matan@nvidia.com) with SMTP; 2 Sep 2020 11:35:12 +0300 Received: from nvidia.com (pegasus25.mtr.labs.mlnx [10.210.16.10]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0828ZB3w001936; Wed, 2 Sep 2020 11:35:11 +0300 From: Matan Azrad To: Maxime Coquelin Cc: dev@dpdk.org, stable@dpdk.org Date: Wed, 2 Sep 2020 08:34:59 +0000 Message-Id: <1599035699-358487-1-git-send-email-matan@nvidia.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH] vdpa/mlx5: fix completion queue assertion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The CQ configuration enables the collapse feature in HW what cause HW to write all the completions in the first CQE. When this feature is enabled the HW doesn't switch the owner bit when it starts a new cycle of the CQ, not like working without the collapse feature. The current SW CQ polling wrongly added an assertion to validate the owner bit switch what causes a panic in debug mode. Remove the aforementioned assertion. Fixes: c5f714e50b0e ("vdpa/mlx5: optimize completion queue poll") Cc: stable@dpdk.org Signed-off-by: Matan Azrad Acked-by: Xueming Li Reviewed-by: Maxime Coquelin --- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c index 5a2d4fb..742ee62 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c @@ -205,8 +205,6 @@ comp = (cur_wqe_counter + 1u - next_wqe_counter) & cq_mask; if (comp) { cq->cq_ci += comp; - MLX5_ASSERT(!!(cq->cq_ci & cq_size) == - MLX5_CQE_OWNER(last_word.op_own)); MLX5_ASSERT(MLX5_CQE_OPCODE(last_word.op_own) != MLX5_CQE_INVALID); if (unlikely(!(MLX5_CQE_OPCODE(last_word.op_own) ==