From patchwork Tue Aug 11 06:14:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 75353 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8CCDA04D8; Tue, 11 Aug 2020 08:15:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 165511C00D; Tue, 11 Aug 2020 08:15:15 +0200 (CEST) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id 359D41B203; Tue, 11 Aug 2020 08:15:13 +0200 (CEST) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 10 Aug 2020 23:14:19 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 10 Aug 2020 23:15:12 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 10 Aug 2020 23:15:12 -0700 Received: from nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 11 Aug 2020 06:15:08 +0000 From: Gregory Etelson To: CC: , , , , Ori Kam , Wenzhuo Lu , Beilei Xing , "Bernard Iremonger" Date: Tue, 11 Aug 2020 09:14:42 +0300 Message-ID: <20200811061443.8214-1-getelson@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1597126459; bh=f4bX9zm0GMSeN3YR0kdBrvscfaMzYv6XL4c/RVBOsYw=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Transfer-Encoding:Content-Type: X-Originating-IP:X-ClientProxiedBy; b=HEHeckKzfORK5lMbd81mHga6k8H6eF84Npf/JzJEEwCJb7J54ie7/JRrltaNoOIgq u6CuayHsUB5v8d2/hDpBqxurAzsCUzSOWyWcoEngLe7UoNW1LuaUtNtttjHW/nRprf +9mrtNNdBMQguMPeU2SwsBbgGZsELnGKFLuker8JAxSdDhpetE9Ar9agfk0CUiefcf bVb55RrrSIW7F4jq6UfTofac9tZ8rW9HdwWuyvLDTyiYZMsXQ4dmCfkQwMol8u5UfL 7jRMdUQrZ6DjdQXvQH3dbrxbctUvElp1BXGEreF7/8rmfa3OzKaMdcTTIaPitQXq6B 5H+rDuc+82YAA== Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow rules list after port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" According to current RTE API, port flow rules must not be kept after port stop. Testpmd did not flush port flow rules after `port stop' command was called. As the result, after the port was restarted, it showed bogus flow rules. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: stable@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Ori Kam Acked-by: Ajit Khaparde --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 7842c3b781..4ba5c41c6e 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2627,6 +2627,9 @@ stop_port(portid_t pid) RTE_PORT_HANDLING) == 0) continue; + if (port->flow_list) + port_flow_flush(pi); + rte_eth_dev_stop(pi); if (rte_atomic16_cmpset(&(port->port_status),