From patchwork Fri Aug 7 05:02:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ori Kam X-Patchwork-Id: 75268 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F730A04AD; Fri, 7 Aug 2020 07:03:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F5BD2BF1; Fri, 7 Aug 2020 07:03:12 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id EDC852B87 for ; Fri, 7 Aug 2020 07:03:10 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from orika@mellanox.com) with SMTP; 7 Aug 2020 08:03:10 +0300 Received: from pegasus04.mtr.labs.mlnx. (pegasus04.mtr.labs.mlnx [10.210.16.126]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0775390R016917; Fri, 7 Aug 2020 08:03:09 +0300 From: Ori Kam To: thomas@monjalon.net, arybchenko@solarflare.com, david.marchand@redhat.com, John McNamara , Marko Kovacevic Cc: orika@mellanox.com, dev@dpdk.org Date: Fri, 7 Aug 2020 05:02:58 +0000 Message-Id: <1596776579-46445-1-git-send-email-orika@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1596464905-43867-1-git-send-email-orika@mellanox.com> References: <1596464905-43867-1-git-send-email-orika@mellanox.com> Subject: [dpdk-dev] [PATCH v3] doc: update RSS action with best effort X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using the rte_flow action RSS types field, may result in undefined outcome. For example selecting both UDP and TCP, selecting TCP RSS type but the pattern is targeting UDP traffic. another option is that the PMD doesn't support all requested types. Until now, it wasn't clear what will happen in such cases. This commit clarify this issue by stating that the PMD will work in the best-effort mode, and will fail in case the requested type is not supported. Signed-off-by: Ori Kam --- v3: * Address ML comments. v2: * Address ML comments. --- doc/guides/prog_guide/rte_flow.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 3e5cd1e..eada283 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -1735,6 +1735,18 @@ unspecified "best-effort" settings from the underlying PMD, which depending on the flow rule, may result in anything ranging from empty (single queue) to all-inclusive RSS. +In case there are Non-applicable RSS types in the rule, +Best effort will be used. +This may be the result of: + +- Setting both UDP and TCP on the same rule. + +- Setting RSS types that don't match the requested pattern, + for example, matching on UDP and hashing RSS on TCP. + +If requested RSS hash type is not supported in ``dev_info``. +The flow creation will fail. + Note: RSS hash result is stored in the ``hash.rss`` mbuf field which overlaps ``hash.fdir.lo``. Since `Action: MARK`_ sets the ``hash.fdir.hi`` field only, both can be requested simultaneously.