From patchwork Thu Jul 16 07:26:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 74166 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8AF2A0546; Thu, 16 Jul 2020 09:26:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 928581BEA8; Thu, 16 Jul 2020 09:26:59 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id BC4241BE95 for ; Thu, 16 Jul 2020 09:26:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594884418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uwuu0+2zK5+bLpeb/2ZpfV46VR8tVQNjUaHZpRIHjHY=; b=eVNoN0l+kKTPGgTl3VScCbuxDJgw3lQeu3MLwSnzTcccvU9yTSdzjVlrJ7TyO+8OGXBftv 78+Fmmcp1wyKG5r43n6fGZoLQYQVtWaa7VmzB5lgYaly0zDWM2SAsqP6B4Lvuo8+mrqH3f uU/SSO8SklZ0wgE+79jNsr41wnBQ0gw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-flCR2hhsM4GkREJbN9oojg-1; Thu, 16 Jul 2020 03:26:56 -0400 X-MC-Unique: flCR2hhsM4GkREJbN9oojg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A5411800D42; Thu, 16 Jul 2020 07:26:55 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.195.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 29C2B1002391; Thu, 16 Jul 2020 07:26:53 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Thomas Monjalon Date: Thu, 16 Jul 2020 09:26:48 +0200 Message-Id: <20200716072648.3076-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] devtools: forbid experimental build flag for non-examples X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation since https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5 Warn people not to copy/paste this flag that was needed before. Signed-off-by: David Marchand --- devtools/checkpatches.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 58021aa5dd..82d57b565b 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -77,6 +77,14 @@ check_forbidden_additions() { # -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 + # forbid use of experimental build flag unneeded in non-examples + awk -v FOLDERS='app lib drivers' \ + -v EXPRESSIONS='-DALLOW_EXPERIMENTAL_API allow_experimental_apis' \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Using experimental build flag for in-tree compilation' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + # svg figures must be included with wildcard extension # because of png conversion for pdf docs awk -v FOLDERS='doc' \