From patchwork Mon Jul 6 20:25:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73288 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 010A1A00C5; Mon, 6 Jul 2020 22:26:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D87F1DB88; Mon, 6 Jul 2020 22:26:46 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 486BB1DB88 for ; Mon, 6 Jul 2020 22:26:45 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202644euoutp0277cf9b9de9fec27f4fdb3ebdaaf33b69~fQ61NH7qP1760117601euoutp02y; Mon, 6 Jul 2020 20:26:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202644euoutp0277cf9b9de9fec27f4fdb3ebdaaf33b69~fQ61NH7qP1760117601euoutp02y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067204; bh=BG13JEDguLywByJwOXQTWe6Zorck+0Dg5OriYR0Hx5A=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=BYEbtouI22mQ4t4ofjrCeEW2iB90Oyb5/7YllnOqeiLDvaVP9lOY58sbhP+cc8XnS szZqtaYAgCgo4e6XQf/Nw1Tai4sbqvSSAjK+XYb2Ak1A6xtVlXLQ8KFCIwQxCIJy56 9rEVeQVhmOe0UGylXwMYx4qYDkiQP7cmGlFKPrO8= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202643eucas1p1da6ede74521ffcc522cef1b84835ec5e~fQ60LJfH40814308143eucas1p1h; Mon, 6 Jul 2020 20:26:43 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 8A.89.05997.309830F5; Mon, 6 Jul 2020 21:26:43 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202642eucas1p2929ffa3795a06b1e99d19a6b0e90da76~fQ6y_TrCp3131931319eucas1p2x; Mon, 6 Jul 2020 20:26:42 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202642eusmtrp24b228b7630808619732568ae52970af5~fQ6y9TmVv3205132051eusmtrp2k; Mon, 6 Jul 2020 20:26:42 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-8e-5f03890372dc Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 5A.3E.06017.209830F5; Mon, 6 Jul 2020 21:26:42 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202640eusmtip106d5317c52445d6d46e8af9206317659~fQ6xNNmdk1560515605eusmtip1S; Mon, 6 Jul 2020 20:26:40 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:25:51 +0300 Message-Id: <20200706202626.28628-2-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0xTdxjG8z/n9JxDZ92x4ny9Eposc2aDOfzwbnHTTaNnUxP9sriZgVWP wMbFtIK3LwQVasEqtXGjzIqAA7kqAkWCN2QgVqwlEMoEaQjzgs4CQgQFteXU6Lff/3meN8/7 Jn+eVtewc/nYhF2SLkEbp2GVTE3TuPNz+jAd9UVWZghW3LIR7LuXT6PH0sNixuBBCt3Fy7He /pcCzb0pFJrMQxTai4wsPvGkMvh02E5h9yUHh9a2VA6HGx5weMSZQ/DBxACN2bnPCDpt1Qoc v1bHoncij0HTiw6CR6tuEGzOHGLQcrGWYJpRwMGzhRzmdy/EYc8NBh1dFzgsHXXRWH1rkmBW cwXB1rTXihWh4ovcMwoxv/4RJR4/7aLFpq4TnJjZYqPE809rKdF7uYMVTVXFRLzZl0GLJf1j 7AblL8pl26W42GRJF/7tFmVMmcfM7bTO2dNrauVSSEGwkQTxICyF7PQxxkiUvFooIjBQ9B+R HyMEyrwZAecZgfLGSu7tSHnxn1OsFgoJjNXvkEOjBNIbe6YMVlgEDoON8hvBwnkW7BOdlN+Y KXwNnqGcKWaEj6H78d0pVglfgX3SpZAbQqDk3FXaz0G+fKP3Aiu3LYTOUyOB/Axoye5n/Ez7 8geqc2h5doyH7nJR5lXwxHCEkXkmDDRXBS6YD68vnqJk3g/PKzs5/6IgGAjcyzsUCC2Hqse3 fcz7Cj6FirpwWf4OroweoP0yCNPB/f8MeYXpYK75IyCrwJCmltMauNrSFpABJl9Ok2URjlq8 1DESan3vFut7t1jf1eYSupjMlpL08dGS/ssEaXeYXhuvT0qIDtuWGF9JfL/Z8ap5pJbUTWxt IAJPNNNUBpaOUiu0yfq98Q0EeFoTrPq+1RGpVm3X7t0n6RKjdElxkr6BzOMZzWxVRN6jX9VC tHaX9Lsk7ZR0b12KD5qbQj7LKZ21evc+678r15SXRFDGeTe33d9aZlp3dzCS/9m1afj2HFPs uTuzfrwfWvpDwW/mjeaQ3rMfXhqwWB7WdnELYj+Awm/OkPVNznT3sgj25P7Mf5LaeiL7OtbY UsOy3EWfCKm6xJMtowVLd2xybV77k7s6tL2+QkslXv+o/W/nePtqs4bRx2iXLKZ1eu0bTshA lskDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRjG+Z9zds6UJsdl9HeS1UKKoNW8tFcri+jD+RJ0IQK72NCTWzln O9MuH8q01JZZmlTOWNqyyyyt1JxlUaM0nSYmdlNriGGpeFkFKZptWtS3h/f5vTd4xKS0TiQT a5OMvCFJnSinfSnnr4buZcQpMnaFvdsPKpotCHo+WklwFXTTcHrkBAHvbGuhruayCPI/pRGQ mz9KQM1NEw2DrnQKhtw1BHQ9djJgfp3OgNvRx8CZ1iIEfRP9JBQWf0PQaqkWwdizhzQMT1yl IHe8A8HZqpcIGnJGKSiotSPINLEwcusGA9auYHC7XlLgfF/JwO0fbSRUN08iyGuoQNCSOSVa t5AbLy4Vcda6rwR3vqSN5OrfX2C4nEYLwd0bshPc8JMOmsutsiGuqec0yZX1/qQ3+cYoVhv0 KUZ+gUYvGNfIdyghVKGMBEVoeKRCGabaFRUaIV8evTqeT9Sm8obl0XsUmjuufCbZHHjoU24L k4auBZiQjxiz4bjcdokxIV+xlC1F2Nl+lTIhscfAeKCXnGFm44k3JnqG+YZwbeeYyGvQ7BLs zLYQXiOA7aRxe9ZxymvMZqOwa7SI8GqKDcFdA53TWsJG4prJNtHM1Pm47O7T6Q0+Hv75cCXt 1VJWi7sfWNGMDsZvr3z/0+uPGwt7p48j2cW4wiL1lknPmIzqIvIc8jf/R5n/Ueb/qGJE2lAA nyLoEnRCqEJQ64SUpARFnF53H3mS86B+rMqOTENbHYgVI/ksSTZNxkpF6lThsM6BsJiUB0jW tzh3SyXx6sNHeIM+1pCSyAsOFOF5M4+UzYnTe3KYZIxVRihVEKlUhanCVoJ8riSbfbZTyiao jfx+nk/mDX/7CLGPLA2V5jBHr2s+muNczleaCeX2kgOfZRus81eFuNzZ90869ms+b86rzOoP GwoxBcVbdnBNqdbC14Exe3sGtS/aG9LG0w8GBsv23e3oupiVoXhcFfPh7KwtxvqouW77xqCy wCOLEhi/qPjGuhWq2i9NpdvKNzltx/q2TGlLEt/4jxY8CpknpwSNWrmUNAjq3/Prpz9PAwAA X-CMS-MailID: 20200706202642eucas1p2929ffa3795a06b1e99d19a6b0e90da76 X-Msg-Generator: CA X-RootMTR: 20200706202642eucas1p2929ffa3795a06b1e99d19a6b0e90da76 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202642eucas1p2929ffa3795a06b1e99d19a6b0e90da76 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 01/25] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is optional. The value ETH_SPEED_NUM_NONE (0) was already part of the API. The value ETH_SPEED_NUM_UNKNOWN (infinite) is added to cover two different cases: - speed is not known by the driver - device is virtual Suggested-by: Morten Brørup Suggested-by: Benoit Ganne Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index a49242bcd..2090af501 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -303,6 +303,7 @@ struct rte_eth_stats { #define ETH_SPEED_NUM_56G 56000 /**< 56 Gbps */ #define ETH_SPEED_NUM_100G 100000 /**< 100 Gbps */ #define ETH_SPEED_NUM_200G 200000 /**< 200 Gbps */ +#define ETH_SPEED_NUM_UNKNOWN UINT32_MAX /**< Unknown */ /** * A structure used to retrieve link-level information of an Ethernet port. @@ -2262,15 +2263,16 @@ int rte_eth_allmulticast_disable(uint16_t port_id); int rte_eth_allmulticast_get(uint16_t port_id); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It might need - * to wait up to 9 seconds in it. + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). + * + * It might need to wait up to 9 seconds. + * @see rte_eth_link_get_nowait. * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. @@ -2279,15 +2281,13 @@ int rte_eth_allmulticast_get(uint16_t port_id); int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It is a no-wait - * version of rte_eth_link_get(). + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. From patchwork Mon Jul 6 20:25:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73289 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17F67A00C5; Mon, 6 Jul 2020 22:27:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A6BB1DBDC; Mon, 6 Jul 2020 22:26:49 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id CFAE11DBD2 for ; Mon, 6 Jul 2020 22:26:47 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202647euoutp02ee4801d61d941a8934cd2143dd52cb27~fQ63offde2313123131euoutp02F; Mon, 6 Jul 2020 20:26:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202647euoutp02ee4801d61d941a8934cd2143dd52cb27~fQ63offde2313123131euoutp02F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067207; bh=bD6exGuCIqpNjp7dVHSb8nnuGQ3GW2DEMrleMuU6VqY=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=CcSE7YPtGdeaqqmTZHXX7XNv9Wj9btkxycfSBQvx6lfWt5fQ1fIaAPpyf9AfpVVbY Wx13/TQJehEasFQjOARcO+2hV4ewwTuIrzovVXFBHCD5uT/neQaeRqyL3vfMb5Oup5 zS3ks7SLDmiuJ1cvXxfjfS9Ea/P+BtCnnZzUH+aw= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202646eucas1p172985330db1c86069e8889813c07a14f~fQ62hrMz40323603236eucas1p1m; Mon, 6 Jul 2020 20:26:46 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 9D.A4.06456.509830F5; Mon, 6 Jul 2020 21:26:45 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202645eucas1p13880f5302149ddf67a2f814290111286~fQ6124nQ41288012880eucas1p1a; Mon, 6 Jul 2020 20:26:45 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202645eusmtrp2585cbfb70827261ec1d05ffc4b24063f~fQ612GfqC3205132051eusmtrp2l; Mon, 6 Jul 2020 20:26:45 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-dc-5f03890552e6 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 7C.3E.06017.509830F5; Mon, 6 Jul 2020 21:26:45 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202643eusmtip14484a4f5a638478778f4ad936156a931~fQ60D1LDA1500415004eusmtip1R; Mon, 6 Jul 2020 20:26:43 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:25:52 +0300 Message-Id: <20200706202626.28628-3-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxSHc+43nXXXq4tnzmjsRvyKqGHLzoyZzph5N5Nl2bItMVGseoNm gKYVlZklxAnBwhgWNzKoBSELFUwQaaGiKCJSWCkMEoY6ddUYFVRasVVRlFEuZv895/md857k 5JVY5VdhlrQjbbdmSTOnmAQDV9820rWEP8QmLct0rKCaTifQrRsVLAWPXBcoN3yQoctVq+hs g4Mn+7+ZDOXbHzHU4LIJ9CB4gKOh4QaGrjX5RSruPSDScMtdkX7uLgG6OzrI0u9lj4G6nR6e Ri40ChQaLeco/3kf0C/udiBf3iOOjpz2AmXbZAofrxSp4tocGg62c+S/UifSiWgPS57Ol0CH fTVAgewxfvU89XnZH7xacXaAUQuP9bBq25XfRDWvw8motUNeRg2d6xPUfHcVqH/eymXV6tvP hC8NGwwrt2kpO/ZolqUfbzZsj9S1sbvOF8G+c/ey+Uzw77NBnITy+1j19CZvA4OkyC5Ah6eZ 04sIYMdAraAXjwGd3Ue51yNhV6sYY0WuBPSFp+pNUcBINIuJBYK8AP05TiYWzJBrBWwY7Z8I psvr8KfqPIgxJ8fjnULXhDfKH+H1Aa+gb5iL1Seb2RjHySuwNVQn6NvmYH9pZOJRlP+S0N3q 5fWBtXh/8Jmo83Qc9LkneTaOnS5ldN6PT0/1i/pwDuCN8qzJplXovt81zpLEyguxpnGprj/B fzqjExrlqXj54bSYZsfRXl/E6tqIOdmK3m3C5o7eSY348sUUXasYCJeL+n2aAHtGjokFMLf4 /11lAFUwU0u3piZr1uVp2t4EqznVmp6WnLB1Z+opGP+s/le+YS9Ee7e0gCyBaYoxKLFJCm/e Y81IbQGUWNMM45qAf5Ni3GbO+EGz7EyypKdo1hZ4R+JMM42J5QMbFTnZvFv7XtN2aZbXKSPF zcqEQ51ZcmXC4YtPHpQot99KNPWceC8o5ColhffWfNF98cITzlPf4fhq3mcFP9Y//DayrqD6 qm29XcgKscV/xw8WLzv5KtBkzw1ccmYENwvqWNenTHv8N2+PxjmhzZU8/8Ov3w19l043P1/0 5tUzH/QtFhpnr32j1+OAoprj+7esfrFhKNHEWbebly9iLVbzfyHhXp+oAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH/d17d+9VXF2W1S+h1ySSwOV8tGOZlv90IZAiIShzjrw407nY na+gMI1l07S0B6ktH1SmkuVrK8xyiFprWEqWlCYh9jI1LXywHi7pvy/n8z3nfOEclpTNUr5s UqpRMKRqUuS0F+X43T0UIDlHqgNdzpXQ8NyC4MNwNQkjl4ZoyJ86Q8Cb2khos5ZLoPh9NgGF xd8JsNaYaRgfyaFgYtpKwLtHDgZK+3IYmLZ/ZOB8bxmCj64vJFyrmEHQa2mRwHzHQxomXVUU FC68QlDU3IOgu+A7BZce2BCYzBxM3bnNQPW7dTA90kOBY7CJgfqfL0loef4LwcXuBgRO0x/J ro38QsVNCV/d9pngSypfknzX4BWGL3hqIfj7EzaCn2x/RfOFzbWIf/Yhn+TrRufofV6HFOEG fZpR2KDVi8ad8sNKCFIow0ARFBKmUAarjmwPCpVvjQhPEFKS0gXD1oh4hfZHUxd5/PFVlNn+ ySTJRo5MM/JkMReCp2o6GTPyYmXcTYStXcWUGbGLAOOvo+SSZwV2DZjpJc8MwkU9nyRuQHP+ 2JFnIdzAh3tL4/6zpyk3WMHtwbl1BcitKW4THiupIdxayoXhoc82emnqelx378m/DZ7cdtw5 2fSvLuOS8FBrNVrS6/DrGz+IC2hZBfKoRT5CmqhL1IlBClGjE9NSExVH9bpGtHj01q75Zhsy TxywI45Fcm9pHk2qZRJNupilsyPMknIfaZTTESeTJmiyTggGvdqQliKIdhS6GPAi6bvyqH7x hVKNamWoUgVhSlWwKngbyFdL87iOWBmXqDEKyYJwXDD87yNYT99sFGNlq+YsiVpk64ns7Xjj yv6j9neOVcYHV0YaT7VE5a46O76pr7z0es6LHSW/7dFi9MH6QENC354B086SzZdVUceY5fpv mjV7G8874vVPdw/H3m033U/JYjJu/VoYDuh3ZrYWta0ty4+L9uNPamm//d4ZEcu8Yjzq+5O/ qYq7Z2k5JWo1yi2kQdT8Bb0c9tIKAwAA X-CMS-MailID: 20200706202645eucas1p13880f5302149ddf67a2f814290111286 X-Msg-Generator: CA X-RootMTR: 20200706202645eucas1p13880f5302149ddf67a2f814290111286 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202645eucas1p13880f5302149ddf67a2f814290111286 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 02/25] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit add function which treat link status structure and format it to text representation. Signed-off-by: Ivan Dyukov --- MAINTAINERS | 1 + app/test/Makefile | 3 + app/test/meson.build | 2 + app/test/test_ethdev_link.c | 278 +++++++++++++++++++++++ lib/librte_ethdev/rte_ethdev.c | 169 ++++++++++++++ lib/librte_ethdev/rte_ethdev.h | 54 +++++ lib/librte_ethdev/rte_ethdev_version.map | 4 + 7 files changed, 511 insertions(+) create mode 100644 app/test/test_ethdev_link.c diff --git a/MAINTAINERS b/MAINTAINERS index 5e706cd7e..f4fb31ea2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -393,6 +393,7 @@ T: git://dpdk.org/next/dpdk-next-net F: lib/librte_ethdev/ F: devtools/test-null.sh F: doc/guides/prog_guide/switch_representation.rst +F: app/test/test_ethdev* Flow API M: Ori Kam diff --git a/app/test/Makefile b/app/test/Makefile index e5440774b..9f43b8c3c 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -251,6 +251,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_SECURITY) += test_security.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c test_ipsec_perf.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec_sad.c + +SRCS-$(CONFIG_RTE_LIBRTE_ETHER) += test_ethdev_link.c + ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y) LDLIBS += -lrte_ipsec endif diff --git a/app/test/meson.build b/app/test/meson.build index 56591db4e..6df31a4dc 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -39,6 +39,7 @@ test_sources = files('commands.c', 'test_efd.c', 'test_efd_perf.c', 'test_errno.c', + 'test_ethdev_link.c', 'test_event_crypto_adapter.c', 'test_event_eth_rx_adapter.c', 'test_event_ring.c', @@ -199,6 +200,7 @@ fast_tests = [ ['eal_flags_misc_autotest', false], ['eal_fs_autotest', true], ['errno_autotest', true], + ['ethdev_link_status' true], ['event_ring_autotest', true], ['fib_autotest', true], ['fib6_autotest', true], diff --git a/app/test/test_ethdev_link.c b/app/test/test_ethdev_link.c new file mode 100644 index 000000000..4ece44a5b --- /dev/null +++ b/app/test/test_ethdev_link.c @@ -0,0 +1,278 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2020 Samsung Electronics Co., Ltd All Rights Reserved + */ + +#include +#include + +#include +#include "test.h" + + +static int32_t +test_link_status_up_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + printf("Default link up #1: %s\n", text); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 2.5 Gbit/s FDX Autoneg\n", + text, strlen(text), "Invalid default link status string"); + + link_status.link_duplex = ETH_LINK_HALF_DUPLEX; + link_status.link_autoneg = ETH_LINK_FIXED; + link_status.link_speed = ETH_SPEED_NUM_10M, + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + printf("Default link up #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 10 Mbit/s HDX Fixed\n", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + link_status.link_speed = ETH_SPEED_NUM_UNKNOWN, + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + printf("Default link up #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at Unknown speed HDX Fixed\n", + text, strlen(text), "Invalid default link status " + "string with HDX"); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_down_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 128, NULL, &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link down\n", + text, strlen(text), "Invalid default link status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_string_overflow(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + + ret = rte_eth_link_strf(NULL, 2, "status %S, %G Gbits/s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Format string should fail, but it's ok\n"); + + ret = rte_eth_link_strf(text, 2, "status %S, %G Gbits/s", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Format string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[2] == 'Y', "String1 overflow\n"); + + ret = rte_eth_link_strf(text, 8, NULL, + &link_status); + RTE_TEST_ASSERT(ret < 0, "Default format string should fail," + " but it's ok\n"); + RTE_TEST_ASSERT(text[8] == 'Y', "String1 overflow\n"); + + ret = rte_eth_link_strf(text, 10, NULL, + &link_status); + RTE_TEST_ASSERT(ret < 0, "Default format string should fail," + " but it's ok\n"); + RTE_TEST_ASSERT(text[10] == 'Y', "String1 overflow\n"); + + text[1] = 'Y'; + ret = rte_eth_link_strf(text, 1, "%S", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string should fail, but it's ok\n"); + RTE_TEST_ASSERT(text[1] == 'Y', "String1 overflow\n"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_format(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + printf("status format #1: %s\n", text); + ret = rte_eth_link_strf(text, 128, "status = %S, duplex = %D\n", + &link_status); + printf("status format #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = Up, duplex = FDX\n", + text, strlen(text), "Invalid status string1."); + + ret = rte_eth_link_strf(text, 128, "%A", &link_status); + printf("status format #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Autoneg", + text, strlen(text), "Invalid status string2."); + + ret = rte_eth_link_strf(text, 128, + "%G", + &link_status); + printf("status format #4: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("40.0", + text, strlen(text), "Invalid status string3."); + + ret = rte_eth_link_strf(text, 128, + "%M", + &link_status); + printf("status format #5: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("40000", + text, strlen(text), "Invalid status string4."); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_return_value(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + int i = 0; + for (i = 0; i < 128; i++) + text[i] = 'Y'; + text[127] = '\0'; + ret = rte_eth_link_strf(text, 128, "status = %S, ", + &link_status); + printf("return value #1:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_strf(text + ret, 128 - ret, + "%A", + &link_status); + printf("return value #2:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_strf(text + ret, 128 - ret, + ", duplex = %D\n", + &link_status); + printf("return value #3:ret=%u, text=%s\n", ret, text); + ret += rte_eth_link_strf(text + ret, 128 - ret, + "%M Mbits/s\n", + &link_status); + printf("return value #4:ret=%u, text=%s\n", ret, text); + RTE_TEST_ASSERT(ret > 0, "Failed to format string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("status = Up, Autoneg, duplex = FDX\n" + "40000 Mbits/s\n", + text, strlen(text), "Invalid status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_invalid_fmt(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_40G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 128, "status = %", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string1 should fail, but it's ok\n"); + ret = rte_eth_link_strf(text, 128, + ", duplex = %d\n", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string2 should fail, but it's ok\n"); + ret = rte_eth_link_strf(text, 128, + "% Mbits/s\n", + &link_status); + RTE_TEST_ASSERT(ret < 0, "Status string3 should fail, but it's ok\n"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_format_edges(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_UNKNOWN, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_HALF_DUPLEX + }; + char text[128]; + ret = rte_eth_link_strf(text, 4, "%S", &link_status); + printf("format edges #1: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_strf(text, 6, "123%D", &link_status); + printf("format edges #2: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_strf(text, 7, "%A", &link_status); + printf("format edges #3: %s\n", text); + RTE_TEST_ASSERT(ret < 0, "It should fail. No space for " + "zero terminator\n"); + ret = rte_eth_link_strf(text, 8, "%A", &link_status); + printf("format edges #4: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "It should ok, but it fails\n"); + return TEST_SUCCESS; +} +static struct unit_test_suite link_status_testsuite = { + .suite_name = "link status formating", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_link_status_up_default), + TEST_CASE(test_link_status_down_default), + TEST_CASE(test_link_status_string_overflow), + TEST_CASE(test_link_status_format), + TEST_CASE(test_link_status_format_edges), + TEST_CASE(test_link_status_invalid_fmt), + TEST_CASE(test_link_status_return_value), + TEST_CASES_END() /**< NULL terminate unit test array */ + } +}; + +static int +test_link_status(void) +{ + rte_log_set_global_level(RTE_LOG_DEBUG); + rte_log_set_level(RTE_LOGTYPE_EAL, RTE_LOG_DEBUG); + + return unit_test_suite_runner(&link_status_testsuite); +} + +REGISTER_TEST_COMMAND(ethdev_link_status, test_link_status); diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index d06b7f9b1..ef5d6ac8c 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -2383,6 +2383,175 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) return 0; } +static int +rte_eth_link_strf_parser(char *str, size_t len, const char *const fmt, + struct rte_eth_link *link) +{ + size_t offset = 0; + const char *fmt_cur = fmt; + char *str_cur = str; + double gbits = (double)link->link_speed / 1000.; + static const char AUTONEG_STR[] = "Autoneg"; + static const char FIXED_STR[] = "Fixed"; + static const char FDX_STR[] = "FDX"; + static const char HDX_STR[] = "HDX"; + static const char UNKNOWN_STR[] = "Unknown"; + static const char UP_STR[] = "Up"; + static const char DOWN_STR[] = "Down"; + + char gbits_str[20]; + char mbits_str[20]; + /* preformat complex formating to easily concatinate it further */ + snprintf(mbits_str, 20, "%u", link->link_speed); + snprintf(gbits_str, 20, "%.1f", gbits); + /* init str before formating */ + str[0] = 0; + while (*fmt_cur) { + /* check str bounds */ + if (offset > (len - 1)) { + str[len - 1] = '\0'; + return -1; + } + if (*fmt_cur == '%') { + /* set null terminator to current position, + * it's required for strlcat + */ + *str_cur = '\0'; + switch (*++fmt_cur) { + /* Speed in Mbits/s */ + case 'M': + if (link->link_speed == + ETH_SPEED_NUM_UNKNOWN) + offset = strlcat(str, UNKNOWN_STR, + len); + else + offset = strlcat(str, mbits_str, len); + break; + /* Speed in Gbits/s */ + case 'G': + if (link->link_speed == + ETH_SPEED_NUM_UNKNOWN) + offset = strlcat(str, UNKNOWN_STR, + len); + else + offset = strlcat(str, gbits_str, len); + break; + /* Link status */ + case 'S': + offset = strlcat(str, link->link_status ? + UP_STR : DOWN_STR, len); + break; + /* Link autoneg */ + case 'A': + offset = strlcat(str, link->link_autoneg ? + AUTONEG_STR : FIXED_STR, len); + break; + /* Link duplex */ + case 'D': + offset = strlcat(str, link->link_duplex ? + FDX_STR : HDX_STR, len); + break; + /* Error cases */ + default: + return -1; + + } + if (offset > (len - 1)) + return -1; + + str_cur = str + offset; + } else { + *str_cur++ = *fmt_cur; + offset++; + } + fmt_cur++; + } + *str_cur = '\0'; + return offset; +} + +int +rte_eth_link_printf(const char *const fmt, + struct rte_eth_link *link) +{ + char text[200]; + int ret; + ret = rte_eth_link_strf(text, 200, fmt, link); + if (ret > 0) + printf("%s", text); + return ret; +} + +int +rte_eth_link_strf(char *str, size_t len, const char *const fmt, + struct rte_eth_link *link) +{ + size_t offset = 0; + double gbits = (double)link->link_speed / 1000.; + char gbits_str[20]; + char mbits_str[20]; + /* TBD: make it international? */ + static const char LINK_DOWN_STR[] = "Link down\n"; + static const char LINK_UP_STR[] = "Link up at "; + static const char UNKNOWN_SPEED_STR[] = "Unknown speed "; + static const char MBITS_STR[] = "Mbit/s"; + static const char GBITS_STR[] = "Gbit/s"; + static const char FDX_STR[] = "FDX "; + static const char HDX_STR[] = "HDX "; + /* autoneg is latest param in default string, so add '\n' */ + static const char AUTONEG_STR[] = "Autoneg\n"; + static const char FIXED_STR[] = "Fixed\n"; + if (str == NULL || len == 0) + return -1; + /* default format string, if no fmt is specified */ + if (fmt == NULL) { + if (link->link_status == ETH_LINK_DOWN) { + if (sizeof(LINK_DOWN_STR) > len) + return -1; + return strlcpy(str, LINK_DOWN_STR, len); + } + + /* preformat complex strings to easily concatinate it further */ + snprintf(mbits_str, 20, "%u %s ", link->link_speed, MBITS_STR); + snprintf(gbits_str, 20, "%.1f %s ", gbits, GBITS_STR); + + offset = strlcpy(str, LINK_UP_STR, len); + /* reserve one byte to null terminator */ + if (offset > (len - 1)) + return -1; + /* link speed */ + if (link->link_speed == ETH_SPEED_NUM_UNKNOWN) { + offset = strlcat(str, UNKNOWN_SPEED_STR, len); + if (offset > (len - 1)) + return -1; + } else { + if (link->link_speed < ETH_SPEED_NUM_1G) { + offset = strlcat(str, mbits_str, len); + if (offset > (len - 1)) + return -1; + } else { + offset = strlcat(str, gbits_str, len); + if (offset > (len - 1)) + return -1; + } + } + /* link duplex */ + offset = strlcat(str, link->link_duplex ? + FDX_STR : HDX_STR, len); + if (offset > (len - 1)) + return -1; + /* link autonegotiation */ + offset = strlcat(str, link->link_autoneg ? + AUTONEG_STR : FIXED_STR, len); + if (offset > (len - 1)) + return -1; + /* Formated status */ + } else + offset = rte_eth_link_strf_parser(str, len, fmt, link); + + return offset; +} + int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) { diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 2090af501..580f89382 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -2295,6 +2295,60 @@ int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); */ int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link); + +/** + * print formated link status to stdout. This function threats all + * special values like ETH_SPEED_NUM_UNKNOWN, ETH_LINK_DOWN etc. and convert + * them to textual representation. + * + * @param fmt + * Format string which allow to format link status. If NULL is provided + * , default formating will be applied. + * Following specifiers are available: + * - '%M' link speed in Mbits/s + * - '%G' link speed in Gbits/s + * - '%S' link status. e.g. Up or Down + * - '%A' link autonegotiation state + * - '%D' link duplex state + * @param link + * Link status provided by rte_eth_link_get function + * @return + * - Number of bytes written to stdout. In case of error, -1 is returned. + * + */ +__rte_experimental +int rte_eth_link_printf(const char *const fmt, + struct rte_eth_link *link); + +/** + * Format link status to textual representation. This function threats all + * special values like ETH_SPEED_NUM_UNKNOWN, ETH_LINK_DOWN etc. and convert + * them to textual representation. + * + * @param str + * A pointer to a string to be filled with textual representation of + * device status. + * @param len + * Length of available memory at 'str' string. + * @param fmt + * Format string which allow to format link status. If NULL is provided + * , default formating will be applied. + * Following specifiers are available: + * - '%M' link speed in Mbits/s + * - '%G' link speed in Gbits/s + * - '%S' link status. e.g. Up or Down + * - '%A' link autonegotiation state + * - '%D' link duplex state + * @param link + * Link status provided by rte_eth_link_get function + * @return + * - Number of bytes written to str array. In case of error, -1 is returned. + * + */ +__rte_experimental +int rte_eth_link_strf(char *str, size_t len, const char *const fmt, + struct rte_eth_link *eth_link); + /** * Retrieve the general I/O statistics of an Ethernet device. * diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map index 715505604..6c80597d1 100644 --- a/lib/librte_ethdev/rte_ethdev_version.map +++ b/lib/librte_ethdev/rte_ethdev_version.map @@ -241,4 +241,8 @@ EXPERIMENTAL { __rte_ethdev_trace_rx_burst; __rte_ethdev_trace_tx_burst; rte_flow_get_aged_flows; + + # added in 20.08 + rte_eth_link_strf; + rte_eth_link_printf; }; From patchwork Mon Jul 6 20:25:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73290 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9443A00C5; Mon, 6 Jul 2020 22:27:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A1491DC80; Mon, 6 Jul 2020 22:26:51 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id AD94D1DC30 for ; Mon, 6 Jul 2020 22:26:49 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202649euoutp0293e42927a463f9315b3419a1100e3c03~fQ65iaPoV1760817608euoutp021; Mon, 6 Jul 2020 20:26:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202649euoutp0293e42927a463f9315b3419a1100e3c03~fQ65iaPoV1760817608euoutp021 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067209; bh=xmD2mOfSPYEySXTKCkIqMp30Ohht0MjEUFipNVMWweQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=vhgqpzoZvNsu+CnnonJof/duJ98+HYzl0uNP0XQOmx9T05fnRFg3Dykb28TxAXJN+ akFaH7nwfPkcOzOH750zO8XTpe2Qf3FcO0nHnCGXjCN3P7fp7rPECuTh+3jW/wB9Om n2QIOCb/iY+cHVyb30ZmZ8t8JaJS7FdSFnsGtMLA= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202648eucas1p1442491ef0fcb4b06233029e4fecef5cc~fQ65BGOuG1288412884eucas1p1h; Mon, 6 Jul 2020 20:26:48 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id AC.89.05997.809830F5; Mon, 6 Jul 2020 21:26:48 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202648eucas1p17baebff6b2420c5b1c9e53a5dd51998c~fQ64fWGyO1287412874eucas1p1l; Mon, 6 Jul 2020 20:26:48 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706202648eusmtrp110ed84e8df31f80e1cbddcd265cd8783~fQ64eQjmE2178321783eusmtrp1k; Mon, 6 Jul 2020 20:26:48 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-95-5f03890887b0 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 10.AF.06314.809830F5; Mon, 6 Jul 2020 21:26:48 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202646eusmtip15870affda4678ca6e50552535cabf46d~fQ62qQaWH1560515605eusmtip1T; Mon, 6 Jul 2020 20:26:46 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:25:53 +0300 Message-Id: <20200706202626.28628-4-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwTdxjH89xd747Gmlsh8YlbNGtm9hKBqTifmUWdW5bbyx9z2R/GBFmH NzQCsp64odlCGCtYATfEEWSp2GYTUMekhSKILwUtWIqR2YDGMeiMDFBQXpxi2Ua5mv33+X1f nueXX34iazzMLxZ3ZO5WLJnmdBOv5xovP+6OF/ezKa9O9S+nui47UKjfydJA2e88Hbifz1Bf 7Xo66/lRR6V/5DJUUvqAIU+1jae7A3kcjU14GLrV6hfoSE+eQBPeIYGKr1YCDYVHWKqomgS6 am/Q0eOLzTyNhx0clcwEgQ66O4B8RQ84KjvTBGS1SXS/5rhAzltLaGKggyP/DZdAJ6evsdTQ NQv0va8OKGD9V7fheXmm6ied7Dw7zMiHjl1j5cs3fhDkok47I58ea2Lk8XNBXi5x14J8JXSA lU/cfsR/qN+if2Obkr5jj2JJXPeJfrvr0iibVZbw5XBfDeTCwxdsECOilISjoUrGBnrRKFUD /nXwMKcdpgBdt71RZxLwidspPK38Eu6Jpo4D3ryTH01NA5ZXWCGS4qWX0F9onzfipNM8esK9 TMSIldZh+ahjnjlpGRbf9c2PNUivY32LH7QVS/HErxfYCMdIa7F93MVH2Cgtwd6jU/NDUeoS 8efrAV4rvI22/fZoORZHfO7oXZ9D/6EiTuN9+Hd9r6CVCwH7Hd9GQ+vRPdo9x6LISi9jXXOi Jr+JwWonE5FRWoh9956JyOwcljaWs5pswEKrUUub8EJnT1RGnH2yQJNlLBloi75PK2B7S4Hu O1h65P9dVQC1sEjJVjPSFHVlpvJFgmrOULMz0xJSd2XUw9xn9f/jm2qC5vCnXpBEMC0wFPJs ilFn3qPmZHgBRdYUZ9gY8G81GraZc/Yqll0plux0RfXCsyJnWmRY5RhONkpp5t3KTkXJUixP XUaMWZwLO8sr1PeSC76a/TOv+OTgslNy2r6G32qmV8ktg5s+n2w/Vh2/puOOfH1FX9bH5wMb j66ktoKAc0Pj+zeTXvtoONW7Zu/FyXfeqgs8SjqVqnN1zrRZP9CHPC2xlfCZY3MIh/ITFz5c nR0cpOCLyV2YM/Lu1q+/wStja890C/Gt0r24zSZO3W5e8QprUc3/AXmUJWOoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917dzfN5XUZ/RKyGgUhNJu6PJppJdkliCKJwEwbdtGR22R3 W6ZIZmk2H6nZu9Q0qTQy31YWNTK1aaFhKmqJGGaKzidZ9phK/3043+/58oVzRKRkhnIRqTR6 TqdRRktpe8ryp7Fvi+giGb61dVYAZS15CAY+F5HQn9tHQ5r1PAFdJQFQX3tbADlfEgnIzJkg oPaBiYbR/iQKxiZrCeh9YRHCzfYkIUyah4SQ8eEWgqH57yTcKJhC8CGvWgBzr5/RMD5fSEHm zw4El6qaEDSmT1CQ+7QOQYqJAevD+0Io6nWFyf4mCizdlUJ4NNNGQnXLbwTZjWUIWlP+CnZu YH8WFAvYovphgr18t41k33ZfFbLpzXkEWz5WR7DjLztoNrOqBLHvBtJItnTwB33QPkTmp9Ma 9Nz6KC2v3yE9KgcPmdwHZB5ePjK5p/cxXw+F1N3f7wQXrTJyOnf/47KoyoYRMiZXFjvc9RAl otmNJmQnwowXfjzfTi2whClGOP1XmAmJbHOMRwbJJctKPP/JRJuQvc0yhXBzz5VFgWY2Y0tq HrEgODM9NP544exi0ErGH18bKSQWmGI24YzRRuECixkfXPHcgpZS1+HSJ68Wg+wYX/xmvJJe KqHCfTVFaIldcWf+NJGFVhSgZSXImTPw6kg1L5fxSjVv0ETKIrTqCmQ7ec3buco61F4ebEaM CEkdxKk0GS4RKI38abUZYREpdRbvbrWEScQnlKfjOJ02XGeI5ngzUtgKZpMuqyK0tgfS6MPl Crk3+Mi9Pb09t4F0tTiVeR0qYSKVeu4kx8Vwuv97hMjOJREtT3DtUgRdt3aG1PJD5ojb9+yW GWc1Y4XtTfr3e+OfHrLm7J9uyI932JcVyj7rtxrWhLmkzQxExcWCW33xrcnSCu23nvVBSLX9 jNWxwRqUrTKayxRfnQKd9py3NzsEwdeEpGRJCHP4TuCslg+Ii4xOntjlGMweCG4513Fq7bUj UoqPUsrdSB2v/AeKgybBCAMAAA== X-CMS-MailID: 20200706202648eucas1p17baebff6b2420c5b1c9e53a5dd51998c X-Msg-Generator: CA X-RootMTR: 20200706202648eucas1p17baebff6b2420c5b1c9e53a5dd51998c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202648eucas1p17baebff6b2420c5b1c9e53a5dd51998c References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 03/25] app: UNKNOWN link speed print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 9 +++------ app/test-pipeline/init.c | 11 +++++------ app/test-pmd/config.c | 20 ++++++++++++-------- app/test-pmd/testpmd.c | 9 +-------- app/test/test_pmd_perf.c | 17 +++++++---------- 5 files changed, 28 insertions(+), 38 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab..4a4c572c3 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -685,12 +685,9 @@ show_port(void) printf("Link get failed (port %u): %s\n", i, rte_strerror(-ret)); } else { - printf("\t -- link speed %d duplex %d," - " auto neg %d status %d\n", - link.link_speed, - link.link_duplex, - link.link_autoneg, - link.link_status); + rte_eth_link_printf("\t -- link speed: %M, duplex: %D," + " auto neg: %A, status: %S\n", + &link); } printf("\t -- promiscuous (%d)\n", rte_eth_promiscuous_get(i)); diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index 67d54ae05..b59064672 100644 --- a/app/test-pipeline/init.c +++ b/app/test-pipeline/init.c @@ -155,7 +155,7 @@ static void app_ports_check_link(void) { uint32_t all_ports_up, i; - + char link_status_text[50]; all_ports_up = 1; for (i = 0; i < app.n_ports; i++) { @@ -173,12 +173,11 @@ app_ports_check_link(void) all_ports_up = 0; continue; } - - RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", + rte_eth_link_strf(link_status_text, 50, "(%G Gbps) %S", + &link); + RTE_LOG(INFO, USER1, "Port %u %s\n", port, - link.link_speed / 1000, - link.link_status ? "UP" : "DOWN"); - + link_status_text); if (link.link_status == ETH_LINK_DOWN) all_ports_up = 0; } diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a7112c998..cb2795a94 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -604,10 +604,9 @@ port_infos_display(portid_t port_id) } else printf("\nmemory allocation on the socket: %u",port->socket_id); - printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); - printf("Link speed: %u Mbps\n", (unsigned) link.link_speed); - printf("Link duplex: %s\n", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_printf("\nLink status: %S\n" + "Link speed: %M Mbps\n" + "Link duplex: %D\n", &link); if (!rte_eth_dev_get_mtu(port_id, &mtu)) printf("MTU: %u\n", mtu); @@ -730,6 +729,8 @@ port_summary_display(portid_t port_id) struct rte_eth_link link; struct rte_eth_dev_info dev_info; char name[RTE_ETH_NAME_MAX_LEN]; + char status_text[6]; + char speed_text[12]; int ret; if (port_id_is_invalid(port_id, ENABLED_WARN)) { @@ -750,12 +751,14 @@ port_summary_display(portid_t port_id) if (ret != 0) return; - printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\n", + rte_eth_link_strf(status_text, 6, "%S", &link); + rte_eth_link_strf(speed_text, 12, "%M", &link); + printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %sMbps\n", port_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, - dev_info.driver_name, (link.link_status) ? ("up") : ("down"), - (unsigned int) link.link_speed); + dev_info.driver_name, status_text, + speed_text); } void @@ -3899,7 +3902,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) ret = eth_link_get_nowait_print_err(port_id, &link); if (ret < 0) return 1; - if (rate > link.link_speed) { + if (link.link_speed != ETH_SPEED_NUM_UNKNOWN && + rate > link.link_speed) { printf("Invalid rate value:%u bigger than link speed: %u\n", rate, link.link_speed); return 1; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4989d22ca..a1b9c1c1c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3010,14 +3010,7 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. speed %u Mbps- %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_printf(NULL, &link); continue; } /* clear all_ports_up flag if any link down */ diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index 352cd4715..7ebe4efae 100644 --- a/app/test/test_pmd_perf.c +++ b/app/test/test_pmd_perf.c @@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status[50]; printf("Checking link statuses...\n"); fflush(stdout); @@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) { - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - if (link_mbps == 0) - link_mbps = link.link_speed; - } else - printf("Port %d Link Down\n", portid); + if (link.link_status && link_mbps == 0) + link_mbps = link.link_speed; + + rte_eth_link_strf(link_status, 50, NULL, + &link); + printf("Port %d %s\n", portid, link_status); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:25:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73291 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 007A3A00C5; Mon, 6 Jul 2020 22:27:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 908021DC74; Mon, 6 Jul 2020 22:26:55 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id B4A5B1DC8A for ; Mon, 6 Jul 2020 22:26:53 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202653euoutp015018deaf9c0f5b063c2d29c1530ae03c~fQ69Fi_KR3113131131euoutp01r; Mon, 6 Jul 2020 20:26:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202653euoutp015018deaf9c0f5b063c2d29c1530ae03c~fQ69Fi_KR3113131131euoutp01r DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067213; bh=uryTUJWnZHC1KobIzwDiYco1DBs90ldLDdgUZPnDwJM=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=T517KIdYP3zyvYD108r7npDztvhHtwJQWLApyhD5Rd0euHZgkwUvgU2MM3wp+aJl9 iVeneAxD1je3lcMBPZLepUrmoiZ/fwve7XF/JTdeKr9QKlkXdVtemhrIxlz6wqYVkQ bhWd9kC/1Ruo4vhSbEVPMQTa0GCUuAmzPevK8yMg= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202652eucas1p2d08b104fb82999813a52cc6f58c5f809~fQ68Kol250115501155eucas1p2h; Mon, 6 Jul 2020 20:26:52 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 51.96.06318.C09830F5; Mon, 6 Jul 2020 21:26:52 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202650eucas1p129e158e9a86b26d047a592c32d019ab3~fQ66_tFiC0787207872eucas1p1V; Mon, 6 Jul 2020 20:26:50 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706202650eusmtrp112d6002fc60cfe81ebfcd36c723fcaaf~fQ6694U3a2178321783eusmtrp1l; Mon, 6 Jul 2020 20:26:50 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-12-5f03890cf8ff Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 32.AF.06314.A09830F5; Mon, 6 Jul 2020 21:26:50 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202649eusmtip1eec2a40d04a2d7b6f6c7cb061f4602fe~fQ65NybE71500415004eusmtip1T; Mon, 6 Jul 2020 20:26:48 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:25:54 +0300 Message-Id: <20200706202626.28628-5-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSaUwTaxSG881MZ4ZeqmPVeKLGpWoiJG7R5B6IUVxiJpq4/dBEI9xenYso raYVr8sfFG2gIAKiRtRaAYOihgpVFquBXmOBAiq5WI2ohKgNioDI0mpdaKfGf895z/ue8+Xk 42n1aXYin6TfJxn02mQNq2TuPPS3zInMoBPm59l4LGuyEOx8VURjR/5LFjP7jlH4rHQpOiov KDDvdSqF2XmfKKy8amaxu+Mogz39lRS233NzWNB6lMN+p5fDE4/OE/QG3tN4zvqZ4CPLbQX6 62pY7A0UMpj9pY3gSXs9QVfWJwbzq6sImswC9l0r4bCofQr2d9Qz6H5eweGNwSc03m76RjDX VUaw2fRDETdd/GK9ohCLHF2UeOryE1p8+PwMJ2Y1WCjxVk8VJfbeb2PFbHspERs7M2nx+hsf u165Rbl4h5SctF8yzFvyl3Ln8c5iau+PPw6UPH6pSCVfeTOJ4EFYBCbrWcpMlLxauErAPHIK uRgg0PD/EC0Xnwk8bfMyvyLDPY2s3CghUDHQF3YNEqjz3Ay5WGE2uNMtocHjhFssVAY8VLAx VlgBLzKPkSAzwiwocPSHAiohBjwZ/9Hyiqlw3VYb4gghFh70VrBBVgtTwHNpIDQUhMc8DHmb WTmwErrdNoXMY+G9y87JPBncp7LC7z4Mw+UeTg6nE3hVeDxsWgr2Dy0jzPO0EAVlNfNkeRlk ee1UUAZhFDz7OCYo0yOYd+csLcsqSDepZbcGahtawzLAt6+RsizCuxPt4fvcI/Dd52JzyNSC 37ushJSSCVKKUZcoGRfqpX/nGrU6Y4o+ce72PbpyMvJZ3d9dg1XkfuBvJxF4oolUdfB0glqh 3W88qHMS4GnNONXyZne8WrVDe/CQZNiTYEhJloxOMolnNBNUCwu7tqmFRO0+abck7ZUMv7oU HzExlVwuX5YT7TTNd+V63qZsTHM23g2sc6ylZkTFZG6tXXPEFNVly30zrWnSi1XVXdn10/2v N4z3X3Fccmyq1q/Vre5dMTq6ujCuuzUi5p8/VauWcP6h2JaC5Wk5cavbfWmxNeM/1F20Pdj8 8ak1ubhpi69v1/b8jGKf5cjMt4sWOFtr8uOTNIxxp3ZBNG0wan8CaDWdB6gDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3ddLS5z5g//MBs9LGh2feQxlmYS3D8KggyirLX0ppLb bPdONPvDzFLno9KSspraikoFMyst7GUPrSWWUma6MjFGFmr2Lstc2X8fzud7DgfOYUjVF8qP STZJgsVkSNHQCsr5u9W1WJFP6pccrQuBukd2BAMvHST0H3bRUDCaQ8Dz6ihobjwhg5JXWQQU l3wgoPGcjYb3/dkUDI81EtB33SmH8s5sOYy1uOVQ1HEcgXt8iIRjlR8RdNgvy+D77Ws0jIyf oqD4x1MEBy61IWgt/EDB4atNCPbbWBg9f1YOjj5/GOtvo8DZ0yCH2s9PSLj86BeCQ611CNr3 T8hWzOF/VJ6R8Y7mtwRfWvWE5O/3lMn5wgd2gq8fbiL4kRtPab74UjXiHw4UkHzN4Dd6rWKj VmcxWyUhIMksSss1mzgI1nIRoA0OjdByIeGblwWHaYIidQlCSnKaYAmK3KpN2jdwmkidmJ5+ 9rFLloV+MjbkxWA2FH8dfkjbkIJRsWcQvtBfRtoQMykwfjdI/st44/FntqnMR4SPfK0gPIJm A7Ezz054hJrtpXFX7h7KI7zZGNxbkIM8TLHzcHnz2N+6ko3A3fl3pqbOxjUXbv1lL3YZvjvS QHtYxSZj1xUH+sf+uLviE3EQzaxE06qRWrCKxkSjyGlFg1G0mhK18WbjRTR58yv3vzc0oc76 dS2IZZBmhjKPJvUqmSFNzDC2IMyQGrVyZbtzi0qZYMjYJVjMeos1RRBbUNjkgodIP5948+QH mSQ9F8aFQwQXHhIeshQ0vso89nacik00SMIOQUgVLP/7CMbLLwvt7FCvJ4rc5w9ItVXbOVeb ui/dZ7QzerabT40hSiVm/iuu/XTbHikwNtPfZ1Xm2oVRj5dESwFxhXq7d6muq0y3ZvTYzbSV p1bP8lve46t4u2WBcW9QV27My5nyTYGO17ElKuqeXrGh/k5j4G4hadu8k8wO38gX2TeHCO2s N8FzazSUmGTgFpEW0fAHAhC1PQkDAAA= X-CMS-MailID: 20200706202650eucas1p129e158e9a86b26d047a592c32d019ab3 X-Msg-Generator: CA X-RootMTR: 20200706202650eucas1p129e158e9a86b26d047a592c32d019ab3 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202650eucas1p129e158e9a86b26d047a592c32d019ab3 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 04/25] doc: update sample app with unknown speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- doc/guides/sample_app_ug/link_status_intr.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst index 04c40f285..596782b9d 100644 --- a/doc/guides/sample_app_ug/link_status_intr.rst +++ b/doc/guides/sample_app_ug/link_status_intr.rst @@ -158,6 +158,7 @@ An example callback function that has been written as indicated below. { struct rte_eth_link link; int ret; + char link_status[200]; RTE_SET_USED(param); @@ -169,11 +170,10 @@ An example callback function that has been written as indicated below. if (ret < 0) { printf("Failed to get port %d link status: %s\n\n", port_id, rte_strerror(-ret)); - } else if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + } else { + rte_eth_link_strf(link_status, 200, NULL, &link); + printf("Port %d %s\n\n", port_id, link_status); + } } This function is called when a link status interrupt is present for the right port. From patchwork Mon Jul 6 20:25:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73292 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D25CAA00C5; Mon, 6 Jul 2020 22:27:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF9B21DC91; Mon, 6 Jul 2020 22:26:56 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 96E291DC8A for ; Mon, 6 Jul 2020 22:26:55 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202655euoutp02376a043dc0e9d04ad3f81951fdc15647~fQ6-CuG_42313123131euoutp02G; Mon, 6 Jul 2020 20:26:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202655euoutp02376a043dc0e9d04ad3f81951fdc15647~fQ6-CuG_42313123131euoutp02G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067215; bh=1R9omrZ5fAPdKYuUkOS/6cuY8buXbZ+pEv8UB5bwG/w=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=l6mUu/fRH4miOrx58FFb2h9bxac8Iq290xxfIJPjKvzETpKMIRmpcNj/4PF+0jlHT 8zLPY086qKF5D2d4guSfy33DmgHvrTRwMl7GqHxStYht+MWNYxJ7CbLS7EejS5xiTZ 4hkOUsN2urWV3aIht/ErIvBI2YjZQcUSiMLmmmZA= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202654eucas1p2138358a919b2dd17e71b8ca180b38fff~fQ6_JA01O0115901159eucas1p2c; Mon, 6 Jul 2020 20:26:54 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id CE.89.05997.E09830F5; Mon, 6 Jul 2020 21:26:54 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202653eucas1p2d1714d7aab0ca69d129654ea91a1dae3~fQ69Zzdet0114101141eucas1p2k; Mon, 6 Jul 2020 20:26:53 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202653eusmtrp2f87a390de1aeb79dad50b22ab9a95bda~fQ69ZBxb83205132051eusmtrp2o; Mon, 6 Jul 2020 20:26:53 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-9a-5f03890e98a2 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id DE.3E.06017.D09830F5; Mon, 6 Jul 2020 21:26:53 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202651eusmtip15e277f9ec7176dc726bf0f09c6d64f64~fQ67rKUtP2342423424eusmtip1Z; Mon, 6 Jul 2020 20:26:51 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:25:55 +0300 Message-Id: <20200706202626.28628-6-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0yTZxTHc947jdV31cwT5iV2Lk6TiQ43znQZ8/LhHXGXL34xmVjHm2JW atNymbolxDiChbEJ6ILbWgZuOjCiUtrKZAPCbEtRlIwUFBywJSibFhAyBZRR3pp9O//f/3+e c54nj8QayoREab81W7VbTRajoOO8Vx93vrLwGJu+IfzzIqrrcAEN3almaaC8X6Ci0aMM9dSk 0hXftzyV/pHPUEnpGEO+s06B/hk4wtGDcR9DfU1hkU51HRFpvHVYpC86vwEanhlhqaLyIVCn q4Gnxy2NAkVnqjgqmeoG+tITBAoUj3FUftkPVOCUafSnMyJV962g8YEgR+HeepHOTd5kqaHj CdDxQB3QtYJZ/u1VylTlD7xSfeUeo5R9f5NVrvaeFJXikItRLj7wM0r0l25BKfHUgNI+VMQq tX89Ej7Q7da9maFa9ueq9qS39uoyg+fzbO3iJ3+ebhHywSs4IUFCeRO6p73gBJ1kkM8CRmtK eU1MANY7b3GaeAhY0X4enrXc7iphNOMMoGewLy4mAYt8Q1wsJcgvY7jQNW8skS8K6JuJzAlJ Wixvx+nuVbEMJ7+E3XddbKzWy2/gj6ePxiesxNoLzfM8Qd6MbdH6+WUN8gqMuCfmz0S5Q8Li /HOM1rADJ5v98RstxpGAR9TqZTh72R3PHMZ/L0VErbkQ8E7V5/FQKnr+vi7GlmPltVjXmKTh rRhpi0IMo7wQe+4/F8PsXFnq/ZrVsB4LCwxa2ojNoa44RnwyvUDDCjYNlsdftAlw9O4U8xWs PPX/rEqAGliq5jiyzKrjVauat95hynLkWM3rPzqQdQnmvmr4aWDCD40z+1pBlsC4QF8osOkG 3pTrOJjVCiixxiX6bdfCewz6DNPBQ6r9QLo9x6I6WuEFiTMu1SdX3fvQIJtN2erHqmpT7c9c RkpIzAfrssaxte0nzHmU2jaYm+EO/Ora3cxXhIaX30jp7RdSNn+a9prfXE1b/Pzkjdo01TuR bCnztvEbEn8LJdukyHfK7zadbp+vNkEv2vYc/+zR7PM7k3ateX/H6+uCPSO5q49ts76Ycv8d w3uHtgeX33KGetKy3z1sWd3wdEt/pnu4osXIOTJNG9exdofpP4o80DamAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdjal2XFa/REqGwYStTpe2jsxuxKnLyHYBbrZ0IOz3GY7 84qUqZjNtDS7WLI0L+UMu3gtuugSNWdkyrqg1jCxMlOzgiy7rEnfXt7n97w88LwSUvaV8pHE 6oy8QaeOk9PulO13x+BK6QkycvX9gkVwo9uMYOh1OQmOokEaciezCHhpWQf3mkpEUPgmnYD8 ws8ENF0z0TDmyKBgfKqJgIH7NjFc7M0Qw5T1nRjynl5C8G5mlITi0i8InpobRDDdepeGiZkr FOT/sCM4Vd+JoOPkZwqK7jQjyDYxMFl9VQzlA4thytFJge1VnRiuf3tGQkP3LwQFHTcQPMn+ I1q/lPtRWiniyu99ILgzZc9Irv3VOTF38rGZ4G6NNxPcxAM7zeXXWxDXNZRLcjXD3+lw992K UIM+wcj7avSCca18DwsBClYFioAglYINVO4LCQiWrwoLjebjYhN5w6qwAwpNZ21SfJc4+W1F K52OGmkTcpNgJgj39+YTJuQukTGVCGdUP3QKEqeA8cdhcpbxwjPPTfQs8wXhGseIS6AZf2zL MbvM3kw/jfuOH6P+mb2YTfinfek/hmKWYft7s4uXMipcVZGFZo8uwTU3W1x7NyYEt03UuQLJ mFg82FiOZufF+MXlr8Rp5FGK5liQN58gaGO0QoBCUGuFBF2MIkqvvY2cjTe2T9c3I9N4hBUx EiSfK82hyUiZSJ0opGitCEtIubd04xPbfpk0Wp2Syhv0kYaEOF6womBnwALSZ36U3vk/OmMk G8wqQcUqA5WBa0C+UJrDtO6VMTFqI3+I5+N5w38fIXHzSUfbt6aOeY7XpN09wY6m2UfPzq1t rzzF4sZvGyZyZSsF62jmC8YvPPtwG15/fknK5nlklajsYJ+lgKrsOjLt2XIzYt3O7rykXWlH /1iimOKhzHkxG1VlPX6xK5S+ZSXJF84/yg7bdjp0g3/9glt09I6es5s8PuXptrR6aeRIYxzp dMgpQaNml5MGQf0Xea06eQcDAAA= X-CMS-MailID: 20200706202653eucas1p2d1714d7aab0ca69d129654ea91a1dae3 X-Msg-Generator: CA X-RootMTR: 20200706202653eucas1p2d1714d7aab0ca69d129654ea91a1dae3 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202653eucas1p2d1714d7aab0ca69d129654ea91a1dae3 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 05/25] net/ixgbe: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov Reviewed-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 248f21d14..34a171116 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4300,11 +4300,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: - if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T || - hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L) - link.link_speed = ETH_SPEED_NUM_10M; - else - link.link_speed = ETH_SPEED_NUM_100M; + link.link_speed = ETH_SPEED_NUM_UNKNOWN; break; case IXGBE_LINK_SPEED_100_FULL: From patchwork Mon Jul 6 20:25:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73293 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A50D9A00C5; Mon, 6 Jul 2020 22:27:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 48EA81DC9A; Mon, 6 Jul 2020 22:26:58 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 1175F1DC93 for ; Mon, 6 Jul 2020 22:26:57 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202656euoutp01e2058873127fb57414f42dacbfcbe06d~fQ7AeTyB_2799827998euoutp01A; Mon, 6 Jul 2020 20:26:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202656euoutp01e2058873127fb57414f42dacbfcbe06d~fQ7AeTyB_2799827998euoutp01A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067216; bh=zbg2xoSaiDgck4H57R7Z3rwqX+vJJlCAoA2nccHDMek=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=qn/OBAF9nRQFQanDlNrHaLDpyQwxJySMTtDGeELp9mFNvqQ5/FZZZbBmRiDb7RgTo 5fntfiidAeRYqZ+o14N+nBdz++Wwalg89IZQn9P6cwBlrSrtp6XzxdokRyIAki2y1N 9jpdCKv9p9RzZEOEy+J/f3tD4KgBOdtYDfHrBMDQ= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202656eucas1p2cdf64e943a0a1d96b897755e0e29c77a~fQ7ASPvrf3131931319eucas1p21; Mon, 6 Jul 2020 20:26:56 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id E0.99.05997.019830F5; Mon, 6 Jul 2020 21:26:56 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202656eucas1p1acaa7bcd4a93fadfb28164e348986e7a~fQ6-63pz51287412874eucas1p1n; Mon, 6 Jul 2020 20:26:56 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202656eusmtrp29d0f31afa8db0d4c8e4d5cd43100094f~fQ6-6Fyhr3205132051eusmtrp2q; Mon, 6 Jul 2020 20:26:56 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-9e-5f038910379b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 21.4E.06017.019830F5; Mon, 6 Jul 2020 21:26:56 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202654eusmtip1e40b3bc3c210a35a9e8e29d970575308~fQ6_J7en-1560515605eusmtip1U; Mon, 6 Jul 2020 20:26:54 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:25:56 +0300 Message-Id: <20200706202626.28628-7-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0hTYRjG+c45O+c4nJxml5cMrUFQUWo3eI3Iii4H+ieK/kgoW3UyyVub 2o3EomTNW1oUdrHpSksLM3WzsUWNSG2mWciy0oYE4rp4W/eVeTpF//2+532e53v5+Hhae5qd zienZUqGNH2KjlUztkffOhYIp+jE2N7umVjXXk6wv89Ko+9sL4v5wycofFETj077JRWWvsml sKh0hEL7dTOL733HGfw4aqfwtcvD4YVnxzkcdQ9wWNh5keBA0E9jmWWMYGd5kwq/PXCwOBSs ZLDoezfB4sZWgi0FIwyevdtMMM8s4PCNag6tryNx1NfKoKengcObn7pobGr/SbCkpY7gk7xx 1cpZ4nfLNZVodQ5S4pmKLlp81HOOEwvayimx/mMzJQ7d62bFosYaIj7uz6fF2rdf2Y3qBPXy 3VJKcrZkiFmxQ73X1PWSy3gadtDmsFC55HKomYTwICwBv+0YJ7NWuE7A1LbWTNQTHCBg73Zx ymGMQMDlZcyE/5Ooc+YoejWBwoEBRjl8IvDePczIVawwBzymckoeTBbqWbAHvZScDhdWQ4GL lz2MMBt6250qmTVCHPgu+RhlpSiovX2fljlEWAYPhxpYZb1I8F4J/OkEoZ2Hpr4rlLLRGvD7 I5RsOPhbGjmFZ8D4Xdki8xH4csfLKVkTgb7Kk39N8dD4roOTe2hhLtQ5YhR5Fby7WqNS6sPg xYdJskxPYKntPK3IGjDlaRW3Du63PfsrA/z8EaqgCBc7JOVxXASe28a40yTqwv+rLITUkGlS ljE1STIuSpMORBv1qcastKToXempd8jEP/X8agk0E0dwp5sIPNGFakwsnahV6bONh1LdBHha N1mz+olnu1azW3/osGRITzRkpUhGN4ngGd00zeLKwW1aIUmfKe2TpAzJ8G9K8SHTc4ljS+am 9Jn2WSVzghWWnBJD9Oec/XxDWRyz9KS6MlCxObZXx8RHDbYu31ocl3FgwcMqvfWobvGHvk5V 7rXioYLnR/MLg5qR+dlFEf1Jpj1TarmMQf/leyHjU26tc+LbqYmBnvNlVWLm01MJcV9fRa4/ EfZ5ofVVvSF8w7iXC5XiY3WMca9+4TzaYNT/Bi5g4OajAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3eVprdp9MPAahZU5GrT5Vn0wiIuRQ/qjyCtteyilnN2 77SMCouytcx8UfRaq1GWVqs0NZ2hEmpN0RVmVqspwbBiPrIosYdL+u/L+X6+5xw4hyHlI1QE k5pu4oV0fZqCDqZcv1s80ewpUrfI3MaAo82KoO+9nQRviYeG04PHCXhdtgKc1ZclUPQhh4D8 oiECqm9ZaPjiPUaBf7iagHf1LilcfHFMCsNNPimc6biEwDf2iYQLtq8IOqyPJPCzsZaGgbHr FOSPdiE4W9mKoCVviIKSxzUIci0sDN4ulYL9XSQMe1spcPVUSOHONzcJj9p+IShscSBoz/0j WTmLG7XdkHB2Zz/BFV9zk1xzzzkpl/fMSnAP/DUEN/Cki+byK8sQ97zvNMmVf/xBbwreplwq GDNN/MwUo2hapkhQgVqp0oJSHatVqmLiti9RaxQLly/dzaelZvHCwuU7lSlm9xtpRmfIgapa G5GDrky2IIbBbCx2OI9YUDAjZ28g3Hu8TzJRx/jzR9KCgsZlGB57ZaEnmK8IF9R5JAGDZudi l9lKBIxw9i2NX548SgXCYWw8zqtnAgzFzsGeNuc/XsZqsfeyl5poOgOX32/4NyCIXYKfDlTQ AS1nU7Gnyo4mdCTuvjpCFKAQG5pUhsL5TNGQbBDVSlFvEDPTk5VJRsNDNH7xquaflTXI4t/S hFgGKSbLzDSpk0v0WWK2oQlhhlSEy+LbXTvkst367IO8YNQJmWm82IQ04wsWkhFTk4zj/5Nu 0qk0qjjQquJi4mIWg2KazMw2JsrZZL2J38vzGbzwP0cwQRE5qHN9+GprobbD543y183Gu+Yl 9DK6w9M3a7zuN7Zc34LR0D439q8NTczelFa0L2fd/qQGx7KDq6K5EwOoMLL3e88eWHMzPtdh n1Ia6o7i84evJPwqXnem+fwuods3uM/ZEv02RrFBXeq8G5bhrz20MXGuUDRSu/nLa755a/+9 qFgFJaboVfNJQdT/BbVrNGIHAwAA X-CMS-MailID: 20200706202656eucas1p1acaa7bcd4a93fadfb28164e348986e7a X-Msg-Generator: CA X-RootMTR: 20200706202656eucas1p1acaa7bcd4a93fadfb28164e348986e7a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202656eucas1p1acaa7bcd4a93fadfb28164e348986e7a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 06/25] net/i40e: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c | 5 ++++- drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 472ce2a9e..f718356b5 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2891,7 +2891,10 @@ update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link, link->link_speed = ETH_SPEED_NUM_40G; break; default: - link->link_speed = ETH_SPEED_NUM_NONE; + if (link->link_status) + link->link_speed = ETH_SPEED_NUM_UNKNOWN; + else + link->link_speed = ETH_SPEED_NUM_NONE; break; } } diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index eca716a6a..cf931bf9c 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2163,15 +2163,15 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, new_link.link_speed = ETH_SPEED_NUM_40G; break; default: - new_link.link_speed = ETH_SPEED_NUM_NONE; + if (vf->link_up) + new_link.link_speed = ETH_SPEED_NUM_UNKNOWN; + else + new_link.link_speed = ETH_SPEED_NUM_NONE; break; } /* full duplex only */ new_link.link_duplex = ETH_LINK_FULL_DUPLEX; - new_link.link_status = vf->link_up && - new_link.link_speed != ETH_SPEED_NUM_NONE - ? ETH_LINK_UP - : ETH_LINK_DOWN; + new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); From patchwork Mon Jul 6 20:25:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73294 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFC09A00C5; Mon, 6 Jul 2020 22:27:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E01F81DCAA; Mon, 6 Jul 2020 22:27:01 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id B246F1DCA2 for ; Mon, 6 Jul 2020 22:27:00 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202700euoutp026b612e59b411c30335e07b1feb63532f~fQ7D4rvM51760817608euoutp022; Mon, 6 Jul 2020 20:27:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202700euoutp026b612e59b411c30335e07b1feb63532f~fQ7D4rvM51760817608euoutp022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067220; bh=8FgdUe6Aml3rB/AWNSgZoZqeJOx9OS3/lqpbs6iX2+c=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=JG+vSkx62pZa4aPvmHC9SIVTFWInxKc8xVcl9jRG0ju7PBtN43O207KAHDm7KI2SS ZxyoPxW9+C/ni+NlUZJgVFLBoIcS5/TEvHMepV6TAqqvlKnC8v1GbcpnfhUZiQGJCr uHizccpIflpoY9K8LooIgb45MOCvI/Tk9lDxwBXU= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202659eucas1p2c86500f4b20f5e7f9366d4f1c8ea90e5~fQ7CwR9ml0116301163eucas1p2j; Mon, 6 Jul 2020 20:26:59 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 50.B4.06456.319830F5; Mon, 6 Jul 2020 21:26:59 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202658eucas1p16fb0b9d392a4c480915058a034bac1e7~fQ7CWBg7H0787207872eucas1p1W; Mon, 6 Jul 2020 20:26:58 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202658eusmtrp2a26a8571b61ebe196681316f8e6d1b16~fQ7CVNudp3205132051eusmtrp2r; Mon, 6 Jul 2020 20:26:58 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-ee-5f038913d7e7 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 43.4E.06017.219830F5; Mon, 6 Jul 2020 21:26:58 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202656eusmtip1e4d22cb0ec32c5857214ac3f45e62d15~fQ7AmUwYG1500415004eusmtip1V; Mon, 6 Jul 2020 20:26:56 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:25:57 +0300 Message-Id: <20200706202626.28628-8-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSbUxTZxjNc9/be29ru1yLC4/OYGzC1G2KBJe9m8SPTdlN/OOvLfFjrBs3 SMZXeinKFhJGpKkVUBk4xQUYjV9oQKBYJLhgXVq1fAwEqdGxhmmcMkUQgrIiUm51/845zznv efLkFYixnFsipGXmyJZMc7qJ07EXvS96VkcdIMlrux7raUNnFdDhISehwfI/OXrw6X6GBuo2 0nb3Lxpa9lcBQ0vLxhjqPuPg6L/BQpY+GXcz9O5lP08r+wp5Ou55wNOSnhNAH4QeEXq85hnQ nqoWDX1xpY2jo6FalpZODwA95LoG1Fc8xtLyS61AbQ6RPj17mqfOuzF0PHiNpf7bzTw9P9lL aEvnDNAjvgagXbZZzabl0nTNSY3kbH/ISD/92ksk7+2jvFR8vYqRGp+0MtLobwOcVOqqA+nG 8EEinbv3nNuu26FLTJHT03JlS9yGr3V72ofusdnd/L6p3n4ogHrOAVoBxXUYqPRoHKATjOIZ wIGiNl4lE4CNsxUR8gzQWVrwJuIM2iKR04D93lsR1yTgxMn7TNjFiSvRb69iwoNFYiOH7tDg HBGEKHEzTjdtC3tYMRZHfpyZ9xvEj/FGvZtVG5bhuQsdJIy14if4+2jzfLNRjMHB6on5N1Hs FPBOXxGogS1Y/c9zouIofORz8SpeirOXqhkV/4BTTYO8GrYDDtUWRUwb0TXSzYeXI+IqbGiL U+XNaD/knt8Zxbcw8HhhWCZzsOziz0SVDWi3GVW3CTuu90VkxJn/9KosYfnR+6Ce5zLgsdAF 5jAsq/y/qwagDqJlq5KRKivxmfLeNYo5Q7Fmpq75NiujCeb+qv+lb7wVJvu+8YAogElvCAok 2agx5yp5GR5AgZgWGT7t8n9lNKSY876XLVnJFmu6rHjgHYE1RRsSah/uNoqp5hz5O1nOli2v p4ygXVIA2rH44oqSXDKlce+qmfy8/v3Ct5O23mrqcX254W+86fbeucr0Lzg1mnte7ytZHEqK rYj29n62wnZspCN/rCUxx7jzRHdMoCIp8SV7WNST/Jnu9bti8xxH2jZ9eEpRMCUqzvpBynCz JiGQsP2jd2O0u1fZrWuXrs5e4PxjaHHaF1n5JlbZY45/j1gU8ytJX2BPpwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSeUiTcRjH+73vu3dTWrwtpR8GHYugg1bzaM+ku6gX+yMpksrMVr2o5DbZ u3UHKs7WLLsk6JrasPK2vFap1MhzmpppidcIy+xQm10OO1zWf194vp8PDzyPiJR8ofxEMRo9 p9OoYqW0N+X4VduzVHKGjFzu7JJBYaMFweteKwnOtB4aUkaSCHiVswYqym8I4FJfPAGplz4T UH7XTMNHZyIFQ65yArorHUK49jxRCC77gBDONV9HMDD+noSrGaMImi2lAhh78pCG4fFbFKS6 2xGcL6lDUHv2MwVpD2wIks0MjGTfEYK1eza4nHUUODqLhZD3tZWE0safCC7WFiJoSv4tWDuP dWdkCVhrxSDBXs5sJdmazitC9my9hWDvDdkIdriqnWZTS3IQ2/A6hWRz+3/Qod67ZSt1WoOe mxut5fWrpOFy8JfJlSDzD1TK5AGKiGD/IOmy1SsPcrExhzndstX7ZNEVvf1U3DPh0e+tL1A8 KqDNyEuEmUBsdSYLzMhbJGGyEHb3JZBmJJoYYPyhn5zszMDjHea/fQkzinBmdoQn08xC7DBZ CA/rw3TRuO10AuVhZzDrsPv+Fk+HYhbgDwk/CU8WM0rcUFBOTTrn4Nyix3/9Xkwwfjpc/M8f g3vKrGgyz8Yv078QF9C0DDQlB/lwBl4dpeb9ZbxKzRs0UbIDWvV9NHHxspqxEhsyD223I0aE pFPFJpqMlAhUh/ljajvCIlLqI17f5NgrER9UHTvO6bSROkMsx9tR0MSCF0k/3wPaif/R6CPl QXIFKOWKAEXACpDOFJuYJ3skTJRKzx3iuDhO958jRF5+8ShskT34fcfYLGN+69ZoQe18V5Lx 3dsA15lPIc2huxRG88agvKGvpm/7BsPS6osftQy2GfPpkcqbJdVJZSY2NGXn5mxD1dX94SfO pScpBzSlR7kNTOKpziXVGSHGgqqa0um+2YWfRk86Qgbf3D4yElMZkbwpz9aZ5rYKilpssX07 tkkpPlolX0zqeNUf+MHuxAcDAAA= X-CMS-MailID: 20200706202658eucas1p16fb0b9d392a4c480915058a034bac1e7 X-Msg-Generator: CA X-RootMTR: 20200706202658eucas1p16fb0b9d392a4c480915058a034bac1e7 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202658eucas1p16fb0b9d392a4c480915058a034bac1e7 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 07/25] net/ice: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- drivers/net/ice/ice_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index b51fa2f17..76f797de0 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3135,8 +3135,11 @@ ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) link.link_speed = ETH_SPEED_NUM_100G; break; case ICE_AQ_LINK_SPEED_UNKNOWN: - default: PMD_DRV_LOG(ERR, "Unknown link speed"); + link.link_speed = ETH_SPEED_NUM_UNKNOWN; + break; + default: + PMD_DRV_LOG(ERR, "None link speed"); link.link_speed = ETH_SPEED_NUM_NONE; break; } From patchwork Mon Jul 6 20:25:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73295 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74A1AA00C5; Mon, 6 Jul 2020 22:28:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D98AD1DCB7; Mon, 6 Jul 2020 22:27:04 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 1EA331DCB7 for ; Mon, 6 Jul 2020 22:27:03 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202702euoutp01b9e52ad275f338a81d1afbb66cb052b1~fQ7GJqdYn2593425934euoutp01f; Mon, 6 Jul 2020 20:27:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202702euoutp01b9e52ad275f338a81d1afbb66cb052b1~fQ7GJqdYn2593425934euoutp01f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067222; bh=fNqGGGujtZQoaCNUifIZpoVDm0FLT/KHJy8jVKrEsB4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=kGoyOk9GV9E127XvmJLkUwee4qTHOINg4oUuXVlPa2howwp6PH4NvjRBKaWvs17A8 sTvPFAKgWl1Qr+4VnFWGFyO/QNAI7+OKONK8nIdmdPferbODFB9k8GR6Gvmi8qkXxa zpbCcTZNZvOxtScapGbm09wIj/4nkkIuFtxRvuYk= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202701eucas1p2ab9b897f7381aff634f274917fa955cf~fQ7FS8P4T0115501155eucas1p2l; Mon, 6 Jul 2020 20:27:01 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id F3.96.06318.519830F5; Mon, 6 Jul 2020 21:27:01 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202701eucas1p2e1edbd116f7bb5b3cf3d9a5432ad6ff9~fQ7E9_glI2938529385eucas1p2B; Mon, 6 Jul 2020 20:27:01 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706202701eusmtrp122f0a72dcdfd01de7001ee59747cd651~fQ7E9JtvN2178321783eusmtrp1p; Mon, 6 Jul 2020 20:27:01 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-20-5f0389159ce7 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C4.AF.06314.519830F5; Mon, 6 Jul 2020 21:27:01 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202659eusmtip1dfeddb4c84ceb9a5bbb7e07e5c9fa265~fQ7DI-dtC1560515605eusmtip1V; Mon, 6 Jul 2020 20:26:59 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:25:58 +0300 Message-Id: <20200706202626.28628-9-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTG89739t5LtXhXMJzgIlvjkmkUXdTlaHQwQ5abxRgTncmWTCx6 +YgUSSvOj3/4smKpqMiccwtUmLGABEEEBCWFYIsWYWBMYQNpiIaAfAk0Gwi6lovZf7/zPM85 533fvALVFnDhQlLKcdmYok/WcWq21jnbuWHleRq7yTqEWNleSHDwRQlFb0E/h7mT2Qz2lEXh g7rfVZg/kM5gXv4bBuvsFg5HvZksjk/VMdj30M3j9e5MHqdahni80PkbwaH5EYq/2qYJdhbe U+FscwOHE/PFLObNPSd4saaNoMv6hsWC+/UEzRYRJ0tv8VjStxqnvG0sunvv8njb10XxXvsC wcuuSoJPze9V0Z9Kc7abKqnkwTAjXbnRRSVn71Vesj4uZKSq8XpGmmh6zkl5NWVEejKYS6Xy l/9ye9U/qHcckZOTTsjGjV8dUidmuwaZVNvOk++a/ybpJGeThQQJIG6B0qZxVYC1op1ARvZ+ C1H7eYbAeLmdKsU0gRdXq7kPHX/Yr/GKcYtAr6OKUQofgamMVzSQ4sTPwZ1TuGiEilUc1M17 mIARIkZDqbWKDTArfgZnJ58tskbcBoM+L1FWRED5HcfioCBxO7RO3OWUA64GT9HM4lAQ2wUw mytZpSEGRr0DjMIhMOKq4RX+GNxXrEuZM/BPtYdXmnP8Fyo+uxSKgprXHX4WBCquhcqGjYr8 Ndz+uZ8JyCAGQ8/YRwGZ+jG/9heqyBrIMWuVtA4cj7uXZICFt8sVWYKRS++XXvEhAYetl1wi Edf/32UjpIyEyWkmQ4Js2pwi/xRp0htMaSkJkYePGaqJ/6+637l89aRpPq6FiALRLdd4BRqr VelPmE4ZWggIVBeq2fXUfVCrOaI/dVo2Hos1piXLphaySmB1YZrNxcM/asUE/XH5qCynysYP LiMEhaeTkkOju4eFiPTGaetf6y+HfGNYWBMd/+e5FcsGYjLC28DZs+tcl3ObY/sn2Vsr9pXP dWTsLqr4UrSNBTkb9oTu6Z9wvIWKmeCthgPXGqNssrdrtuhibkcWDek+XF96JvxRw9jBxums pNFvPa74tQnfnW4N9p2PTP0+Ji7PQmdX2j0XdKwpUf/FOmo06f8DkHGaMKcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTYRjHe885Oztai8PSehEyGwQRdPKoc4+RXb+cD0FSEFTWOthhWm6z nWlZXyyWzaWmFWLlrSxTC8rMS1dyXWZNC5U0tdWY0r3UWdHKMi/07Qe//3OB52FI9Q8qjEkx WSWLSUzV0MGU+6/LszQ0h9RHjldHwNW2MgS+15UkeE95aDg2bCPgZe0quNNUooATb7IIyD8x QkBTtYOGz97DFHz1NxHw6q5bCWc6DyvB73ynhLznZxG8G/tIwumKUQTPyxoUEGi5RcPQ2HkK 8n+9QHD8RisCV+4IBaduNiPIdrAwXHNJCZWvwsHvbaXA3VuvhCvfO0hoaPuDoNB1FUF79rhi 9ULhV8VFhVB55wMhnDzXQQqPe4uUQu6TMkKo+9pMCEP3XtBC/o1aJDz1HSOFy4M/6YTgrdwK izndKkUkm2VrvGYbD1EcHwdcVEwcx0frti+P0mqWrVyxS0pNyZAsy1bu5JJtLh+RVhG//29L P8pC9kgHCmIwG4MvVBcrHSiYUbMXEa5+f4F0IGZCYPxpkJzOzMFj3Q56OjOKcE2OB00Kml2M 3fYyYlKEsP007jp6iJoUc9jVuCa3boopdhE+Mtw1xSo2Dvu+e9F01wX48rX7UxOC2OX44VA9 PclqNgV7GivRNIfjnvJvRAGaXYFm1KIQKV02Gowyz8miUU43Gbgks/E6mrh54+NAfTPqrNvk RCyDNLNUdprUqxVihpxpdCLMkJoQ1dp29w61apeYeUCymPWW9FRJdiLtxIKFZFhoknnig0xW Pa/ldRDH66J10bGgmaeysy2JatYgWqU9kpQmWf7XEUxQWBbaF05W5c3cWJ4gvo1YRxaPbcyZ 632dJwYemPYWRMbGJ4w2jJSUerfw2bdd3i/KM6u0RXXzF/W16zl5c/egmfoWqYvxcPdu/jlQ XuAtt3X1Dfze7TwYkqgNrHnW0186d+cGvyHwduZmsIeu9TNpsS7Vo/VuW0b0wO/bz9Kqwn0f NJScLPJLSIss/gMi2+nyCQMAAA== X-CMS-MailID: 20200706202701eucas1p2e1edbd116f7bb5b3cf3d9a5432ad6ff9 X-Msg-Generator: CA X-RootMTR: 20200706202701eucas1p2e1edbd116f7bb5b3cf3d9a5432ad6ff9 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202701eucas1p2e1edbd116f7bb5b3cf3d9a5432ad6ff9 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 08/25] examples: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov --- examples/ipv4_multicast/main.c | 12 ++++------- examples/l2fwd-jobstats/main.c | 12 ++++------- examples/l2fwd-keepalive/main.c | 12 ++++------- examples/l3fwd/main.c | 12 ++++------- examples/link_status_interrupt/main.c | 30 +++++++++++---------------- 5 files changed, 28 insertions(+), 50 deletions(-) diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c index 7e255c35a..0d4957658 100644 --- a/examples/ipv4_multicast/main.c +++ b/examples/ipv4_multicast/main.c @@ -572,6 +572,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -591,14 +592,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index 47a3b0976..740f1c80f 100644 --- a/examples/l2fwd-jobstats/main.c +++ b/examples/l2fwd-jobstats/main.c @@ -689,6 +689,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -708,14 +709,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c index b2742633b..d8be0a727 100644 --- a/examples/l2fwd-keepalive/main.c +++ b/examples/l2fwd-keepalive/main.c @@ -453,6 +453,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -472,14 +473,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 24ede4290..ef0f19a39 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -810,6 +810,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -833,14 +834,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/link_status_interrupt/main.c b/examples/link_status_interrupt/main.c index 9bbcadfcf..5e286060d 100644 --- a/examples/link_status_interrupt/main.c +++ b/examples/link_status_interrupt/main.c @@ -118,6 +118,7 @@ print_stats(void) const char clr[] = { 27, '[', '2', 'J', '\0' }; const char topLeft[] = { 27, '[', '1', ';', '1', 'H','\0' }; int link_get_err; + char link_speed_text[16]; /* Clear screen and move to top left */ printf("%s%s", clr, topLeft); @@ -131,9 +132,10 @@ print_stats(void) memset(&link, 0, sizeof(link)); link_get_err = rte_eth_link_get_nowait(portid, &link); + rte_eth_link_strf(link_speed_text, 16, "%M", &link); printf("\nStatistics for port %u ------------------------------" "\nLink status: %25s" - "\nLink speed: %26u" + "\nLink speed: %26s" "\nLink duplex: %25s" "\nPackets sent: %24"PRIu64 "\nPackets received: %20"PRIu64 @@ -141,8 +143,7 @@ print_stats(void) portid, link_get_err < 0 ? "Link get failed" : (link.link_status ? "Link up" : "Link down"), - link_get_err < 0 ? 0 : - (unsigned int)link.link_speed, + link_get_err < 0 ? "0" : link_speed_text, link_get_err < 0 ? "Link get failed" : (link.link_duplex == ETH_LINK_FULL_DUPLEX ? \ "full-duplex" : "half-duplex"), @@ -445,6 +446,7 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, { struct rte_eth_link link; int ret; + char link_status_text[60]; RTE_SET_USED(param); RTE_SET_USED(ret_param); @@ -457,13 +459,8 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, port_id, rte_strerror(-ret)); return ret; } - if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", - port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + rte_eth_link_strf(link_status_text, 60, NULL, &link); + printf("Port %d %s\n", port_id, link_status_text); return 0; } @@ -478,6 +475,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -497,14 +495,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:25:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73296 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30756A00C5; Mon, 6 Jul 2020 22:28:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 375CF1DCC4; Mon, 6 Jul 2020 22:27:06 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 982661DCA4 for ; Mon, 6 Jul 2020 22:27:05 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202705euoutp021718c05e275ce8baefc31c810d331aa4~fQ7IdDfKC1760117601euoutp020; Mon, 6 Jul 2020 20:27:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202705euoutp021718c05e275ce8baefc31c810d331aa4~fQ7IdDfKC1760117601euoutp020 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067225; bh=Mcy1FKB5X97xPHfABEMsRH14jwW9/cdD4WTM5f5JTOo=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Fg5/YdxYK21bwQ7w96SppIsMnayQAwaryfK5kKQ7hZvCJZl8pvEON82M34txWEQ1P KowOidsLAcjsUhTlqDGTdKDieRY31sn+KAEEkFeplZzrZDHIJvxnOFxOW4NJSrDvYp sGsS73wh+51QCpceI7IPbKwcIfVynD2MSD/VZ4Eg= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202705eucas1p1864d756f5df71fa70595f414f72c2112~fQ7IGbvWd0893808938eucas1p1u; Mon, 6 Jul 2020 20:27:04 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 53.99.05997.819830F5; Mon, 6 Jul 2020 21:27:04 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202704eucas1p2489800126a0327fa6b1696fac1a05b3f~fQ7HZICOB0116301163eucas1p2l; Mon, 6 Jul 2020 20:27:04 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706202704eusmtrp1bb63a30ded0ebd59fdbee10befb8ffeb~fQ7HYSdlK2178321783eusmtrp1q; Mon, 6 Jul 2020 20:27:04 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-a8-5f0389185b81 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id E6.AF.06314.819830F5; Mon, 6 Jul 2020 21:27:04 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202702eusmtip14ff0d02b2f47d14ada3f74ec147af5a3~fQ7FkZ_wZ2342423424eusmtip1b; Mon, 6 Jul 2020 20:27:02 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:25:59 +0300 Message-Id: <20200706202626.28628-10-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSWUwTURSGc2emM9PG4lBMuEEjocZESQCtRk+MghAfJj4YNb64YtWRqgW0 IyqiAobNgoBI3AMVYsBigqxFBJdGQShgxCAQyyKasKgsBeLGIu1gfPvPd85/lpvLkqpM2os9 FnFaMERo9WpaQVXW/Wrxw1fI0FWjjeuguCkHQV93Pgm92V00pI4mENBhDoIayz0ZZPXEEZCe NUaApdBIw7feyxQMOywE2GttDNxpvcyAw9rPwNW3dxH0Tw2RcNs0juBtToUMfr2spmFkKo+C 9N9tCDLK3yCoTxujIPtJFYIkIwejDwsYyLcvBUfvGwpsnWUMPJp8R0JF0zSCa/XFCJqTZmWb ffjfpgcyPr9mkOCv339H8nWdNxg+rSGH4EuGqwh+5FkbzaeXmxHf2JdK8kVfftLbFXsUG48I +mNnBENA4EGFrrN/00mj/Fxt2844VMUYkZzF3Fr8xx5PGpGCVXGFCD++NU1JwQTCXxxWQgrG 54KepzIjYl2WG0mBTreKK0D4w+Q2qWYSYXuBnXAmaG4FtqXkuMyLuBIaW6baXQkPbitOq6yW OTXFLcfPE2ddXMltwLa7fbS0kzcuevyCdGr5HH81UkZL05bi9twJV1PMNbF4YKaGkDbagpvv u0leDzxUXz5/2xJsu55GSToG/yhtZyRvCsLdeYnzRUG4/GsL4+xDcitxcXWAhINxatbX+fZu uOO7uxOTczKr8iYpYSVOSVJJ1Wr8oqF1HmM8/WeBhHmcPN4gk56nFuGM6UKUibzv/J9lQsiM PIUoMTxMEDURwll/URsuRkWE+R+ODC9Fc//UNlM/UYWqpw5ZEcci9QJlCk2GqmTaM2J0uBVh llQvUoY02w6olEe00ecFQ2SoIUoviFa0mKXUnso1eYP7VVyY9rRwQhBOCoZ/WYKVe8WhgN01 Dt2OfceXiSEe3l67yzoHes598m3bqOZuv9Zc0J8aWF0Z9HxZ8DjtFpss93LXmHNjYi8VreyI p7LXxIo73ut8TKWbugYXvvZrXBdoTl9/NCrat473+5yg0TetMO3a+/JexUdL7sy3R92txos6 R+LPFndOTUUmqD4EBWg8u3LVlKjTrvYlDaL2L/LlICmjAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSf0yMcRz2fd/33rtrjncn810mnDGzuVxJn5LKj9mrmRF/hH44eVdH19m9 d5G/0qhcya+Eyrm0QowjdUmhW+vKaa0spKKfy691dWEhcufmv2fP83k+n2d7PiJS6qR8RKoU HadNUSbLaC/K/sfWuxKfIuNXmb7TcO+FEcHAu1IS+vJ7acgZO0HAm4pwqLMUC+D8+3QC8s6P E2C5aaDhS18GBaNOCwE99XYhFHZkCMFpHRHC6bYiBCNTn0i4YppA0GasEsCPhloaHFPXKcj7 2YngzMNmBLbccQryH9UgyDQwMHbrhhBKe3zB2ddMgb2rUgh3vrWTUPXiN4JztnsIWjOnBRGL 2Z+mMgFbWveRYC+UtJNsU1eBkM1tMRLs/dEagnU86aTZvIcViH0+kEOyt4cm6e1ee+ShWo1e xy1K0vC6dbK9CvCXK4JB7r86WK4ICIoN8Q+U+YWFHuCSVamc1i9snzypa2TdYYP4aH1nVDqq ERqQSISZ1bggM8yAxCIpU4Zw+miah8b48xDppjEzB0+9MtAG5OUamUB4IsNJuAWaWY7t2UbC LXgz3TR+mXWccgtzmEicW10rcGOKWYqfnpz+Z5AwIdheNEB7ti7Et83P/l0Qu/hGRyXtCaHC vdWlyIN98etrX4mzaJYJzahA3pyeVyeqeYWcV6p5fUqiPEGjfoBcfVc3/aisQR33d1oRI0Ky mZJsmoyXCpSpfJrairCIlHlLNrTa46SSA8q0Y5xWE6/VJ3O8FQW6Ap4jfeYmaFzfk6KLVwQq giBYERQQFLAGZPMk2UxDjJRJVOq4Qxx3mNP+9xEisU86Cu3vbfy6JfzS7B0xHWZiydy31+5M Xi4s6ToUe2SwLmrH2EVbfuPwMmHOpu6GWbKIqTWmPFVg3PrawW0+k/3K6dqNJ+hyTbKlZTBh fseuTVG/9EOR4cPyD3eDcxpGjnRmq2ZGx47HZNl3ry3ev+ixY+PC42b71qvmoYjyBZbNLdEH 17bJKD5JqVhBannlX5CzlQUFAwAA X-CMS-MailID: 20200706202704eucas1p2489800126a0327fa6b1696fac1a05b3f X-Msg-Generator: CA X-RootMTR: 20200706202704eucas1p2489800126a0327fa6b1696fac1a05b3f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202704eucas1p2489800126a0327fa6b1696fac1a05b3f References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 09/25] examples/bbdev_app: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c..44e6952e6 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -313,6 +313,7 @@ check_port_link_status(uint16_t port_id) uint8_t count; struct rte_eth_link link; int link_get_err = -EINVAL; + char link_status_text[60]; printf("\nChecking link status."); fflush(stdout); @@ -323,11 +324,8 @@ check_port_link_status(uint16_t port_id) link_get_err = rte_eth_link_get_nowait(port_id, &link); if (link_get_err >= 0 && link.link_status) { - const char *dp = (link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - "full-duplex" : "half-duplex"; - printf("\nPort %u Link Up - speed %u Mbps - %s\n", - port_id, link.link_speed, dp); + rte_eth_link_strf(link_status_text, 60, NULL, &link); + printf("\nPort %u %s", port_id, link_status_text); return 0; } printf("."); From patchwork Mon Jul 6 20:26:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73297 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AF6BA00C5; Mon, 6 Jul 2020 22:28:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60CFD1DC8F; Mon, 6 Jul 2020 22:27:10 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5CBDD1DC41 for ; Mon, 6 Jul 2020 22:27:09 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202709euoutp01172f1affa1ed9869ac3016d94e10ed68~fQ7L_rUe-3113131131euoutp01s; Mon, 6 Jul 2020 20:27:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202709euoutp01172f1affa1ed9869ac3016d94e10ed68~fQ7L_rUe-3113131131euoutp01s DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067229; bh=sZj87uqkawQ60wf+sT4re4HeKIKPddDywVxgWZ8WdS4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=IzsIq1RVkKvXWoUQOPBQDBBlW6qIO4jn3oMID8v/ya+Di5rLbmRja8BESPLt0fKgN yS1I5o4qZautPb4G41XzxcjFB5fpmJtu1z8kMfv3oq78uaRiqOSUOxgvHkK538jict D2UdKa2BeZJ2LfoQPdS+en21IEz6qSQwM8VgG7tk= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202708eucas1p16f3a6e3b16cf24cc759b8a24e7b593f5~fQ7K8_CFq0893808938eucas1p1w; Mon, 6 Jul 2020 20:27:08 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 72.B4.06456.B19830F5; Mon, 6 Jul 2020 21:27:08 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202706eucas1p299579aa6492e84e34f0d3912032e51e0~fQ7JzjAAY2938529385eucas1p2C; Mon, 6 Jul 2020 20:27:06 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706202706eusmtrp150e150eb41fb32f55469d4e9f4fa16dc~fQ7JyRaAE2178321783eusmtrp1r; Mon, 6 Jul 2020 20:27:06 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-f8-5f03891b366d Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 65.4E.06017.A19830F5; Mon, 6 Jul 2020 21:27:06 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202704eusmtip1b061978672c41c8d745a6bc764a28bd0~fQ7H_ZtJo1560515605eusmtip1W; Mon, 6 Jul 2020 20:27:04 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:00 +0300 Message-Id: <20200706202626.28628-11-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHPffe3nvbWHMtZp6gwmimccvE+RZPNjNx2bK7DybqF5PFgZ3e gBkgaUXntg/ECGMFKwMiEVnlJQqjLgiUgorMNQQoRUFEC0GxwRnmy8DyEqXAHKXX+O1/fuf/ f855njwiayjkI8VDqUcUc6op2cjrOFfbdPe6lb+wCR+dLAGq6bIDDQ9VsOQvfMBTzouTDPVX b6fmxhIN5T/MYMiWH2CoscrK03P/CY5GxxsZun/dK1Bx7wmBxt0jAp3qPgc0MvuUpbOlE0Dd 9gYNTf91laex2XKObMG7QKedHUDtuQGOCq80AWVZJXrxe6VAFfejaNzfwZF3oF6gS1O3WWro mgP6tb0G6GbWa01cjBwsvaCRK5qfMHJB2W1Wbhs4I8i5Hjsj1442MfJYy11etjmrQe4czmFl x9+v+F26r3XbDirJh44q5vWf7tcl9V3+DdL+0H4/0zIjZECbYAWtiNJmLMgr4aygEw1SFeC9 ZwNMuJgELGrNYsPFBOBc2Qi8iUxfnFZdlYCePC8XahikKUBb99aQ5qW16M22L5iWSbU8Ns76 mFAjQvoC+84ENCHNSauxL+PawiJ66WPsq/hZnRCNjss32JDWzvPWsXo+PCAKfecnFw5FqUNE W0sXFw58jq6LATUcgU/bnertVqK3IFf1/Igv63xCOJwNOFSeqZq2o/PZrXktiqz0PtZcXR/G OzDoyWFDGKUl2P/v0hBm52W+q0jFeszOMoTdRrzh6VUx4tzM4jCW0e8ZVB/xOuC5TjubB9HF b2eVAlTDciXdkpKoWDakKsdiLaYUS3pqYuyBwyl1MP9Xvf+1jzfBVO+3bpBEMC7W+0U2waAx HbUcT3EDiqxxmf6zm954g/6g6fgPivlwgjk9WbG4YYXIGZfrN5U/+cYgJZqOKN8pSppiftNl RG1kBuzZ78t5b99QYXHdQ1ePw7FzSbFxMiJ+T9Q1++449yeOjc+HoncGA6151i/NP8U8njkQ 47dlrkmOimQYbZVpo/SVpy249ayvtmGi/k7Pu/9k7ibraKe78xHjOm1D15+8a21Swaq0R4u2 xQw2X4ntGXbGb1m39/U7H97ae6l/cEVlXJGRsySZNnzAmi2m/wEMXJi+pwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzVSWUwTYRD2393uLsSSTUFZiUFs4kVisQVkODUadR80YIg+eGGFFVBKSbd4 RRMknAW5RBNFEa2icoT7RoWKgBYkKGcUJYSIiqEcagTqUSC+fTPfMZPM0LjkJ+FAh0dqeU2k MkJKWhPGP21Dmx2S8aAtZRXOUNKRi2Dkgx6H4ewhElIm4zAYKNgGjTW3RJD1MQaDtKwpDGoe 6Uj4NhxLwMR0DQbvnxgpuPkmloJpwxgFV7pyEIyZv+JwI28GQVdulQhmm+tJMJnvEZA214sg vbIdQVvqFAHZdbUIEnQMTD5+SIH+vSNMD7cTYBysoKDoRzcOVR2/EWS2lSDoTPgr2r6Wm8t7 IOL0jV8w7urdbpxrHbxOcakvczGubKIW40xPe0kurbIAca9GUnCucPQXGWB9SOajUUdreacw taD1lR6Wg0Im9wSZws1TJnf1OOqlcJe6+PmE8BHhZ3iNi99xWVhP6W0UVWx1bv7pPBWDWikd sqJZxo2dzZ/FdMialjAPEJucvlDQFoJlx0fxJY0ta+7TkUuaGcSOfh5cJEhmI2tMyl002zHv SPZt4mVigbBldrE916dEC5hg1rE9MQ2L08SMF9ujT0RLqWvYwtKmxSArS7/FVEEuYAkTzg5V 69ESdmT773zHMpBNHlpWgOz4aEEVqhIUMkGpEqIjQ2XBalU5sty8unW2shbpJgINiKGRdLk4 icSDJCLlGeG8yoBYGpfaiXd0Go9JxCHK8xd4jTpIEx3BCwbkblkwE3dYEay2fFCkNkjuLvcA T7mHq4frVpDai5OY5iMSJlSp5U/zfBSv+e/DaCuHGLT74v6WQpOQH/IiL+S+tG5jXM7O9Wdt sj4NeMdTcX2B8TJq3walf/u4/TWiKOmUmxvjrR5SlDsVND082HQisX51dZGpeyWYsRFX+2Kb PZfa0t+F+zNlw/ka37Mtje7mk6JC+kB/afujAwH+koysZ9Wvn28ylDUnJO/FA1c1hG6okhJC mFLujGsE5T+kdxH1CQMAAA== X-CMS-MailID: 20200706202706eucas1p299579aa6492e84e34f0d3912032e51e0 X-Msg-Generator: CA X-RootMTR: 20200706202706eucas1p299579aa6492e84e34f0d3912032e51e0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202706eucas1p299579aa6492e84e34f0d3912032e51e0 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 10/25] examples/ioat: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ioat/ioatfwd.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b66ee73bc..8bf80c262 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -700,6 +700,7 @@ check_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret, link_status = 0; + char link_status_text[60]; printf("\nChecking link status\n"); RTE_ETH_FOREACH_DEV(portid) { @@ -715,15 +716,11 @@ check_link_status(uint32_t port_mask) } /* Print link status */ - if (link.link_status) { - printf( - "Port %d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_strf(link_status_text, 60, NULL, &link); + printf("Port %d %s", portid, link_status_text); + + if (link.link_status) link_status = 1; - } else - printf("Port %d Link Down\n", portid); } return link_status; } From patchwork Mon Jul 6 20:26:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73298 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62A4DA00C5; Mon, 6 Jul 2020 22:28:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE62A1DCDA; Mon, 6 Jul 2020 22:27:12 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 3F9FB1DCCE for ; Mon, 6 Jul 2020 22:27:11 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202711euoutp022f54e392c40e78fa5bdfd4b5bfbee0c0~fQ7NuwlTJ2313123131euoutp02H; Mon, 6 Jul 2020 20:27:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202711euoutp022f54e392c40e78fa5bdfd4b5bfbee0c0~fQ7NuwlTJ2313123131euoutp02H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067231; bh=KYoq+D7jL7TMj8sFJ9dEXZ47ChxgDfY/ELcSA7WUHJo=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=eNOUARENg/OrQEtSebEDhnN/UsX/NbupZS+LyRHBW9RT2RMTi5zEVGa4OkchVDfxf TKWm0hw0KESwT7o/SvpbwCxg+0XUHOCGDliTxb+W60LEYti6aSv2iMfYbm54q1tsDI Gu4TgtPP0J7jCt1u7kWwBVPTQ/mvGKacGQ75GjQE= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202710eucas1p2f5415bce5265dbed3cf8221f077725ea~fQ7NOUThR0115501155eucas1p2n; Mon, 6 Jul 2020 20:27:10 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 16.96.06318.E19830F5; Mon, 6 Jul 2020 21:27:10 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202709eucas1p2cb2da3247bfdd0b25a3fdfd2fd7b2d99~fQ7MIIcIM0114101141eucas1p2n; Mon, 6 Jul 2020 20:27:09 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706202709eusmtrp166da330fb42f16bf93c2a339b43929b0~fQ7MHHzdA2178321783eusmtrp1s; Mon, 6 Jul 2020 20:27:09 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-29-5f03891ea62c Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 09.AF.06314.D19830F5; Mon, 6 Jul 2020 21:27:09 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202707eusmtip151c65d78ce32a4c3cec1bcc084f4f3bb~fQ7KXelzY2342423424eusmtip1c; Mon, 6 Jul 2020 20:27:07 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:01 +0300 Message-Id: <20200706202626.28628-12-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxSHc+57e3vp6HJXyDxBh7HLIpr4sciSE2PU+ZHcZMtCsn8WFseq 3qCBomnFzS1xBLRhgJ0WlMm2jpUYFc2Qz1ZFQDZBrAw1MVBhWJyxAZVWoCpQ5mhvzf57znN+ 5z3JySsyw3EhRdydt0+x5JlyjYKOb+ma7luR+j3LWj3ZvIjqbjqBHgzXMPJX/C1QaegQRwO1 G6jV/bOGHPcLOLI7nnHkPlMi0BN/IU/jE26Ohq54tVR1p1BLE50BLR3p+wkoEBljdLJ6EqjP 2ayh6auXBApGXDzZZ+4C/dB0Hai77BlPFRc9QLYSiUJnT2upZiiVJvzXefL6GrV0PnybUfPN OaBj3XVAvbZXmo1L5JnqUxq5pnWUk8t/u83kLt8JrVzW4+Tk+nEPJwfb7gqyvakW5BsPSpl8 7uFLIUOXqVu3U8ndvV+xrFr/pW7XYF8l2zu78OvnwTAUQNHbJZAgopSORROHoAR0okE6A/ho 0MerxRSgvb5KoxaTgO3XwprXIy1DPk5tnAY8NTfG1CIM6PDei6UEKQ29xc5YKlmqF9Ad6eei jSRpKz78p5dFmZfeQ5d9Jub10lr8ozEA6orFeO5CRyyTMO//DDYKUTZIqdj/61TsUZRuiTjc 1q9VB7ZguetlnJNwrLspzovQW17Gq/wtvmiI5qPDxYDDrsPx0AZsevzXPIsik5Zh3aVVqv4Q j4yf4KMapTdx4OlbUc3m0dFSyVStx2KbQU0bsaPnTlwjzs0mqlrGwfbS+LGuAI7VvuKOwuKq /3dVA9TCAiXfas5WrGvylK9WWk1ma35e9sode8wNMP9Zvf92hz3QFtneCZIIxkS9X2RZBo1p v/WAuRNQZMZk/aZe7xcG/U7TgW8Uy54sS36uYu2EhSJvXKBf4xrdZpCyTfuUHEXZq1hedzkx IaUAuo5mFG/NCfVstK9Oq042feC0z2pHLn9aleV4l4RbwcSMHZ5l2zKFLQ0/th70DZQnn59q 7/jEEbjaNlmz1P0kMHqvbmkRM5/cbDv8zkeXuQt82vHMSLo3/bv7689+zKZzlug25Yx81jOb NPP5utTNKaHRY43PQ4UVaz2/+x//MlJpe8PIW3eZ3l/OLFbTf26TjSWoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTYRSF/Wem0wEtjgV1ggJaNSqG4lCQiwsuickkJmrkDVSsMAEibUmn EEAfEIxCRRQEFCUVIbjgglihoGhoXUArIUBQG4oSJMENyiIgCGqB+HZyv3NubnIuhUvHCE8q Tq3jtWplvIx0Jax/Grv8vLLwyI3ZIwuh8q0BQc/HMhy687tIODt4CoMPFduh3lQsgrxPaRjk 5A1hYLqlJ+FHdzoBA8MmDOxPrWK40pYuhmFLnxjOtVxF0Df1DYeikhEELYZqEUyYH5PgmCol IGeyA8H5R00IGrOHCMivq0VwWk/D4O2bYiize8NwdxMBVptRDHdHW3GofjuNILexEkHz6b+i HSu5yZJyEVdW/xXjLl5vxblXtkIxl/3agHFVA7UY53jWQXI5jyoQ96bnLM7d6f1F7ncNl2/V ahJ1/IpYjaDbJotgIUDOhoA8IDBEziqCD20OCJL5h26N5uPjknitf+gReWxnyyU84fey5DHH KEpDGUv0yIVi6ECmxm7D9MiVktLliDEXjhN6RDkBw3zvxec87szUOz055xlBzLTpiWgGkPQ6 xpppmA170J0k037mJDED3OndTO/n5tk0Qa9hSnMmsRktoTczz419aG6rD3PnQcOsx8U5f+Ew kjNaSscxXTVlaE57M++v/cQuILcSNK8CefCJgipGJbByQakSEtUx8iiN6iFydl7zasJYi9qq wiyIppBsgSSTxCOlImWSkKKyIIbCZR6SXc3Ww1JJtDIllddqIrWJ8bxgQUHOA3Nxz8VRGucH qXWRbBAbDCFssCJYsQlkSyWZtPmglI5R6vhjPJ/Aa//nMMrFMw2lFRy8VmRff7T/ckWEwZKS ZbMWX5+vVuSPTyyYHnjZJGn3tdt2roo3Zb3o3ECaO/QtfqvHisZS+0Ozm/cuF8nXTv9k9Tea 7q96ucUsMRr2nLg3+sVIU2GYp+21UtFKpBpS8t2O+xRkhS/KSD/Je8GBfX4NRW/CvRJK6hyt PsuSZYQQq2R9ca2g/AeAYhfyCQMAAA== X-CMS-MailID: 20200706202709eucas1p2cb2da3247bfdd0b25a3fdfd2fd7b2d99 X-Msg-Generator: CA X-RootMTR: 20200706202709eucas1p2cb2da3247bfdd0b25a3fdfd2fd7b2d99 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202709eucas1p2cb2da3247bfdd0b25a3fdfd2fd7b2d99 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 11/25] examples/ip_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications: * ip_fragmentation * ip_reassembly * l3fwd-acl Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 13 +++++-------- examples/ip_reassembly/main.c | 12 ++++-------- examples/l3fwd-acl/main.c | 12 ++++-------- 3 files changed, 13 insertions(+), 24 deletions(-) diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c index 4afb97109..18a6df77e 100644 --- a/examples/ip_fragmentation/main.c +++ b/examples/ip_fragmentation/main.c @@ -593,6 +593,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -612,14 +613,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up .Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index 494d7ee77..910c89ae3 100644 --- a/examples/ip_reassembly/main.c +++ b/examples/ip_reassembly/main.c @@ -712,6 +712,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -731,14 +732,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index f22fca732..ddfec9487 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -1815,6 +1815,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1834,14 +1835,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:26:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73299 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48AAFA00C5; Mon, 6 Jul 2020 22:28:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5DCA11DCE2; Mon, 6 Jul 2020 22:27:14 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 9353D1DCDD for ; Mon, 6 Jul 2020 22:27:13 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202713euoutp028fecdf3534322598c7bf16d41716598e~fQ7P67tTD1760817608euoutp023; Mon, 6 Jul 2020 20:27:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202713euoutp028fecdf3534322598c7bf16d41716598e~fQ7P67tTD1760817608euoutp023 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067233; bh=q3R1NjSfULTkmVfHv5xauRfm4wQ4m9PAU/4z8Fmz1iI=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Tyt/K07ycnbstYTCy0vlS1dvUqzmhxevImco6sT015HAq6JVm+pOMkqBTwEtXCR7G Qifc/QDf2Sko1Vq0Mf2Ib24xlxhsai8QZ3XzT0xaIuErEFPw6Uo5DcGvevwLrvIN3e 4tAuskKeAfPNidu+cejL3uZp6zhGqd8AlDSfBTbo= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202712eucas1p1a9bdb8ecc390217b27856d3af601fa33~fQ7O_fqpy1287412874eucas1p1t; Mon, 6 Jul 2020 20:27:12 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 75.99.05997.029830F5; Mon, 6 Jul 2020 21:27:12 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202711eucas1p12fc8d5efc4eb465d9b09c2e7d2d70ad7~fQ7OjL3pw0323603236eucas1p1s; Mon, 6 Jul 2020 20:27:11 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202711eusmtrp2399d3e354d7832e43c66b57aba5a3fe7~fQ7Oibkdm3205132051eusmtrp2s; Mon, 6 Jul 2020 20:27:11 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-b0-5f03892023af Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 87.4E.06017.F19830F5; Mon, 6 Jul 2020 21:27:11 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202710eusmtip1b3677ef58ad377942ec2f494820ae140~fQ7MzBbNB1560515605eusmtip1X; Mon, 6 Jul 2020 20:27:09 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:02 +0300 Message-Id: <20200706202626.28628-13-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSW0wTaRTH8820M0OxZiyynqDROlnvCrvKw9FVQSVmHoz44IMxKladgJFW tyMo+tKQXVIRkZsQQQtLYxAkAlrl4iVYlapFWNy4XMIiks0S0HKTRkG6SJ0a337nd87/nO/h 42hdNhPGHTWdlMwmQ6LAaFR3myZa1ujP0XE/Pc7isarZRrCvx05jb94/DJ4f+Y3CjooovF97 RY05bywUZuaMUlh7PZ3B972pKhwaq6Ww+4GbxcJXqSyOOftZvNBaRLB/apDGyyUfCLba7qhx 4lEDg8NTpSrMnHxN8KLjGUFXxqgK8+rrCKal8zhSXsaivXshjvU+U6G78zaLld42Gu80+whm u6oIvkybVkcvFidLrqlF+/0BSsz9o40WmzrzWTHjuY0Sa4bqKHH44WtGzHRUEPFF33lavPHv J2aXZq9m4xEp8WiyZI7YfFCTUPO2UH0id/Zpz+AmC3EHp5MgDvhIaKv2qNOJhtPx1wk4OjpZ pRgncMVXFCg+EGjy2sm3SPlnO+NnHV9G4E3xToW9BHxD8/3M8MvBbbVR/vBcvoaB2ql2yt8I 4XdA1tVUtZ9V/BIYaq7/6rX8Brg0UcYqBxbBjepG2s9BM/7J8O3AsYXQXjz+dSnwzRyU/fmJ VgIx4KpsoRQOgUGXI7BoAUzXFwf8Wfh4q51VwlYCPaW/B4aiwPGuZYY5juZXQFVDhKK3wHCr g/Fr4GdDh2eOX9MzmHO3gFa0FqxpOmVagMbnrwIawPd5lqJFcI52E+X1DwhM98ZmkUWF30+V EFJB5klJsjFekteapFPhssEoJ5niww8fN94iMx/V/b9rvI40TB1yEp4jwiytlaHjdGpDspxi dBLgaGGudutL9wGd9ogh5YxkPh5nTkqUZCeZz6mEedp1pQP7dXy84aR0TJJOSOZvXYoLCrOQ 4P7TeR2hu39xu9f8tUee+Fj0q7CzID/lx+quiHs20/b8bSH/jf8dvVVv861qLTcXdBvfrTg3 Eq1vvLfMe/Vp7MYNEdNevWV18cPcjH3J+TXWKnuosGVpm1ba88OL2P0xj3OsZnbBBU92aEwU JUxqbuorI8O9TX3ZkevDulITMj0WQSUnGH5eSZtlwxcdQAwGpAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+93XprW6TbOrkdagkNDZfORRtMIIrlCg+FdZ2dCbj9wmu5tk /pGJmk1bZhZktaxhvgLzkY80H8OmNk0ssiRfiSD2mI/sodljy/rvw/l+zzlfOEeIixcJN2Gi UsOplfJkCeVIWH51j3p7XMRjdt+f8YfqPgOCyTEjDhNFoxTkzWVh8KZyH7Q23iKhcDwDA33h PAaN5ToKPk5kEmBdaMRg5IlFAMUvMgWwYJoWwKWBmwimV97jcKPkM4IBwyMSljofUzC7co8A /fIrBJfrexB0588TUNTchCBHR8NcRZkAjCPusDDRQ4BluE4AD74M4vCo7yeCK93VCPpzfpP7 t7PLJaUka2ydwdirdwdx1jx8XcDm9xowtsbahLGzba8oVl9fidhnk3k4WzX1nYpwPCoNUau0 Gm5bgorXhEqiZeArlQWB1Nc/SCrzCzwe7Bsg8dkbEsclJ6Zyap+9J6UJNe+KyZSr6898eh+a gSxrdchByND+TMUPI2VnMV2KmK7n6ToktNUZ5sMUvmpxYlaGdDaLo83yGTEF5mxkFyjak7Hk GjC74Ey/pZiXF84TdsGJPsQU3M4k7UzQOxhrXzNmZxEdzFxbKhOsTvVgqh52/N3gYKt3zdb9 C5HIjDYY0Sq7M6/vLGIFaH0JWlOJnDktr4hX8L5SXq7gtcp4aaxKUYtsF28wL9U3IZ01yoRo IZKsE+VSeIyYlKfyaQoTYoS4xFkU1m85IRbFydPOcmpVjFqbzPEmFGALeAV32xSrsv2PUhMj C5AFQpAs0C/Qbw9INoty6c5jYjperuFOc1wKp/7fhwkd3DLQgW9PT+gjo52Dw82HoinX4i6r NF40l+s1d9jdtCHNu729HA14uHLj9S39isiItiPp4RLK56vZtNBjcG/3Gk9F/a2TpVXaYug9 dzP8cObG7pKh0OGo0DUt6R1baraK5j312cqk2uSwjhDHraSLaoz0iiWLREkV+3a+PHgqy+WG hOAT5LJduJqX/wEYiSYiBwMAAA== X-CMS-MailID: 20200706202711eucas1p12fc8d5efc4eb465d9b09c2e7d2d70ad7 X-Msg-Generator: CA X-RootMTR: 20200706202711eucas1p12fc8d5efc4eb465d9b09c2e7d2d70ad7 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202711eucas1p12fc8d5efc4eb465d9b09c2e7d2d70ad7 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 12/25] examples/ip_pipeline: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index d79699e2e..ca461ea0c 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -249,7 +249,8 @@ print_link_info(struct link *link, char *out, size_t out_size) struct rte_eth_link eth_link; uint16_t mtu; int ret; - + char link_speed_text[16]; + char link_status_text[10]; memset(&stats, 0, sizeof(stats)); rte_eth_stats_get(link->port_id, &stats); @@ -268,18 +269,19 @@ print_link_info(struct link *link, char *out, size_t out_size) } rte_eth_dev_get_mtu(link->port_id, &mtu); - + rte_eth_link_strf(link_speed_text, 16, "%M", ð_link); + rte_eth_link_strf(link_status_text, 10, "%S", ð_link); snprintf(out, out_size, "\n" "%s: flags=<%s> mtu %u\n" "\tether %02X:%02X:%02X:%02X:%02X:%02X rxqueues %u txqueues %u\n" - "\tport# %u speed %u Mbps\n" + "\tport# %u speed %s Mbps\n" "\tRX packets %" PRIu64" bytes %" PRIu64"\n" "\tRX errors %" PRIu64" missed %" PRIu64" no-mbuf %" PRIu64"\n" "\tTX packets %" PRIu64" bytes %" PRIu64"\n" "\tTX errors %" PRIu64"\n", link->name, - eth_link.link_status == 0 ? "DOWN" : "UP", + link_status_text, mtu, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], @@ -287,7 +289,7 @@ print_link_info(struct link *link, char *out, size_t out_size) link->n_rxq, link->n_txq, link->port_id, - eth_link.link_speed, + link_speed_text, stats.ipackets, stats.ibytes, stats.ierrors, From patchwork Mon Jul 6 20:26:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73300 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22931A00C5; Mon, 6 Jul 2020 22:28:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 800391DCEA; Mon, 6 Jul 2020 22:27:17 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5F80F1DCEA for ; Mon, 6 Jul 2020 22:27:16 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202716euoutp01d606eeee820a90d7993651acda2ba3f8~fQ7ShPqQ82593425934euoutp01g; Mon, 6 Jul 2020 20:27:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202716euoutp01d606eeee820a90d7993651acda2ba3f8~fQ7ShPqQ82593425934euoutp01g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067236; bh=1YhjGGZIH+BiDd1vuZIqrQ6NKJL1whpE3mlU+Xfl3zM=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=ThSZYqUojhpD+BaffTIyHhUS/jXbNGVx3+iFezg5hmyQM0xakemrKpKmh1i8pVn96 DLSgK4dyiqVTAtQkxRn7+yf/HKLg30C5XdizJV8VkICk+aPFepA/OmEPiQwtIF9aLT ntQOADjCAilNZ+bXKuQJyC2FHgsQnDnISNWQLco0= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202715eucas1p2d3d8f427b87b7400ca18f3a3596f6384~fQ7RfngCJ0114101141eucas1p2o; Mon, 6 Jul 2020 20:27:15 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 97.99.05997.229830F5; Mon, 6 Jul 2020 21:27:14 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202714eucas1p1b5817c2d30800b97f6c2acbe891f9aa4~fQ7Q_RiJ70814308143eucas1p1o; Mon, 6 Jul 2020 20:27:14 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202714eusmtrp2f8168597a2990ceee3e234d45d468a3b~fQ7Q9dYii3205132051eusmtrp2t; Mon, 6 Jul 2020 20:27:14 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-b4-5f0389221b1f Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id A9.4E.06017.229830F5; Mon, 6 Jul 2020 21:27:14 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202712eusmtip177ab76e21a3303b7ed204e9d3a17cb4e~fQ7PLEIhX2342423424eusmtip1d; Mon, 6 Jul 2020 20:27:12 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:03 +0300 Message-Id: <20200706202626.28628-14-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf0yMcRzHfZ/nued5ujl7XOgjxtyYX6uQPz5oyLBno838ZTbl8KyirnZP 5ddmDbXrJIn5cZFcXFRb1OVOykhUrjKMspHkRxJ1rjOiovOc+e/9eb3f370/++zL09rjbDAf b0iRjAZ9go5VMzceDLaG6LLomAWe9xFY3lxAsKujiMbOk69YPOI+TGF7yQqscZxTYd7rdApz 8r5S6LhiZvFz50EG+zwOCl/Wuji0PDnIoaeum8Ojj/IJdg99ovFs4QDBRwVVKhy8W81i/5CV wZyfzwgeszcSbMj+yuDJm06CmWYB3VeLOSx6OQ09nY0Mul5Uclj27TGNVc3DBI83lBNsyfyt WjlD/Fl4WSUW1fRQ4omLj2nxwYtTnJjdVECJ1/uclNh/+xkr5thLiPiw6wgtlr77wW5Qb1ZH 7JAS4tMkY9jyreq44Tcuklyq3mPpy6DSSSFvJgE8CIvhVpOFMRM1rxWuEPj42aZSBi+B5+ff +IcBAiV3B5h/T06ft9M+rRWKCQzUb1RC3wh4z55R+QxWmAMuUwHlMyYI11lwDLVRPiNQWA8V tdl/NSPMgtt9HayZ8LxGWAofMqKUgulQeu3O34KAUVzfX8kqZdOg7YKXUjKNPBztmKzo1ZCd ZffzQPjUYOcUPRV+37zg5/vhe0Ub59sHBBOBDmuGP7QC7L2tnG8HWpgL5dVhCo6Ee+lvVT4M wjho/zLeh+lRmXfjNK1gDZgytUpaB3eanvgxwPCvsYoUwa3cQCvUEnhdWcbmkumW/1WFhJSQ IClVToyV5EUGaXeorE+UUw2xoduTEivI6Ed1jTR4naR6aFsdEXiiG6sxsXSMVqVPk/cm1hHg ad0EzaoWV7RWs0O/d59kTIoxpiZIch2ZwjO6IE24tWeLVojVp0i7JClZMv5zKT4gOJ2kJByz ReZbwi09xc97o+ZUza5fBhPL3WnewRnx+4TFY4ouWQ9cDXsXGJw/kjvpTFb02ohAW1TSfdh5 aElNc1PLr65QuTNuu8fWOvL0MLemLC6k+/Kr6oz57bmGeJfnxALn+y3rQtzfTe2pe0yHIjc5 bcZex8zoJeFBc62WqKTVyft1jBynXziPNsr6P5C5MqekAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cdLS5T6adC2SjIyNmmtqOYRRRc6EHgP1HWuuhFTefi 3k0yCMzKbJmp2ctqaWaZBpZOp2Wv9Zi6LOwtPrL3e5YmadhjU/rvy/l8z/ccOIchVSNUMJOW aRbETD5DTSso9x9XX7h6L2lY8PNKENTdsyF41V9JwkBpHw37vu0i4HnNYmh1nJBByYscAgpL vhPgqLbS8GUglwLPkIOA3qtuOZQ9zJXDkPO9HPY/OI7g/fgnEo6VDyN4YGuUwdjNyzQMjp+m oPDXEwQH7G0IXAXfKShtaUaQZ2Xh2/lzcqjsnQFDA20UuLsb5HBhpIuExnu/ERS76hB05v2V LZnF/SqvknGVrR8J7mBFF8nd7T4s5wrabQR3ydNMcIPXntBcob0GcR2v9pFc7ZtReo1inSZO NFnMQmiqSTIvUq/Xgk6jjQGNLipGo43Ub4jVRasj4uOShYy0LEGMiN+kSf390o221Cq2lnl2 EzmonLEiPwazUfjISTtpRQpGxVYhXHtnJ2FFjBdg/PkNOenxx+NPrfSkZxjhUscfwgdodi52 59sIHwhge2j8aM8Oygf82ZW4/mrBhIli5+Brnn7aF6pkY/G73asmQ2fi2os3Jgb4ecu3Bxto n1axabivqRJN6hn42akfRBGaVo6m1KAAwSIZU4ySTiPxRsmSmaJJMhnrkffkTXfH7M3I6klw IpZB6qnKfJo0qGR8lpRtdCLMkOoA5dJO90aVMpnP3iaIJoNoyRAkJ4r27ldMBgcmmbwPlGk2 aKO1eojR6iP1kQtBPV2Zz95MVLEpvFlIF4Qtgvi/j2D8gnNQoCO+a9l4WG6SKu7oNsuoonOx 2CCmr55t1sfkKYI4Q1FdaEu7Q8SHhPkJ20usGdfRivAzgfTyHY7e1Ne2rJ6AS/x2VUh+GKQk 1LxN0gR+6PgacjFx9sngRJch0hj0d3RlOq+YZkH0iHlsZO3jW2fbNw9jmXmXrboi6n7ZTLea klJ57TxSlPh/kYMv6wgDAAA= X-CMS-MailID: 20200706202714eucas1p1b5817c2d30800b97f6c2acbe891f9aa4 X-Msg-Generator: CA X-RootMTR: 20200706202714eucas1p1b5817c2d30800b97f6c2acbe891f9aa4 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202714eucas1p1b5817c2d30800b97f6c2acbe891f9aa4 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 13/25] examples/ipsec-secgw: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ipsec-secgw/ipsec-secgw.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index f777ce2af..551838229 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -1775,6 +1775,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1794,14 +1795,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:26:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73301 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C464EA00C5; Mon, 6 Jul 2020 22:29:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B57E1DCF4; Mon, 6 Jul 2020 22:27:20 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id AFFDB1DCF3 for ; Mon, 6 Jul 2020 22:27:19 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202719euoutp028f0153aa552b91f97d8ce4a1031d2453~fQ7Vm8lAE1760117601euoutp021; Mon, 6 Jul 2020 20:27:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202719euoutp028f0153aa552b91f97d8ce4a1031d2453~fQ7Vm8lAE1760117601euoutp021 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067239; bh=Gr1Jcl7miAeWLUh9GahLeLAq7ORJTSLyxj+MvXGXDw4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Rlh4ZNW8lnAlxVGFn+D0ZV+3/hg0xLUeAXpFmP3Vq8VNwHUAi3TZJw9TrjgKVNdEy Owrkx9UPlW/7LzrP/u++rLwxV18sDtYTVAa4bRsqTw8Xd3tCjY5VAY1tlqajFR1kvq ugxFFT/CY2trH9nS6p9OkMnSa4KmqmalI/yNJHhE= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202718eucas1p1869aa2ba51f9ec8dd06e6d093dd99f38~fQ7UlTqyE1287412874eucas1p1v; Mon, 6 Jul 2020 20:27:18 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 38.96.06318.629830F5; Mon, 6 Jul 2020 21:27:18 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202717eucas1p2d66b3ffebdd370ac1e2ecd9f398259d8~fQ7Tafw7D0500605006eucas1p2p; Mon, 6 Jul 2020 20:27:17 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202717eusmtrp235b6bd7a6f6eb24d612d16a13748a8ca~fQ7TZc8WW3205132051eusmtrp2u; Mon, 6 Jul 2020 20:27:17 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-32-5f038926067e Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 2B.AF.06314.529830F5; Mon, 6 Jul 2020 21:27:17 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202715eusmtip12e6906245383229d2961bbe1a26b4968~fQ7RpzpFE1560515605eusmtip1Y; Mon, 6 Jul 2020 20:27:15 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:04 +0300 Message-Id: <20200706202626.28628-15-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa1BMYRjH5z3n7DmnnY45NvKKEdu4FLmUyzPGNcycDz74IDOFsjhT6Da7 cokxjUmybYsVRpktNaYb3XVTjcJu2bRCqpE0MUNuKVJU2N2zxrf/83v+/+d55p2XJRWptAd7 IOqwqI5SRShpOVVh+mn1nXeODF16ts4dilqMCPp6sknoTX1FQ/LXBAI689dDbeV1GRhexxOg NwwSUJmrpeFT72kKvgxVEtBdZ2Eg7elpBoYa3zGQYk1H8G78AwnXMr8hsBrvyOBnQw0NA+NZ FOh/tSM4X96EwKwbpCC1ugpBopaHr3k5DGR3z4Kh3iYKLF1lDNwabiPhTssEgovmIgSPE//I NswRfmXelAnZtf2EcOlGGymYuq4wgq7ZSAglX6oIYaC+nRb05flIeNSXTAoFb0fpbfJg+Zr9 YsSBI6J6ybo98vDnulY65gF/rNowxsSj85wWubCYX46Lui5TWiRnFXwuwm2jFaRUfEc4s1CP pOIbwl2/c+h/kUedVqcrxxapf0ZIxTDC2hcm0u6i+QXYkmR0NKbwJTSuHO8g7A03fjP+YXpI 2TXFz8Uvm67ZAizL8avx7SubpA2euKD4nmOOiw0/GChzbFbws3BHxnfHTMy3sNiaMMFIgc3Y qtdSknbDH8zlTj4T/6nOICR9Ao+UdjBSOAnhnqwzTtN6XP6xlbEfQfLeuKhmiYQ34vQbTxy3 YX4S7vw82Y5JmzRUXHViDiclKiS3Et9rfurEGE+MuUpYwM3ZZc7nqUNY/6aauIA80/7vykQo H00TYzWRYaLGP0o8ulijitTERoUt3hcdWYpsf9Xy2zxcherH9zYinkVKV66XJUMVMtURzfHI RoRZUjmFC3hsCVFw+1XH40R1dKg6NkLUNKIZLKWcxvln9e9W8GGqw+IhUYwR1f+6BOviEY+8 w5XF9MHgVV6Xd6wIuMv17RuJ167dMiM913drSMoI6e5TOHV7T15cqPqUKXDmwtzn1yM2xdUH xo7NVi4a9Nj6+lSc33tdQ3dwwy7/hgJf8/yA6aR3oFdQsueOIIN4ctSvtd+L42pTMlz6V/ot dPU23vd3d0uIGdi5dKoqR1cwlp+npDThqmU+pFqj+gsHJZAbpwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTYRSF/Wem04FYnYwQRzQIVRI12jos9ta4i2beNOHNDapMgNhS0mkb IdHgEoVaURFJUEGwNCgoKosgCpGCgJRFVBQCCCEQXNlxQVwKjW8n9zv35CbnUjgzRfhQMbFG wRCr0cpJT8L5p75nXUAyHr7+RT8B95uyEPS/t+HQl9ZDwvnRMxh05G+Fp2U3JJDam4hBSuoY BmW3LSR86TtFwPB4GQbdlU4pXHt1SgrjjiEpXGi9jmBo5hMOGdkTCFqzSiXws7qChJGZWwSk TLcjuFjSgKDeOkZA2uNyBGctNIzeyZOCrdsXxvsaCHB2Fkvh7lQbDqVNvxFcrr+PoPnsX8k2 f3462y7hbU8/YvyVnDacr+tMl/LWF1kY/3C4HONHqtpJPqUkH/GN/edxvmDgB7nXc59ik0Fv Mgp+0XrRuFm+n4NABacGRWCwWsEFqQ5uDAyRK7dsihS0MWbBoNwSoYh+Y20h42rpY49Tf0kT 0UWZBXlQLB3MNna04hbkSTG0HbGDtV2EBVEuwLKfB3C3ZxE789ZCuj0TiH2Q2zIHSHoV60zK wmaBF91Fsq/PnSRmwSI6lP1W93xOE3QA29WQgc+GyuiN7L30ne7Q5WzBg2dzOR6uce1IMTmr GTqG7XlkQ27ty767OYldQguy0bx85CWYRF2UTuQUokYnmmKjFEf0uiLkqvxR3c/icvTqYZgD 0RSSz5clkXg4I9GYxXidA7EULveS7Wh2HmJkkZr4BMGgDzeYtILoQCGu+y7jPt5H9K4HijWG cyGcCtScKkgVtAHki2VJdPUBho7SGIWjghAnGP7vYZSHTyLKDJ5eu7RIu6sxQ171peV0qSrO 71Ply8Mq89dCPiyzyN7SHGFZMW7v/qw6XnN7v3JZdMJIYl5OvH2id6WyCtkKlU9q2jczASd8 ucb1/ntqArQJg5PJ2yuYeMqxOm/hB+97u0siEpqXPDd/n/xTGZpbeFJ/tUC918RMtXmEpZ6x JssJMVrDrcENouYfYOb7tQgDAAA= X-CMS-MailID: 20200706202717eucas1p2d66b3ffebdd370ac1e2ecd9f398259d8 X-Msg-Generator: CA X-RootMTR: 20200706202717eucas1p2d66b3ffebdd370ac1e2ecd9f398259d8 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202717eucas1p2d66b3ffebdd370ac1e2ecd9f398259d8 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 14/25] examples/kni: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5d12a5b8..8ad7fb532 100644 --- a/examples/kni/main.c +++ b/examples/kni/main.c @@ -661,6 +661,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status\n"); fflush(stdout); @@ -680,14 +681,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %uMbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ @@ -717,19 +713,15 @@ check_all_ports_link_status(uint32_t port_mask) static void log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link) { + char link_status_text[60]; if (kni == NULL || link == NULL) return; - if (prev == ETH_LINK_DOWN && link->link_status == ETH_LINK_UP) { - RTE_LOG(INFO, APP, "%s NIC Link is Up %d Mbps %s %s.\n", + rte_eth_link_strf(link_status_text, 60, NULL, link); + if (prev != link->link_status) + RTE_LOG(INFO, APP, "%s NIC %s", rte_kni_get_name(kni), - link->link_speed, - link->link_autoneg ? "(AutoNeg)" : "(Fixed)", - link->link_duplex ? "Full Duplex" : "Half Duplex"); - } else if (prev == ETH_LINK_UP && link->link_status == ETH_LINK_DOWN) { - RTE_LOG(INFO, APP, "%s NIC Link is Down.\n", - rte_kni_get_name(kni)); - } + link_status_text); } /* From patchwork Mon Jul 6 20:26:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73302 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C913A00C5; Mon, 6 Jul 2020 22:29:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 253CA1DD03; Mon, 6 Jul 2020 22:27:23 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id DCC751DD01 for ; Mon, 6 Jul 2020 22:27:21 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202721euoutp012d57561823b63b85378905da2f06b726~fQ7Xqhdr_3113131131euoutp01u; Mon, 6 Jul 2020 20:27:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202721euoutp012d57561823b63b85378905da2f06b726~fQ7Xqhdr_3113131131euoutp01u DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067241; bh=0KRTz2AP5FV+jHZTStTVbtq12s0MKBOah3XGntzISPk=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Z1ItDP+i1Xh0gJvi6Qg4fCSOcC9hvncNZmcn7wcXvNPoMKFMvEjuA4zZE2DChmb4F DSHFpQyi3WCr/MdgP9nGNVrnDQHKchxBMXi6OwmTqWY6pMnMp0jdzzcV+HGqIGtPRV 4iOgglVwcbaHNJNKgTWLcSXvvhVHwy0LZEiCsiVg= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202720eucas1p1ab61962675986a31f8d9062341dd3377~fQ7WwRkXo0894308943eucas1p1f; Mon, 6 Jul 2020 20:27:20 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 5A.96.06318.829830F5; Mon, 6 Jul 2020 21:27:20 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202719eucas1p1b61bd1297794e070c607c4eb916c7017~fQ7V7QW9G0323603236eucas1p1t; Mon, 6 Jul 2020 20:27:19 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202719eusmtrp20e29457320cb293dda9e4dc2817b6824~fQ7V6bN4u3205132051eusmtrp2x; Mon, 6 Jul 2020 20:27:19 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-35-5f0389286346 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 7D.AF.06314.729830F5; Mon, 6 Jul 2020 21:27:19 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202717eusmtip12a7a990aa0d76c8f2133446978cf0033~fQ7UIn_oY2342423424eusmtip1e; Mon, 6 Jul 2020 20:27:17 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:05 +0300 Message-Id: <20200706202626.28628-16-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTGc+69vfe2o9u1ED1hBrPuI2iizsgfZ8umTvZxl5nFaOISo+JV b8CMzxacbolhzGFFxA1hZGpKbbOIsIUPkQIqIm7WWkRhU6gKa4wZ4qbVAkOxylpuzf57zu88 z3mSN6/Imir5RHFrdr5qyVYyzbyBazn/uGd+8h427c2GwrlU320HujXkYilQMcjT3ge7GBqo XUqn3Id1VP5nIUNl5Q8ZcteU8PRPoIij+yE3QzdP+wQ62FckUKhrWKB9lw8BDYfvsvSjYxTo sv2Ejh6fbecpGHZyVDZ5FWh/8wUgT+lDjiraWoGKSyR6cOyoQK6bSRQKXODI5z8u0M/jvSyd 6H4K9L2nHuhS8ZRu2SvypOMnnew6NcLIB470svJ5/w+CXOq1M3Lj/VZGDnZc5eWy5lqQL97a y8p1tx/xKw1rDe9sUTO3blMtC5dsNGQEnCeF3H2G7b8NuJlCKBJLQC+ilIKDle18CRhEk1QD eMfbJGjDGGCn7UBsGAU8E/yLfR65cc3JaIujgL/01MTy44BP/ujmoy5eSkafzT7tSpAaeXSH +5noIl5agaGWG1xUc9LrkcAxIaqN0tvouFILWsUcrGvonK7TR/ivwePTR01SEvZXj00fRemK iFP2Z7HA+1hpH2Y0HY93Pc2CpmfjVFt1jH+FE039gha2AQ45v42ZlmLz3z0RLYqsNBfr2xdq +D3scU3wUYzSizhwb0YUsxFZ3lLFatiItmKT5jZjp7cvhhGfPonTsIy/t1eA9j6nAVv6S5nv YM7B/7scALUwSy2wZqWr1sXZ6hcLrEqWtSA7fcHmnKwmiHxW3zPPeCt0hDd1gSSCOc4YENk0 k07ZZt2R1QUosuYE4/JLvg0m4xZlx5eqJSfNUpCpWrvgZZEzzzIudo6sN0npSr76uarmqpbn W0bUJxaC7uPJ1OueO8knWxNq+kzzYcRbps/r/RC+XvVGlfOTJW/lrz1nq+t4F1I+XXbblzGw Lm/shba8l4rCcR/NVHPXObqTykf924Of7U9ZsxI/qN65Wtlc5U3NCB0ab5tMZab8ltmN//ob 5rkz9+x2Kfr4bxoT5TUz5ddyJtIrB1e8OrR6zMxZM5RF81iLVfkP1gycKagDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTcRDG/e9ut0u1ZlNq+IcHxE0UJFJYEBmIV3gwG+XByIMJqLXCBogt 1W4hCDEiGsQKeBEUMYBURAoKilyKRlEpWgyeCIEqGhKiJXJ5gXgUiG+/zPd9M5PMMKTqO+XN JKeYRVOKTs/RCsrxx+4M9DtOaoPvVQRCXVcpgo/vrCQMFjppODF2lIBe2wZoa74ogzPvswgo ODNOQPNVCw0jg9kUfJloJmDgrkMOF15my2GifVgO+d0lCIZnPpNQXD6JoLu0UQZTD27TMDpT QUHB9BsEJ291IrDnjVNQ2NqCIMfCwlh1lRysAz4wMdhJgaOvQQ61316Q0Nj1G8Fpex2CZzl/ ZRuXCdPllTLB2vaJEM5eekEKHX1FciHvSSkh3PjSQgij997QQsEtGxKefjxBCjVDP+mtiljN WpMx1Sz6Jhkl8zoujocQDR8BmpDVERo+NHxnZEgYF7R+bYKoT04TTUHrd2uSBivuyPflK9If 9zYTWSibsSAPBrOrcX9PBWFBCkbFViJsv24jLYhxCxi7hsh5jyee6bHQ855JhK85XWhWoFl/ 7MgtnQur2X4avzp2mJoVPNloPNHUP8cUuxz/el0tn2UlG4nLn9vQfNeluKb+/twED3f90WgD PcsqNhk7m6xonn3w27KvxCm0uBwtsCG1mCoZEg0Sr5F0Bik1JVETbzTcRO6bN3VMNbSglzdi 2hHLIG6RMpcmtSqZLk06YGhHmCE5tTLqmWOXSpmgO5AhmoxaU6pelNpRmHvB06T3knij+4NS zFo+jA+HCD48NDx0DXBeylz2wQ4Vm6gzi3tFcZ9o+p8jGA/vLHRuS0Rf9N6i3dhLcrhaPTqD ojKr/GKClbwr3hqZ8KE+6ke1urd26NRG7u3+lZ57ojdbGlb0OEu8lmZti1rCFVZdtiiSRoyB q6aKHx6xBxxSXOFVGXmZGWp9bNqjsBHuz6Yu3+D0zw/rWsti/Ju0Ha44CYr1U/UHt59/vvla d+5CjpKSdHwAaZJ0/wA/weVaCQMAAA== X-CMS-MailID: 20200706202719eucas1p1b61bd1297794e070c607c4eb916c7017 X-Msg-Generator: CA X-RootMTR: 20200706202719eucas1p1b61bd1297794e070c607c4eb916c7017 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202719eucas1p1b61bd1297794e070c607c4eb916c7017 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 15/25] examples/l2fwd-crypt: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-crypto/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e..7648ea027 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -1734,6 +1734,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1753,14 +1754,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:26:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73303 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16142A00C5; Mon, 6 Jul 2020 22:29:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5032E1DD08; Mon, 6 Jul 2020 22:27:25 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 099981DD08 for ; Mon, 6 Jul 2020 22:27:24 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202723euoutp02fa9ddca0e1be837bd294504410ba1294~fQ7ZpDMyo2313123131euoutp02J; Mon, 6 Jul 2020 20:27:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202723euoutp02fa9ddca0e1be837bd294504410ba1294~fQ7ZpDMyo2313123131euoutp02J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067243; bh=srhawFEXUKW2qnG3XOlQI1DTOaaunL+pDywNZ8YTyIM=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=kiM3wsqJtcoNARgfrdrX8Y3g7dmH6WT45aVle2d8l8pShMjpZd21XxmvfUFSztpVl k/cR2a94CFksvyzWpvhi8nh384BWDeynWnO2Y+6RA8ya1tJP+Q0mPDcNhunww2z7Gq Ajs+oCWDYk9LBAiQoOQF1TyC6DAPZqU1ndyEAu+Q= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202723eucas1p1a50d8a6e86561d37037edd3330650bc4~fQ7ZHJMwh1288012880eucas1p1j; Mon, 6 Jul 2020 20:27:23 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 45.B4.06456.B29830F5; Mon, 6 Jul 2020 21:27:23 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202722eucas1p1a631c58e9805c00286a2a4b469aeb124~fQ7YVPSFa0478404784eucas1p14; Mon, 6 Jul 2020 20:27:22 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202722eusmtrp20036d3d260b0816c4015ff1089acd1b3~fQ7YUdzwX3205132051eusmtrp2y; Mon, 6 Jul 2020 20:27:22 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-09-5f03892b5384 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 4C.4E.06017.A29830F5; Mon, 6 Jul 2020 21:27:22 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202720eusmtip1a395af4430c92d06cdfccd5622f6fe8a~fQ7WkI8Dy1791017910eusmtip1C; Mon, 6 Jul 2020 20:27:20 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:06 +0300 Message-Id: <20200706202626.28628-17-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTdxTGc+69vfe2s8tdJfHoFs1utkRFRcaSHd2Lm1my+4FkS2b2wUxY N69ghMpa0Tk3g0QIVIqCTjaHBcukCHMdUqW+pnROZEUMTQoyFRqmczosWiAKK3OUi9m35/ye 55yT889fZE37+XniRssW1Wox58i8gTt1abxraXIpm7nc9ecz5Ol0Ag3217EUOXCTpz0PdjN0 rXEVnWut1lHlQAFD5ZUPGWptsPM0FCnkKBprZejG+aBAh0KFAsUCdwRyXP0e6E78Hkvf1Y4A XXWe1NF42xmehuMujsonwkB7vZeB2ssecnTgtA+o2C7Rg2NugepuzKdY5DJHwb4WgX4c62bp ZOckUEW7B+hK8RPd2y8qE7VHdUrdubuMsv9IN6tc6jsoKGUdTkZpjvoYZfhCmFfKvY2g/Da4 h1Wabj3mPzCsNbyxXs3ZuFW1prz1iSE77vazeU7DF3svOJkCqBDtIIoovYr7rpvtYBBNUgNg U/djXitGAX89chS0YgRwKPwX/7Sj7PBcjbsBvd/+IWjFGGD1RD1jB73ISwsxWOJkEkaS1Mxj a7x32pgtpeNIiYdNaE56GQeOx4SENkorsbDGOZ1BaQE2/eyfzuin+MXhFj6hTdJ87K0ZnR6K UqeIhfWTrNbwLv5QX8Vrejbea/cKmn4Bn5yumRm6Ax+d6BW05hLAflfRTGgVev/uEhK3sdIi 9JxJ0fA72FU+pNNOfhav3X8ugdkpWXmqitWwEUuKTVpaRn9HaAYjTv4zS8MKHu7xc9r7nAf8 qToi7IMFh/7fVQvQCHPUfFtulmpLtajbltnMubZ8S9ayzzbnnoCprxr8tz3mg7HQpwGQRJBn GSMim2nSmbfatucGAEVWTjKuvhLMMBnXm7d/qVo3Z1rzc1RbAJ4XOXmOMc11d51JyjJvUTep ap5qfeoyon5eATgabh27+Ut/cpt722DbwME0X0apseq9NV8veb2oZ4dvpbCwY+eGHs9tvzts GW2uT//cm7FWvv/+m9c/knf2hXsdGzJSi9LWrPj4K8fqqBzanT2c54yEugYCrl1JLa99E3eM 61/6fVHNo9ulKbHoxbMVseQVc48vadllkPSvpH8ITdEGmbNlm1MXs1ab+T8e3WsmpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3ddrS5L6ZeB1SAKo9mm5lHMoj/iEpWGYKmVDb2p5TbZ 3SSDwExs3dTSHtDraomYZpnmq5ek5COnmJWW+EhEMCumzoQeprms/758z/dzzoFzGFI1RXky iUYLbzbqk9S0grLPtgxs8j5Hxmxur/SA8nYJwfBgIQlDlwdoOD+RQcCH0m3wrPamDPI+phGQ kzdJQO1dkYavQ+kUOJy1BPQ/t8vh+pt0OTgbR+WQ3XkDwejMZxKuFUwh6JSqZfCj4QkN4zN3 KMj52Y3gQlUrgpasSQouP65DkCmyMFFSLIfCfi9wDrVSYO99JIey6S4Sqtt/I8htKUfQkTkn 276W+1lQJOMKn40R3KXbXSTX3HtVzmW9kgiuwlFHcOP13TSXU1WKuLbh8yR3b+Q7HaaI0gSb TVYLvybBJFi2qqO1oNNoA0Gj8wvUaH0DDgXp/NU+IcFxfFJiCm/2CTmiSZgpfkEmS4oTF+ol Ig3lMiJiGMz64axbK0XkxqjYIoTnKvct2Bh/GSFdNmaX45kekV6ITCGcPbbTpWl2A7bbJEJE Csad7aPx27OnKVdhObsbT9nK/8IUuw5/vO+Uu7SSDcLp+S7A1XQ1vvfwxd+M27z/cvzRvwGJ eKCmEC1oL/w+/xtxES0tQItKkTtvFQzxBkGnEfQGwWqM18SaDJVo/uA1zT+q6pDoCG9ELIPU S5Q2moxRyfQpQqqhEWGGVLsrd3TYD6uUcfrUk7zZFGO2JvFCI/KfXzCX9PSINc2/j9ESo/XX BkCgNsA3wHcLqFcobWzDQRUbr7fwx3k+mTf/5wjGzTMN7TLt7zMOHYkL+dKdHFq3bLRz1puU Z3qWTSdW7fn6IJtu8gpeNGfY8rT3QPLrptGN+RliqMlx47oYLQ0fDvqVEhdJdz//JF1bWxR+ 7Ewu3ZSXEaqo9StZHdiwx76xJTZi1buI2aO2vW0vddaeqPorPtHNePDU0QrJ4RGWHrn+gHOx mhIS9Fpv0izo/wDhg+MKBgMAAA== X-CMS-MailID: 20200706202722eucas1p1a631c58e9805c00286a2a4b469aeb124 X-Msg-Generator: CA X-RootMTR: 20200706202722eucas1p1a631c58e9805c00286a2a4b469aeb124 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202722eucas1p1a631c58e9805c00286a2a4b469aeb124 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 16/25] examples/l2fwd-event: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-event/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 4fe500333..3e6d1c311 100644 --- a/examples/l2fwd-event/main.c +++ b/examples/l2fwd-event/main.c @@ -366,6 +366,7 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status..."); fflush(stdout); @@ -389,14 +390,9 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - port_id, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", port_id); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", port_id, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:26:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73304 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 644B9A00C5; Mon, 6 Jul 2020 22:29:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6788D1DC41; Mon, 6 Jul 2020 22:27:29 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 879271DD10 for ; Mon, 6 Jul 2020 22:27:27 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202727euoutp01756545be9af6418e7459e4517369d4a7~fQ7c33lq52799827998euoutp01D; Mon, 6 Jul 2020 20:27:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202727euoutp01756545be9af6418e7459e4517369d4a7~fQ7c33lq52799827998euoutp01D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067247; bh=mj3hE/gu7NzVbUKqiHTNl/YjUhTA6ayvrigfQL+Dyrc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=r/5uobxKBb6dkF4kFhc0fPmaRcsXuaPDevnrRVKqh6A+G43cjS8cPH6iQUTk5xejP BPXcD23E14QCiRBykZ8x0wcz7oT+kqcA+FVxB/TmQwNGJe7ySXjgZpmpaTEfENzsVW HSxViCyDXI4ll9DfjoJ9QE8v/IsV0IYEHWAP3zDg= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202726eucas1p1bf5a7dc2e3042ced44a70fbea2240134~fQ7b2ao6F1288412884eucas1p1n; Mon, 6 Jul 2020 20:27:26 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 7C.96.06318.E29830F5; Mon, 6 Jul 2020 21:27:26 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202724eucas1p196ad6a9590f4b488e13b265fee3b854a~fQ7arm0IQ0814308143eucas1p1q; Mon, 6 Jul 2020 20:27:24 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200706202724eusmtrp1d0fcf8b756c5318e6025e4657532fb12~fQ7aqlTyu2178321783eusmtrp1t; Mon, 6 Jul 2020 20:27:24 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-3b-5f03892ee903 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 9F.AF.06314.C29830F5; Mon, 6 Jul 2020 21:27:24 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202723eusmtip1b7201daf8b1b2df60f8c593be1f74a48~fQ7Y7OroN1560515605eusmtip1a; Mon, 6 Jul 2020 20:27:23 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:07 +0300 Message-Id: <20200706202626.28628-18-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0wTWRTHPTPTmaFrzThgvIsGYhPjIy4qYnJiNj6Ij/lgjH7wERWwyqQa yyOtuD6yEc1KsLAFq9H4CNYBRVBTHsVWFAK4oWJRFINFRa3oyuqygiCKCrtSp2a//c/v/7/n nHtzeVq0s5H8ttQdsjnVYNKzWuZK46c7P8UcopNmHcrXorO5ALDzaSGNgaNPWMzp/Y3C9tIF eN19WoP2Z5kU2uzvKHRfsLLYHTjA4Ns+N4UdNT4OT7Ye4LCvoYvD31tOAXYNvaHxhKMfsKWg SoOf6qtZ7BlSGLR9bgPMc90E9Oa+Y/DoVQ9gllXA3pJiDgs7orAvcJNB38NKDi8N3KOxqnkY 8LDXCXg76z/NwknSZ8c5jVR4/TUlHTl7j5YaHx7jpNymAkoqf+uhpJ7aNlayuUpButWZQ0sX Xw6yK7XrtT8ny6ZtO2XzzPmbtFvvv3Cx6a/CdhU7/UwmPOasEMYTIY647TfAClpeFC4A+dNb RKvFeyDtgRIIpkShH4jSlvj9RJ2tRqOGioE4Oh+FigEgdQcrqGCKFaYSX3YBFTQihHKWuIf8 34xwYSnpqvrABDUjTCY3bE3fFtEJ80jll1uMOiKaXCyro4M6bIT/0VPJqmtEEf+Z95SaucuT vxxoBX5ELyYPepepOJy88bpCd5tIfEdyQy33ko8Vfi64DxGygTxVDoZCC4jr7ztcsA8tTCPO 6pkqXkQUfy6rth9D2v8ZG8T0iLRfOU6rWEeys0Q1rSd1Ta0hTMjwl9Eqlkjt+TOh16kBMvj4 PJsP0Sf/n+UAKIXxcoYlxShb5qTKv8RYDCmWjFRjzJa0lAoY+am+f70DHqgd2twAAg/60boA TyeJGsNOy+6UBiA8rY/Qxd/2JYq6ZMPuPbI5LcmcYZItDTCBZ/TjdXOU1wmiYDTskLfLcrps /u5SfFhkJqyJa9SOSSij6jO782bEr9s+e/XlaMPHvUuUl6P6ij540n3XVhTOXV8+qNQ/j5he zt399cFz57wpzZElNtOT6ijfLlHJC483rdoX170osWbxj21J4g+PkjdkedYYhegObWz38rQc Y2R/Qkv+3GFl7YtY/eqNrfuX+1eeKBoXu89ZFleiZyxbDbOn02aL4Svg4TA9pQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917dzel1WVa/TJ6raSImt7p9Bj2MCjuH0JB0B+VrWXXRzlX u5tkRanUsmUzHxSVrxxiucBqmhoqauFriqhZWlnLIs1MS9PK7DGV/vtyPt/zPQfOkZCyCcpL Eh1r4PWxmhg57U45/jT0blh/kVT7NpkCoLglB0HfaysJzsxeGi59OUdAd9EWqCzLEkH6mwQC LOlfCSi7baZhyJlEwfBoGQGvqhxiuNGRJIbRun4xXG67iaB/apCE63ljCNpySkXws/YRDSNT +RRYJrsQpJY0ImhI+UpBZkU5ApOZgS93CsVgfbUMRp2NFDh67GK4O95OQmnLbwRpDcUIWk1/ RVtXcpN5BSLOWvmR4DJutZNcfc9VMZfSlENw94fLCW6kuovmLCVFiGvuu0Rytvc/6F3uexXB ep3RwK+I0gmGTfJ9LCgVbBAolP5BCtYvMGyjUiX32Rx8mI+JjuP1PpsPKqI635XQxz64nSgs fk4loJdiM3KTYMYf11iqRGbkLpExBQj/yu0gzEjiAhh/ek/Oejzw1DMzPesZQ7jCNjkDaGYt diTnENPAk3lJ484LidQ08GB24P7SiRlNMd74saVpZpqU2Yjtv5qp2dTl2HavZibIzVV/MmKn p7WMica9D61oVi/Dz3O/EVfQvDw0pwh58kZBG6kVWIWg0QrG2EhFuE77ALlu/rD+p70cddzf XYcYCZLPlSbTpFom0sQJ8do6hCWk3FO6rdVxQCY9rIk/yet1ar0xhhfqkMq1YBrptSBc5/qg WIOaVbGBEMQG+gX6BYB8kTSZqd0vYyI1Bv4ozx/j9f/7CImbVwJaw4d+rkittZZEhAjdeaeb 2kxJIaZ85cChDzvw6t0kxqEe9tfGs0SrqCHGP6Nn8YvavRE7+xqdvku2p3c716waTM9QHa/O mhor+75r6fx7A1uDDh05P6f93ZlgsffC/PVDb5fLwrKfsspTidl7PMbvDIfmuj+4ZlNX26iI lCpyXCWnhCgNu47UC5p/QExviQkDAAA= X-CMS-MailID: 20200706202724eucas1p196ad6a9590f4b488e13b265fee3b854a X-Msg-Generator: CA X-RootMTR: 20200706202724eucas1p196ad6a9590f4b488e13b265fee3b854a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202724eucas1p196ad6a9590f4b488e13b265fee3b854a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 17/25] examples/l2fwd: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index e04c601b5..9d5f7307e 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -571,6 +571,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -594,14 +595,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:26:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73305 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C06BAA00C5; Mon, 6 Jul 2020 22:29:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8EF2C1DD15; Mon, 6 Jul 2020 22:27:31 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 19D8B1DD13 for ; Mon, 6 Jul 2020 22:27:30 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202729euoutp02c5776c98b489ca95361f08defbbdb4fc~fQ7fS3GZ01760117601euoutp023; Mon, 6 Jul 2020 20:27:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202729euoutp02c5776c98b489ca95361f08defbbdb4fc~fQ7fS3GZ01760117601euoutp023 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067249; bh=FZgu+DseHLusxJkCwaRQ1GfffzIWoM6QnM8E1SGa7oc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=vK16U1hbO/sgc3h1qZ/LABzdOHvGRuouI+AwhrGvSq/6t0Zzv/Z1U6sTN03EQZ54H qQ5JwPMFOLkLSDH+aQHPgOvgeVURKk/jD+jhpjUE4Wag/DhuOot9e68YQPJtqWn/lo RXbl6WJEkwONdHyiiQpm7oIb9HC3uhAFO2LjrQas= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202728eucas1p27bad5b671aa96e3508e2fff06a8fd49e~fQ7eRVyaG3131931319eucas1p25; Mon, 6 Jul 2020 20:27:28 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 9E.96.06318.039830F5; Mon, 6 Jul 2020 21:27:28 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202727eucas1p2b575e02cd42371084aaf970887fad4da~fQ7dFfUee0116301163eucas1p2r; Mon, 6 Jul 2020 20:27:27 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202727eusmtrp2e17ac4291a46978c0d2ade2eb1e88706~fQ7dEu_Bq3205132051eusmtrp2z; Mon, 6 Jul 2020 20:27:27 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-3f-5f0389304843 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 6E.4E.06017.F29830F5; Mon, 6 Jul 2020 21:27:27 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202725eusmtip155eb32bd544424679d71ddead1f9db76~fQ7bS5rvY1791017910eusmtip1D; Mon, 6 Jul 2020 20:27:25 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:08 +0300 Message-Id: <20200706202626.28628-19-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0wTWRTGvTPT6dBQMlRZz6oBbWKyvngEoicbFZ9xYtQYE82GRLHqBIyA 2gqKrxRRtiKiFpTobgqWGBGNgDxaSTFYDQWqsjTKw0UWia7IKihKFtlil3FK/O87v++79zu5 uRytMbPTuN0pB0R9ii5Jy6qYmoYvLQsiT9Pxke2+uVj2yEKwt7uYxp78Fyye+XCSwo7SWHTY fleg+S8jhbnmjxTaSrJZfNdzgsGBIRuFXXVuJV7xnFDikPONEs+2/EbwjbefxstFnwi2WKoV +OV+LYuDXiuDuaPPCJ6raiToyvnIYP5dO8GsbB4/3LiuxOKuUBzqaWTQ3VmpxFvDrTRWPxoj eMFVRvBxlk+xbJYwWnRNIRQ73lJC3tVWWmjovKQUcposlFAxYKeEwXvPWCG3qpQIzb1naOHm qxF2oypOtXiXmLQ7TdRHLN2uSiy4/YLss6oOna65RBlJvzKbBHDAx8DJtjw6m6g4DV9CoNc9 4B8+E+jL97Hy8InAA89rxcQRq6OPlrSGv07gqitRDg0TGDMXspLB8j+B22ShJGMKX8GCzdtO ScZkfh20tnURSTP8bPgjx8NIWs3/DPdHCvxLhcHN8vpvDQHj/OFgJSu3hUJ74WdKzjRycKMl Rtar4HVfs3+7ydDvqvLfMwN8dwv9+SPw7512pbQQ8CYC3dZT/lAsVP3zZFxzHM3PgbLaCBkv h4yuEVbCwAdBx/tgCdPj0lxTQMtYDaYsjZzWQn2Tx48Bxv4LlLEA+c4K/1PVESj6Nfw8Cbvy vaqIkFIyVUw1JCeIhugU8WC4QZdsSE1JCN+5N/kOGf+p7q+uYTu5593hJDxHtIHqHo6O1yh0 aYb0ZCcBjtZOUa947N6mUe/SpR8W9Xvj9alJosFJpnOMdqo62vp2q4ZP0B0Q94jiPlE/4VJc wDQjuZx28OX0mLUb87Z4HX8vPGzxqra3HfVZn2ZcDA7eYt72fvWKJSEhFSELTF832zI7fMXH 1hi7N83LW7W/duWTBx0RkWGhnQ0mnw1GfyzfER27KKMuJu1WYVTchtI/N8c5MuvX/fJDdbWx PDCz/vnM9LWBJZV2+3p+oX5l+POg+eJxz6QoLWNI1EXNpfUG3f8Ur7HupQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0hTcRjtd+/d3Z00uU2rXwusBkZEbs1HfoZWKMSNoqL+K2sNd5umc7K7 RQ8KtTKdZlnRU5YpZWmZ5WOrzNqIrKaYmj1IS5b0MNHSijRtbVr/Hc45H+fA+RhS9oOSMynp Zt6Urk1T0AGU+09Td5gqj9QsrqqSw41mGwLP2zISek5205D/9SABryqWQ4O9WATH32USUHj8 GwH2K1Ya+nuyKRgYshPQdc8thnPt2WIYcn0Uw5HW8wg+jvWRcLZkGEGrrU4EI847NAyOlVJQ ONqJ4GjtYwRNBd8oOHnbgSDHysLXq+ViKOsKgaGexxS4X9eI4dqPNhLqmscRFDXdQNCS4xWt mMeNllwScWUNnwnuxMU2knv0+pSYK3hiI7ibAw6CG2zspLnC2grEPfXkk1xl7y96fcAmZazJ aDHzc5ONgjlOsVkN4Up1DCjDI2OU6ojoLUvDoxSqZbE6Pi1lJ29SLdumTD5d1Y0ySgN25dWf IjJRn9iKJAxmI3FpwyfSj2XsJYSLvDOsiPHxGH/pJSctQXjshZW2ogCfZRjhA6X3Cb9Aswuw O9dG+IVg9g2NOw5nUX4hiF2D2150IT+m2FD8rKB9gpeyS7Hz1+l/wXNwZfWDiQSJj384WENP lkjB3fVlaBKH4JcXvhPHUGAJmlKBgnmLYNAbhHCloDUIlnS9MslouIV8k9c/Gql1IOvARhdi GaSYKs2lSY1MpN0p7Da4EGZIRbA0vsW9VSbVaXfv4U1GjcmSxgsuFOUrWETKpycZfQ+Ubtao o9TREKOOjoiOWAKKmdJc1pkoY/VaM5/K8xm86f8dwUjkmYjJ6JNHSGYxhvjylav2ac90rUuV zLSb+ss9xc4450bcsmNtf058gkpPjW8bPORwqVTDfBu1J9R73mPpfX6lXjc/L+5uS2uHLCEV Dux/H9a5ve+9/v6hfYHFc0saZy9WV0/zjHR6Pzg0l6U/q387EhftRVneDaO67/GryetZyjwF JSRr1QtJk6D9C1j+yyEIAwAA X-CMS-MailID: 20200706202727eucas1p2b575e02cd42371084aaf970887fad4da X-Msg-Generator: CA X-RootMTR: 20200706202727eucas1p2b575e02cd42371084aaf970887fad4da X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202727eucas1p2b575e02cd42371084aaf970887fad4da References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 18/25] examples/l3fwd-graph: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-graph/main.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index c70270c4d..cd8e3aad1 100644 --- a/examples/l3fwd-graph/main.c +++ b/examples/l3fwd-graph/main.c @@ -599,6 +599,7 @@ check_all_ports_link_status(uint32_t port_mask) struct rte_eth_link link; uint16_t portid; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -623,16 +624,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* Print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port%d Link Up. Speed %u Mbps " - "-%s\n", - portid, link.link_speed, - (link.link_duplex == - ETH_LINK_FULL_DUPLEX) - ? ("full-duplex") - : ("half-duplex\n")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* Clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:26:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73306 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AD54A00C5; Mon, 6 Jul 2020 22:29:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A94F51DD29; Mon, 6 Jul 2020 22:27:33 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 858231DCD0 for ; Mon, 6 Jul 2020 22:27:31 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202731euoutp01281b328b8ae5956f4a8768a669faf844~fQ7gnmrIK2593425934euoutp01i; Mon, 6 Jul 2020 20:27:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202731euoutp01281b328b8ae5956f4a8768a669faf844~fQ7gnmrIK2593425934euoutp01i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067251; bh=O8BZcOjmjjfyos4EN+drgkw7ydPT/VazCurM2vsSk0g=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=k9NcxmsJzy/HwjhUpSJwavP0x+JklGxdqrdqQ2vvPdcLaoTwY40f32W36XYTgTfEU 8bfk9D2har68qhLQWzbsL9ZqglQwp9zuoFA1vAyuO1o7svmh26HTN8w9wuvGsWErnl bNv/Ik8ylHZdjmTsdL+ECHs6OhssX4dpnlN9hXAk= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202730eucas1p18b6ca3b076c7bebbaf64c55e375fbd1b~fQ7gBpneS0787207872eucas1p1a; Mon, 6 Jul 2020 20:27:30 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 4A.99.05997.239830F5; Mon, 6 Jul 2020 21:27:30 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202730eucas1p1112175f892b58de011b4002fd66b0d36~fQ7fpygnU0478404784eucas1p15; Mon, 6 Jul 2020 20:27:30 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202730eusmtrp2d73e885c9e40013e337ca0596c3b3491~fQ7fowoJY3205132051eusmtrp20; Mon, 6 Jul 2020 20:27:30 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-c6-5f03893244e4 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B1.BF.06314.239830F5; Mon, 6 Jul 2020 21:27:30 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202728eusmtip17a7245de4ff52ca9275e1bd8b7049f93~fQ7duxfGT1560515605eusmtip1b; Mon, 6 Jul 2020 20:27:28 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:09 +0300 Message-Id: <20200706202626.28628-20-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTGPffe3ntpKHlXP3jDUGN1UxcRPzZ3tsz5EZ130z/252JUqHID ClTTChPNTMOUsIKoQDAyg0C3yNCFoUU+Vgw0hBZbQYykoCioMwRUPkuGtY5Rbo3/Pef3POc8 yZtXZLWFfJR40HBUNhr0KTpezd1sfd0es+4XNm6NO+djrPKUAD59bGWxv/ARjzmjpxjsrtyE 9tpLKszvMzOYlz/GYG2FhceX/ZkcDo/XMtjb6Baw+F6mgOOOAQHPdPwKOBAYYvFi6QRgR0mN Cl83N/A4EijnMM/fBXjW5gJ05o5xWFhfB5hlITj6xxUBrb2LcLzfxaG754aA1yY7WazxvAU8 76wCvJM1rdq8RPKX/q6SrPZBRioo62Sl1p4iQcptK2Gk6uE6Rhq51cVLebZKkG4/zWGlq/9M 8d+rd6u/SpBTDqbLxtiv49VJv7mm2CNF6mNlF60qM5wWLRAmUvIp9Xv9nAXUopZUAK0PtIQG H1DbzxZBGSaA5t1uVL1bcXSb2aDWkitAe+7vUkKTQK/d7ZsN8WQFdWeXMEFjHqnmaW3AywSN uWQXPdXVzAU1Rz6ir8qLhaDWkC9p3yW3oDQsplf/apptCJvhLSM3eKVtEfVe9s0epcQjUvtg Da8sbKPPK9pB0XPpkNMWOhRNp+svM4o+Qf+97hWU5Wygj8tPh0KbqO1F+4wWRZaspFUNsQre QjP/HJrFlETQ7lcfBDE7I/NvXmAVrKHZWVolraNNbfdCmNK3b8IVLNECX0foERuBeuodcA4W F7/vKgWohEg5zZSaKJvWGeQfV5v0qaY0Q+LqA4dTr8PMX3X/5/TVQUNgvwOICLpwTTbPxmlV +nRTRqoDqMjq5mm23nHv02oS9BnHZePhOGNaimxywIcip4vUrC8f3KslifqjcrIsH5GN71xG DIsyw/aE6un4xDYykHHoQtGBN0/md8VwOz//YWSjt2dS9wLG6r5o3vlsdFnScCtsjF9+7LMC 1+D2qRUL5uy3L4j9+5sd7udaa7KTnD25t6ns/qMIffoW4v8uYmLDQ9c5s5zcstvje1DaOdU7 nBCZGzUnGlctNcSc3/Pttull0Sd/Whg+bg/TcaYk/dpPWKNJ/z+6j7l5pwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH/d17d+91NLlMy18SVgMjAmfTbMceJv5RN+hh9Ef0tJFXJ7nN dqdY/6RmZSs1zQSXqbmk0kjN13pJrlBrytI0lXwhopWlpUUPLJta/334nu853wPnsKT8K+XD xupNglGviVPQUsrxp7nfP/ACGbl25qoUKloLEQwPWEkYyu2n4eLnNAJ6yrbA4/oCCeQMJhOQ mfOFgPrbZho+DqVSMDFVT0DfEwcDlo5UBqbsYwxkOK8hGJv5QEJ+8TQCZ2GtBH42PqRhcqaE gsxfXQiyaloQNF/6QkHuAxuCc2YOPt+5xYC1zxemhloocPRWM3D3WzsJta2/EWQ3VyBoOzcr CVvJ/youlfDWx+8J/sqNdpJv6s1j+EsvCgm+asJG8JMNXTSfWVOG+JfDF0m+fOQHHSE9oNxk NCSYhBVag2jarDiogkClKgSUgetClKog9eENgcGKgNBNUUJcbKJgDAg9qtTebPlBxudJk27k WyXJ6CxrRu4s5tZhe08yOcdyrhThztRTZsS6dIzHR8gFiyeeeWOmFyzTCGd1Js0xza3GjvRC woykrBf3lsavz6dQcwVPbgdO62qcZ4rzw59KLMwcy7gNeLDAwSwMXY7LK5/OB7i79OeT1f8C YnF/nRUtsC/uLvpKXEYexcitDHkJCaIuRieqlKJGJyboY5THDLr7yHXxuqaf1TbUUbXXjjgW KRbJ0mkyUi7RJIondXaEWVLhJQtvcxyRy6I0J08JRkOkMSFOEO0o2LVgNumz+JjB9T96U6Qq WKWGEJU6SB20HhTesnSu8ZCci9GYhOOCEC8Y//cRrLtPMsrtrFw82rF/oibXcjniuzl8qdfW E7cblox324oOmqa5BymO2Tg/39nlq4ht+rDy0QynRZ23zE4Tu6Snw0tszoGslOjija1u7/Zo d+7JePZNfT0kTTm4T948EH9v/NFup9oRrcUvvdua2PdDWQWW/ZaUru3+r9RM/5noKI+GxtBK BSVqNao1pFHU/AWVd/nHBwMAAA== X-CMS-MailID: 20200706202730eucas1p1112175f892b58de011b4002fd66b0d36 X-Msg-Generator: CA X-RootMTR: 20200706202730eucas1p1112175f892b58de011b4002fd66b0d36 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202730eucas1p1112175f892b58de011b4002fd66b0d36 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 19/25] examples/l3fwd-power: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-power/main.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9db94ce04..ba6bab4a5 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1945,6 +1945,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -1964,15 +1965,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint8_t)portid, - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:26:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73307 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD2D5A00C5; Mon, 6 Jul 2020 22:29:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E5621DD1F; Mon, 6 Jul 2020 22:27:36 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 857BD1DB88 for ; Mon, 6 Jul 2020 22:27:34 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202734euoutp026cdf55b4438a7afa5b4ed45111f083d6~fQ7jbw5tG2313123131euoutp02K; Mon, 6 Jul 2020 20:27:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202734euoutp026cdf55b4438a7afa5b4ed45111f083d6~fQ7jbw5tG2313123131euoutp02K DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067254; bh=xMUQMNB8i6t8ay1gcbcdZCHyGWgNvOkvIPzWBMqAo/g=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=iPz5wn+A1GPIjANCf9EMF5vnPucW4UJRnpIynHBPyx1V60M+dHFJMSIES7DF9yx7D RU6kc5bGFv1QOaFOZSVNrp8/JzI2nPUFmgZ1qCBKkYBIxV1fQX7AvZtBePEpJFRFUg r0qmtrK2gBKwSZj/yDP7m/csP1U04cWea9WYxwHM= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202733eucas1p272490d59328d89c290a9291ecfba0530~fQ7jFK7xv3131931319eucas1p28; Mon, 6 Jul 2020 20:27:33 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 6C.99.05997.539830F5; Mon, 6 Jul 2020 21:27:33 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202732eucas1p1f8fd4a2c9fc271e08f8b416dd0af0712~fQ7h7iLpA1288412884eucas1p1p; Mon, 6 Jul 2020 20:27:32 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202732eusmtrp2342ac012bd6242c3e22e3ab1e534894b~fQ7h6u_I03205132051eusmtrp23; Mon, 6 Jul 2020 20:27:32 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-cb-5f0389354241 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D0.5E.06017.439830F5; Mon, 6 Jul 2020 21:27:32 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202730eusmtip1305a6c3b75b2ca7e6661f7c2d6b5e489~fQ7gHiGJu1791017910eusmtip1E; Mon, 6 Jul 2020 20:27:30 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:10 +0300 Message-Id: <20200706202626.28628-21-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSe0xTZxTfuff23ktDzbWinKHTrHGZuviamp24KWwxy83iH9OZLc4oq3qD OoqmV5hKtlUiDa+hAttCVawQAxYSBCuPxgc2CtXyGCYEnYqEMRxulLdMAZFyMf73e53zO/ny iawxi48Q98YdVKxx5lgTr+cqap83Ll2TykavuOD6iErr84A62gpYas95xFN63zGG7rki6Url aR1lPbYxlJnVz1BlURpP/7UncRQYqGTo4VW/QI67SQINeJ8I9EvTKaAnY09ZynUOAjXlXdbR 8xsennrH8jnKfNECdNztA6rL6Ocop7oKyJ4mUd+FQoEKHs6ngXYfR/77lwQqGW5m6XL9ONDJ ulKgBvuELupd+YXzvE4uuNLNyNnnmlm59v5vgpxxO4+RywJVjNx7rYWXM90ukO90pLNycef/ /Jf6b/Wf7FZi9yYo1uXrv9Pvaet0cgeaZh9yOnxgg+KZaRAiorQaW/7u4NJALxqlIsCqGi+r kSHAiS43aGQQsCz1BP965FZjvRDERqkQMOm0RQsNA9r/aNAFDV5ahP6UPCZohEllPFaOtU4S UZwlbUSvLSyY4aT3MPWfo1NLDdJazPjLB1rBAiy+WMMGccikfrP3Eq+VzcfWs0NTO1HyiVjd VTo9sAE9/T3TeBY+rXMLGp6HE9VnGQ0n4kh5q6ANpwC25SdPhyLR/W+jEDyOlRZjqWe5Jn+K Pb928kEZpRl4r2fqvdhJmFXxO6vJBkyxG7W0CWtu352WEcdHQzVZxlzPn5x2/VXAzIy1J2CB 402VE8AF4Uq8aolR1A/jlB+WqWaLGh8Xs2zXfks5TP5U/8u6oSrwjO30giSCKdSQwrPRRp05 QT1s8QKKrCnM8FmDf4fRsNt8+Ihi3R9tjY9VVC/MFTlTuGFVfvd2oxRjPqh8rygHFOtrlxFD ImyQW4jZJd+o9vR5d85fcw5u3JocNbyyJFncdnLdT5ERpyAh/FnSqG5h0ejIppzjKwaLPy7r ax3pD01831DxeXbXwi2unNrmr95O3Lc4YOy1CUOHHNcvhncHzvy8qXpOYHzuElnGiq/b12ym hqjZfPMXXW/1PHMkP36w5Uj5vqMfwNYf3zFx6h7zyiWsVTW/AhJfoQSlAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSa0hTYRjuO+fsbFqL49L6MtIahGE1m5f2KqbRrwMVJAWBXXTYwUvOjZ3N sj+tEC/TvCVCtzlb4hXUNDXT0llqTRMrU/GS2MAymaUFJeuyJf17eC7v+8D7ikjJN8pXlJym 47RpylQp7UnZfvdP7wvNJeP29+YFQMOgCcHcjIWE2dJpGvK+ZBIwXhsNnW13BFDy3kBAQclX AtqqjTQszl6jwLHcRsBUl00It15fE8KydV4I14dvI5h3LpBw07yCYNj0UAA/ezpoWHLeo6Bg dRRBYcsAgv78rxSUPmpHkGVk4EtNlRAsU36wPDtAgW2iWQj130dIeDj4C0FxfwOCoaw/gkM7 2VVzpYC1dH4i2BsVIyTbN1EmZPNfmAi2ydFOsEtPRmm2oKUWsS/n8ki2zv6DPu4ZK4vUqvU6 bkeSmtcdlJ6WQ7BMHg6y4NBwmTxEcTYiOEwaFBV5nktNTue0QVHxsqQZu5nSDPtcMt8aQAZU 52VEHiLMhOLnrwaFbixhKhG2NvkakcjFY/zZTq5ZNmHnOyNtRJ4uywrCFYtzArdAM7uxLcdE uAVvZpLGb7KvUu7wJuYothq83R6K2YVzP16l3VjMROD8DwNobag/rmvs/rfAw8U/W2qm1zok 4+lWC1rDfnis/BtRhDaa0bpa5M3peVWiig+W8UoVr09LlCWoVQ+Q6+KtfT9b2pHRccKKGBGS bhDn0GScRKBM5zNUVoRFpNRbfHjIdk4iPq/MuMxp1XFafSrHW1GYq2Ax6euToHb9T5ouTh4m V0C4XBGiCDkA0i3iHKbnjIRJVOq4Cxyn4bT/c4TIw9eANn73MOk1y6UOm6Yqt9Vpj1V0CbPG ou0rp+4W1Ttk2xaoM1dUk4Er5bbHUdba4fCOlD2jikLLW58j1ouhjSF0m248eWtlSuZt/+kY UbfO0Du5OcPrGASU742JnjzLyO9Lcv0dNYM1zt6g8TvM6ZOF26Wa7HhzdWBZAg7IerpeSvFJ SnkgqeWVfwGWWGUQBwMAAA== X-CMS-MailID: 20200706202732eucas1p1f8fd4a2c9fc271e08f8b416dd0af0712 X-Msg-Generator: CA X-RootMTR: 20200706202732eucas1p1f8fd4a2c9fc271e08f8b416dd0af0712 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202732eucas1p1f8fd4a2c9fc271e08f8b416dd0af0712 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 20/25] examples/multi_proc*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 14 +++++--------- examples/multi_process/symmetric_mp/main.c | 12 ++++-------- 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c index c2ec07ac6..3ca9bcae3 100644 --- a/examples/multi_process/client_server_mp/mp_server/init.c +++ b/examples/multi_process/client_server_mp/mp_server/init.c @@ -185,6 +185,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -204,15 +205,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", ports->id[portid], - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)ports->id[portid]); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", (uint8_t)ports->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index 9a16e198c..0480874f8 100644 --- a/examples/multi_process/symmetric_mp/main.c +++ b/examples/multi_process/symmetric_mp/main.c @@ -365,6 +365,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -384,14 +385,9 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:26:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73308 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7AE4A00C5; Mon, 6 Jul 2020 22:30:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52A911DD42; Mon, 6 Jul 2020 22:27:39 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 124711DD31 for ; Mon, 6 Jul 2020 22:27:37 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202736euoutp0102f8f77461ad00381795ce28fc73bee6~fQ7lyhMyz3113131131euoutp01v; Mon, 6 Jul 2020 20:27:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202736euoutp0102f8f77461ad00381795ce28fc73bee6~fQ7lyhMyz3113131131euoutp01v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067256; bh=SjcxeTJpiGhJMyyglT2md+9M7XhR8AM1X0pflSOG9+o=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=tqI8nvknbfKxp/0YL43QHpozjBf2a2PS0gv3DiP1STglfHkFj5eqLDqTIafmvtDAD 3zcYF8bGYECJ9Pdo8PUGvrb4JbnihZU3CEITePzSHZ+fF07A5r89AuWx2RsS4vPCE2 iBElivvWDnj3spHU97R7IiKXFMgw3zQs3lqKCIqc= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202736eucas1p20f77ccbd7a30548a3801a5f112958dac~fQ7lIMCAz2938529385eucas1p2G; Mon, 6 Jul 2020 20:27:36 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id B7.B4.06456.839830F5; Mon, 6 Jul 2020 21:27:36 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202735eucas1p29df73c3a0bf8a49a7969e4f18b05348e~fQ7kNsS8S3131531315eucas1p28; Mon, 6 Jul 2020 20:27:35 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202735eusmtrp274b7e62a9bf28db2bb1f0007cfcd9fd9~fQ7kM1ckn3205132051eusmtrp24; Mon, 6 Jul 2020 20:27:35 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-18-5f038938f8a5 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 04.BF.06314.739830F5; Mon, 6 Jul 2020 21:27:35 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202733eusmtip1b31e2091a451902303ab4f1b8bf090d8~fQ7ieeR8H1560515605eusmtip1c; Mon, 6 Jul 2020 20:27:33 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:11 +0300 Message-Id: <20200706202626.28628-22-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0xTdxjG855zes6hocuxmPjqvMxmM45tOsOWvDFzeMHkRL8s2cVEs7JO T5BYimvBifswgq5BtMAqkSiuIgSFYsaghVYuTtnCxVKI3QyYKCNIMDgFARsBKY56avbt9z7P 817yz19k9Wf4FWK6JUuxWkxmA6/lmjpm+z6gk2zqhwO3NFTX4wIaHqxkaajkPk+nnp5gaMCd TK2+Cxpy/pPLUKFzkiFfdQFPj4fyOBqf8jF0ry0g0PlQnkBT7Q8FcvSVAT2cf8TSufJpoD5X o4ZmbzbzNDFfwVHh3B2gIm8XUOfpSY5KrvmB7AUSPa25IlDlvdU0NdTFUeCuR6Cr4dssNfZE gH7urAMK2l9qtq6V58qrNHJl6xgjn7l0m5U77p4V5NPdLkauH/cz8sT1O7xc6HWDfGv4FCvX jszwn2n3aj85oJjTjyjWjZ9+oz3oab3MHj4nHm3yebhc+JUvgDgRpY/QH5llC0Ar6qVqwCf+ SUEtngEuFHe/SumlacCg8+PXHY78/ljoCmAkWANqEQb0tLRx0RQvrcdAvouJGkuleh598/1M 1EiQUrC26gJEmZPewdH7biHKOmkz/mK/Kqgr1mDtbzfYKMct6n9OeGJnrMb+i89eDUWpR8Si 0bBGbUjBlpliRuUEfNTpjQ1aiS+vXYzpP+DzBvVulPIBByt+ioWS0ftv7yKLIiu9i3XNG1V5 G1Z1jTBRGaU3cODJkqjMLqKzqZRVZR3m2/Vq2oA3ukMxGTHyIl5FGUciierztAFer+lgimHN +f9XlQO4YZmSbctIU2ybLMr3G2ymDFu2JW3D/syMBlj8qoGFzik/hEPftoMkgiFeNySyqXqN 6YgtJ6MdUGQNS3XbgwGjXnfAlHNMsWamWrPNiq0d3hQ5wzJdUsXY13opzZSlHFKUw4r1tcuI cStyIbPNP5ngKutpMXzn9uakGOvtloXjJTk6+1+t8cFmd3rv2M4Gx/J1xy9nBR8YQ39PH91u /t3xnrJq1+bSuLnhyOfGvC2h0veXw8qkQ2/9+MfgksrR4IO3b+52btubPJvk+Co5ZeeJ3h2W erloS3jHntJ902NJRo85/csvyur2j1d7Z54bONtB06ZE1moz/QczJ02XpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0hTcRT2d+/dvXfS5LKsfkhYDoLosZqPduajLCVuBBH1h5KVDruo5Zzd OyODwMTM5iMtCZZmmljpLKv5WGIPrdRaEhpWlqZkD3qQ72hmj03rv++c7/vOd+AcllROUT5s UopJEFP0ySrak3L87hhYrT1Jxq4tbGWh7kkZgrdvKkkYKh6gIXc0i4CXNRugpalUBqcHMwgo OD1GQNMVMw1fhzIp+DbeRED/bQcD53oyGRhv+8hA/tMSBB9nPpNgKZ9A8LSsQQbO1mYaRmYu UlAw3YvgVH0ngo68MQqKb9kRZJs5GK2+zEBlvy+MD3VS4OizMVA71U1Cw5NfCIo66hB0Zf+R hfvx0+VVMr6y5RPBn6noJvn2vrMMn/eojOBvfLMT/MidXpovqK9B/OO3uSRvffeD3u65Sx0q GtNMwtJEo2QKU8VowF+t0YHaP1Cn1gRo9wT7B6nWrA/dJyQnHRLENevj1Im2lktkqoU93Nhk ozLQNdqM5CzmAnF+zgvGjDxZJVeFsOXhqKtgXQTGX96Rc5r5eOa5eVav5CYQHu6Pc2OaW44d OWWE2+vNvabxsxPHKDcxn4vE1qpS5MYUtwx/GKhh3FjBBePz2bXM3NAl2Hr93myA3NV/MGL7 F5CEBxor0Rz2xS8uTBKFyKscedQgbyFNMiQYJI1a0huktJQEdbzRcBO5Tt7Y7rTZUc+NnW2I Y5FqniKHJmOVMv0hKd3QhjBLqrwVm7oce5WKffr0I4JojBXTkgWpDQW5FiwifRbEG10PlGKK 1QRptKDTaAO0AetAtUiRw7XuVnIJepNwQBBSBfG/j2DlPhko2u/cFh1WOiMXO5u7M+6HhH0Z /+6TGhUhL0a6kM3htSuje+udosVryrT77srARX9K6h33Q68e9SqPED5Vi5GFe+QFx+3dB623 onsm7JNx23Bn63TFYPWqzP4o+6v9+xtOWKLaL3eprcNrF/oWZoV1Je/4qSQ9lmwd2hjjMfy+ 47CKkhL1mhWkKOn/Ag7GfmQIAwAA X-CMS-MailID: 20200706202735eucas1p29df73c3a0bf8a49a7969e4f18b05348e X-Msg-Generator: CA X-RootMTR: 20200706202735eucas1p29df73c3a0bf8a49a7969e4f18b05348e X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202735eucas1p29df73c3a0bf8a49a7969e4f18b05348e References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 21/25] examples/ntb: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ntb/ntb_fwd.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index eba8ebf9f..84fe374c4 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -729,6 +729,7 @@ start_pkt_fwd(void) struct rte_eth_link eth_link; uint32_t lcore_id; int ret, i; + char link_status_text[60]; ret = ntb_fwd_config_setup(); if (ret < 0) { @@ -747,11 +748,10 @@ start_pkt_fwd(void) return; } if (eth_link.link_status) { - printf("Eth%u Link Up. Speed %u Mbps - %s\n", - eth_port_id, eth_link.link_speed, - (eth_link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Eth%u %s", eth_port_id, + link_status_text); break; } } From patchwork Mon Jul 6 20:26:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73309 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69126A00C5; Mon, 6 Jul 2020 22:30:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AE291DD3A; Mon, 6 Jul 2020 22:27:41 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 32F6D1DD3E for ; Mon, 6 Jul 2020 22:27:39 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202738euoutp0274f9db5651b4d035a7ed5466fb86566b~fQ7nqrj-11760817608euoutp025; Mon, 6 Jul 2020 20:27:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202738euoutp0274f9db5651b4d035a7ed5466fb86566b~fQ7nqrj-11760817608euoutp025 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067258; bh=XtbX4XCFxTlmDt9RDrOth1o/sdpob+sTnBAjVCFknHA=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=TCUhi0Yb5me7tKwqhAGsLGJf+Htcgfe2iNHcgh65mX0AB9CLrrPwh3jo5yQc/O20m Fo+5qXPa1jRsV4gWU1dngm1Gjtc1OffsOtRpQ/TYUhMGBYx6dyKd1p2vQcL/0UyEUb biEjmTAo1zHb/NQW3LpzYmUkPRT7txD2syyPOQI8= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200706202738eucas1p2e6ec50bc49bdc489df198ffe7b2c06c8~fQ7nRclLC0115501155eucas1p2s; Mon, 6 Jul 2020 20:27:38 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id D9.B4.06456.A39830F5; Mon, 6 Jul 2020 21:27:38 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200706202737eucas1p1314f8a06a538a2181093471bc09ac79d~fQ7mlfj4H1288012880eucas1p1n; Mon, 6 Jul 2020 20:27:37 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202737eusmtrp2645d14d4115248318b2df35e16ce8a8f~fQ7mks_iX3205132051eusmtrp25; Mon, 6 Jul 2020 20:27:37 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-1b-5f03893a01f7 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F2.5E.06017.939830F5; Mon, 6 Jul 2020 21:27:37 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202735eusmtip1a2e8b1b1d7b67f5d21a4d9543ecf9077~fQ7k1XhZ61791017910eusmtip1F; Mon, 6 Jul 2020 20:27:35 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:12 +0300 Message-Id: <20200706202626.28628-23-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0wTWRTHc+dOZ4bGmtlBww1sJNaYoIlP/HBEI6sxOu7qulG/qFGsOsEH raZD8a0EkdTC1t2KuqIigg/AR620FhGJomnV8lCUoAGxPiIBEaSCuyCoLYPZb//zO///OSc3 l8PCYSaS22hIlowGXZKWUdPXPb21E+IO4oTJL7MiwF6Vi+B1cwEGf/YLBjI/plPwrDgeyt0n VWB7mUqB1dZFgbvQwkC7P42GjoCbgqZbPhZy6tJYCFS2sPBn7QkELf1tGI7nfUJQm+tSQe+d MgY6+/NpsPbVIzjkvI/Am9VFQ/aNUgQZFh4+Fl1goaBpFAT892nwPS9h4VLPYwyuqgEEf3vt CKozvql+GS325Z1TiQXlrZR4+MxjLHqeH2XFrAe5lOjoKKXEzop6RrQ6i5H48HUmFi++/Y/5 Q71CPXO9lLQxRTJOmrVGvcHfZtzart7+JD2dTUWvOAsK4wg/jZRZuigLUnMCX4hIoKRcpRTd iNQ4XUgpPiFyx1pN/Yh8OJJGK40LQZf7KqsUPYg4greHXAwfQ3zm3MHBI3gHQ9z9DYPxcH4h 8T16QYc0zY8lB809wR0cp+HjiOumSdkQTS5evT04JyyI73WWMCEt8KNIw+nuwZmEr+JI4aFT jBKYS1o8FVjR4aTN62QV/TP5duP00Nm7yL/XGlglbEakOf/AkCmeON/XsKEjMD+O2MsmKXg2 aXXY6BAm/HDy7MNPIYyD0nb9GFawhpgzBMWtJbcf1A1hQga+DFOwSLIHOoYe8RYirkYP+gtF 5/y/Kw+hYhQhmWR9oiRPMUjbJso6vWwyJE5ct0V/DQW/qu+rN1CKeurWViKeQ9phGj+HEwSV LkXeoa9EhMPaEZo51b7Vgma9bsdOybglwWhKkuRKFMXR2ghNbH7rKoFP1CVLmyVpq2T80aW4 sMhUFKv2xs5rPmGqHmOOE5aNrLdKd6Mcnj297a6pmsZ701WNn4+qj62UfU9zZtT/k5JZtmj3 u6jlV5YUGfb+Fn+5yZB/fpNVj5P7hNhe/0loN5fUzFyHHGcNr+z4/L45X36P6bZvxm+q9qfO L4zOeLL389is5F/XVjyyLYhcE7N0Mb1pupaWN+imjMdGWfcdgKfZ/aYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3cdLa7T6uIfmYOohLbmI8/CF/7ThQoCCXo6h15U2lzs bqEVZCo2p64sCzLx0ZBSe5lOZ6mk1OaaPUxMrSyzQDLTnFoZlm1K/305n+/5ngPnULhkjgii MjINnD5TrZGSIsL91zmyTVmIq7bf7twKd3srEYy9t+IwWjZCQtH3fAyG6uOgvbVCABc/5GBg uTiDQetNMwmTo7kETHlaMXjX4RZC+atcIXi6x4VQ8uIagvHFCRyuVs8ieFFpE8BC1wMSphev E2D5PYDgfHMPAmfxDAFlbXYEBWYavtfdEIL13QbwjPYQ4B5uEsKt+T4cbL1/EJQ67yJ4VrAk iA9hf1fXClhr+xeMvVTTh7OO4StCtthVibGNU3aMne4cIFlLcz1in44V4WzD51/kPtEhWbRe ZzRwG9N1vCFGelgBYTKFEmRhEUqZIjzq6M6wSKk8NjqV02Sc4PTy2GRZ+uiE/vikKKs/P1+Y gz5SZuRHMXQE8+1yLmFGIkpC1yLGOnYVNyPKCxjm62d8xRPALL42kyueWcQszXxCPkDSWxi3 qRLzgUD6Lcn0nztL+EAAvYdxvxxZ1gS9iSk0zSNfqJjeydgeGldCg5mGe4+WB/h5y4+nm0if ltAZzEiLFa3oDcxg1Rx2Aa2pRqvqUSBn5LVpWj5Mxqu1vDEzTZai095H3ou3OBaa7cg8ldiN aApJV4tNJK6SCNQn+GxtN2IoXBooTnjmTpKIU9XZJzm9TqU3aji+G0V69yvFg9am6Lz/k2lQ KSIVUaBURIVHhe8A6Xqxie46IqHT1AbuGMcd5/T/+zDKLygH5akKrzzGqBi7/LnG9Ms2tHl3 4vOftQ6Xa864MK5MWGrU5OVPZDn65MP7e5MPJu06UFXTVrrOZeFCZywFZ1z+5taYO6V0xyvP YPz506cc5SElfhXsKdE5zae9npfxq5ypmP+U7V7km7zYC22D1Nqeb8ElXXE/GuTlm+ouxURf fiIl+HS1IhTX8+p/R/IE4AcDAAA= X-CMS-MailID: 20200706202737eucas1p1314f8a06a538a2181093471bc09ac79d X-Msg-Generator: CA X-RootMTR: 20200706202737eucas1p1314f8a06a538a2181093471bc09ac79d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202737eucas1p1314f8a06a538a2181093471bc09ac79d References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 22/25] example/performance*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/performance-thread/l3fwd-thread/main.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 84c1d7b3a..bd10014a0 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -3433,6 +3433,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -3452,14 +3453,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:26:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73310 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F46FA00C5; Mon, 6 Jul 2020 22:30:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20E271DD49; Mon, 6 Jul 2020 22:27:45 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 1E9C31DB9D for ; Mon, 6 Jul 2020 22:27:42 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202741euoutp01af9a872b84ad543ad8c99b8885f32cfc~fQ7qcuM1l2799827998euoutp01E; Mon, 6 Jul 2020 20:27:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202741euoutp01af9a872b84ad543ad8c99b8885f32cfc~fQ7qcuM1l2799827998euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067261; bh=M/wyN4nGPfl8N+dBV9oGDaEn0+uBQWGX9DXEsrG01Ys=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=ZPn+8HLe1VhnXFpw61STPvdkTXxkSHZjd0Vc79ZNIyxlxz9uUmgN35BY0FFWxc181 KDO4/0w8Sd+2efrv2exDtOWgXoE6GlnxvlCdUwjm9WSJj0omKZVBHTDfZzRivZagWQ aK4qNd1M/bsiSrArZcaZwguconSQE4VfLELvVz2s= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202741eucas1p19051eb5d2c40625554b3ee8c38503e82~fQ7qRVshl1287412874eucas1p12; Mon, 6 Jul 2020 20:27:41 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 8E.99.05997.D39830F5; Mon, 6 Jul 2020 21:27:41 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202741eucas1p2fef03b23c36afc9c8b67b02cf28692a9~fQ7pzSYs83131531315eucas1p29; Mon, 6 Jul 2020 20:27:41 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202741eusmtrp2a51e64e677226be7c4d79cb846d9a715~fQ7psqO4_3205132051eusmtrp27; Mon, 6 Jul 2020 20:27:41 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-d2-5f03893d7e81 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 46.BF.06314.C39830F5; Mon, 6 Jul 2020 21:27:41 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202739eusmtip14d376d517d0cd52ce59cd298c24ac063~fQ7n9Bvnr1560515605eusmtip1d; Mon, 6 Jul 2020 20:27:39 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:13 +0300 Message-Id: <20200706202626.28628-24-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf0yUdRzH93l+3+2unh7d+ESF65oz3fJHNfeZlqRr61n9kTW3is3oSR6R 4oDuAZRcjRnhdRgFslrYkLhSQ9qJgiACw5seyvFjuOyEPCRjklb8xhBPiOO51n+vz/vzeX8/ P/aVWOWgEC+lZWTrrgwt3SFYudOBu91PPf8Zm7w2UPYE+TorgG4MeFkaLAsLVDRWwNDV6kRq bviWp9Lr+QwVl44z1HDMI9Bfg/s4GploYOhaS1Ck8sv7RJrwD4v0ec8hoOHIbZa+qZwE6qmo 5+nuuSaBRiNVHBXPXgH6ou4iUPuBcY7KzjQCFXpkGvvxqEjeawk0MXiRo2DfKZFqpntZqu+8 D1TS7gPqKpznX3hcna38gVe9zbcY9eB3vawa6PtKVA9cqmDU2pFGRh1tvSKoxXXVoHbcKGLV 40MzwlZrkvW5FD09LVd3rdn0jnVX11y/kHVC3NNX7xXzwSN4wCKh/CyGB4+AB6ySIh8DDLdO x4IpwMpWL2MGk4AX3P2sB6RFy/fD66JuRT4K2DhsMWumAfPrO5loQpCfxKC7YtG8VK4VsCES WkwskV/G7t/9XJQ5eTnerPFClO3yBhyovcObMy3D4yfa2ChbFvTzo6cEs1sChg5PLT6KcqeE vxQcihlexMiRGTB5Cd5urxNNfhTnzxxmTN6L/5wMiabZDThQ9WmsKBHr/uwWo6ux8kr0Na0x 5c0YGOrizY0fwKt/PxSV2QUsPf117BB2dBcqZrUD2y5djsmI9+/ZTFnFO20jsRu2ANb6fuO/ hGXl//eqBKiGOD3HcKbqxtMZ+u7VhuY0cjJSV+/IdJ6Eha8anGufaoSmyLt+kCVw2OxugU1W eC3XyHP6ASXWsdS+pSv4tmJP0fI+1F2Zya6cdN3wwyMS54izP1N1a7sip2rZ+vu6nqW7/ssy kiU+HxJmna+n9IyeD0Q0yEzaTwXNbSs3/Lw9pwQT32B+8nf0z5dYQqGba3M3ffBqxyd5Gz+K a1HmIuGd0tn1Lt+qjvjHhjxp68/++tZu28cPN7+0sXynYuueXNF7b8+Y8xXjzbmerX+sGHow KXuLFt6WZfe8N/7a/s1UNKPYrp9L2cvbq2ocnLFLW7eKdRnav7nzr9GmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSfUgTcRjH+93d7qa0vJbRZaS1CiJweprtUdQiJI4giF7+6HWuPHTk3Npt lVJgYqZLLV97scxcYmmgZr6FVg7TalloWmq5pCzJItemkWbWpvTfh+/3+7zA84hx6QThI1Yn GHh9gipeRnoS1pmOQf+IDFwZaGtGUPW8GMEHmxmHofxBEs7ZUzHoq9gIzQ1XRZD7PhmD7Nwf GDTcMpHwbSiFgO+OBgzetVgpuNKdQoHDMkJB1ssiBCPTozhcLnEieFlcJ4LJ1vskjE2XEpA9 1Yvg/L0nCDoyfxCQ39SIIM1Eg/12OQXmd77gGHpCgLW/loI7E1041D3/gyCnowpBZ9pf0aaV 3FRJmYgzN3/BuLwbXTjX3l9IcZlPizGu5nsjxo096CW57HsViHv24RzOVQ7/Ird77pWH67VG A78iTisYImT7WAiSs6EgD1ofKmeDFQfCgkJkAZHhMXy8+hivD4iMlsd1zgyQumrqRH+dmUpG JtKExGKGXs/cHGFNyFMspcsQUzrwm5rTGebrMG5CHi5cxEy/dsfdGSdi2loLMLdB0msZa3ox 5ja86bck8+rsacJtLKK3Mi8+WmaZoNcwn++YkZsldBhjq/kpmuvqx1RWP5qd4OHS28ZqSTdL aTUzWD+Xl9K+zJvr49gFtKAEzatA3rxR0MRqBFYuqDSCMSFWfliruYtcJ69vn6xtRN01Oy2I FiPZfEk6iSulItUxIVFjQYwYl3lLNndaD0olMarEJF6vVeqN8bxgQSGuBXNwn8WHta4HSjAo 2RBWAaGsIlgRvAFkSyTpdOt+KR2rMvBHeF7H6//XYWIPn2R0pe7zyQWiQ7aWtqU91oW2a7jT pCuilknn2b1Sjdd6/LM/DhQG9rfb1ePjofyqgotNb7yiqjd7bRhXF1w6WDi6PKrw1Mhjr8Sj T2P6FGNntC3l72NSdyGJbre9aPVD7x17/LKmtrRdz0tSVS3t/KTfFi3KCNYpk+462b7TS45H OIZlhBCnYtfhekH1D600KTkIAwAA X-CMS-MailID: 20200706202741eucas1p2fef03b23c36afc9c8b67b02cf28692a9 X-Msg-Generator: CA X-RootMTR: 20200706202741eucas1p2fef03b23c36afc9c8b67b02cf28692a9 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202741eucas1p2fef03b23c36afc9c8b67b02cf28692a9 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 23/25] examples/qos_sched: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/qos_sched/init.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 9626c15b8..4bb975fc9 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -160,14 +160,8 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) "rte_eth_link_get: err=%d, port=%u: %s\n", ret, portid, rte_strerror(-ret)); - if (link.link_status) { - printf(" Link Up - speed %u Mbps - %s\n", - (uint32_t) link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else { - printf(" Link Down\n"); - } + rte_eth_link_printf(NULL, &link); + ret = rte_eth_promiscuous_enable(portid); if (ret != 0) rte_exit(EXIT_FAILURE, From patchwork Mon Jul 6 20:26:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73311 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5BD7A00C5; Mon, 6 Jul 2020 22:30:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B8F61DD4D; Mon, 6 Jul 2020 22:27:47 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 226DE1DD4B for ; Mon, 6 Jul 2020 22:27:46 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202745euoutp0257cef95d96e5173425925b61b65eaa95~fQ7uOXFRL1760117601euoutp024; Mon, 6 Jul 2020 20:27:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200706202745euoutp0257cef95d96e5173425925b61b65eaa95~fQ7uOXFRL1760117601euoutp024 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067265; bh=WQh0/xZ8D/8NSNS0F/gifzw1wCeRoFQ4rQBL4QRJi0A=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=fX0kDCLy6mfUNy5yYyykqOQcgsCr1vFAZ9FhiImstdWYzxlKPvfiBqJSKb846Eeol Ylw2ph1NiQRJlmcFCAd+vid7TyIJ86YhyTSMu+w35TPAUWcqBREo677fIjjteYILlY fRDtfMN4ci44zeuTO7AUjmc07tvGcE4dsRBXdDIw= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202744eucas1p160530aa62f91c757b33d8c360238f4a9~fQ7sxRQmX1288012880eucas1p1o; Mon, 6 Jul 2020 20:27:44 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 1C.B4.06456.049830F5; Mon, 6 Jul 2020 21:27:44 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202743eucas1p2a3fdb7441c2c5fc4cbd7c3275376874c~fQ7sXNKC20115901159eucas1p2i; Mon, 6 Jul 2020 20:27:43 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202743eusmtrp2045e718c6252fee4777ebb03274f0d08~fQ7sWZaoD3205132051eusmtrp29; Mon, 6 Jul 2020 20:27:43 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-23-5f038940b34a Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 35.5E.06017.F39830F5; Mon, 6 Jul 2020 21:27:43 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202742eusmtip13f70703ab0e76239f19ef3b39a3e887c~fQ7qmwE9_1560515605eusmtip1e; Mon, 6 Jul 2020 20:27:42 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:14 +0300 Message-Id: <20200706202626.28628-25-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSb0xTZxTGd+7b3nupdnktZB7ZJq5xyWYiajaTM2PUbSa7yfjgh30yUVbH HYq0mLa4sSVLdUqwMJxoNLqF8kcjK0uqWCkYNEAYRSuiVQNmiI2TEZhIrTCRIoxya/btd57n POecvHllZjoqpsu7bE7VbrPkm0WDrrHzxY2Vmw6x7NUDg5x81yuBHg7UMoocuy9SafSAQH3e jdQS+FVPFQ9cApVXPBUoUOcW6XFkv46exAIC9V8OSXQqvF+iWPuQRD/1/AI0ND3C6GTVM6Ce yot6etF2SaSx6RodlU/dBTrs7wIKlj3V0bHmJqBiN6fob2clqu1fSrFIl45C9y5I9PvELUYX r78EOhL0AXUXz+o3vaNMVZ3RK7Utw4JytPoWUzrvHZeUsquVgnL+SZOgjF25Kyrlfi8o1x6W MqX+0aS4xbDVsD5Hzd+1V7Wv2vClYWdna0y/5+CCb2/OjEkuiMhuSJGRf4iD3X+JbjDIJl4H GHzk0mvFOOCZcBy04hlgtGxWfBVx//ggaZwFfH4/yLRiAvDE8UYh0SXy9zBUUikkjDR+XsTA dO+8kcqz0FsamIvLso6/i3eqeUI28nXYMtUA2oYMrD/XyhKcMqd3jF2Y32ziS7HXMz4/E/lN Gav2xZOBzegL+pjGqTgS9Esav4WzzR5B4+/xeUOvpIVLAAdqDiabNqL/nxtS4iDG30ffpVUJ RP4x/tv2g4avY9/ookQzm8OKxhNMk41YUmzSZpix9Wo4KSO+jC/UZAWLD5QmH/Qy4OSRWvgZ Mk79v6oKwAuL1UKHNVd1rLGp32Q6LFZHoS0386sCawPMfdXQTDDWBBPhHe3AZTAvNEZklm3S W/Y6iqztgDIzpxk/6Q5tNxlzLEXfqfaCbHthvupohzdlnXmx8YOa4W0mnmtxqrtVdY9qf+UK ckq6C/LiEJlc9oVpUagtvu50/rL66OSCc85YHrviGfyz/7VZ52a33+kZbmDhv61fv718yDjS d3p7kXvlR3UFruGZtOqcjq6e6vQ+dSIra7T1ceq2yNrD6/nIZ9QfrbF1bHBHtxyq//yad+2K kHFfZvP4px5XRuDk4Bu39UuWBEZnnHl/mHWOnZY1K5jdYfkPuEniRaYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzVSaUwTYRDl293uLmhxU1G+8MOjicZIrJRDpgSPSGI24g+PP8YLqmwApS12 C4rBAB5YFkVRo1FJQQlRqxHkLAYBiQJSD0AFkSKEmKCi5dIoFcVW4r837715M8kMSyq+UwFs ot4kGPXaJCXtQ9n/tPStWJtDxgRdrgqD0mcWBIPvi0kYuNhHQ+7oCQLeWtdCXU2BDM73ZxKQ d36MgJpbEg1fBo5R4ByvIcDx0M7A1c5jDIw3DTFw5uU1BENTn0m4UjSB4KWlSgaTjx7QMDJ1 g4I81xsEZytbEbScHqPgYq0NQbbEwejtmwwUOxbA+EArBfaeCgbufu8goerZbwT5LaUInmdP y9Yt5l1FJTK+uO4TwV+43kHyzT2XGP70UwvB33faCH6k/g3N51VaEd82mEvydz78pDf77FBF Gg0pJmFRgkE0rVbuVEOwSq0BVXCoRqUOCd8dERymXLkmMk5ISkwVjCvXxKoSmhvHZcknZx1u /zPCZKIBVkLeLOZCsXS8H0nIh1VwJQgXOd+5C9YtYDz8gZzxzMVTXRI945lAuLythPEINLcM 280WwiP4cb00fnUqi/IIc7lN2Jpb8y+I4pbg19c5Dy3nInCdqxzNhC7Ed8oa/w3wdvOPRypo D1ZwibivuhjN4AW4u/AbcQ75FiEvK/ITUkRdvE4MVolanZiij1ftM+jKkfvk1c2TlTYkObc1 IY5FytlyM03GKGTaVDFN14QwSyr95Ouf2/co5HHatCOC0RBjTEkSxCYU5t4vnwyYt8/gfiC9 KUYdpg4HjTo8JDxkFSj95Wbu0S4FF681CQcEIVkw/u8jWO+ATFSmqnXETofgowWuWWmpcyIa zFG9fb+WWhyD1pwNcc1l/ss6veq37L8Z3X/wtvQjO9BiG24LOFX69Xd0YWNUUKAmS7/Qt97s uvcjeu/G/q70se7Yduvs2uFzua0H6RcZwKevO5ShmR+xIf9KQqD00WHrZLZvbXgCXPdTJ1de 1+qlpMQErXo5aRS1fwFK19hlCAMAAA== X-CMS-MailID: 20200706202743eucas1p2a3fdb7441c2c5fc4cbd7c3275376874c X-Msg-Generator: CA X-RootMTR: 20200706202743eucas1p2a3fdb7441c2c5fc4cbd7c3275376874c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202743eucas1p2a3fdb7441c2c5fc4cbd7c3275376874c References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 24/25] examples/server_nod*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/server_node_efd/server/init.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/init.c index 378a74fa5..00224850e 100644 --- a/examples/server_node_efd/server/init.c +++ b/examples/server_node_efd/server/init.c @@ -247,6 +247,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -266,16 +267,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - info->id[portid], - link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - info->id[portid]); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", info->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Mon Jul 6 20:26:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 73312 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 714B0A00C5; Mon, 6 Jul 2020 22:30:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 09FC61DD59; Mon, 6 Jul 2020 22:27:50 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 359BF1DD50 for ; Mon, 6 Jul 2020 22:27:48 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200706202748euoutp017dffc0a2cd141bd984368e05bccff19e~fQ7wJSsWD2593425934euoutp01j; Mon, 6 Jul 2020 20:27:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200706202748euoutp017dffc0a2cd141bd984368e05bccff19e~fQ7wJSsWD2593425934euoutp01j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594067268; bh=U2zVf/WfC+GxbbAndLEN5cAyOf8BWxrHjaueCQ0L+Sc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=oaGwpIw66kdMbranPp3eHEsXCGCl0vpX/e7iUQtKFlS4ns5+YUpr3d+gZaK8R3HwQ T8kNybv52gqhTAZpW0x7LzhNPBuI1WtJb3KAGXsbtAtxBLAlmoefpJEhGOVGEB/JQL vavje2j2uARplBVOnienB8aGPhzTjvXJEzX+3h8c= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200706202747eucas1p12893b783051496fca3597be88cbfc2fd~fQ7v391HO0894308943eucas1p1j; Mon, 6 Jul 2020 20:27:47 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 01.A6.06318.349830F5; Mon, 6 Jul 2020 21:27:47 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200706202747eucas1p241ac7df0719d3c05dbc5ba55450a1a7b~fQ7vcAnbV2938529385eucas1p2I; Mon, 6 Jul 2020 20:27:47 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200706202747eusmtrp20ba4712b2ddeff253321cc2b9bf51ca1~fQ7vbNw3_3205132051eusmtrp2_; Mon, 6 Jul 2020 20:27:47 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-54-5f03894374a4 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 57.5E.06017.349830F5; Mon, 6 Jul 2020 21:27:47 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200706202745eusmtip10eb0f2201873e5e5b9f9f0a78a6469be~fQ7trbRF31791017910eusmtip1G; Mon, 6 Jul 2020 20:27:45 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Mon, 6 Jul 2020 23:26:15 +0300 Message-Id: <20200706202626.28628-26-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706202626.28628-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHc+69vffSUL2rGJ/5TqPLNBGd+OHMGPEteqNflmwxUdnYndxU MqikBTfUD0Ck1qqAFDVqBwhxIJJRECg6IKwQAWtlJSFo5E22SCoCWiAKFpFyMX77n9//f85z TvLwtNbGLuXjDEmy0SDF61g1U/Ng8vGG3efomE1tFWuw/FEe4EBvEY39uT0snn99hsInpVFY 57SrMKcvlcLMnDcUOkusLL7qT2dwxO+ksLvezeH1jnQO/a5BDi+23wAcDLyk8VrBGGB7XrUK J/+5z+JooJDBzKlOwKyqVsCWC28YzL1XC2i2Cvj6djGHRd0r0d/fyqD76V0Oyya8NFY/mga8 1FIO6DHPqHaEi1MFt1RiUZ2PEm03vbT44OkVTrzQlkeJFSO1lDja0MmKmVWlID4cOE+Ld/5/ x36nPqzeFivHx52QjRu3/6w+5nDaIHFI/btvZpJOBRdvhRCeCFtIRo+XsYKa1wolQPpSHaAU 40Da/3o+74wBMXc2q6zAz7V4z4YrvBhI9W0HpRQTQN4XD0NwLit8TdyWvDkjTKhgiTPQRQWN RcIBMn7RwwY1I6wlHX0jqqDWCFtJky9NpSy1itxxNNJBHTLLm0fvzuW1wkrSlT8+N5QIrTyp rEtnlYY9xFn+Yl4vIi9bqjhFLycz9/IpRZ8ibyu7OKXZAqS3MGM+FEWqhh5zwdtoYR0pv79R wTvJlZliTjl5AXky/EUQ07Myp+YqrWANsZi1SlpHGts65jEh0+9DFSySsTQnKNvXA2nzrMiG Vdc/P1UAUApL5GRTgl42RRrk3yJMUoIp2aCPOHo8oRJmv6r7Q8tELTQEfnGBwIMuVNPP0zFa lXTClJLgAsLTujDNLo/7J60mVko5KRuPxxiT42WTC5bxjG6JJrLQ96NW0EtJ8q+ynCgbP7kU H7I0FfaV6NccqF84EJu+a+23z+I2n+yxn0rpHNkr+SOSCvMHFoe/M+ij6+PVUYlhfumP2qyD TV99OHTonLi+Zuf+NOr7jIgzN7NzfxieepG1NTvL3vTf6bNfenxDUYuHp5ts2UVHcgSHK+na JnOgTO2VL6+z2zItlrF//274sze6YfVD2V6gY0zHpG/W00aT9BGpGZ3XpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdnYcTk5L6Y8fzBZB1+W8tFfNivrQQfsgCH7oZkNPKrkt d2ZkRGiFl1WaF7IyljnsoiPNvBV2W+KstdTsipkiCzFtXosUzTatbz+el+d9XnhehpRNU/5M qtbA67XqNDktoex/bH2bd+eTCUFVbyRQ+9qEYPCrmYSB0j4azo+fI+BT9Q5obb4uguL+LAIK iicIaL5jpGF04AwFrslmAr48tovh2tszYpi0DonhYmc5gqG57yRcrZhC0GlqFMHM80c0jM1V UlAw+x5BYUMHAtuFCQpKH7YgyDGyMH73thjMXwJgcqCDAvvnB2Kw/OwmofH1PIIiWy0CR86C aOdqbraiSsSZW4cJruRmN8m1f74s5i68NBHcfVcLwY09eU9zBQ3ViHs1eJ7kapy/6VjJPsU2 vS7DwAem6ARDlHy/EoIVynBQBIeGK5QhqoMRwWHyLdu3JfFpqcd5/ZbthxUpdc0l6NiI5MTw wgyZhayMETEMZkNxd+5qI5IwMrYK4SfOVmpJx3jESRqRlxtX4LkPRtrDMnYK4ZxaPw/T7Dps zzMRHq8v20vjntxsyjNYwcbg6YuORQPFrsVv+10iD0vZCPxiOFu0tHQVrql7thjg5dbbxh78 C0jFfU1mtMQB+OONaeIS8qlAy6qRL58haJI1QrBCUGuEDG2yIlGnqUfuxpvaZxpakNEVZ0Us g+Te0jyaTJCJ1MeFTI0VYYaU+0p3OeyHZNIkdeZJXq9L0Gek8YIVhbkPLCL9/RJ17v/RGhKU YUoVhCtVIaqQrSBfKc1jnx+QsclqA3+U54/x+v8+gvHyz0K39sZFrDcFHekS/15j+TPPX5F0 9kb3Wt45Yj/65UbaAuN7prTTsdpKH6Uj/XRPZ3q5RRK5ae9y6tue0XWtj77ZzzkVIKh+/VjQ 2Noto13XZ+Lv+Yx0PN54Kl98tsxWZohSjWLX05iotEsn2uyxXc5ZVC+qN6RmbS58Ex0WSXrL KSFFrdxA6gX1X5fTMowHAwAA X-CMS-MailID: 20200706202747eucas1p241ac7df0719d3c05dbc5ba55450a1a7b X-Msg-Generator: CA X-RootMTR: 20200706202747eucas1p241ac7df0719d3c05dbc5ba55450a1a7b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200706202747eucas1p241ac7df0719d3c05dbc5ba55450a1a7b References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200706202626.28628-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v5 25/25] examples/vm_power_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/vm_power_manager/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 273bfec29..05aec1aad 100644 --- a/examples/vm_power_manager/main.c +++ b/examples/vm_power_manager/main.c @@ -244,6 +244,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid, count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[60]; printf("\nChecking link status"); fflush(stdout); @@ -267,15 +268,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint16_t)portid, - (unsigned int)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint16_t)portid); + rte_eth_link_strf(link_status_text, 60, NULL, + &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */