From patchwork Wed Jun 13 09:36:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "De Lara Guarch, Pablo" X-Patchwork-Id: 41027 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85BC81EDC7; Wed, 13 Jun 2018 11:36:26 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CEEED1ED67; Wed, 13 Jun 2018 11:36:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2018 02:36:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,218,1526367600"; d="scan'208";a="62772329" Received: from silpixa00399464.ir.intel.com (HELO silpixa00399464.ger.corp.intel.com) ([10.237.222.157]) by fmsmga004.fm.intel.com with ESMTP; 13 Jun 2018 02:36:21 -0700 From: Pablo de Lara To: declan.doherty@intel.com, abhinandan.gujjar@intel.com Cc: dev@dpdk.org, Pablo de Lara , stable@dpdk.org Date: Wed, 13 Jun 2018 10:36:48 +0100 Message-Id: <20180613093648.6070-1-pablo.de.lara.guarch@intel.com> X-Mailer: git-send-email 2.17.0 Subject: [dpdk-dev] [PATCH] cryptodev: fix ABI breakage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In 17.08, the crypto operation was restructured, and some reserved bytes (5) were added to have the mempool pointer aligned to 64 bits, since the structure is expected to be aligned to 64 bits, allowing future additions with no ABI breakage needed. In 18.05, a new 2-byte field was added, so the reserved bytes were reduced to 3. However, this field was added after the first 3 bytes of the structure, causing it to be placed in an offset of 4 bytes, and therefore, forcing the mempool pointer to be placed after 16 bytes, instead of a 8 bytes, causing unintentionally the ABI breakage. This commit fixes the breakage, by swapping the reserved bytes and the private_data_offset field, so the latter is aligned to 2 bytes and the offset of the mempool pointer returns to its original offset, 8 bytes. Fixes: 54c836846603 ("cryptodev: set private data for session-less mode") Cc: stable@dpdk.org Reported-by: Konstantin Ananyev Signed-off-by: Pablo de Lara Acked-by: Konstantin Ananyev Acked-by: Abhinandan Gujjar --- lib/librte_cryptodev/rte_crypto.h | 51 +++++++++++++++++++------------ 1 file changed, 31 insertions(+), 20 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto.h b/lib/librte_cryptodev/rte_crypto.h index 25404264b..a16be656d 100644 --- a/lib/librte_cryptodev/rte_crypto.h +++ b/lib/librte_cryptodev/rte_crypto.h @@ -73,26 +73,37 @@ enum rte_crypto_op_sess_type { * rte_cryptodev_enqueue_burst() / rte_cryptodev_dequeue_burst() . */ struct rte_crypto_op { - uint8_t type; - /**< operation type */ - uint8_t status; - /**< - * operation status - this is reset to - * RTE_CRYPTO_OP_STATUS_NOT_PROCESSED on allocation from mempool and - * will be set to RTE_CRYPTO_OP_STATUS_SUCCESS after crypto operation - * is successfully processed by a crypto PMD - */ - uint8_t sess_type; - /**< operation session type */ - uint16_t private_data_offset; - /**< Offset to indicate start of private data (if any). The offset - * is counted from the start of the rte_crypto_op including IV. - * The private data may be used by the application to store - * information which should remain untouched in the library/driver - */ - - uint8_t reserved[3]; - /**< Reserved bytes to fill 64 bits for future additions */ + __extension__ + union { + uint64_t raw; + __extension__ + struct { + uint8_t type; + /**< operation type */ + uint8_t status; + /**< + * operation status - this is reset to + * RTE_CRYPTO_OP_STATUS_NOT_PROCESSED on allocation + * from mempool and will be set to + * RTE_CRYPTO_OP_STATUS_SUCCESS after crypto operation + * is successfully processed by a crypto PMD + */ + uint8_t sess_type; + /**< operation session type */ + uint8_t reserved[3]; + /**< Reserved bytes to fill 64 bits for + * future additions + */ + uint16_t private_data_offset; + /**< Offset to indicate start of private data (if any). + * The offset is counted from the start of the + * rte_crypto_op including IV. + * The private data may be used by the application + * to store information which should remain untouched + * in the library/driver + */ + }; + }; struct rte_mempool *mempool; /**< crypto operation mempool which operation is allocated from */