From patchwork Tue Jun 30 14:45:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 72464 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA1A7A0350; Tue, 30 Jun 2020 16:46:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACBD21C00F; Tue, 30 Jun 2020 16:46:06 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1E6191BF5C; Tue, 30 Jun 2020 16:46:03 +0200 (CEST) IronPort-SDR: BnkqsBP78Nqk3p5JeoldjrbLJT1r1CYG4815Vhi4rnWF3i4I3JsrEeyJTnCrX+kGZ2VFkWsD0Y 1+ZuWJPpjPNA== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="144425380" X-IronPort-AV: E=Sophos;i="5.75,297,1589266800"; d="scan'208";a="144425380" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 07:45:59 -0700 IronPort-SDR: o9jtv/QFkpmWMSXoMeE7dr6bG04l6WFoBR2SKlXh54+xkSOUupeoiuxo6xAfXQmPPFDSnpOsMA ImHrCVvjfsGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,297,1589266800"; d="scan'208";a="321425256" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga007.jf.intel.com with ESMTP; 30 Jun 2020 07:45:56 -0700 From: Ferruh Yigit To: Wei Zhao , Jeff Guo Cc: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org Date: Tue, 30 Jun 2020 15:45:54 +0100 Message-Id: <20200630144554.3728903-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/ixgbe/base: remove dead code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It looks like the question around getting rid of the assignments lived long enough, if they are not needed until now, we can drop them. Fixes: 39bca0ed994c ("ixgbe: DCB in base driver") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Acked-by: Qi Zhang --- drivers/net/ixgbe/base/ixgbe_dcb_82598.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_dcb_82598.c b/drivers/net/ixgbe/base/ixgbe_dcb_82598.c index bb309e28f..dc7b905c5 100644 --- a/drivers/net/ixgbe/base/ixgbe_dcb_82598.c +++ b/drivers/net/ixgbe/base/ixgbe_dcb_82598.c @@ -36,14 +36,6 @@ s32 ixgbe_dcb_get_tc_stats_82598(struct ixgbe_hw *hw, stats->qprc[tc] += IXGBE_READ_REG(hw, IXGBE_QPRC(tc)); /* Received Bytes */ stats->qbrc[tc] += IXGBE_READ_REG(hw, IXGBE_QBRC(tc)); - -#if 0 - /* Can we get rid of these?? Consequently, getting rid - * of the tc_stats structure. - */ - tc_stats_array[up]->in_overflow_discards = 0; - tc_stats_array[up]->out_overflow_discards = 0; -#endif } return IXGBE_SUCCESS;