From patchwork Wed May 20 13:58:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 70479 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76ED9A0093; Wed, 20 May 2020 15:58:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 594471D171; Wed, 20 May 2020 15:58:49 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 75A231D148; Wed, 20 May 2020 15:58:47 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 5959B1217; Wed, 20 May 2020 09:58:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 20 May 2020 09:58:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=fYeX6hW+LGspE FQ6O8cqikdMHCUvUjXZVV7d+SprNpY=; b=w13fk4Rw/F7RJ3jbrDMrXaTwqMeaI 9/FqPeSczqO2ihKTjperFGpBDxUfgK2xuQ7tuG6ncaOxkYXZGnwQMrJuXO+EhZNu bOTQqyPr9TJt5JTIy5XQ8dO5/V9rAFpLeV9PBpIjgFGWMFpFOcsnM2VHNSDc/sVq P7s/0dbRSCy+Oc819/82anBiZLirAax1ilRhKEi49swgBg1SsLrukEEuJZ1Nsui4 pH2RVzLddtIxr5VNHAWCAnMM8EZVp2g7x05o4+ohLaM8hxFZa81yMmg3qOMinfgy CcMDUEwoDxVE+JREXQSlYQOdDQHo1Wbtksh43j/BLiJJw/9fWMpqFjgWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=fYeX6hW+LGspEFQ6O8cqikdMHCUvUjXZVV7d+SprNpY=; b=vtDV7CUK TB9PhePL5Eswf17Kyj+hVS6fSnANmPcf57+2C6UkB/f2KBPMnl9ZFrNSMfg4QQYh Y1rWUDmtqY7yLda84kRUFaQp9q/lEMqSKAxOAW9ITHTqi8z2x4Illt8MtZ6Km8no jRZdu+NAwuKL7hKrZdkCkQOU+k5MJOCbEOR2thDUUdE0V1l8NM4WIuplmFVXCU77 erv+XQ/iubYY2JVQkzGiTuQx/H3l7I+0fOjOUBH0kNVXsUSd/EDfOCGZfH8IZ1aS R/c4pRcf8GZhUtSlW6ncbHOd78QjbnpalveWeABlt88916aebBmeYjIy7WTzjMj0 b6SJYbY5nfezkg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EBC5E3066446; Wed, 20 May 2020 09:58:44 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, stable@dpdk.org, Liron Himi , Natalie Samsonov , Tomasz Duszynski Date: Wed, 20 May 2020 15:58:27 +0200 Message-Id: <20200520135830.1178242-2-thomas@monjalon.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200520135830.1178242-1-thomas@monjalon.net> References: <20200520135830.1178242-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/4] net/mvpp2: fix build with gcc 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" GCC 10 is detecting the enum mismatch when assigning UDP variables with MUSDK constants for TCP. Fixes: 7235341d7517 ("net/mrvl: support classifier") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Liron Himi Signed-off-by: Thomas Monjalon --- drivers/net/mvpp2/mrvl_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_flow.c b/drivers/net/mvpp2/mrvl_flow.c index 381b54e291..ea43255284 100644 --- a/drivers/net/mvpp2/mrvl_flow.c +++ b/drivers/net/mvpp2/mrvl_flow.c @@ -2511,14 +2511,14 @@ mrvl_create_cls_table(struct rte_eth_dev *dev, struct rte_flow *first_flow) if (first_flow->pattern & F_UDP_SPORT) { key->proto_field[key->num_fields].proto = MV_NET_PROTO_UDP; - key->proto_field[key->num_fields].field.tcp = MV_NET_TCP_F_SP; + key->proto_field[key->num_fields].field.udp = MV_NET_UDP_F_SP; key->key_size += 2; key->num_fields += 1; } if (first_flow->pattern & F_UDP_DPORT) { key->proto_field[key->num_fields].proto = MV_NET_PROTO_UDP; - key->proto_field[key->num_fields].field.udp = MV_NET_TCP_F_DP; + key->proto_field[key->num_fields].field.udp = MV_NET_UDP_F_DP; key->key_size += 2; key->num_fields += 1; } From patchwork Wed May 20 13:58:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 70480 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6522BA0093; Wed, 20 May 2020 15:59:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 976121D62D; Wed, 20 May 2020 15:58:54 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 68A0A1C24A; Wed, 20 May 2020 15:58:52 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 2744C1217; Wed, 20 May 2020 09:58:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 20 May 2020 09:58:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=jDLL8Jq6SQ9Fa hHCMvMEEu18FxJIAUjEbdt2CXYN3gY=; b=NKGM7Xq7GY2lA6SbuQDro1FnvPUHE TNv1InB/fzev8r3IsVwmQMKFk966M7nYwQzzGLGp1SYyPGs4Olmu4jgh7ZqPV29x wMCODXVHpkd4KEp3NtUf09sa1jBZuvxK0KTnctmj0ywY7n9vXz5U3tpr7D9BtMhN +jGX7czE1xhTWI2pwnSzIJzO4np0vwheiQLDqkCdk7t7PxOGFDO+GSzBDiNE8rWT zet5rjoOFFhoQ+NFU52+vbXoqpP/HgQ5Ua6N0l/cj79U7C7o3RPq7GXpS0r/d2rf O91hVFSXBc7j4eF44/56rRNmNw2Fz3YGy2vgS/kWU4vm4fQ2El+HRZvCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=jDLL8Jq6SQ9FahHCMvMEEu18FxJIAUjEbdt2CXYN3gY=; b=axojudV8 JJa48Jh23aylw4WWHHj6vyMZckD2p1aUyQq55hkCv3m/SfXSRf8KnJKCrnZj++SF sysDOYXt8GHG7/FOoaoZPnWSBJVbxqaTRcDwymhHnA3ctIquzohYuY8Gf14oOwC0 D22IWgrjpYATbAAzIeg8aLDh5SSUYTDSUvObTsq5xV8gBCgufBE9y4WXQwhXKYdx GRyoAbIFXVN4YuSbj+XEbYYymRwD46P135vx9JH0aX5umCHkKELXhsg0aWChKLCS NRrBdAr+kadaM6515gnSeOXchK+KwBCBayQ83hJvrw3e3WaclBuP4qRv0MWZKd5u oLD2+rTiGf01vw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 39D143066451; Wed, 20 May 2020 09:58:48 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, stable@dpdk.org, David Hunt , Nemanja Marjanovic , Rory Sexton , Santosh Shukla , Konstantin Ananyev Date: Wed, 20 May 2020 15:58:28 +0200 Message-Id: <20200520135830.1178242-3-thomas@monjalon.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200520135830.1178242-1-thomas@monjalon.net> References: <20200520135830.1178242-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/4] examples/vm_power: fix build with -fno-common X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The variables of the same name are merged together if compiled with -fcommon. It used to be the default. This default behaviour allows to declare a variable in a header file and share the variable in every .o binaries thanks to merge at link-time. If compiling with -fno-common (default in GCC 10), the variable must be shared as extern to avoid multiple re-definitions. Fixes: dff22404aaad ("examples/vm_power_mgr: add VCPU to PCPU mapping") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- examples/vm_power_manager/channel_manager.c | 2 ++ examples/vm_power_manager/channel_manager.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c index 4ac21f02c1..4d13697208 100644 --- a/examples/vm_power_manager/channel_manager.c +++ b/examples/vm_power_manager/channel_manager.c @@ -35,6 +35,8 @@ #define RTE_LOGTYPE_CHANNEL_MANAGER RTE_LOGTYPE_USER1 +struct libvirt_vm_info lvm_info[MAX_CLIENTS]; + /* Global pointer to libvirt connection */ static virConnectPtr global_vir_conn_ptr; diff --git a/examples/vm_power_manager/channel_manager.h b/examples/vm_power_manager/channel_manager.h index 8284be0a18..a2a2f2bba0 100644 --- a/examples/vm_power_manager/channel_manager.h +++ b/examples/vm_power_manager/channel_manager.h @@ -41,7 +41,7 @@ struct libvirt_vm_info { uint8_t num_cpus; }; -struct libvirt_vm_info lvm_info[MAX_CLIENTS]; +extern struct libvirt_vm_info lvm_info[MAX_CLIENTS]; /* Communication Channel Status */ enum channel_status { CHANNEL_MGR_CHANNEL_DISCONNECTED = 0, CHANNEL_MGR_CHANNEL_CONNECTED, From patchwork Wed May 20 13:58:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 70481 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21884A0093; Wed, 20 May 2020 15:59:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88B9E1D638; Wed, 20 May 2020 15:58:57 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 79D811D60D; Wed, 20 May 2020 15:58:54 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 706D01219; Wed, 20 May 2020 09:58:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 20 May 2020 09:58:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=jB2OjYGfjEPIS l8t7iJKdVj1gLeBWNA94kkySggoloo=; b=KvLRodqvbPncFe2YZ/2k80dJ8zUmu V+OBLzzQEQIyWIDxRiRhHJ/s9djAEIoLLofhBbUTFOhZ3uJCfLYExXs/5yDOEr0e C7cqP7tRHdNw7rilCxT0PcTTNW1zMgb7LiwgZFp8QARYPePJppqRKQVxH36B1rNN de9mVsNuMh7VPnKcBp52UlIcCcNgyuUu6rsRq/lNmS5EHhknNpWK3vr55jWQPL6q b01SCMHhfJqWf5eaj2ilHi9efSS8WOgWeB+DRkokB11GP/D3Vh5EZHlAoPOlu/3b EtFvLZorMnGx76xbSbjAVINDUlUVA3gjPv0VUJuXDA8yj6eOXCwnr75Mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=jB2OjYGfjEPISl8t7iJKdVj1gLeBWNA94kkySggoloo=; b=f+xmweyO KAPngd0bp/RIqk6gtWNFytV3uqkZaeoGCd+U6AimzuYFRSnY10qBAbQ3fiFpCmHc mNMzR7RnSzNVB54HUs5ZPaOf00fwkWX0ZSHn/kz/NZOaormbpPpfKzUbiblqDkb0 YKhKolhhTkKX+B1AmXd/2B/caqtEjl9JvUQOXSOksxxiv5j7BZm5mVIle7TM0q3H 2NGZpKHFNWKvZHV45m3vp0Mb9UD7weffauF3rCXiX6JHcbfwawQxspOMYhfUJn2y 6np37egIJYbqqx4pZTCqh8EKf4jCH/gbIqwUdxHYk6UAgG0SUfTJrw+aahWiwAyT yg7mBYeZh+EHBA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 37DF33066451; Wed, 20 May 2020 09:58:52 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, stable@dpdk.org, David Hunt , Bruce Richardson Date: Wed, 20 May 2020 15:58:29 +0200 Message-Id: <20200520135830.1178242-4-thomas@monjalon.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200520135830.1178242-1-thomas@monjalon.net> References: <20200520135830.1178242-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/4] examples/vm_power: drop Unix path limit redefinition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The Unix socket path may be as long as UNIX_PATH_MAX. This constant is supposed to be defined in sys/un.h. On Linux, it appears to be in linux/un.h. This constant was re-defined locally, based on a variable declaration. It is breaking compilation with -fno-common (default in GCC 10) We could avoid the variable declaration by using NULL struct, but it looks simpler not redefining this system constant. As the power library and its examples are restricted to Linux only, the Linux header file is directly included. Fixes: 0d74597c1b4f ("examples/vm_power: fix max length of unix socket path") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- examples/vm_power_manager/channel_manager.c | 1 - examples/vm_power_manager/channel_manager.h | 7 +------ examples/vm_power_manager/power_manager.c | 1 - 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c index 4d13697208..74a2a677e8 100644 --- a/examples/vm_power_manager/channel_manager.c +++ b/examples/vm_power_manager/channel_manager.c @@ -4,7 +4,6 @@ #include #include -#include #include #include #include diff --git a/examples/vm_power_manager/channel_manager.h b/examples/vm_power_manager/channel_manager.h index a2a2f2bba0..e55376fcdb 100644 --- a/examples/vm_power_manager/channel_manager.h +++ b/examples/vm_power_manager/channel_manager.h @@ -10,7 +10,7 @@ extern "C" { #endif #include -#include +#include #include #include @@ -26,11 +26,6 @@ extern "C" { /* FIFO file name template */ #define CHANNEL_MGR_FIFO_PATTERN_NAME "fifo" -#ifndef UNIX_PATH_MAX -struct sockaddr_un _sockaddr_un; -#define UNIX_PATH_MAX sizeof(_sockaddr_un.sun_path) -#endif - #define MAX_CLIENTS 64 #define MAX_VCPUS 20 diff --git a/examples/vm_power_manager/power_manager.c b/examples/vm_power_manager/power_manager.c index 7b4f4b3c4d..cd51d4741f 100644 --- a/examples/vm_power_manager/power_manager.c +++ b/examples/vm_power_manager/power_manager.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include #include From patchwork Wed May 20 13:58:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 70482 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFF4AA0093; Wed, 20 May 2020 15:59:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC9111D647; Wed, 20 May 2020 15:58:58 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id E28971D634 for ; Wed, 20 May 2020 15:58:55 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 145A1126A; Wed, 20 May 2020 09:58:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 20 May 2020 09:58:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=DlNeW92G6dzcO /xhVqeHah3KL+UA9mdSB+1GtxqVOFM=; b=Z+wVo2nM15xwX93A8fdC1bxE2cxKR 0BNnlzt/5ITvvLwCjfj0kK2xPqGFZbcIYwsioB+yKLmf3L5NYmSAWvB59hPXOEcu zKh6SXTqcFj+ggHnraqJ8XlNf/hIHTve1yfZqEcNKulIF7PPUEnm47Z50Vti7osk 00IprBQ5IhZqVTQdsiSjlLkPHSe/dlCwoOw45LFQ61/xWSHgO03QOalLvrwAb4Yr 1CqUm6am+G0pDo4DLPHzx+Gp48oF+I0WN133Fg2kJvHTePUHjWRqOI8gQiQTYQRd tLLW+uL3FsHviyVQYjT9xfuSzqyvJnY+Ta/GBwsxT8XDzUo/7rlLfpQ4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=DlNeW92G6dzcO/xhVqeHah3KL+UA9mdSB+1GtxqVOFM=; b=zx60IaKJ wZ49al91uR/PObcu4NKVpPy6jrSD1rNc0+FI6mgIHelLVsihi0ugEOFKcyruarmX hKdhgU3IVgSgvvdSw5hqir2L5Rjcve3ZZv8VoIo18nxzAWDs4VgTpcZulmu5q4VR g13+FkeEIfKOHA5GQ8oBkwpRfuzagQ1ledWSlSA8xbqRUCW0HLZT766aZruAXsxd oAGL7S+bHFSm3MaYrcoGQCNbxQ9C1iIdEyTZi4x+nacimSQ8WqTefYaHfQqEWu0H UmsHSX1Ql24jneufVJMz4Tzcrgfh65Y2A+EMz/ItD+4Nv6EcWQkBOOxjUuHfCXxw zEy5cciN5Wg0Ww== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedvhefgiedvjeegtdevhe efhfetleefgfeivefgffevfeejgedtgfeutdehtdegveenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1DCF53066451; Wed, 20 May 2020 09:58:54 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com Date: Wed, 20 May 2020 15:58:30 +0200 Message-Id: <20200520135830.1178242-5-thomas@monjalon.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200520135830.1178242-1-thomas@monjalon.net> References: <20200520135830.1178242-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 4/4] devtools: allow warnings in ABI reference build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is no point in forcing warning-free compilation when building an ABI reference. It is only preventing from compiling ABI reference of old releases with recent compilers. Note: DPDK 20.02 is built (with warnings) by GCC 10 if using -fcommon. Signed-off-by: Thomas Monjalon --- devtools/test-build.sh | 6 ++---- devtools/test-meson-builds.sh | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 6e53f86fc8..f013656024 100755 --- a/devtools/test-build.sh +++ b/devtools/test-build.sh @@ -68,8 +68,6 @@ J=$DPDK_MAKE_JOBS builds_dir=${DPDK_BUILD_TEST_DIR:-.} short=false unset verbose -# for ABI checks, we need debuginfo -test_cflags="-Wfatal-errors -g" while getopts hj:sv ARG ; do case $ARG in j ) J=$OPTARG ;; @@ -248,7 +246,7 @@ for conf in $configs ; do config $dir $target $options echo "================== Build $conf" - ${MAKE} -j$J EXTRA_CFLAGS="$test_cflags $DPDK_DEP_CFLAGS" \ + ${MAKE} -j$J EXTRA_CFLAGS="-Wfatal-errors -g $DPDK_DEP_CFLAGS" \ EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir ! $short || break export RTE_TARGET=$target @@ -282,7 +280,7 @@ for conf in $configs ; do echo -n "================== Build $conf " echo "($DPDK_ABI_REF_VERSION)" ${MAKE} -j$J \ - EXTRA_CFLAGS="$test_cflags $DPDK_DEP_CFLAGS" \ + EXTRA_CFLAGS="-Wno-error -g $DPDK_DEP_CFLAGS" \ EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \ O=$abirefdir/build export RTE_TARGET=$target diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index e8df017596..18b874fac5 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -74,7 +74,6 @@ config () # return fi options= - options="$options --werror" if echo $* | grep -qw -- '--default-library=shared' ; then options="$options -Dexamples=all" else @@ -127,7 +126,7 @@ build () # # skip build if compiler not available command -v ${CC##* } >/dev/null 2>&1 || return 0 load_env $targetcc || return 0 - config $srcdir $builds_dir/$targetdir $* + config $srcdir $builds_dir/$targetdir --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" ]; then abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION