From patchwork Thu May 14 20:39:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kadam, Pallavi" X-Patchwork-Id: 70281 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E650A034F; Thu, 14 May 2020 22:43:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D50E31D9D3; Thu, 14 May 2020 22:43:49 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 338271D9D3 for ; Thu, 14 May 2020 22:43:48 +0200 (CEST) IronPort-SDR: 2D5x5/K0PQmF5L/anOqvQOnnStVWcdQFySFe+0pBDE5m0otGPDi5ErjkNMQydopqb5rUSMMx1D Q+taRm3w93IQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 13:43:47 -0700 IronPort-SDR: 4/45ogBvArORkGyfKVYKd0RbwxYMjKI0mVOq6Kf1kjKZpXHrBpSp6BJfLNjbzT0h8foT0OKKI3 FYrlM+IeJ2mg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,392,1583222400"; d="scan'208";a="464663218" Received: from win-dpdk-pallavi.jf.intel.com (HELO localhost.localdomain) ([10.166.188.75]) by fmsmga006.fm.intel.com with ESMTP; 14 May 2020 13:43:46 -0700 From: Pallavi Kadam To: dev@dpdk.org, thomas@monjalon.net Cc: Harini.Ramakrishnan@microsoft.com, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, pallavi.kadam@intel.com Date: Thu, 14 May 2020 13:39:45 -0700 Message-Id: <20200514203945.1484-1-pallavi.kadam@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20200513225341.7620-1-pallavi.kadam@intel.com> References: <20200513225341.7620-1-pallavi.kadam@intel.com> Subject: [dpdk-dev] [PATCH v2] eal: fix warnings on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes bunch of warnings when compiling on Windows such as the use of an unsafe string function (strerror), [-Wunused-const-variable] in getopt.c and [-Wunused-variable], [-Wunused-function] in eal_common_options.c v2 changes: Excluded dirent.h file on Windows temporarily. (This file will stay on Windows for later use) Signed-off-by: Ranjit Menon Signed-off-by: Pallavi Kadam Tested-by: Pallavi Kadam Tested-by: Dmitry Kozlyuk Acked-by: Narcisa Vasile --- lib/librte_eal/common/eal_common_options.c | 8 +++++++- lib/librte_eal/windows/getopt.c | 4 ++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 8f2cbd1c6..0546beb3a 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -18,7 +18,9 @@ #endif #include #include +#ifndef RTE_EXEC_ENV_WINDOWS #include +#endif #include #include @@ -115,8 +117,10 @@ struct shared_driver { static struct shared_driver_list solib_list = TAILQ_HEAD_INITIALIZER(solib_list); +#ifndef RTE_EXEC_ENV_WINDOWS /* Default path of external loadable drivers */ static const char *default_solib_dir = RTE_EAL_PMD_PATH; +#endif /* * Stringified version of solib path used by dpdk-pmdinfo.py @@ -329,6 +333,7 @@ eal_plugin_add(const char *path) return 0; } +#ifndef RTE_EXEC_ENV_WINDOWS static int eal_plugindir_init(const char *path) { @@ -362,6 +367,7 @@ eal_plugindir_init(const char *path) /* XXX this ignores failures from readdir() itself */ return (dent == NULL) ? 0 : -1; } +#endif int eal_plugins_init(void) @@ -394,8 +400,8 @@ eal_plugins_init(void) } } - return 0; #endif + return 0; } /* diff --git a/lib/librte_eal/windows/getopt.c b/lib/librte_eal/windows/getopt.c index 170c9b5e0..a08f7c109 100644 --- a/lib/librte_eal/windows/getopt.c +++ b/lib/librte_eal/windows/getopt.c @@ -25,8 +25,8 @@ int opterr = 1; /* if error message should be printed */ int optind = 1; /* index into parent argv vector */ int optopt = '?'; /* character checked for validity */ -static void pass(void) {} -#define warnx(a, ...) pass() +static void pass(const char *a) {(void) a; } +#define warnx(a, ...) pass(a) #define PRINT_ERROR ((opterr) && (*options != ':'))