[V1,1/1] tests/uni_pkt: delete code for check result

Message ID 20230330082353.2404798-2-jin.ling@intel.com (mailing list archive)
State Accepted
Headers
Series uni_pkt/optimize script |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Jin Ling March 30, 2023, 8:23 a.m. UTC
  hw ptype shows the info of NIC descriptor, and sw ptype shows the info of mbuf, both of them can indicate the packet type was detected, so delete the code of check hw ptype only.

Signed-off-by: Jin Ling <jin.ling@intel.com>
---
 tests/TestSuite_uni_pkt.py | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

--
2.25.1
  

Comments

Tu, Lijuan April 11, 2023, 7:49 a.m. UTC | #1
On Thu, 30 Mar 2023 16:23:53 +0800, Jin Ling <jin.ling@intel.com> wrote:
> hw ptype shows the info of NIC descriptor, and sw ptype shows the info of mbuf, both of them can indicate the packet type was detected, so delete the code of check hw ptype only.
> 
> Signed-off-by: Jin Ling <jin.ling@intel.com>


Applied, thanks
  

Patch

diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
index abeb3c35..e883b84d 100644
--- a/tests/TestSuite_uni_pkt.py
+++ b/tests/TestSuite_uni_pkt.py
@@ -16,7 +16,6 @@  translate the offloaded packet types into these 7 fields of information, for
 user applications
 """

-import re
 import time

 import framework.utils as utils
@@ -60,13 +59,10 @@  class TestUniPacket(TestCase):
             pkt = Packet(pkt_type=pkt_type)
             pkt.send_pkt(self.tester, tx_port=self.tester_iface, count=4)
             out = self.dut.get_session_output(timeout=2)
-            pattern = re.compile(r"hw ptype: (.*?)sw")
-            hw_ptype = re.findall(pattern, out)
             for pkt_layer_name in pkt_names:
-                for tag in hw_ptype:
-                    if pkt_layer_name.strip() not in tag:
-                        print((utils.RED("Fail to detect %s" % pkt_layer_name)))
-                        raise VerifyFailure("Failed to detect %s" % pkt_layer_name)
+                if pkt_layer_name not in out:
+                    print((utils.RED("Fail to detect %s" % pkt_layer_name)))
+                    raise VerifyFailure("Failed to detect %s" % pkt_layer_name)
             print((utils.GREEN("Detected %s successfully" % pkt_type)))

     def test_l2pkt_detect(self):