[V2] tests/vf_offload: optimize script

Message ID 20230327173650.780985-1-songx.jiale@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] tests/vf_offload: optimize script |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Jiale, SongX March 27, 2023, 5:36 p.m. UTC
  in general, vfs do not need to enable trust on. some intree drivers have
a issue that vfs with trust on cannot receive vf vlan packets, and
this issue will not be fixed. in order not to affect subsequent case
testing, do not enable trust on unnecessarily.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_vf_offload.py | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

V2:
-modify the comment description
  

Comments

Tu, Lijuan March 28, 2023, 1:24 a.m. UTC | #1
On Mon, 27 Mar 2023 17:36:50 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> in general, vfs do not need to enable trust on. some intree drivers have
> a issue that vfs with trust on cannot receive vf vlan packets, and
> this issue will not be fixed. in order not to affect subsequent case
> testing, do not enable trust on unnecessarily.
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>


Applied, thanks
  

Patch

diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py
index 9475ef22..47f6351b 100644
--- a/tests/TestSuite_vf_offload.py
+++ b/tests/TestSuite_vf_offload.py
@@ -91,20 +91,21 @@  class TestVfOffload(TestCase):
         self.host_intf_0 = self.dut.ports_info[self.used_dut_port_0]["intf"]
         self.host_intf_1 = self.dut.ports_info[self.used_dut_port_1]["intf"]
 
-        self.ip_link_set(
-            host_intf=self.host_intf_0,
-            cmd="vf",
-            port=0,
-            types="trust",
-            value="on",
-        )
-        self.ip_link_set(
-            host_intf=self.host_intf_1,
-            cmd="vf",
-            port=0,
-            types="trust",
-            value="on",
-        )
+        if self.dcf_mode:
+            self.ip_link_set(
+                host_intf=self.host_intf_0,
+                cmd="vf",
+                port=0,
+                types="trust",
+                value="on",
+            )
+            self.ip_link_set(
+                host_intf=self.host_intf_1,
+                cmd="vf",
+                port=0,
+                types="trust",
+                value="on",
+            )
         self.ip_link_set(
             host_intf=self.host_intf_0,
             cmd="vf",