diff mbox series

[V6,5/5] tests/vf_offload: fix and improve unstable implementations.

Message ID 20221223085527.29760-6-ke1.xu@intel.com (mailing list archive)
State Accepted
Headers
Series add vf checksum offload and tso case for tunnel packets. |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test fail Testing issues

Commit Message

Ke Xu Dec. 23, 2022, 8:55 a.m. UTC 
  Improved checksum validation part for tunnel cases, ensuring correctness
 under different scenarios.

Abandoned the using of packet sprintf method in validation, fixing the
 possible wrong output under certain packet organizations.

Branched bad checksum counting, ensuring the correctness under DCF enabled
 scenario.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
 tests/TestSuite_vf_offload.py | 32 ++++++++++++++------------------
 1 file changed, 14 insertions(+), 18 deletions(-)

Comments

Weiyuan Li Dec. 23, 2022, 9:03 a.m. UTC | #1 
> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Friday, December 23, 2022 4:55 PM
> To: dts@dpdk.org
> Cc: Xu, Ke1 <ke1.xu@intel.com>; Li, WeiyuanX <weiyuanx.li@intel.com>; Fu,
> Qi <qi.fu@intel.com>; Tu, Lijuan <lijuan.tu@intel.com>
> Subject: [DTS][PATCH V6 5/5] tests/vf_offload: fix and improve unstable
> implementations.
> 
> Improved checksum validation part for tunnel cases, ensuring correctness
> under different scenarios.
> 
> Abandoned the using of packet sprintf method in validation, fixing the
> possible wrong output under certain packet organizations.
> 
> Branched bad checksum counting, ensuring the correctness under DCF
> enabled  scenario.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> Signed-off-by: Ke Xu <ke1.xu@intel.com>
> ---
Tested-by: Weiyuan Li <weiyuanx.li@intel.com>
diff mbox series

Patch

diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py
index 6765fcc5..62e74c33 100644
--- a/tests/TestSuite_vf_offload.py
+++ b/tests/TestSuite_vf_offload.py
@@ -461,20 +461,10 @@  class TestVfOffload(TestCase):
             p = self.tester.load_tcpdump_sniff_packets(inst)
             nr_packets = len(p)
             print(p)
-            packets_received = [
-                p[i].sprintf(
-                    "%IP.chksum%;%UDP.chksum%;%IP:2.chksum%;%UDP:2.chksum%;%TCP.chksum%;%SCTP.chksum%"
-                )
-                for i in range(nr_packets)
-            ]
-
-            packets_received = [
-                item
-                for item in packets_received[0].replace("??", "").split(";")
-                if item != ""
-            ]
-            self.logger.debug(f"packets_received=>{packets_received}")
-            self.logger.debug(f"expected_chksum=>{expected_chksum}")
+            chksums = checksum_pattern.findall(p[0].show2(dump=True))
+            packets_received = chksums
+            self.logger.debug(f"packets_received: {packets_received}")
+            self.logger.debug(f"expected_chksum: {expected_chksum}")
             self.verify(
                 len(expected_chksum) == len(packets_received),
                 f"The chksum type {packet_type} length of the actual result is inconsistent with the expected length!",
@@ -609,10 +599,16 @@  class TestVfOffload(TestCase):
         bad_outer_l4csum = self.vm0_testpmd.get_pmd_value("Bad-outer-l4csum:", out)
         bad_inner_ipcsum = self.vm0_testpmd.get_pmd_value("Bad-ipcsum:", out)
         bad_inner_l4csum = self.vm0_testpmd.get_pmd_value("Bad-l4csum:", out)
-        self.verify(bad_outer_ipcsum == 42, "Bad-outer-ipcsum check error")
-        self.verify(bad_outer_l4csum == 66, "Bad-outer-l4csum check error")
-        self.verify(bad_inner_ipcsum == 42, "Bad-ipcsum check error")
-        self.verify(bad_inner_l4csum == 84, "Bad-l4csum check error")
+        if self.dcf_mode == "enable":
+            self.verify(bad_outer_ipcsum == 24, "Bad-outer-ipcsum check error")
+            self.verify(bad_outer_l4csum == 48, "Bad-outer-l4csum check error")
+            self.verify(bad_inner_ipcsum == 42, "Bad-ipcsum check error")
+            self.verify(bad_inner_l4csum == 84, "Bad-l4csum check error")
+        else:
+            self.verify(bad_outer_ipcsum == 24, "Bad-outer-ipcsum check error")
+            self.verify(bad_outer_l4csum == 36, "Bad-outer-l4csum check error")
+            self.verify(bad_inner_ipcsum == 36, "Bad-ipcsum check error")
+            self.verify(bad_inner_l4csum == 72, "Bad-l4csum check error")
 
     def test_checksum_offload_disable(self):
         """