From patchwork Thu Dec 22 09:37:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ke Xu X-Patchwork-Id: 121286 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB257A034C; Thu, 22 Dec 2022 10:38:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0FA640698; Thu, 22 Dec 2022 10:38:54 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 50BEF400D7 for ; Thu, 22 Dec 2022 10:38:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671701933; x=1703237933; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+1VCE3RvMJyTR1txYl7+gw1fFwMhuu2M7Z1uY+UC0DM=; b=G87rIKISOqOyryySLDfFsO7W1a3uKBiavElpyUGzOqj0aqnJ62TEGF0Z Cn9zl1r7XVqjfGRjVEqJHqz+pCRrhBZxcicx4MatKEF6eUW333dx70E+/ LP2HlaW0hFUM5yKDC77QdANCvGcypzyTo/FbqHIvixQUVVKmQy8ph7t0B o6tDY88Ak5hptrjXfBTjLEH5Gco+kjItRbNxBQbjCdleiOepVBSlKvyqn jjiQXyi+5YeImKJqkdGyVclmiiLCxgI2K+LF69zHaoU+QRsuqBaZSQxMC KmMFgStJXpioV6n+gPDDXSxFFWwg+LjxZccT2YFXrw7zlPPZd8TRZpQt0 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10568"; a="299758302" X-IronPort-AV: E=Sophos;i="5.96,265,1665471600"; d="scan'208";a="299758302" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2022 01:38:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10568"; a="684130072" X-IronPort-AV: E=Sophos;i="5.96,265,1665471600"; d="scan'208";a="684130072" Received: from dpdk-xuke-lab.sh.intel.com ([10.67.119.8]) by orsmga001.jf.intel.com with ESMTP; 22 Dec 2022 01:38:50 -0800 From: Ke Xu To: dts@dpdk.org Cc: weiyuanx.li@intel.com, qi.fu@intel.com, lijuan.tu@intel.com, Ke Xu Subject: [DTS][PATCH V4 1/5] tests/vf_offload: fix 2 typos and a bug. Date: Thu, 22 Dec 2022 17:37:11 +0800 Message-Id: <20221222093715.116863-2-ke1.xu@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221222093715.116863-1-ke1.xu@intel.com> References: <20221222093715.116863-1-ke1.xu@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Checksum is wrongly spelled as checksup. Finally is wrongly spelled as fially. String formating is wrongly put out side of the function call. Signed-off-by: Ke Xu --- tests/TestSuite_vf_offload.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py index 75c75f05..55d0ae85 100644 --- a/tests/TestSuite_vf_offload.py +++ b/tests/TestSuite_vf_offload.py @@ -265,7 +265,7 @@ class TestVfOffload(TestCase): ( ip_checksum, tcp_checksum, - udp_checksup, + udp_checksum, sctp_checksum, ) = packet_received.split(";") print( @@ -273,8 +273,8 @@ class TestVfOffload(TestCase): ip_checksum, "tcp_checksum:, ", tcp_checksum, - "udp_checksup: ", - udp_checksup, + "udp_checksum: ", + udp_checksum, "sctp_checksum: ", sctp_checksum, ) @@ -284,9 +284,9 @@ class TestVfOffload(TestCase): if tcp_checksum != "??": packet_type = "TCP" l4_checksum = tcp_checksum - elif udp_checksup != "??": + elif udp_checksum != "??": packet_type = "UDP" - l4_checksum = udp_checksup + l4_checksum = udp_checksum elif sctp_checksum != "??": packet_type = "SCTP" l4_checksum = sctp_checksum @@ -435,7 +435,7 @@ class TestVfOffload(TestCase): command = ("tcpdump -w tcpdump_{0}.pcap -i {0} 2>tcpdump_{0}.out &").format( iface ) - self.tester.send_expect("rm -f tcpdump_{0}.pcap", "#").format(iface) + self.tester.send_expect("rm -f tcpdump_{0}.pcap".format(iface), "#") self.tester.send_expect(command, "#") def tcpdump_stop_sniff(self): @@ -474,8 +474,8 @@ class TestVfOffload(TestCase): Execute scanner to return results """ scanner_result = self.tester.send_expect(scanner, "#") - fially_result = re.findall(r"length( \d+)", scanner_result) - return list(fially_result) + finally_result = re.findall(r"length( \d+)", scanner_result) + return list(finally_result) def number_of_bytes(self, iface): """