From patchwork Wed Dec 21 17:18:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiale, SongX" X-Patchwork-Id: 121192 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C89A1A034C; Wed, 21 Dec 2022 09:59:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3B03410D3; Wed, 21 Dec 2022 09:59:06 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 48F4E40698 for ; Wed, 21 Dec 2022 09:59:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671613145; x=1703149145; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=apFskXtlqbETm20bOx3M8SZdf+H4dobfeTsoI2e90fw=; b=fd5GmSx6VVv5OciLdPrYFTJZ4yokzGpWEPh2MWVq80nHO4rwAEzmqyf9 nmhJ/zK18t5RJK96558HGU2wdmenE8Vck6CdZaWwp/UopkSGwHjQUzX/t tXA6JITpK3qy02WmTiq9qA1pQ3uCed0kVkZo8ZJ3DH1eY9c5If0SNT3za +GNkjyJhmZCPVY7K7oornsHt4fvFCp0NDjj/ciM0fCBN5ESp8JEwfr0k1 gF8LKb0jvRXAnWGA2suWReIsIxVK/JuG8hKT4jRy4FtLR0jd5Pgu3pX5v TuErpthCam3bXxJYSNn9Ew5H7HW86vkcDBA/W/iEO02Rh5EnpKtAi57qi Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="299501723" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="299501723" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 00:58:54 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="714745776" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="714745776" Received: from unknown (HELO localhost.localdomain) ([10.239.252.94]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 00:58:52 -0800 From: Song Jiale To: dts@dpdk.org Cc: Song Jiale Subject: [dts] [PATCH V1 2/2] tests/ice_limit_value_test: optimize scripts Date: Wed, 21 Dec 2022 17:18:40 +0000 Message-Id: <20221221171840.19652-2-songx.jiale@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221221171840.19652-1-songx.jiale@intel.com> References: <20221221171840.19652-1-songx.jiale@intel.com> X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org 1. when the dpdk testpmd exits abnormally, the port will not be initialized, and sometimes the other test cases will be affected. therefore, after the test, should use quit to close the dpdk testpmd normally to avoid the impact between cases. 2. the object named "self.session_third" is undefined, delete useless code. Signed-off-by: Song Jiale Acked-by: Lijuan Tu --- tests/TestSuite_ice_limit_value_test.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/TestSuite_ice_limit_value_test.py b/tests/TestSuite_ice_limit_value_test.py index 06160c0a..d6f2f969 100644 --- a/tests/TestSuite_ice_limit_value_test.py +++ b/tests/TestSuite_ice_limit_value_test.py @@ -1256,13 +1256,10 @@ class TestICELimitValue(TestCase): def tear_down(self): # destroy all flow rule on port 0 - self.dut.kill_all() - self.destroy_env() if getattr(self, "session_secondary", None): self.dut.close_session(self.session_secondary) - if getattr(self, "session_third", None): - self.dut.close_session(self.session_third) + self.destroy_env() + self.dut.kill_all() def tear_down_all(self): self.dut.kill_all() - self.destroy_env()