[V2,2/2] tests/dynamic_queue: modify script according to dpdk code change

Message ID 20220916083855.48856-2-linglix.chen@intel.com (mailing list archive)
State Changes Requested
Headers
Series [V2,1/2] tests/queue_start_stop: modify script according to dpdk code change |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test success Testing OK
ci/Intel-dts-doc-test success Testing OK

Commit Message

Lingli Chen Sept. 16, 2022, 8:38 a.m. UTC
  According to dpdk commit 3c4426db54fc(app/testpmd: do not poll stopped queues).
modify dynamic_queue: Tx stopped queue not display

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 test_plans/dynamic_queue_test_plan.rst |  4 ++--
 tests/TestSuite_dynamic_queue.py       | 15 ++++++++-------
 2 files changed, 10 insertions(+), 9 deletions(-)
  

Comments

Weiyuan Li Sept. 19, 2022, 3:12 a.m. UTC | #1
> -----Original Message-----
> From: Lingli Chen <linglix.chen@intel.com>
> Sent: Friday, September 16, 2022 4:39 PM
> To: dts@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; Chen, LingliX
> <linglix.chen@intel.com>
> Subject: [dts][PATCH V2 2/2] tests/dynamic_queue: modify script according
> to dpdk code change
> 
> According to dpdk commit 3c4426db54fc(app/testpmd: do not poll stopped
> queues).
> modify dynamic_queue: Tx stopped queue not display
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>
> ---
Tested-by: Weiyuan Li <weiyuanx.li@intel.com>
  

Patch

diff --git a/test_plans/dynamic_queue_test_plan.rst b/test_plans/dynamic_queue_test_plan.rst
index 96cfcb8a..d22068a0 100644
--- a/test_plans/dynamic_queue_test_plan.rst
+++ b/test_plans/dynamic_queue_test_plan.rst
@@ -94,7 +94,7 @@  Stop one Tx queue on port 0::
 
 Set txonly forward, start testpmd
 
-Start testpmd, then stop, check this stopped queue only transmits 255 packets
+Start testpmd, then stop, check this stopped queue not display
   
 Setup this stopped queue on the port::
 
@@ -162,7 +162,7 @@  Stop one Tx queue on port 0::
 
 Set txonly forward, start testpmd
 
-Start testpmd, then stop, check this stopped queue only transmits 255 packets
+Start testpmd, then stop, check this stopped queue not display
 
 Reconfigure ring size as 512 for the stopped queues on port 0::
 
diff --git a/tests/TestSuite_dynamic_queue.py b/tests/TestSuite_dynamic_queue.py
index ebbe869c..5a826bd1 100644
--- a/tests/TestSuite_dynamic_queue.py
+++ b/tests/TestSuite_dynamic_queue.py
@@ -163,13 +163,14 @@  class TestDynamicQueue(TestCase):
             out = self.dut_testpmd.execute_cmd("stop")
             tx_num = qringsize - 1
 
-            if self.nic in ["cavium_a063", "cavium_a064"]:
-                self.verify("TX-packets: 0" in out, "Fail to stop txq at runtime")
-            else:
-                # Check Tx stopped queue only transmits qringsize-1 packets
-                self.verify(
-                    "TX-packets: %d" % tx_num in out, "Fail to stop txq at runtime"
-                )
+            # check rxq start successful
+            self.verify("TX-packets:" in out, "txq start failed")
+            # check Tx stopped queue not display
+            self.verify(
+                "TX Port= 0/Queue={:>2}".format(queue) not in out,
+                "Fail to stop txq at runtime",
+            )
+
             if chgflag == 1:
                 chg_qringsize = qringsize % 1024 + 256
                 if qringsize == 512: