diff mbox series

[V1] tests/port_control: optimize the test script to make run stably

Message ID 20220801052734.13946-1-weiyuanx.li@intel.com (mailing list archive)
State Superseded
Headers
Series [V1] tests/port_control: optimize the test script to make run stably |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Weiyuan Li Aug. 1, 2022, 5:27 a.m. UTC 
  The case of VF binds PF port to kernel driver, and the next test case
of PF needs to be bound to the dpdk driver, but it does not test failed.
So, add check whether the PF port is bound to the dpdk driver.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_port_control.py | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Jiale, SongX Aug. 3, 2022, 6:05 a.m. UTC | #1 
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Monday, August 1, 2022 1:28 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1] tests/port_control: optimize the test script to make run
> stably
> 
> The case of VF binds PF port to kernel driver, and the next test case of PF needs to
> be bound to the dpdk driver, but it does not test failed.
> So, add check whether the PF port is bound to the dpdk driver.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
Tested-by: Jiale Song < songx.jiale@intel.com>
Peng, Yuan Sept. 7, 2022, 4:15 a.m. UTC | #2 
Acked-by: Peng, Yuan <yuan.peng@intel.com>

-----Original Message-----
From: Weiyuan Li <weiyuanx.li@intel.com> 
Sent: Monday, August 1, 2022 1:28 PM
To: dts@dpdk.org
Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
Subject: [dts][PATCH V1] tests/port_control: optimize the test script to make run stably

The case of VF binds PF port to kernel driver, and the next test case of PF needs to be bound to the dpdk driver, but it does not test failed.
So, add check whether the PF port is bound to the dpdk driver.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
diff mbox series

Patch

diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
index d571b01f..7d5b2b7b 100644
--- a/tests/TestSuite_port_control.py
+++ b/tests/TestSuite_port_control.py
@@ -37,6 +37,7 @@  class TestPortControl(TestCase):
         self.socket = self.dut.get_numa_id(self.dut_ports[0])
         port = self.dut.ports_info[0]["port"]
         self.pf_default_driver = port.get_nic_driver()
+        self.driver = self.get_suite_cfg()["vf_driver"]
 
     def set_up(self):
         """
@@ -191,6 +192,14 @@  class TestPortControl(TestCase):
         )
 
     def test_pf_start_stop_reset_close(self):
+        # check PF whether bind to vfio-pci
+        res = self.dut.send_expect("usertools/dpdk-devbind.py -s", "#")
+        pattern = f"({self.dut.nic.pci}).*drv=vfio-pci"
+        regex = re.compile(pattern)
+        mo = regex.search(res)
+        if mo is None:
+            self.bind_nic_driver(self.dut_ports[:1], driver=self.driver)
+
         self.start_testpmd(self.host_testpmd)
         # start port
         self.start_pmd_port(self.host_testpmd)