diff mbox series

[V1] tests/vm2vm_virtio_net_perf: fix script issue

Message ID 20210416070638.1484058-1-weix.ling@intel.com (mailing list archive)
State Superseded
Headers
Series [V1] tests/vm2vm_virtio_net_perf: fix script issue |

Commit Message

Ling, WeiX April 16, 2021, 7:06 a.m. UTC 
  1.Fix testcase 8 iperf test parameter wrong issue.
2.Use 'killall qemu-system-x86_64' command to kill qemu to avoid
when qemu exception can't quit issue.

Signed-off-by: Ling Wei <weix.ling@intel.com>
---
 tests/TestSuite_vm2vm_virtio_net_perf.py | 34 +++++++++++-------------
 1 file changed, 15 insertions(+), 19 deletions(-)

Comments

Ling, WeiX April 16, 2021, 7:12 a.m. UTC | #1 
> -----Original Message-----
> From: Ling, WeiX <weix.ling@intel.com>
> Sent: Friday, April 16, 2021 03:07 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V1] tests/vm2vm_virtio_net_perf: fix script issue
> 
Tested-by: Wei Ling <weix.ling@intel.com>
Wang, Yinan April 20, 2021, 1:54 a.m. UTC | #2 
Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ling, WeiX
> Sent: 2021?4?16? 15:12
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/vm2vm_virtio_net_perf: fix script issue
> 
> > -----Original Message-----
> > From: Ling, WeiX <weix.ling@intel.com>
> > Sent: Friday, April 16, 2021 03:07 PM
> > To: dts@dpdk.org
> > Cc: Ling, WeiX <weix.ling@intel.com>
> > Subject: [dts][PATCH V1] tests/vm2vm_virtio_net_perf: fix script issue
> >
> Tested-by: Wei Ling <weix.ling@intel.com>
diff mbox series

Patch

diff --git a/tests/TestSuite_vm2vm_virtio_net_perf.py b/tests/TestSuite_vm2vm_virtio_net_perf.py
index d1e94093..51b94199 100644
--- a/tests/TestSuite_vm2vm_virtio_net_perf.py
+++ b/tests/TestSuite_vm2vm_virtio_net_perf.py
@@ -73,12 +73,16 @@  class TestVM2VMVirtioNetPerf(TestCase):
         self.device_str = None
         self.checked_vm = False
         self.dut.restore_interfaces()
+        self.path=self.dut.apps_name['test-pmd']
+        self.testpmd_name=self.path.split("/")[-1]
 
     def set_up(self):
         """
         run before each test case.
         """
         self.dut.send_expect("rm -rf %s/vhost-net*" % self.base_dir, "#")
+        self.dut.send_expect("killall -s INT %s" % self.testpmd_name, "#")
+        self.dut.send_expect("killall qemu-system-x86_64", "#")
         self.vm_dut = []
         self.vm = []
 
@@ -291,9 +295,8 @@  class TestVM2VMVirtioNetPerf(TestCase):
         return iperfdata
 
     def stop_all_apps(self):
-        for i in range(len(self.vm)):
-            self.vm[i].stop()
-        self.pmd_vhost.quit()
+        self.dut.send_expect("killall -s INT %s" % self.testpmd_name, "#")
+        self.dut.send_expect("killall -s INT qemu-system-x86_64", "#")
 
     def offload_capbility_check(self, vm_client):
         """
@@ -338,20 +341,13 @@  class TestVM2VMVirtioNetPerf(TestCase):
         self.verify(md5_send == md5_revd, 'the received file is different with send file')
 
     def bind_nic_driver(self, ports, driver=""):
-        if driver == "igb_uio":
-            for port in ports:
-                netdev = self.dut.ports_info[port]['port']
-                driver = netdev.get_nic_driver()
-                if driver != 'igb_uio':
-                    netdev.bind_driver(driver='igb_uio')
-        else:
-            for port in ports:
-                netdev = self.dut.ports_info[port]['port']
-                driver_now = netdev.get_nic_driver()
-                if driver == "":
-                    driver = netdev.default_driver
-                if driver != driver_now:
-                    netdev.bind_driver(driver=driver)
+        for port in ports:
+            netdev = self.dut.ports_info[port]['port']
+            driver_now = netdev.get_nic_driver()
+            if driver == "":
+                driver = netdev.default_driver
+            if driver != driver_now:
+                netdev.bind_driver(driver=driver)
 
     def test_vm2vm_split_ring_iperf_with_tso(self):
         """
@@ -490,7 +486,7 @@  class TestVM2VMVirtioNetPerf(TestCase):
         self.vm_args = "disable-modern=false,mrg_rxbuf=on,csum=on,guest_csum=on,host_tso4=on,guest_tso4=on,guest_ecn=on,packed=on"
         self.prepare_test_env(cbdma=True, no_pci=False, client_mode=False, enable_queues=1, nb_cores=2,
                               server_mode=False, opt_queue=None, combined=False, rxq_txq=None)
-        self.start_iperf_and_verify_vhost_xstats_info(iperf_mode='ufo')
+        self.start_iperf_and_verify_vhost_xstats_info(iperf_mode='tso')
 
     def test_vm2vm_packed_ring_iperf_with_ufo(self):
         """
@@ -595,9 +591,9 @@  class TestVM2VMVirtioNetPerf(TestCase):
         """
         run after each test case.
         """
+        self.bind_cbdma_device_to_kernel()
         self.stop_all_apps()
         self.dut.kill_all()
-        self.bind_cbdma_device_to_kernel()
 
     def tear_down_all(self):
         """