diff mbox series

[V1] tests/cvl_switch_filter:update class name and instance Packet class

Message ID 20200727183311.18274-1-jianweix.mei@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/cvl_switch_filter:update class name and instance Packet class |

Commit Message

Mei, JianweiX July 27, 2020, 6:33 p.m. UTC 
  1. Suite TestSuite_cvl_dcf_switch_filter.py and TestSuite_cvl_switch_filter.py have 
the same class name, lead to logs generated in one log file.
2. Class packet have not instantiated.

Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
---
 tests/TestSuite_cvl_switch_filter.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Lu, Nannan July 29, 2020, 8:20 a.m. UTC | #1 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jianwei Mei
> Sent: Tuesday, July 28, 2020 2:33 AM
> To: dts@dpdk.org
> Cc: Mei, JianweiX <jianweix.mei@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_switch_filter:update class name and instance
> Packet class
> 
> 1. Suite TestSuite_cvl_dcf_switch_filter.py and TestSuite_cvl_switch_filter.py
> have the same class name, lead to logs generated in one log file.
> 2. Class packet have not instantiated.
> 
> Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
> ---
>  tests/TestSuite_cvl_switch_filter.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_cvl_switch_filter.py
> b/tests/TestSuite_cvl_switch_filter.py
> index 01a2842..5dc7d21 100644
> --- a/tests/TestSuite_cvl_switch_filter.py
> +++ b/tests/TestSuite_cvl_switch_filter.py
> @@ -2487,7 +2487,7 @@ tvs_mac_ipv6_tcp_non_pipeline_mode = [
> 
>  test_results = OrderedDict()
> 
> -class SwitchFilterTest(TestCase):
> +class CVLSwitchFilterTest(TestCase):
> 
>      def set_up_all(self):
>          """
> @@ -2506,6 +2506,7 @@ class SwitchFilterTest(TestCase):
>          src_file = 'dep/testpmd_cmds_rte_flow_fdir_rules'
>          self.dut_file_dir = '/tmp'
>          self.dut.session.copy_file_to(src_file, self.dut_file_dir)
> +        self.pkt = Packet()
> 
>      def set_up(self):
>          """

Acked-by: Nannan Lu <nannan.lu@intel.com>

> --
> 2.17.1
Tu, Lijuan Aug. 12, 2020, 5:58 a.m. UTC | #2 
> > 1. Suite TestSuite_cvl_dcf_switch_filter.py and TestSuite_cvl_switch_filter.py
> > have the same class name, lead to logs generated in one log file.
>  >2. Class packet have not instantiated.
> > 
> > Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
> > ---
> >  tests/TestSuite_cvl_switch_filter.py | 3 ++-
> Acked-by: Nannan Lu <nannan.lu@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/tests/TestSuite_cvl_switch_filter.py b/tests/TestSuite_cvl_switch_filter.py
index 01a2842..5dc7d21 100644
--- a/tests/TestSuite_cvl_switch_filter.py
+++ b/tests/TestSuite_cvl_switch_filter.py
@@ -2487,7 +2487,7 @@  tvs_mac_ipv6_tcp_non_pipeline_mode = [
 
 test_results = OrderedDict()
 
-class SwitchFilterTest(TestCase):
+class CVLSwitchFilterTest(TestCase):
 
     def set_up_all(self):
         """
@@ -2506,6 +2506,7 @@  class SwitchFilterTest(TestCase):
         src_file = 'dep/testpmd_cmds_rte_flow_fdir_rules'
         self.dut_file_dir = '/tmp'
         self.dut.session.copy_file_to(src_file, self.dut_file_dir)
+        self.pkt = Packet()
 
     def set_up(self):
         """