diff mbox series

[12/20] net/ice: goto clean up lable to avoid memory leak

Message ID	tencent_61C69CF0409C524458EA707D5F8EA088040A@qq.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	David Marchand
Headers	Message-ID: <tencent_61C69CF0409C524458EA707D5F8EA088040A@qq.com> From: Weiguo Li <liwg06@foxmail.com> To: dev@dpdk.org Cc: adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com, bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com, hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com, simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com, shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org, kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com, declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com Subject: [PATCH 12/20] net/ice: goto clean up lable to avoid memory leak Date: Wed, 23 Feb 2022 02:18:10 +0800 In-Reply-To: <cover.1645551559.git.liwg06@foxmail.com> References: <cover.1645551559.git.liwg06@foxmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	fix memory leaks in error handling \| [00/20] fix memory leaks in error handling [01/20] baseband/acc100: fix a memory leak in acc100 queue setup [02/20] common/dpaax: fix a memory leak in iterate dir [03/20] crypto/dpaa2_sec: fix memory leaks in error handlings [04/20] crypto/qat: fix a memory leak when set encrypt key fail [05/20] net/bnxt: fix a memory leak in error handling [06/20] net/bnxt: fix 'ctx' memory leak when new malloc fail [07/20] net/bnx2x: add clean up for 'rxq' to avoid a memory leak [08/20] net/cnxk: free 'node' memory when node add fail [09/20] net/dpaa: fix a memory leak when validation fail [10/20] net/failsafe: fix a memory leak in error handling [11/20] net/iavf: fix a memory leak in error handling [12/20] net/ice: goto clean up lable to avoid memory leak [13/20] net/ice: fix memory leaks in error handlings [14/20] net/ice: avoid fix memory leaks in register parser [15/20] net/memif: fix some memory leaks in error handlings [16/20] net/sfc: fix a memory leak in error handling [17/20] net/vmxnet3: fix memory leaks in error handlings [18/20] raw/ifpga/base: fix memory leaks in error handlings [19/20] raw/ntb: fix some memory leaks in error handlings [20/20] regex/mlx5: fix a memory leak in error handling

Checks

Context	Check	Description
ci/checkpatch	warning	coding style issues

Commit Message

Weiguo Li Feb. 22, 2022, 6:18 p.m. UTC

  When function return in this branch, the memories of 'input' and 'rule'
are not released, goto corresponding lable to do the clean up.

Fixes: 40d466fa9f765b ("net/ice: support ACL filter in DCF")

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 drivers/net/ice/ice_acl_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/net/ice/ice_acl_filter.c b/drivers/net/ice/ice_acl_filter.c
index 8fe6f5aeb0..5ddc5262d4 100644
--- a/drivers/net/ice/ice_acl_filter.c
+++ b/drivers/net/ice/ice_acl_filter.c
@@ -530,7 +530,7 @@  ice_acl_create_filter(struct ice_adapter *ad,
 				   RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
 				   "failed to set hw configure.");
 		ret = -rte_errno;
-		return ret;
+		goto err_acl_set_input;
 	}
 
 	if (flow_type == ICE_FLTR_PTYPE_NONF_IPV4_OTHER) {