From patchwork Thu Jan 25 16:18:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 34482 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFD251B1A9; Thu, 25 Jan 2018 17:18:46 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0040.outbound.protection.outlook.com [104.47.1.40]) by dpdk.org (Postfix) with ESMTP id CAA941B024 for ; Thu, 25 Jan 2018 17:18:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Tc6ShamZsSkhqFbXBt/hmWXPPQeMWDgZhvkw5ujY3b0=; b=KVDjvQKQCz3QjvP5geP4B4BLzEX9mTVFdEt1qXm388iLs8vM/kSV90xfn8yFAB6dmkCLKLmbnLUqmL2LpmyYIZ0kkAEnXUzqUznDeMsIo0vzdPN3sI8zbKJJV3GCRxj9GpLa55m4dkELk5+cCbgcBbgfTFVdM4fvzdOgO7o6wOY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB6PR05MB3143.eurprd05.prod.outlook.com (2603:10a6:6:1a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 25 Jan 2018 16:18:40 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org, Xueming Li Date: Thu, 25 Jan 2018 18:18:00 +0200 Message-Id: X-Mailer: git-send-email 2.12.0 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: DB6PR0301CA0051.eurprd03.prod.outlook.com (2603:10a6:4:54::19) To DB6PR05MB3143.eurprd05.prod.outlook.com (2603:10a6:6:1a::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 68374429-eda8-405a-5090-08d5640f4c99 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR05MB3143; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 3:ZcMczM70SpSI7Qzo3BDYET2fJnqYtNdYOBE1aSDg00AT4Wiqlhwty40Sru3IzZLBAQLpsiDr4MKfGWe4pELkWSZxw1VixUT8Qr35LV19tZlljOTGA7g6DG/2fH/PHCWaPMkSNJDSpZlQeRq7ZkSKue3UqORJWbyYSL1V3ivpZLzXOL3ZBXq+48ChJdLFmaEPnG1d8pGgKFNXOfaFFCO7i0D6MZAFpUUVup/MUGjmRpHbpqSHCGxz2f16ckQSmmNq; 25:4zNGRq6exEtTKuSvGEFcx83SReIx7bF9vYm6ATbOXVJWERflO+/dyq0FPt9rGpLAIuWMXvr1EpbOkP2CeyzxSU/yGVfuXPN0hsBSlEeNPrZSc0fCPYhdtDIXvvHuIVPzG/cvDDYGwjPZ4oJ1YYoYqebKibpsq7QQUH1w68y8zQ9yBuYlrP/+OuEIF3HhXu+ZpnTY0i7Mv5wyBYaS6qoIWjBE7CbzILau1Vv8H+UuHZME32Vzou0H3gGf0hGsbx2/up0+YoKw+Pm5WPFYHR3/8/mOLxcUdNo+cRQw6KFPvq+b4gcWoZiKUxAHgE3A6T2izKWXr5c0d8odmkMHMsI2gA==; 31:SmqY27tOdPytWfPgDlp8HJjmMerSP0TRUIgTfGaEGnUWP9V6pTHkdlvRpBxwbWikDQXzSk9XuAdz2YCLqxFvFjQo3N3LTzujNKLDWXqpUzrRQWju+6GpG0wd5RHTbzHiUs6RbJnZxSiWb8INKZuITzNOqYUJtZjBwkZ72JUZhuq7lNDwRvrema4Bb5Hgw61HZy4QxaaplKp21cXrIYYSuItNyFz9p3pTWcY4Mq8jm4Q= X-MS-TrafficTypeDiagnostic: DB6PR05MB3143: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 20:xMbTwT1RAe1by8eioGvQEuT0UbA2QveN+PJOC4LKMtDE16JTrkbk1R0pLIuaqSmbX180J5Y8lITAcgM5NDuOS1fjbScE6djf7Z9ib8qEPwTISVlxxV/kE8MDJdO/QSERh4GwPDi7OkKdKhAvyWe5+B1BMbXmYps8RsmSwt5ATMJMzraW6aNwr2VzznoxBT83SKq5QPGkILGWPhx0OTbsdQi2MXjshFakVgWnxlzxdy3WDSG9q4iCkNE5FNQQZaknV2YXs1+sHH422XUGDHGgfKeuw711ggbFRmnbPw4CdWpiMEs1NKw8DP3X2NV/gwyOzrXjczacwPtziWxvu7y171wExYB5O5v/VqwMSSrBWJieDLyEWHgH8uvSwVEe0TcV8RtRwKGbLLYrv8zgA0IbNnA7k/CTG/u/Ghx7rn7u/78OZmo/1+gw4jH95s7tRu+uqNp5fj6rnerQuq+9ZoQ8G0qjgT7vkGTVCq6vj1i0O1w4BZHrw4FdNklfunTvcu9c; 4:CIUJxBK8sBBWEKKoqUJz5KMJmixmXHOqGp9we6Q8gtSnPD1c5a6QoBrACcieK8hbD9UeMTrB0mZpFIWH1vUNFaZ5FyZHs0VODhHKz7eTIi7dIx1CaDl2bP5gTy5A8M0dnJ6t/KBQndALMsFEzc/hAP0PG+zNJeCYtBBBwkojhRdCzIP7QLerIsbkwrsSpc1im+RazJrSKxn5EQmWepixES5ufhbZiUbGz1z+8jhFrPY0eLChx+wtLXIi541CqSJypiDv6ANuOnGxIKU7/nPb1g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231023)(2400081)(944501161)(10201501046)(3002001)(6055026)(6041288)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR05MB3143; BCL:0; PCL:0; RULEID:; SRVR:DB6PR05MB3143; X-Forefront-PRVS: 0563F2E8B7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(346002)(39380400002)(366004)(189003)(199004)(53936002)(478600001)(21086003)(4326008)(107886003)(6636002)(6666003)(47776003)(25786009)(55016002)(106356001)(69596002)(86362001)(36756003)(2906002)(66066001)(8676002)(16526018)(16586007)(81156014)(81166006)(8936002)(3846002)(105586002)(48376002)(50466002)(26005)(316002)(68736007)(6116002)(51416003)(7696005)(118296001)(76176011)(5660300001)(7736002)(305945005)(97736004)(52116002)(386003)(2950100002)(186003)(50226002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3143; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3143; 23:SbqUv2+P//Xk+hcWz25+kjESa2Crlg4tVUGyFMvJy?= FVBUNNrHmvSFCU2wWG0bfQtDviKszvO9YHLBa03zSs9xmLeWg6yh/DY5DAcJpHd7E5H4rqoTsjohlQN2IFlAikuOXJABjxgvnXtPq/fZelvcOhxWeCrbW5rj8l0r7IRBUQBnV/9WoZYmOf083rZSg66H5y0R6hQQQ40eCfzKrx/j3RWtRdlx0K9Ji4jsV6wlK0oaZHVKVKSWO/CnI4sl0SSE7eL94QLM6n/yzv3QmSFKypH4pgN9rkj9YiXSGZu9egwlY4cY2ZKhtfKwB2uI30y9RbkBEEFGOBOeZyS28+tXegmVnGUKWeKH9ID4t6hjcdwx7Psy3eMcUEHjGE9HtESGQf2TnjQ8kR8W+U2NrtNqsfV+SwfV4brab/SJEKg0hAAziCD17ZR5pG7bkdwPMXrrNwc3jBqDCASfcnENe+hGPS65ydNl/xfB6/6YbYaaDPBgNMvb/nQEPI9IdsbUja2NFNl+6Rdahl6WLNiVAzzCfOv6p6ieCYSRw8IGsyET/4xNDbxVi8qdgTDdKJhJwe1xJqZ7VNnQrFnLplxURAc+OkKvKyNyAk9CgWdsf8GK+EGoLyXNzNg6MAo7GmDlDUEn8gcnDpe4uDukd22z/1HOH9bwAiknGuG8g/cn2dSancd76+obinhgbelhdifleQpt9p2Rnp6tm1p0PW15u4e80HH/7mKHsE6lsNsp82b0TSQaCHceC4m/jJshoArp1Stp4XzJayMFbYtAxcvkvhHPffe2vV3Y4wsECVX7XX0thU5UHJCwPFn1R8EFjJEi1oRhLEwV4ugX044U0l4zlPbvQ5Mdxxgmr3OezB3epNHGjwfnpBySJF2ntOZOUOBChUk49UCn9sFTOW7KWO5gPB9t4LlBmsVPoD6Amxr3/8S+K+OKqefmECYtGgQeaP4u0k4uvDhLKGT0dQkEE1TnUEg5xUTqmXKQvO+XmHI8jNt+CATLH/KQBMIjY/qh5EsdH2fsXJFlCk3/W2jnhbpELqSSnlAuyxmQveYgPt4XZpKm6+qvhKw8JRZyRcDdR8TMi1W8kkdzKCJ5+XmiB9tSTt71DjXvH0eHxuzfkDBMTNEvvmc+tJibETULFzyPVOz0tP/XOoywi0FGgCRuwRkePyogw== X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 6:PsG5on/zbEIIiihix1bAoteSKAwotEdqry7gmmnq0unVwlw1+BWXM4GpZz5Jw7aROREQOu33YJud+qpUlsJIACG4iovyhXUtXwjUn+3yLR2PSNScvmdVZKIasRsEkDZ7R74rauOyaXON15raLuUAe55zek7agmg48vqZdUcdloAVFNIDGVasRRs2eR+P8FQd9rR6o1Zm+BsNI7ArOr2tjhAwsHL9RrKhUQXhG/qezRfqWHydQ45IIfk5B5HK5gNz2jsNHbjzPa+Y9DZUBq/r2eu2tKkrfOdXyfhMbSX+wsKbivDiAXIoeNicZMylTU9gDLdQMN3hTKIUaZGyVssiMtSJQskjKMztSU7Sbbc+gZY=; 5:OhAOSu4CVsQN+6v7kx2K1zG1xnCKu81rZ/1G8IfqeVJ8nnU53fPP++b5BRnI+kK/eZw/pWTMSwbjY0usReabZ+OkgtCYNEzQil78lTYBh5Jv1Q+jxb5jIe5jKijzateqWX98Nz5pdhYDFOQYhhN0I01G5eNlbohpemRwtLXa074=; 24:kukzacM/f1JetmKpGaWzSTlzg6BuvEPABy28a1un2cIQ9oFh4SiHLGogvddUsO66bNNHmRA9OYS9xBlhHQImbpz9S9Sb6rAScNhMlgwnum8=; 7:kjwSsJxz9e+RsClFEkokavFI9BR1QIPKFQUozwMPTfjtdUgkrvgc7OfkDC+O+4irP3Q3KVZ4LwZSVUhSVlpw+o5hotM153AgKzfyIoKOI4iRNgS1EYvWIe9K3qAN1Cc2MVyFPHnhlIDn2r0uMJqeX4wCYOC11XXOvrEYrehfQUNhDmkXy8FzXzEnK6KfYbCy7X4WwIuwV2o4E7Ri8tMbQZ8b7Gq3EI35yrNupJ5heiVXTOPUqE7+SJ509D91pI3G SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2018 16:18:40.9415 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68374429-eda8-405a-5090-08d5640f4c99 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3143 Subject: [dpdk-dev] [PATCH v2 3/6] net/mlx5: remove assert un-accessible from secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Verbs structs such as ibv_mr are not accessible from the secondary process. Choose to remove the assert in favor of performing more checks on the critical data path. Signed-off-by: Shahaf Shuler Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index a63364d79..26be206a7 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -563,8 +563,6 @@ mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb) if (txq->mp2mr[i]->start <= addr && txq->mp2mr[i]->end >= addr) { assert(txq->mp2mr[i]->lkey != (uint32_t)-1); - assert(rte_cpu_to_be_32(txq->mp2mr[i]->mr->lkey) == - txq->mp2mr[i]->lkey); txq->mr_cache_idx = i; return txq->mp2mr[i]->lkey; }