From patchwork Mon May 23 05:53:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Panu Matilainen X-Patchwork-Id: 12936 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 0868E68FC; Mon, 23 May 2016 07:53:41 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B11CA68F6 for ; Mon, 23 May 2016 07:53:39 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A0D763B721; Mon, 23 May 2016 05:53:38 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org.com (vpn1-6-59.ams2.redhat.com [10.36.6.59]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4N5rbYQ030683; Mon, 23 May 2016 01:53:37 -0400 From: Panu Matilainen To: dev@dpdk.org Cc: thomas.monjalon@6wind.com Date: Mon, 23 May 2016 08:53:33 +0300 Message-Id: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 23 May 2016 05:53:38 +0000 (UTC) Subject: [dpdk-dev] [PATCH] mk: Fix cruft getting installed by "make install" with tar >= 1.29 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --exclude became a positional option in tar 1.29, breaking the test app filtering in "make install", causing .map files and all test apps to get installed in bindir. Adjust the tar arguments accordingly, this is compatible with older versions too since they do not care about the order. Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1337864 Signed-off-by: Panu Matilainen --- mk/rte.sdkinstall.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index 68e56b6..abdab0f 100644 --- a/mk/rte.sdkinstall.mk +++ b/mk/rte.sdkinstall.mk @@ -116,9 +116,9 @@ install-runtime: $(Q)$(call rte_mkdir, $(DESTDIR)$(libdir)) $(Q)cp -a $O/lib/* $(DESTDIR)$(libdir) $(Q)$(call rte_mkdir, $(DESTDIR)$(bindir)) - $(Q)tar -cf - -C $O app --exclude 'app/*.map' \ + $(Q)tar -cf - -C $O --exclude 'app/*.map' \ --exclude 'app/cmdline*' --exclude app/test \ - --exclude app/testacl --exclude app/testpipeline | \ + --exclude app/testacl --exclude app/testpipeline app | \ tar -xf - -C $(DESTDIR)$(bindir) --strip-components=1 \ --keep-newer-files --warning=no-ignore-newer $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir))