From patchwork Thu May 3 07:59:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 39281 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 352EB2BA3; Thu, 3 May 2018 09:59:56 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0063.outbound.protection.outlook.com [104.47.0.63]) by dpdk.org (Postfix) with ESMTP id 4EDF21D7 for ; Thu, 3 May 2018 09:59:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uXA5sAZ7fHAiIBBXWr6uI8xymbrx7EiqXdXhMxh+D7M=; b=WHJdpEYEvRNZHAn6vgIx2XroQ2T1q7k9mXp2IbdxWy44uBiMmTnVN7chIjyCd91EfxXgoK47dczhgpmicqQBWAKzMdeHWRbxK6MFkR8eWJfWW3NLNi+Ea1KIZGKrP6ZLOL1VoPJGf0/EoZOZPf/6sUVP4wNfbUEa3RrK8EJ8jVc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB7PR05MB4427.eurprd05.prod.outlook.com (2603:10a6:5:1b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.23; Thu, 3 May 2018 07:59:52 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org Date: Thu, 3 May 2018 10:59:36 +0300 Message-Id: X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180501111806.112319-1-shahafs@mellanox.com> References: <20180501111806.112319-1-shahafs@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: CWLP265CA0040.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:11::28) To DB7PR05MB4427.eurprd05.prod.outlook.com (2603:10a6:5:1b::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4427; X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4427; 3:DRHMEBGWhhY132RBpw4hYUIEgHMUdBX7G+TCfAM4JUFcGCNO7wJoFiUD93GXid1MKXnWEJovxu+GlAtVyJRcGRDDKr9QhyvKV+6rnIrAu4Y2RdTrT2zLiF28BFBjbM3fdY2hX2OGLLnrW5kSpjA/Anp350PPXs0uWHRFlcwvuOE/zomeXw18yiS1K6gJFVMGL7/2GqLcuqKc+Dv7w0FuasxgW24Ehsk10FkigEqPvx7+o2yt2fxUDvyL7QNvaMUn; 25:1ezw4eJGKqckDap61wf6unDiutG607LHR3t7QFepfWLaQ2sIqxEs2GxbXyTXOuiXzvI0GLV1q3Rfu8nn7rYQVjdYNrJSfNOePrp5RVGTq0YtC8F6H8bxW+2brCblsfCzICwbvehUbPrx4oxZiVLQlShBLbHciCoo5kkq9ujOfxpEB3m+Pc3+FFPeVU7MJ86KhUFet+RoTKexw0xuRsAk/8ctVIx5BiaDPPHH8dUymfPzqnv6v7fNxMrRGOi+4g/y0J4iqvJt/MZzWI+1EtRF/B6jpyuYqF4S+hxqYhIdsaXr4vzWjeL3c6pPCbhWY/8lAZyeqMmuT8j+Zha01rGcFw==; 31:mryV3d0doMuFFUfk9Pcaiz30bYiVvCB4JlTgOSHi0PeUVm3Kn5h1U+730C5Y8zlQ6h/70d+SSb6zlsW0mKX+wwQUNVo7WdG0QFSazrC9bxA2RDaF01W/h2jTdGosmgiDG9owC+83btSzJcEbqMPX/MBK62FGS4AV/KvqNMoYG+ca6UIxb92UC8n2O4cxjSf5h4C/1YbsuUBlh9gIBKY1ROeGJUXwHJglvoMLYzJctl4= X-MS-TrafficTypeDiagnostic: DB7PR05MB4427: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4427; 20:yzTYHG47Ktcq1Np8tYZSjt3cxjKbjbwEmB48ynuC68TlrYTWwepKGecFBuTXYkrE/Kf0ibdJpjfyIXX3mwXZpvGpv4/7pk2dBnCcq9cD1HrgOqSYjJ+0+fOJHu38GqPInKQslLtz4oESUPVj5uod8hQAHUxpVda87pcC+uqEZfBBHmb6fo/WWKO2ADsg73cxod08ndfu0D/iRby7Bz9agTEIDHhj/2LJl3XPWYZMfF/G14uXfv5wpUVYr/0IYDaaez8mn8wQJOD6oHUAdwxEA1eCvPI/KXAGmzo8H9R8fsyDFyvwyM+MEG+iFoxd8N9kDTCNIuEUEKT4uUl+aUVeygOkwH9gNUCqRX7izMJk6ZXcWTv4Cv2JRJnY8IBDtyiZ+0AVkcMvEF7hnxURb9K/sCWeulQquKPED/C6ygfsDLkt4R1/TKKBpQbyW8ljaoSJyDh7/3WhxUUf65XMShtSVNFLdLKubW4RQR/fzt1cJPF181eG20MeqM+u4H5BI1+k; 4:VKNfcSxZPi4P4d0gpHSt0ffU7ss5GxWe7FdYgpMMh22Nmo2UH3T4JQ5qKlAoypd7i8IZNs/Nr1f3/fD3c3ns5HcWW+dQY4ODQum8Cn/I84SbRNBHE24bhiuOikF3VgAI/W0yZGhiv/zqcPz4flQ8+YO7AV3jZgrD3eeBOkHXFG9DY79RdLF0UGvyqvv7HvlLM5qvdItzNIJqw5VZCZu4+z2jnL8fnCOd9L9K+bhnkdmKqNOSkx3MxGgGKi3YYiMEpGBlRUpCK31YhPBFiULuxQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:DB7PR05MB4427; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4427; X-Forefront-PRVS: 066153096A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(396003)(39380400002)(346002)(39860400002)(199004)(189003)(956004)(386003)(118296001)(305945005)(47776003)(16586007)(66066001)(16526019)(486006)(7736002)(5660300001)(26005)(476003)(52116002)(186003)(2616005)(25786009)(51416003)(76176011)(3846002)(81156014)(8676002)(6666003)(6636002)(7696005)(81166006)(59450400001)(36756003)(106356001)(97736004)(446003)(68736007)(55016002)(86362001)(48376002)(21086003)(50466002)(4326008)(2906002)(11346002)(53936002)(6116002)(105586002)(316002)(478600001)(50226002)(8936002)(69596002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4427; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR05MB4427; 23:Oa7FYEhwEpuhEr0C+gUaPA0hAwrkATDiFVL5BTw8X?= EU5dxtxn9BlwYepnM2WMTwx28QbANiouDDSXKV6oWv9S7CiXdxmj+UJyuQ46/M8NvZUVGdYvZ/Xua5lMoyTn2APg2eUql5wmvNCxuOd1KLBYKs1aB1s7yLSxkcgxKcpGwTBTSZJQe5RPzATdRWzmYIFm55fsHKpmonUdZTPwZ1Ir3VO6qxzg2Hk1KCQtdFXacAbUFR47IQYujWsfOAPSPsUoCcvAsgGcfPGW9ahYoKxtVu8rlH1vCRdspwDchedNf4DspvU42ZZw83fCCqdSRM7uXBowvXAquctpHslEnYn+zzk/8i/sTGQ/BBuyPQti+hUyj8BEC0Yyfkg2OA18R5k4K/fXw7TvWgzPFZM3pwX1Gu3qlvdj4411hXvJEkyJRR6ngaYq94FxIYtEA5EIH2y4aNSy1CUaYmeNrZmzHplnNs+jHtQgUIvMMxD2a1C3dXC9gi9WhS108rDQLwcAfpk/3gCWQrZnpnHhpGnoP3iFj/T75JY/6UbyMk9BGqSiAdgtJmLUd5rrTzfBKqi7dmeM3tfS1sSYcL+Tp/HeQscE+a5MDUxdkRKmtJAuLiVR99vrZOulasYIu4VJ/j6dQUxnv4SH1piAuEkUeaolkJFJAdZZISjnbx5Vp1eNaYKb5qqyYo999iduPQVOw8P9lHPiFxzqxUrVWIc/wTHV/XxFt9fgm48DyAap+ICdWoc/12B43nSvCB66hQ9EUp6zTmDVLgbzWWyX7BtDPeDZxGJoOnK3LshYb81iLolU477gPOZEGq9NiAkQNk/vEv+etunLBsdK8LgxlooSesqonQ+S3Lc5zEnWBY5RBT66PJg/dEpcPACNP5Q8uEHvQaNH/K97T4CdRVdu+kARVqBgaGlOaysuhTGIj3WN0/RoCFDrZyQGJZXapRNjEimmIvl6k1g6It7QJze+v3nAG4nq0/BK6mN3JguIEo8A19BufwrwctNWH3oruEeBJHVtGQ6VeyCxVRX27ZV+nz8e70h0KCJkG5v0NcgLZ1NtyOiScckvl/EkBXdcNg924TAtm191/1Kjq+KtBWfOXTXbhrfmnZ435wQrP/yIsKuwZiprZeyG9bPwFtcgAudOD6WBBMxjVwm0cXKmNB4FnD8VnD+IZYnRsUL6dpkCTigwQrm42N12tTwdgFC05Tl/8AhiRnSiAHX6QfZ/FiHlTLSNTDze2SG/qypmzk8NcauoDRpDOZYvbw= X-Microsoft-Antispam-Message-Info: hmVXlS7B4105GQi/ICgxt+KB/7VOEMC0NCQgz4C/HI7WvMwLHJW18sj4zbJpaD8IyxFmWWQyUV+inqCqA5arpSTNdHzJblNP9lGCaMCiBWm6u+ViccihaJAaVMatmCx6SgR3lniyzzroPlMYqa+Y1aMCH2OytekcBaiTCBXQ8//OqmRGYF85ZIwkNRwiLrd2 X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4427; 6:3g9BnAUkwOAYrR3PoUHBRwyMmzmrwuw6a1/5DdORt77IWv7jrVFccSoKNY7eZp+RjB2aJM44baowTbprjU6889//zFNV2S4oBSHMJE3f17/8uP0FptYpFlHx3q2hV0XzOUPK1aIZy9q8/6mfHMSCXhk/tz4hqHVgUooBsOwdNvHnipQZJIvYLTeijEqCwi62bKxug4/P6mGIrDGY4Xs7QfC4REruLhHjP08491TfDwG1JLUe19YuT1GJYtilkoWo48cpmdx5vK+ggay2INAUM1KEh4y8t8ufrcnHfP2XZFjxuCdHd8D2bo8dQ8uohDyH7onkplv4yHBXeB2Rdt+tTylPx2zWs1uZpBpa+8gvYxHcZeNPMySmQ3pIr9jfUlqBtpdODUBSmckUK3PigT2j51GvRkjeMIn3nEUyTqlP3dfu/hGOKlI9pdGWrJjXFdiIIZw/NbHs6XZjKJ5ysyBL9g==; 5:U74ebE/W1VU6B3VR1TVtmljzQBq8VLsm64a1rJcehGYy5s7l9u/sdB5qseiT2toCNXVvAEm9ooPzy0ZFdsm5UD5YN79rOaviDhk81BMy8R1A73LSYLKZACO7YcwGaoeFp7paxtBKc9pUli6E6CMhF8UDMW5wmEkiQIM8OIRuwM4=; 24:Z90gr1PF207eD1dAMvQaQbyQX4gv6A/P/SrMaNlovmPUvFREG6CkoaxcSw74xhhPhpC3iVzyZSzd4IFR64C6FpDr5Om4XCPJNYED3veY1vM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4427; 7:4DFADjaS0LTPvhDH7aRJxV73hnuOMvN5nyW7EcyxV8gvlZLFlrYw3wcq7ixNUPqPGXfH7kobiJ7SanyFoLjheB4yAY8m05T5H8MYjPX6YKRZpSOCw+WR/KdQqjhxLmp9IMMbEZK5Ju5ov/W+UAl0xXfciUr+nfx0jN78qVyqOTdHktxZdtC8GTxlDXyoAE2UgXBxlXSj5M1jXehSNii+F2mB8YM/ydt6z9J+YsVUleQHgeP1MA9zgz9y8YcHCen1 X-MS-Office365-Filtering-Correlation-Id: c1e55427-b1ef-40b0-fa1b-08d5b0cbda59 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2018 07:59:52.5972 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1e55427-b1ef-40b0-fa1b-08d5b0cbda59 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4427 Subject: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix socket connection return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Upon success, mlx5_socket_connect should return the fd descriptor of the primary process Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") Signed-off-by: Yongseok Koh Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- On v2: - No change. --- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5_socket.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 8f983061a0..46cb370a29 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -804,7 +804,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, goto error; /* Receive command fd from primary process */ err = mlx5_socket_connect(eth_dev); - if (err) + if (err < 0) goto error; /* Remap UAR for Tx queues. */ err = mlx5_tx_uar_remap(eth_dev, err); diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c index e12c4cb2e1..99297d5c43 100644 --- a/drivers/net/mlx5/mlx5_socket.c +++ b/drivers/net/mlx5/mlx5_socket.c @@ -294,7 +294,7 @@ mlx5_socket_connect(struct rte_eth_dev *dev) } ret = *fd; close(socket_fd); - return 0; + return ret; error: if (socket_fd != -1) close(socket_fd);