[v3,4/4] vfio: add errno on unsupported platforms
Checks
Commit Message
Currently, when code is running on FreeBSD or Windows,, there is no way
to distinguish between a geniune error and a "VFIO is unsupported"
error. Fix the dummy implementations to also set the rte_errno flag.
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Chenbo Xia <chenbo.xia@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/eal/freebsd/eal.c | 13 +++++++++++++
lib/eal/windows/eal.c | 2 ++
2 files changed, 15 insertions(+)
Comments
On Thu, Oct 28, 2021 at 4:15 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> Currently, when code is running on FreeBSD or Windows,, there is no way
> to distinguish between a geniune error and a "VFIO is unsupported"
> error. Fix the dummy implementations to also set the rte_errno flag.
>
> Cc: stable@dpdk.org
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: Chenbo Xia <chenbo.xia@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Added (what I hope are correct) Fixes: line in patches 2, 3 and 4.
Series applied, thanks.
@@ -1005,6 +1005,7 @@ int rte_vfio_setup_device(__rte_unused const char *sysfs_base,
__rte_unused int *vfio_dev_fd,
__rte_unused struct vfio_device_info *device_info)
{
+ rte_errno = ENOTSUP;
return -1;
}
@@ -1012,11 +1013,13 @@ int rte_vfio_release_device(__rte_unused const char *sysfs_base,
__rte_unused const char *dev_addr,
__rte_unused int fd)
{
+ rte_errno = ENOTSUP;
return -1;
}
int rte_vfio_enable(__rte_unused const char *modname)
{
+ rte_errno = ENOTSUP;
return -1;
}
@@ -1032,6 +1035,7 @@ int rte_vfio_noiommu_is_enabled(void)
int rte_vfio_clear_group(__rte_unused int vfio_group_fd)
{
+ rte_errno = ENOTSUP;
return -1;
}
@@ -1040,30 +1044,35 @@ rte_vfio_get_group_num(__rte_unused const char *sysfs_base,
__rte_unused const char *dev_addr,
__rte_unused int *iommu_group_num)
{
+ rte_errno = ENOTSUP;
return -1;
}
int
rte_vfio_get_container_fd(void)
{
+ rte_errno = ENOTSUP;
return -1;
}
int
rte_vfio_get_group_fd(__rte_unused int iommu_group_num)
{
+ rte_errno = ENOTSUP;
return -1;
}
int
rte_vfio_container_create(void)
{
+ rte_errno = ENOTSUP;
return -1;
}
int
rte_vfio_container_destroy(__rte_unused int container_fd)
{
+ rte_errno = ENOTSUP;
return -1;
}
@@ -1071,6 +1080,7 @@ int
rte_vfio_container_group_bind(__rte_unused int container_fd,
__rte_unused int iommu_group_num)
{
+ rte_errno = ENOTSUP;
return -1;
}
@@ -1078,6 +1088,7 @@ int
rte_vfio_container_group_unbind(__rte_unused int container_fd,
__rte_unused int iommu_group_num)
{
+ rte_errno = ENOTSUP;
return -1;
}
@@ -1087,6 +1098,7 @@ rte_vfio_container_dma_map(__rte_unused int container_fd,
__rte_unused uint64_t iova,
__rte_unused uint64_t len)
{
+ rte_errno = ENOTSUP;
return -1;
}
@@ -1096,5 +1108,6 @@ rte_vfio_container_dma_unmap(__rte_unused int container_fd,
__rte_unused uint64_t iova,
__rte_unused uint64_t len)
{
+ rte_errno = ENOTSUP;
return -1;
}
@@ -481,6 +481,7 @@ rte_vfio_container_dma_map(__rte_unused int container_fd,
__rte_unused uint64_t iova,
__rte_unused uint64_t len)
{
+ rte_errno = ENOTSUP;
return -1;
}
@@ -490,6 +491,7 @@ rte_vfio_container_dma_unmap(__rte_unused int container_fd,
__rte_unused uint64_t iova,
__rte_unused uint64_t len)
{
+ rte_errno = ENOTSUP;
return -1;
}