From patchwork Wed Mar 4 06:17:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Panu Matilainen X-Patchwork-Id: 3843 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id B07B15683; Wed, 4 Mar 2015 07:18:06 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7FBF611C5 for ; Wed, 4 Mar 2015 07:18:05 +0100 (CET) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t246I4i0029624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 4 Mar 2015 01:18:04 -0500 Received: from localhost.localdomain.com (vpn1-4-127.ams2.redhat.com [10.36.4.127]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t246I3dw023310 for ; Wed, 4 Mar 2015 01:18:03 -0500 From: Panu Matilainen To: dev@dpdk.org Date: Wed, 4 Mar 2015 08:17:52 +0200 Message-Id: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Subject: [dpdk-dev] [PATCH] config: default to shared library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" With symbol versioning its vital that developers test their code in shared library mode, otherwise we'll be playing "add the forgotten symbol export" from here to eternity. By defaulting to shared we should catch more of these cases early, but without taking away anybodys ability to build static. Signed-off-by: Panu Matilainen Acked-by: Neil Horman --- config/common_bsdapp | 2 +- config/common_linuxapp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index 8ff4dc2..76b97be 100644 --- a/config/common_bsdapp +++ b/config/common_bsdapp @@ -76,7 +76,7 @@ CONFIG_RTE_FORCE_INTRINSICS=n # # Compile to share library # -CONFIG_RTE_BUILD_SHARED_LIB=n +CONFIG_RTE_BUILD_SHARED_LIB=y # # Combine to one single library diff --git a/config/common_linuxapp b/config/common_linuxapp index 97f1c9e..1852951 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -76,7 +76,7 @@ CONFIG_RTE_FORCE_INTRINSICS=n # # Compile to share library # -CONFIG_RTE_BUILD_SHARED_LIB=n +CONFIG_RTE_BUILD_SHARED_LIB=y # # Combine to one single library