From patchwork Thu Jan 25 16:17:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 34480 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26DE51B161; Thu, 25 Jan 2018 17:18:44 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0079.outbound.protection.outlook.com [104.47.1.79]) by dpdk.org (Postfix) with ESMTP id 020721B015; Thu, 25 Jan 2018 17:18:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UGHiPAnmfWsb3WV7avWAaIm6EGiMov7mubvzOdp+IZ8=; b=jGgXT6nYPh6TtofkhLrAIS03FdjQPPDbl1HldUPatpV/1ItFootR79IoTnZ/zrtnu7wh3VDiJyE8+HhFclsSxcExZxwMTErzOptsTR3ZHFKkYF+Fx7cNif8bHCSor5QleIA9PW57hRqzSG9hB6EOCRySMLVJut0081XkeNWjJTY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB6PR05MB3143.eurprd05.prod.outlook.com (2603:10a6:6:1a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 25 Jan 2018 16:18:38 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org, stable@dpdk.org, Xueming Li Date: Thu, 25 Jan 2018 18:17:58 +0200 Message-Id: X-Mailer: git-send-email 2.12.0 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: DB6PR0301CA0051.eurprd03.prod.outlook.com (2603:10a6:4:54::19) To DB6PR05MB3143.eurprd05.prod.outlook.com (2603:10a6:6:1a::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2cf3647e-73f1-4aa6-e7b6-08d5640f4b6c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB6PR05MB3143; X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 3:WUJMJSIJNcCr6f4NywPT7FX5Vyi2R9hvOuAbP0oNXuIpyCJf7a4QnoXfeY1+iXXNBIjHUH4SornN/h4XuYZWrHoBvVUttIYRKEPCLsB6NRFn4f0L25JA56kTsmAi53NnGDeNyXZ5CXBbbqHz1lSPR4qIYhOl3knGGICkWKFQ8hy/BvdoS3Z9SzQAEzwqn2kJauGj6p6046tUOVhuGDoQgEbNvWewYP8luQfVIpLyONOP+WaRV7c+flVDb9OaQ6PC; 25:nwLiDIU7ngju7olfF+Jj0Zijc/wmTWdg0eL/JwcoPBWCn89+OGsQF/j7hlBwPsX3/Pu0dan8yVvXiMQn0Ovl+cYS9l7CRD5FkSTpe48eMUBjIEWvBqhy8m/QD61A97XqDk6fts0Q1wZOJbR3SC/OhjTseCv5JILyjtbTid+ItnSmm2UwuFzG5rpbXy5iawluABLP7kj/8J7nNPdnHKvzz9S0bCx8GE0kvCgHPPzRUl4B23WhtsHe8MC2SSKzHQ0t3pIIQZRxiMYobC/SHzN5fXC4uxl7VTKlOduur38v0MSa38Jf7irF151k0RFEtvWIIjtRDDR5pPC8jtr6SWT/vg==; 31:tMviJR4ZNdTPYqMvpcG4V2RfS4sbzKD1aB+26xWwxTKhYHdk4YlkG4Rfxo+meYvCYruiovs0YHzog9xojm0kgzg0pMiqVzNkFMxrF6fAjbMHW0DFKZWd1jZMVPfWOa5As+La/UN1NGB9nEP70Jh0eZRsnm66a0JSsEXDerjF+/9P8w/6GGFP6mMriXNsYOJkvgKOHBcRLVctrbVKMW216cqHonQU/lLom9ps/VDu9wk= X-MS-TrafficTypeDiagnostic: DB6PR05MB3143: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 20:HWpaskRLZz9cXzxWvWu49AEcGhM80xmzhVj0CDqm2+NS9RKJnVNw7MOXe8HMcAswdjDBp8qTqWN6xP73qP07DrxX6vPUFfLcHFSaV0TBiJ0FVZZIFI1zJyfpXEhmv7Ja+HiRZ9GJOfOfIJ3WPuadAB6lyw1D6Nv+oG8L0ATptAdUsCFNATO1pUV6jYwf4i8LoAM276HEREWmdYlx8pO329mMUIgZjtCsixAsDtqUPU/2T2XqYMhbi2PgaGa0FaZwB/+PBpJhwsHeLvUvSe0y4Kk9Qep1TvmLucgs3/3ccmQRGwu+vtbSecsSvfMLH8FnhhrvhIKby3qcvEHmpdNS718oIeFQCmBp943PVn0AGj2EN6eBhX8yPDpqbGuVbQvUwIUk5Ft/WsYd0v9wuTnLp/9POwX3NIqC6Xj8vHAcW5e+rKIqz52mLxlFAXM1oL1JXl1fsHg1DvgX3mVcEaMh0Dk6m0zsPv1m4HN5hD0yww7vP1/kcrEvdYqVYShvSLTI; 4:3c72LOWj5F/j96VstU67SF0F8aLxHm+apAZvx5bgOS6mGUuZVwFu19v8oo6nf83fAbPSHWSCpNpQ3ByEmhimIZAszKunm6cJz/NQy+8ciFQ+lpmlQQcClUNZEz714Qx+Hda4/4kZbZ/clKHJoeX5Pr+QJTUyzTdZhZM8wBYA+RFwrYkZapMtB76OT9pS5YqGBQ1qzWLKI+h5dxwQ7XO7jZ0DgVz2mgc0Fzyv3rk4iTFJNi9pFUToD3uLrEdlkn1m5MrKOAizWtKLPzCW/+Z2gw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231023)(2400081)(944501161)(10201501046)(3002001)(6055026)(6041288)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB6PR05MB3143; BCL:0; PCL:0; RULEID:; SRVR:DB6PR05MB3143; X-Forefront-PRVS: 0563F2E8B7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(346002)(39380400002)(366004)(189003)(199004)(53936002)(478600001)(21086003)(4326008)(107886003)(6636002)(6666003)(47776003)(25786009)(55016002)(106356001)(69596002)(86362001)(36756003)(2906002)(66066001)(8676002)(16526018)(16586007)(81156014)(575784001)(81166006)(8936002)(3846002)(105586002)(48376002)(50466002)(26005)(316002)(68736007)(6116002)(51416003)(7696005)(118296001)(76176011)(5660300001)(7736002)(305945005)(97736004)(52116002)(59450400001)(386003)(2950100002)(186003)(50226002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR05MB3143; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR05MB3143; 23:kgVJ5AythElAZJyxdNOAG71wDbjv+DBFLyTntmloe?= xvRGzFwD4rjffS87OJsbvGmNsNsPvXdpLK1gU5/Kl0eAj6K11ttYn24cqDKoKViHdOGxNbS0mFcI4ylQg6i8DFMNi7msS4r9y9ue8x6VpXr5BuA3dDkYG24EYhuRzMMEN8gG+lfRNITnUr8RXzlX1mcIM4ZMXDPrZ5iI+5kaUgzV3YMb0aBQbQwQEyaR6G9PwG6QUlLo8lrGUtKfs5NL09YYiIu9Ly4Y0yzVdH/ZiU4aEpiU6JOoJT3lJDmKnlu5wRpiwtJTWmL42bGzRJEhQJkuh5e1DlS+2Piyt8ZlsWAlbe67Dc2fZcB3BJJcjmPdwT8p4WMfkuyqbB2YXMRDFJlCw8vgLyyPdssgCGRr6q2J+SK0ou0D/F8pwEJe9hffBHeTNzs30U1XeNHhj2KKqvyeuBS7u64AcLrhqwqBbDlXZmswKh+d70xhqP+x3u1BFxDJEhhIyVvnPE3VUqVXnnZs0N6A073L3BKVkYXeMT+nLDQyTQhGDYk8FsrbBKY459tHc94ilkY1vUK1OiKPiiGfpimCFK85oPS1PrTwxu3ieerAKBc4SMLAml086N226X0+VZTwgA4u5gqYciGa2Bg9ruDZ2IzeJyWED2TLvGu3VO9dYmgjNTVR03tgjaKjLaWJQ+TuU03VsksUrw0t53gwLASkp3KmIMln8PEHLdUPaQG84EUJ109LQI0DGtzIEtGUxnUvJQy9W2nSF7/X2wVNsVKOQ/jhlE+kh3mnmQd24vYapb65hZWKFNSCyJk/ybEIx/ieqvEsdiLQRfEwTIvSrfes5S4mSDiSYYpqq1KbstyEJoPX0UHZVI85+8kNUEADNHsfDpc3LjJETTU/50GFR3Mi/d5b9P3Yc0VA/LNmOOn3GmC9jrojTxWX6kEjtJI7gF76r9hgOMeV/wZsArRZM9V6IUSkP1SNXhgkZyCTmmbm73IWZDxRfHxnjs2BGBJGKIxbYbqQ+cWtCD1WJS2TkUs4L4R6cAYN8U0kejhBtwjmsPIZRV7LIYq+EhsN67frU5PbmHRF9an/SGp3bW7mgYpcmqdz7n6THIdowLDIycV0cXjbS2HqK2bv7uAlU0qH7Fs6N7Zd6/Di9UrBwVI3w7cC9GAMqzdIsJ7VOZKsP2uao94IIzALcYZ6mejqQfs8VJKH3wjIbsNmdV6zlZtz5tDDkl63NyicsWTywUmEA== X-Microsoft-Exchange-Diagnostics: 1; DB6PR05MB3143; 6:GhHr9o1yITOV7oBEZk1CAuM2isueQrSJ/j7TcOxx1nxz74yMbfg37qDfMGqmt8fV3fl28mmzViP2psjIDNSHGGx2fnJOCa8pWTgUSSd3n+27m6eQ74pSzdlG/mp/IPtjJFuoqIbOkdBodiFdj8b/gSRiQqCfrKfOA6IICSTOmrsD2bN3Qn2vEAKbwB6nUHjoCAO7yY55+Zy8GgCQhaa5Bxx8ZHzb7VnJ8+0GV6m8NK3ZQnPv6Jzb3r3lAWR43MKYiy19427mEABWljCbPFNHP6J5KVRD6lrRCMkwqgDQhySrphZuQ8bL2RBHnRoH4K0upbCh4JF2cH7cOF2uVdIWTfYZkgLgfsaikP56Hbrks6s=; 5:9GbXBRlXmVulgIJ2SCQz7P8px3Asny+BO7wy4TG8St2lx1qvPeFqVEovEL2p1LDRu/sXaVo6qD0FtRQjkBNQieQEvgfI+STKQnwbigHC4nS+MuhhyrGTd7A9HRK66s2jxbCVbk5JIl5Xpt6aLMXkthP4vt1Ayv30Ae2I9JO1gnw=; 24:M+KPUxUbgjBG67K1Hp60g0KdI/h2GAp7PGNnahT/RfyVt3BzEuLw0ZEg2TScQp/pBxL9QbyUsUaVF/i0goHOJXcB2FxOHMl/tshg5RNBaEM=; 7:MMHR3SOPPx3rJS/zSxPLfGYT1ru5uSgd3AZqgYaimdldDDXZEKFbte3H9CR0RHLq4hx2K0bZld9silHzHgc/ZCyAIDsy6Ha+6izD1+0L94AiCQpRfF84t6kQNMBVPlTTLHXJAXPaEH0gx+CZ6wzNDZF1vKsA7BxOIXpZA+qaVXjMg2pNLDHbsbBeMQUHYAGXGYgsCiUtUm5qx6LqZPwc7/gby0kfcoYzrduKoUn4ulMGiSGYf8yP0UbKfFHg78b9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2018 16:18:38.8946 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cf3647e-73f1-4aa6-e7b6-08d5640f4b6c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3143 Subject: [dpdk-dev] [PATCH v2 1/6] net/mlx5: fix Memory Region cache lookup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The Memory Region (MR) cache contains pointers to mlx5_mr. The MR cache indexes are filled when a new MR is created. As it is possible for MR to be created on the flight, an extra validation must be added to avoid segmentation fault. Fixes: b0b093845793 ("net/mlx5: use buffer address for LKEY search") Cc: stable@dpdk.org Signed-off-by: Xueming Li Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index 2eb2f0506..a63364d79 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -555,7 +555,8 @@ mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb) if (likely(txq->mp2mr[i]->start <= addr && txq->mp2mr[i]->end >= addr)) return txq->mp2mr[i]->lkey; for (i = 0; (i != RTE_DIM(txq->mp2mr)); ++i) { - if (unlikely(txq->mp2mr[i]->mr == NULL)) { + if (unlikely(txq->mp2mr[i] == NULL || + txq->mp2mr[i]->mr == NULL)) { /* Unknown MP, add a new MR for it. */ break; }