From patchwork Fri Jul 7 00:09:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ga=C3=ABtan_Rivet?= X-Patchwork-Id: 26592 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 147957CB9; Fri, 7 Jul 2017 02:10:18 +0200 (CEST) Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 6D090567E for ; Fri, 7 Jul 2017 02:10:02 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id 77so24324040wrb.1 for ; Thu, 06 Jul 2017 17:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=XpocGuO7DKMvDBpGzaICe7BH7j2K5C/Q7tCLsZZx87o=; b=T1GRHwYpcauvY6yXkbSD4V6P9LXDmdvIxIq7qJMBiLUsc4iufSGxLNKyGcRBQ5ENcV b/48lFNCHJXN9Auzgcva2P+m2lTQjkK30JMJfDXRStKSnllGDKpGRYzflpmwz86duVu3 FYKrg2CSBWkryjpj7d9E4vobn8uZHstE+E8wrA4P9I1c8IlCar/QKPEUrvzoiYsrUGmE lfkdQqonsZpf6IaFGM40onqrkWObRyRqRTRVyK9sR/2nbWCg2hXyW256hcr9ZhueNLwQ pLnY9pwhJxcGJ5lvTGJ8Lcvx1iYcnZ4lzS0C6w1SbAHVcwTSPh6hBuRH5ttwS5FDi2Rm 5OAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=XpocGuO7DKMvDBpGzaICe7BH7j2K5C/Q7tCLsZZx87o=; b=RhheJVQRxzdugG4PFRNCDsVKHm4ETD6dPfpQChZmyooKHgqKltftpICZRdeJbVKUs/ tprxONLEEjOtKslEuaNGGcmAYr7msOvXlsq5PM3KOgfp3c9uhaZLo26xBQyHXGdcbZ7f eNlr7WzTLixwXMhe8cLnaTx/41GEyVJclGZs0Vo0Z/redSnxSNuPTINLioXBfelVajBg xaCSCiJfPHCAuwocJy/9dvW2mmD1Eyvmc6NhrTY4wUVFjl6Gy8M/dMsEGebKAtrTTRGM Y39v/DbUOhgdGt7JZDVmjbl6KPs+464IdDGiNisc0itkAPADzXZ9HQ0Rl0pRLn9WN4IH YFPg== X-Gm-Message-State: AIVw113dVTrA0yl7zY+2fs6DQLt1dmbZ0GQsEBKOa1zRqJm8/59pvlfT VvMZ1ikex+H5yIjlH6s= X-Received: by 10.28.107.131 with SMTP id a3mr280428wmi.60.1499386201921; Thu, 06 Jul 2017 17:10:01 -0700 (PDT) Received: from bidouze.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f45sm2391166wrf.2.2017.07.06.17.10.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Jul 2017 17:10:01 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet , stable@dpdk.org Date: Fri, 7 Jul 2017 02:09:13 +0200 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v6 06/22] pci: fix generic driver pointer on probe error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The field is set but never resetted on error. Fixes: 7917d5f5ea46 ("pci: initialize generic driver pointer") Cc: stable@dpdk.org Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index ab01749..fbdc356 100644 --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_eal/common/eal_common_pci.c @@ -237,6 +237,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, ret = dr->probe(dr, dev); if (ret) { dev->driver = NULL; + dev->device.driver = NULL; if ((dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) && /* Don't unmap if device is unsupported and * driver needs mapped resources.