From patchwork Sun Aug 27 06:47:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 28026 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 77EFD7CE4; Sun, 27 Aug 2017 08:47:21 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0062.outbound.protection.outlook.com [104.47.2.62]) by dpdk.org (Postfix) with ESMTP id 326167CC4 for ; Sun, 27 Aug 2017 08:47:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qrVufg8aKZMSQOcc0I8McXxuwv5AaB9Y5NBIBdyFvQY=; b=TXM1lPeDfuRQHCwQC1QEE4jr7AoUDnS+OnnkOpSpN7hLgDkrouWJBsYSRpEWKJbo5aZjRuFVzNJqC/LI43q3rtJ5odnriTAPOf6aB4kUFjBqHuRRO/EtNAuxsHu51lWJ8fzwTrSCkihHksbyzIY764CB0B1oozA5rhs/U938cSk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by AM4PR05MB3137.eurprd05.prod.outlook.com (2603:10a6:205:3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Sun, 27 Aug 2017 06:47:14 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, Yongseok Koh , Alexander Solganik , Sagi Grimberg Date: Sun, 27 Aug 2017 09:47:08 +0300 Message-Id: X-Mailer: git-send-email 2.12.0 In-Reply-To: References: <1503301622-14220-1-git-send-email-sagi@grimberg.me> MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: AM5PR0502CA0023.eurprd05.prod.outlook.com (2603:10a6:203:91::33) To AM4PR05MB3137.eurprd05.prod.outlook.com (2603:10a6:205:3::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d66dff7-e3ee-4a91-dca8-08d4ed177424 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM4PR05MB3137; X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3137; 3:F3WHCZSA4vzE0VCDT4djM5AOPvvqDrEtdMJn/i6LK+TVYcDk9tckQhqstvQa2s/rbrSL1R92I69mA/2bE8WfnSTUH26HdZ2HytnvUzIbY8bryf1iMq7Ba4eN35owJVq8zQIb5eBhpyk1I8Qg9ny+g0cb3mMUEHLaxugAR3GFnAkPEdDpq8bTn7BxdlhQKdELLOilwIf0zzQDFxbCn+5HW7D/NKaXIv/uoVhKJ8r01x09ev+0/lLjp+TG/aJ5OgxP; 25:NgtQN3wpx1j0bBcvpJa5S+ZhSclklyg9CmjeaRqn9nd4hx//BOPEVjuMpHApP6j/PouUTyh9luYloE37i1GDTOSacjya+gwvX6enASC2U35cLAul7VG/li9oNrIRt9p6W2QxIpsN8iwaMo9jcS0Yu0WK/KNB4eD2HlRAK+u6DgKx4jcfKgBt6OGIuccZmo8eM6oJR3gBbq+goWmBCq4movWqgjYH5FZq+t5LvU9o6ta/wghPX2pZfhFxsDpO3C+q7CT3ny2wG1pfClyKcpKVdHSNvz/n5YlUrsratgeBP6PPjF9fyB4Xq+SBAvQp4hdZ9a9wya51qM6hukBvdh+u7g==; 31:5SkuLnbyXeGAOWy05xbtVVIrLhvLB4spE6VaPVh4TqysdpDDIK/8zlxthGD22azr7lxCGZHMXZ1FuBQ16fA42iP7AbA8hEXO99n9YrO6G/8xgGIY7RxYfWMhBXHcXSvO1PlUXSV8Cd3Zz0HY7ChDZeRfv1MNA2Yiy/d+VUhZe3Mgm9Ej0lTNO/s4X8j3qH0D5sAGtUHkwHjU9Sy/jB/3Q70x8kMmXWTS212ZN2vg0PU= X-MS-TrafficTypeDiagnostic: AM4PR05MB3137: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3137; 20:zbBbaaEhRXuFB5KEu6KKIP/d3trYjLqJC5NlIhjx++sUlihclRErH78xbRQBobqeseKV+nJh7CcvMukmu0IX7Vn1fTQWxzdYXI7CZaA4WaDrUwNLb/z6SMERwIoQAykqt8UHMHRAeOoeXPtty5leA7bRgj4vfBq7iWMz18NyiUMlheYZ8OQ+z9txJAmLXPnaSLVq/c+lVvN0Bx1k3swfo9OHvmtm1qFZO8I/k6UL3lvmy9FVWQ8MV2wO5PFh4DSPGb7VhOdAUwnz3Xr3YNXww2CYta1OC8mrf7bH5MCT5VE5EPYnzvLll2kFtkTR7T1WvHWZ0un4N50ObmDm/GWKqbcGWJYNfnn8Qo7IwM9LrLyM/rPnTtXdZfjxPcXkh9ycgyZhn5aCbCypZx0ggefHv89s91LFxO00d2FGss8WJvrtXmNVz4/xgqoyPW0l64U8RYE6c1nZ39DWPTHp3zvOPTvP4t5WxciMG/3BPWM/Km11miGK1iOEsgg1VQZgIkEq; 4:4CQeUbYlhS6hksL4dfg5aPTK/67b8DFog+gCsTC6IA3aWkOSIWj610MkNeD232UNEKzwWWD3QGpg5LLmz9+Og8XDSBP4d3uiWI/CJSYD+VL5zvjXD3BFThQ7FRPs7FkQQGnK/z6ev2j+POYkqpqTCDb6MIzLRWpijhQbjYFueIxOkPOeMy3T9fm1+HL0GtmQsmjKwMsKorQqNbDfgbeUwiLTjc0rTMQnnzpW+IIVJnVqOUbvujh3CyruBYOI2R8q4lmSMqGqMpKor8ZH6Oe3JmDrb1noIrfU1dfp8fJ+H6I= X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR05MB3137; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR05MB3137; X-Forefront-PRVS: 0412A98A59 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(39860400002)(189002)(199003)(33646002)(53936002)(21086003)(68736007)(25786009)(5003940100001)(189998001)(105586002)(97736004)(101416001)(33026002)(6116002)(54906002)(4326008)(3846002)(55016002)(478600001)(106356001)(110136004)(36756003)(48376002)(305945005)(50466002)(2906002)(6666003)(76176999)(2950100002)(50986999)(42186005)(8676002)(69596002)(50226002)(81166006)(5660300001)(47776003)(7350300001)(66066001)(86362001)(7736002)(118296001)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3137; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM4PR05MB3137; 23:evMDmGmq+Rsl+CrtrUMVCDLz6Y+kYK1jinDNxAvlv?= Vma+Mj5pIemy89LgLU3odlpksnpGiLs9+QyDyjhzmNekV22BgNyd8OqnKEHAl9ndTnM/mI5DV7QtH0koeGmRSqNU2B8i3e4l3d+0NhPay2vtGhti8ZiufUEWvvyiT7Cw17+IMYamuQ82p0k+RhRukK+00slnoYIimVGiuUxi4yEApcavC1jU/NMCwtGwEsPi8IffAPlEn4s7J6mfEdDUt/unF+k/btUpHhXaBaoUW5OsEJ3mjXHps9m4XLDUOh/gBuFmXZEy5mHRz/x5NBuHEcbYo7JNYhs7xDKXbvVdOT1Pyv/Eu5hiKNVenhBeLpPneoWmfgqg7+YryA4x+Jck2xueM5YfQXzhDWAc1zxizogS+0PUuUE0xFzPfZAby7CvYntz3+HWWzo6Yg4kXlGRwDgHluaTFfda8v/6fDpeFD1k6uwtxZA9VTa5XBf8i4huXafME1IsXgez2J+gbld5xRHxfX7qskIYZ5tzR2frULZ5Kh2I43J2d2Aw3V4n0idSkmaRCNXKzXna9Rj45Lgv12hDYNqrJ8FJ2cYyGz4AHtLN0A3gGGpMKCPSw72DGu2oSDCOZ+EywphUkQf2S4uYQKVvWMX+NtFI8XexY3EbtZCjaewn4ID5tZ0+4cChwCGQdDgST5HeCYHmnfwdVsvZsw6d3y3NOHMm+aJeCTUHDbdyJETll6sbz9YBrbrNaweV74Hydxx+hpCYBeSgt2mBaU/X/3++lg51onUNnxgqm5Swt3pu12xDOdU2OzvI9wrgL+ddjhgH8JZ5uMWjZDvDA/DAGQ4yZpib3mOKH9po9rDAX9FLSqLRtS+ncm5ailZOB0n8ST0/W+nb90ognUxTk9YmUh6gNpIcTeay1XAToOXPpRytzKMesuHyHPIytBqDI6vkTkfFz7dsCw09RGzHYVXBlMf2YYK9qTC3S2wtFwlZ3YMqXBmz3KnJTKrC6KvrWcId8XPQMhl+PBYgOjSAwZTBGcOxZ9E2QpukNfypZGpeeMa3cow6fVFKSfIVsoSdr19aBO+BGrawKZDPiWTQ3sJgKOimnSStlGRw6FufcOBCiUzqWGmRIX6we/H9LLAHEcROapw1TpCGm5Q/X2zkqBZDoDqgmPdzTaKv4Fd9bRYgA== X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3137; 6:btys/6TIG3PHBsU4IrWuF2T5EqK+okFgHR8pgOnCjDYXG5eMGgSkKEmgoQEZUArk/s250P0gM4ZDf0Zh4x2X4JS0dIrgVtU1bb9Qe3TiVZxb5I5w4yZxHJ2P+POR1IXVevQD04lU9RC+3B6DEJbwymMNe6vX7y9Y4V2lWv2RVwyZUmNLTutUZG4qSM9lqr8YQrffBL385qZxvP1yHCQT3+5QZHk+ACnGJ5MDTQvFddiIo280dlqtjXkLkG6a2eTdEJaYt1fOMwI3EYVdnksC+yL6JOCJB2ROLAZvlTDa/Zc2KlCx36QSV03HyNSm7Yq2bhrr0iAUz81xNm43kK0sOw==; 5:D4LyQMHHoffhbiE8QG9tZjN2Z1DFk7TtvdYFBh1R4nGkU+jdEqGTdlZS0g/cGgC7LBjeCcQHx4gnbmK4BR+j45USGuaw8ZdHRJEgcv/hcKMDlCmOoNrdypQyDgKdIH7PIlgKAYLbPIIcBuEKIX1ZiQ==; 24:9R1/3dOMqkv+aGLfRUYQyD9sPoH81yUgdoDdMUFCEMdr8Wwcj9hrCtlFQG88+eCUp/prfEB47w+BZ+4pACJ0/gTdQFohR5i5yJ+z+cLZeZk=; 7:QpQVAhQlROREBcrmEEAp7zPvRlm94vTaj3zDZ1DxFeaRR8XnvEs5dLsExoP+pdBZd7J2kvywLjuQ/bK9Bakfu/q0QTsqU/o6zWdSpRYJNjKRA2JlVa4YSDB3COeJTc2fLWG5ioHjQkp7dc/C1JJ4dGeCGvMiIN2aFwp27Sf6BfzhBJOZqgjzbTKIzwUzZ3bGKpnoc9eWBKShDGQJaKTDsPyYSd7LOToWzKEuktdbwCE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2017 06:47:14.8436 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3137 Subject: [dpdk-dev] [PATCH v2 1/2] net/mlx5: replace memory barrier type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The reason for the requirement of a barrier between the txq writes and the doorbell record writes is to avoid a case where the device reads the doorbell record's new value before the txq writes are flushed to memory. The current use of rte_wmb is not necessary, and can be replaced by rte_io_wmb which is more relaxed. Replacing the rte_wmb is also expected to improve the throughput. on v2: * replace compiler barrier with rte_io_wmb. Signed-off-by: Shahaf Shuler Signed-off-by: Yongseok Koh Signed-off-by: Alexander Solganik Signed-off-by: Sagi Grimberg Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index b3b161da5..e9895a9c0 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -591,7 +591,7 @@ mlx5_tx_dbrec(struct txq *txq, volatile struct mlx5_wqe *wqe) uint64_t *dst = (uint64_t *)((uintptr_t)txq->bf_reg); volatile uint64_t *src = ((volatile uint64_t *)wqe); - rte_wmb(); + rte_io_wmb(); *txq->qp_db = htonl(txq->wqe_ci); /* Ensure ordering between DB record and BF copy. */ rte_wmb();