From patchwork Fri Feb 26 16:20:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tengfei Zhang X-Patchwork-Id: 88266 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 287E5A034F; Fri, 26 Feb 2021 17:23:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C31C407FF; Fri, 26 Feb 2021 17:23:07 +0100 (CET) Received: from APC01-PU1-obe.outbound.protection.outlook.com (mail-oln040092254013.outbound.protection.outlook.com [40.92.254.13]) by mails.dpdk.org (Postfix) with ESMTP id 311CC40692 for ; Fri, 26 Feb 2021 17:23:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BVsR9DmydHZtRBr4KhNhJCd/BakgrBsmMZr60Sj7zOmliuEfXSxz6YkoGgrW/Eb/bNvpvXr4K+Cy0elRuBhAmyaeFS5Uaf/22c3E6LGia8EAJhtfrjF7Nja6ynYnAL9JIheh4VDoFGZyPd4xjN5HB36kF8bvj75Yn8cERJWMAk9/IdW6XlzJ+Fcp5oSNTSPHmqO3UJJ9R2J6DwWxtlKiRKswKgjIUmgp/9bp2Q9/bn6mjUyTgjaWOYPNPVgIEKQaFGn4w0In2v+CDi4KbEzEehAKP1bSmzhjjCWLliLgFpshkm88rnxn2GWMjHylEqSU4G7iEiF65xAqMgLU1U+scA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oLvxR6nZPe8FYOzsDlP8KB3gYg6t7Ocb0uyXpdywP7A=; b=FczuzS+uRgzPD2LTClBmCXVBVURVa9NNDrKFdsjEY05xHqZ2OEit//FzFTC6gfv7YMhY6+dvvQKM3YGsEVKQ3nYvMst1eXqHeTW1t6D0fCizl3fy8zeYwr9xekRKWzq8/XnDHCtEGbyMJhe1lznuk8G3D9Fn/l0TEs4p51b5CcPrwEZz2J/dmNJX1CCCW3yPzOpUl/xBqB3ywlB0RxzQaeO9mpMzbRGqc2BzWUhqdBHaGqV0kJvZTFaGC4vVPuSz3AdK5H3XoHDVsbRg9MC+GLXxVtgFME3elWuVOoBsmCk78hwYrwlKWCW5odfBhmueI/w2lY9XA89ZUhAZB+e8DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oLvxR6nZPe8FYOzsDlP8KB3gYg6t7Ocb0uyXpdywP7A=; b=TOzA6DFFVwisOm9JEbwzlPfy/5/jjsW5unp0MDhjC845F4kG6DPzivPO+e8cJPV9713bfkeAB5AEOjQ2zUiVHlYoeV0NuqtoJPbBmib9fLq1sIkvEUvoRODTvR55UDWuIVeLY34mxOCLsiS3uKJRnM/HuIGPEIoSCQq3LqtswmiHZ+Cwboqpeohco3ieQsSe3nv/rcVjzhgA/FOxSSrTKzxvlOZyBhkUgYvOlAoF6LkLZquPh0HzMQZv4clJfV1WUP7oXHUrklRmf8JPhfSKDDZ8c+itwmTtiuiEvnhGJEjlwRBh1PAizOhwt57jS2VqLUiwOTbOLFcPfYiTrNCKRw== Received: from HK2APC01FT130.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::52) by HK2APC01HT054.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::460) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Fri, 26 Feb 2021 16:23:04 +0000 Received: from ME3P282MB1668.AUSP282.PROD.OUTLOOK.COM (10.152.248.52) by HK2APC01FT130.mail.protection.outlook.com (10.152.248.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Fri, 26 Feb 2021 16:23:04 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:AED1B60DE4DB85D4DF9517E7927A5B2DC416348B131290C5906DE50AE4BB5E99; UpperCasedChecksum:07CA2D7B57FE40B01A4011E3D9B41E0CBBBB9C820F06B3E2E936014C3A04E016; SizeAsReceived:7288; Count:45 Received: from ME3P282MB1668.AUSP282.PROD.OUTLOOK.COM ([fe80::cde5:5660:e27b:a333]) by ME3P282MB1668.AUSP282.PROD.OUTLOOK.COM ([fe80::cde5:5660:e27b:a333%8]) with mapi id 15.20.3890.020; Fri, 26 Feb 2021 16:23:03 +0000 From: ZhangTengfei To: Ferruh Yigit Cc: dev@dpdk.org, ZhangTengfei Date: Sat, 27 Feb 2021 00:20:29 +0800 Message-ID: X-Mailer: git-send-email 2.26.2 X-TMN: [7mpf1RX0N3vsCzFYzg0BQxNSod3+Sj1V] X-ClientProxiedBy: HK2PR0302CA0013.apcprd03.prod.outlook.com (2603:1096:202::23) To ME3P282MB1668.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:a5::11) X-Microsoft-Original-Message-ID: <20210226162029.23081-1-zypscode@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (121.225.193.98) by HK2PR0302CA0013.apcprd03.prod.outlook.com (2603:1096:202::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.9 via Frontend Transport; Fri, 26 Feb 2021 16:23:01 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: c571141a-9c8c-4eb8-3267-08d8da72c9c7 X-MS-Exchange-SLBlob-MailProps: qY7UPrLqMbYVe8x1ROAjbsxq2yW8HLkIHL51ENyaXvxgJ8+qTazuSSylu69nb2td+2i9t3YbqTL+Y8sg7pPRlLJlnkDHIwPO5jrTCuRvW/kioZoDtuL/ogHR8S2iP/PsQML88RnDnOhhQhe+2A8DM/oRA90Qk2OV0/izJOiZXYpQuowRp9vlvfiseeh2zM2oTv7RYy5JCkZm+jlyD6e1KnLDJt1lNNzQF0GqPujPVY+6sT86E2K5AWKVcIdQu69j1Gdjh+oHpk4fn70KybAF6Zek8seCerMYmFenOzok5coCj5Hz6BKEFHhOeOxWl5zd0xlKN+088SFL1+n8vH1S5gBu54QMrAuIU/z/9HqtWVa4o+Io0wx60GU0ZWEy2i0yCBfm+LWOpZu2hNxFi0z87zQBKG4vcqwGZwNlO8cu7sZuZUZMV8XWsi2Mjec/oWIBoSjZ3wCW7kdU+WyyLShYyEfannUrrNNcEJ5IRj8fQ2K1nj7VLUX22sZLdQyIJdVtosGG2r3uF6gbdIAfv7OVn7nmg8Vi8bsMPRWWYtbPGFtfAnUd4yauy9MVwFZhDvaSm/iWsvy4mU2pSS3p5h2HIkJbdIiAvrqtyNYj6yekWXgT8nw1XihwSfAIJbn8XqhqE40EL7+PtzW/JSt48gqt1/Qcv4zbaa8U0ydsmQalcmwEGlBG4SAFZHunAQ6/41Mg5Ga+j6xQ0AeHa/0UsB6VXQ== X-MS-TrafficTypeDiagnostic: HK2APC01HT054: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NgtjUUmUkfsL7jRPOEwFNkSSlYOu8Gm07Nvrv72PRj3QUfSgphY0y2PJeJ6rAlTc5W5854ZjWI05hnBgCJcGLWw9ESaZ0z2zIeI4givZjeoY6VZnDQd1TCXXBD/06FhXQlVlZ2fR2wGllz5BKBsNSIusmgL6ISLJNidpYBut1oVoMQ/+2z1Vxyj1M1hwtEbif6slhtZnwjSGCwvSBGIVX8NLzyxjSTViVeNYAK73aWQJKxwOkiBki7vYSyGsF0xq9sYOjD8+uV38i5FPEOSAnXGTzm1WHqjAi1pGg0khWjjgpezuIaTRhq1d4tQsmWVo2lHWlw79Tk5MqRMRFOXGmIyCjpbMfPtBr3V90ot/7Oeq48GUbOLk4ZhIicaorlpd4tkg1eyGfUYOguPluWZIOg== X-MS-Exchange-AntiSpam-MessageData: MJmhJLuQO4igtFLjpCpJF2/mCncdF7MY/Od9GComdzuD9ZZJRZMHqGZkQiWkJsICyMVCEET/dO6J3cnAjROpKeiUqjSnJgoTtGJntL+ADjA4K9z0n2vgQpEs09CJWzQ0UDtrfI8xuZmBSiom7deMpw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c571141a-9c8c-4eb8-3267-08d8da72c9c7 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2021 16:23:03.8622 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HK2APC01FT130.eop-APC01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT054 Subject: [dpdk-dev] [PATCH] driver/net/pcap fix: pcap fd leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pcap fd was opend when vdev probed, but not closed when vdev removed. This bug appears in dpdk-pdump Signed-off-by: ZhangTengfei --- drivers/net/pcap/rte_eth_pcap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 90f5d75ea..fb01ea924 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -1597,6 +1597,7 @@ pmd_pcap_remove(struct rte_vdev_device *dev) if (eth_dev == NULL) return 0; /* port already released */ + eth_dev_stop(eth_dev); eth_dev_close(eth_dev); rte_eth_dev_release_port(eth_dev);