From patchwork Tue Sep 6 16:09:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre Pfister X-Patchwork-Id: 15624 X-Patchwork-Delegate: yuanhan.liu@linux.intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 828686A87; Tue, 6 Sep 2016 18:09:43 +0200 (CEST) Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id DF54C6932 for ; Tue, 6 Sep 2016 18:09:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1167; q=dns/txt; s=iport; t=1473178182; x=1474387782; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=B9pjG11oph9T1g4vJ5Oc7r+NrKcisjy+SCcxrAIwLhc=; b=iuYo99Nxx5yPJWlqy3tNSL0Gwpo03s2Rj+EsZM4Q2Ya/Zuy/aLg5rtNN jkscCDj21E+QiF1b+9lD62EwgKLLLCdX/bxk+ooAiwGZl4dk/jhiKyfHJ SkY/69df5i+FIEMocs3BLm33FBFVdx14v1JP81UzgIy7yRxB3MNCZIWs9 s=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DTAQBE6c5X/4cNJK1dGgEBAQECAQEBA?= =?us-ascii?q?YMtAQEBAQEegVMHjSeoeYIPggKGHAKBXDgUAQIBAQEBAQEBXhwLhGEBAQEEOj8?= =?us-ascii?q?QAgEIEQMBAh8QMh0IAgQOBYhKvDYBAQEBAQEBAQEBAQEBAQEBAQEBAQEchi+Be?= =?us-ascii?q?AiCToRAgy2CLwWZUwGPNY9ZjEyDeQEeNoRHcIVqfwEBAQ?= X-IronPort-AV: E=Sophos;i="5.30,292,1470700800"; d="scan'208,223";a="319281417" Received: from alln-core-2.cisco.com ([173.36.13.135]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 06 Sep 2016 16:09:40 +0000 Received: from XCH-ALN-016.cisco.com (xch-aln-016.cisco.com [173.36.7.26]) by alln-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id u86G9emf021254 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 6 Sep 2016 16:09:40 GMT Received: from xch-aln-017.cisco.com (173.36.7.27) by XCH-ALN-016.cisco.com (173.36.7.26) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 6 Sep 2016 11:09:40 -0500 Received: from xch-aln-017.cisco.com ([173.36.7.27]) by XCH-ALN-017.cisco.com ([173.36.7.27]) with mapi id 15.00.1210.000; Tue, 6 Sep 2016 11:09:40 -0500 From: "Pierre Pfister (ppfister)" To: "dev@dpdk.org" CC: Maxime Coquelin , Yuanhan Liu , Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v3] virtio: enable indirect descriptors feature Thread-Index: AQHSCFkSf5vkB2qTrUSqttmkbs7FlQ== Date: Tue, 6 Sep 2016 16:09:39 +0000 Message-ID: References: <516F65D3-4706-4CC5-916B-6ECD29CBE177@cisco.com> <20160905022028.GF30752@yliu-dev.sh.intel.com> <6EFF45F1-172E-4470-B4D7-AED90474DE50@cisco.com> <1dfca8cf-e5ef-1040-8a40-d617ed03e5c0@redhat.com> <20160905140824.1f0c80a2@xeon-e3> <27D7470D-6FC7-4922-92A4-341CAD203689@cisco.com> <20160906083213.6d2cc3bd@xeon-e3> In-Reply-To: <20160906083213.6d2cc3bd@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.228.42.60] Content-ID: <1C19F60DA2484B429B68807374B4F29D@emea.cisco.com> MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] virtio: enable indirect descriptors feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From be1210e77f0f9072ccb8e6970552596b6780a44c Mon Sep 17 00:00:00 2001 From: Pierre Pfister Date: Fri, 2 Sep 2016 16:24:57 +0200 Subject: [PATCH] virtio: enable indirect descriptors feature Virtio indirect descriptors are supported by the data-path but the feature bit is never set during feature negociation. This patch simply adds VIRTIO_RING_F_INDIRECT_DESC back to the supported features bit mask, hence enabling the use of indirect descriptors when the feature is negociated with the device. Signed-off-by: Pierre Pfister --- drivers/net/virtio/virtio_ethdev.h | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 (Apple Git-66) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 2ecec6e..31c91a5 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virtio_ethdev.h @@ -63,6 +63,7 @@ 1u << VIRTIO_NET_F_CTRL_RX | \ 1u << VIRTIO_NET_F_CTRL_VLAN | \ 1u << VIRTIO_NET_F_MRG_RXBUF | \ + 1u << VIRTIO_RING_F_INDIRECT_DESC | \ 1ULL << VIRTIO_F_VERSION_1) /*