From patchwork Wed Nov 30 09:18:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre Pfister X-Patchwork-Id: 17340 X-Patchwork-Delegate: yuanhan.liu@linux.intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C49B337B8; Wed, 30 Nov 2016 10:18:46 +0100 (CET) Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) by dpdk.org (Postfix) with ESMTP id B1E4537A8 for ; Wed, 30 Nov 2016 10:18:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1177; q=dns/txt; s=iport; t=1480497524; x=1481707124; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=uFNGiuW0DAYwpmGO9pl6Qezn+kM4u/oCGqMXcSvlOkI=; b=AT1MoZdaE6wM7GwZtY9F49rz87U7fb6QJ4Ec5s5i29P8CQZtsOr35Tn3 Rhgb9WCFefofsSxoydAj4k4P5IOKBiJ8vaeMdv3h8wQeT6NcF+80tbhQL 6QWwWNazTsoD5b9MBlZ2uAYfjgg/k1Q2yZmgotSJg79THqZ/cTO595wfx o=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AHAwCEmD5Y/5hdJa1dGgEBAQECAQEBA?= =?us-ascii?q?QgBAQEBgzgBAQEBAR+BWweNPqoLgg6CB4YiAoF2PxQBAgEBAQEBAQFiHQuEaQI?= =?us-ascii?q?EJxM/EAIBPhAyJQIEDgWIba5aPYtUAQEBAQEBAQEBAQEBAQEBAQEBAQEBHIY+g?= =?us-ascii?q?X2Gd4NhgjAFmlUBkQ2QMkmRNAEeN4EXMAEBgyccgV1yhhKBMIENAQEB?= X-IronPort-AV: E=Sophos;i="5.31,573,1473120000"; d="scan'208";a="175282461" Received: from rcdn-core-1.cisco.com ([173.37.93.152]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2016 09:18:43 +0000 Received: from XCH-ALN-019.cisco.com (xch-aln-019.cisco.com [173.36.7.29]) by rcdn-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id uAU9Ih2a032252 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 30 Nov 2016 09:18:43 GMT Received: from xch-aln-017.cisco.com (173.36.7.27) by XCH-ALN-019.cisco.com (173.36.7.29) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 30 Nov 2016 03:18:42 -0600 Received: from xch-aln-017.cisco.com ([173.36.7.27]) by XCH-ALN-017.cisco.com ([173.36.7.27]) with mapi id 15.00.1210.000; Wed, 30 Nov 2016 03:18:42 -0600 From: "Pierre Pfister (ppfister)" To: "dev@dpdk.org" CC: Yuanhan Liu , Maxime Coquelin Thread-Topic: [dpdk-dev] [PATCH v2] virtio: tx with can_push when VERSION_1 is set Thread-Index: AQHSSuq+3VobKIFZrE+Y5YtuRB59Zw== Date: Wed, 30 Nov 2016 09:18:42 +0000 Message-ID: References: <82834CFE-767C-41B0-9327-E64B8210E076@cisco.com> <46762894-5016-f634-c355-77af881685e6@redhat.com> <1FAE01C3-B03F-443A-A77C-579254A07E0E@cisco.com> <5c99bc35-839b-84b8-1df9-db80f288d7b7@redhat.com> <30923c66-8eaa-f7d4-2e6a-d65d8b254e8e@redhat.com> <6D3BD8A2-1567-42FA-9672-EE682D827A84@cisco.com> In-Reply-To: <6D3BD8A2-1567-42FA-9672-EE682D827A84@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.228.42.25] Content-ID: <7E4F872180971847A2AAC8B75D017D92@emea.cisco.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] virtio: tx with can_push when VERSION_1 is set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Current virtio driver advertises VERSION_1 support, but does not handle device's VERSION_1 support when sending packets (it looks for ANY_LAYOUT feature, which is absent). This patch enables 'can_push' in tx path when VERSION_1 is advertised by the device. This significantly improves small packets forwarding rate towards devices advertising VERSION_1 feature. Signed-off-by: Pierre Pfister --- drivers/net/virtio/virtio_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 22d97a4..1e5a6b9 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -1015,7 +1015,8 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) } /* optimize ring usage */ - if (vtpci_with_feature(hw, VIRTIO_F_ANY_LAYOUT) && + if ((vtpci_with_feature(hw, VIRTIO_F_ANY_LAYOUT) || + vtpci_with_feature(hw, VIRTIO_F_VERSION_1)) && rte_mbuf_refcnt_read(txm) == 1 && RTE_MBUF_DIRECT(txm) && txm->nb_segs == 1 &&