Message ID | B27915DBBA3421428155699D51E4CFE2ECC997@IRSMSX103.ger.corp.intel.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 53FC2683D; Tue, 10 Mar 2015 01:57:23 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9EA8B5FEB for <dev@dpdk.org>; Tue, 10 Mar 2015 01:57:21 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 09 Mar 2015 17:57:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,371,1422950400"; d="scan'208";a="696231271" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 09 Mar 2015 17:57:19 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.247]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0195.001; Tue, 10 Mar 2015 00:57:19 +0000 From: "Mcnamara, John" <john.mcnamara@intel.com> To: "Mcnamara, John" <john.mcnamara@intel.com>, "Kavanagh, Mark B" <mark.b.kavanagh@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: rte_memcpy.h: additional cflags required with OVS Thread-Index: AdBah3Gj040QJ0mYRHia+o7JqLV4XgACC7cAAA82PFA= Date: Tue, 10 Mar 2015 00:57:18 +0000 Message-ID: <B27915DBBA3421428155699D51E4CFE2ECC997@IRSMSX103.ger.corp.intel.com> References: <DC5AD7FA266D86499789B1BCAEC715F846D4EB43@irsmsx105.ger.corp.intel.com> <B27915DBBA3421428155699D51E4CFE2ECC6E8@IRSMSX103.ger.corp.intel.com> In-Reply-To: <B27915DBBA3421428155699D51E4CFE2ECC6E8@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] rte_memcpy.h: additional cflags required with OVS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
John McNamara
March 10, 2015, 12:57 a.m. UTC
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John > Sent: Monday, March 9, 2015 5:51 PM > To: Kavanagh, Mark B; dev@dpdk.org > Subject: Re: [dpdk-dev] rte_memcpy.h: additional cflags required with OVS >> In the meantime the following might work for OVS: >> >> $ ./configure CFLAGS='-Wno-bad-function-cast -march=native' --with- >> dpdk=$DPDK_BUILD >> $ make >> >> Hi, It will also need a patch like the following to netdev-dpdk to account for changes in the RSS flags: $ git diff
Comments
On 3/10/2015 8:57 AM, Mcnamara, John wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John >> Sent: Monday, March 9, 2015 5:51 PM >> To: Kavanagh, Mark B; dev@dpdk.org >> Subject: Re: [dpdk-dev] rte_memcpy.h: additional cflags required with OVS > >>> In the meantime the following might work for OVS: >>> >>> $ ./configure CFLAGS='-Wno-bad-function-cast -march=native' --with- >>> dpdk=$DPDK_BUILD >>> $ make >>> >>> > > Hi, > > It will also need a patch like the following to netdev-dpdk to account for changes in the RSS flags: > > $ git diff > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index 1ba8310..90dd06f 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -97,8 +97,7 @@ static const struct rte_eth_conf port_conf = { > .rx_adv_conf = { > .rss_conf = { > .rss_key = NULL, > - .rss_hf = ETH_RSS_IPV4_TCP | ETH_RSS_IPV4 | ETH_RSS_IPV6 > - | ETH_RSS_IPV4_UDP | ETH_RSS_IPV6_TCP | ETH_RSS_IPV6_UDP, > + .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP, > }, > }, > .txmode = { > > Yes, otherwise will lead a compile failure. Thanks, Michael >
>-----Original Message----- >From: Mcnamara, John >Sent: Tuesday, March 10, 2015 12:57 AM >To: Mcnamara, John; Kavanagh, Mark B; dev@dpdk.org >Subject: RE: rte_memcpy.h: additional cflags required with OVS > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John >> Sent: Monday, March 9, 2015 5:51 PM >> To: Kavanagh, Mark B; dev@dpdk.org >> Subject: Re: [dpdk-dev] rte_memcpy.h: additional cflags required with OVS > > >>> In the meantime the following might work for OVS: >>> >>> $ ./configure CFLAGS='-Wno-bad-function-cast -march=native' --with- >>> dpdk=$DPDK_BUILD >>> $ make >>> >>> > > >Hi, > >It will also need a patch like the following to netdev-dpdk to account for changes in the >RSS flags: > Thanks John, both myself and Panu had already caught this :) >$ git diff >diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c >index 1ba8310..90dd06f 100644 >--- a/lib/netdev-dpdk.c >+++ b/lib/netdev-dpdk.c >@@ -97,8 +97,7 @@ static const struct rte_eth_conf port_conf = { > .rx_adv_conf = { > .rss_conf = { > .rss_key = NULL, >- .rss_hf = ETH_RSS_IPV4_TCP | ETH_RSS_IPV4 | ETH_RSS_IPV6 >- | ETH_RSS_IPV4_UDP | ETH_RSS_IPV6_TCP | ETH_RSS_IPV6_UDP, >+ .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP, > }, > }, > .txmode = { > >
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 1ba8310..90dd06f 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -97,8 +97,7 @@ static const struct rte_eth_conf port_conf = { .rx_adv_conf = { .rss_conf = { .rss_key = NULL, - .rss_hf = ETH_RSS_IPV4_TCP | ETH_RSS_IPV4 | ETH_RSS_IPV6 - | ETH_RSS_IPV4_UDP | ETH_RSS_IPV6_TCP | ETH_RSS_IPV6_UDP, + .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP, }, }, .txmode = {