From patchwork Thu Feb 26 15:36:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John McNamara X-Patchwork-Id: 3751 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id F334D5697; Thu, 26 Feb 2015 16:36:31 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E2EFD5681 for ; Thu, 26 Feb 2015 16:36:29 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 26 Feb 2015 07:36:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,653,1418112000"; d="scan'208";a="533240623" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga003.jf.intel.com with ESMTP; 26 Feb 2015 07:27:08 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.247]) by IRSMSX154.ger.corp.intel.com ([169.254.12.237]) with mapi id 14.03.0195.001; Thu, 26 Feb 2015 15:36:16 +0000 From: "Mcnamara, John" To: "Mcnamara, John" , Tetsuya Mukawa , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function Thread-Index: AQHQUb7LTo0aF5i4iUWTHIMfWx5B3J0DCoHQ Date: Thu, 26 Feb 2015 15:36:16 +0000 Message-ID: References: <1424414516-18609-1-git-send-email-mukawa@igel.co.jp> <1665241.NKrJfZ0zyg@xps13> <20150225164902.70f8abd6@urahara> <3153139.jQ5sXg5pox@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John > Sent: Thursday, February 26, 2015 12:21 PM > To: Tetsuya Mukawa; Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port > hotplug function > > The following commit introduced this issue: > > $ git bisect good > c743e50c475f73edf78e5ba26445d7c6ea217f40 is the first bad commit > commit c743e50c475f73edf78e5ba26445d7c6ea217f40 Hi, The above commit also has throws a warning with ICC: lib/librte_pmd_null/rte_eth_null.c(47): error #83: type qualifier specified more than once static const char const *valid_arguments[] = { ^ An earlier commit also throws a warning with ICC: lib/librte_pmd_null/rte_eth_null.c(47): error #83: type qualifier specified more than once static const char const *valid_arguments[] = { ^ Commit: 92d94d3744d7760d8d5e490be810612cf4a9cfb0 is the first bad commit commit 92d94d3744d7760d8d5e490be810612cf4a9cfb0 Author: Tetsuya Mukawa Date: Thu Feb 26 04:32:26 2015 +0900 ethdev: attach or detach port I applied the following patch to fix these issues, (in order to test with the HEAD). You can review them to see if they are valid and apply something similar: John. diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index bb94ccb..6ea7a17 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -433,7 +433,7 @@ static enum rte_eth_dev_type rte_eth_dev_get_device_type(uint8_t port_id) { if (!rte_eth_dev_is_valid_port(port_id)) - return -1; + return RTE_ETH_DEV_UNKNOWN; return rte_eth_devices[port_id].dev_type; } diff --git a/lib/librte_pmd_null/rte_eth_null.c b/lib/librte_pmd_null/rte_eth_null.c index bb10276..3ef5842 100644 --- a/lib/librte_pmd_null/rte_eth_null.c +++ b/lib/librte_pmd_null/rte_eth_null.c @@ -44,7 +44,7 @@ static unsigned default_packet_size = 64; static unsigned default_packet_copy; -static const char const *valid_arguments[] = { +static const char *valid_arguments[] = { ETH_NULL_PACKET_SIZE_ARG, ETH_NULL_PACKET_COPY_ARG, NULL