From patchwork Tue Mar 7 16:35:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John McNamara X-Patchwork-Id: 21566 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 077EFF8C0; Tue, 7 Mar 2017 17:36:04 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 254036CD4 for ; Tue, 7 Mar 2017 17:35:51 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2017 08:35:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.36,258,1486454400"; d="scan'208"; a="1119574357" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga001.fm.intel.com with ESMTP; 07 Mar 2017 08:35:47 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.142]) by IRSMSX108.ger.corp.intel.com ([169.254.11.173]) with mapi id 14.03.0248.002; Tue, 7 Mar 2017 16:35:46 +0000 From: "Mcnamara, John" To: Billy McFall , Thomas Monjalon CC: "Lu, Wenzhuo" , "olivier.matz@6wind.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring Thread-Index: AQHSkQBVCqLtUdmaNkyTrfKq9VzWt6GJfJGAgAAgxMA= Date: Tue, 7 Mar 2017 16:35:46 +0000 Message-ID: References: <20170123211340.22570-1-bmcfall@redhat.com> <20170127183800.27466-1-bmcfall@redhat.com> <20170127183800.27466-2-bmcfall@redhat.com> <2417966.3G0haXHz4n@xps13> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzhjYThhMjAtNTMwZi00NzE3LTk3OTMtMWYwYmNmYTQ1OTk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlF2TldhSzdQVndyYU0zbnRcL3pxcEpZSVdIS1haUGJRSFZ0Nk13S1hTeDVJPSJ9 x-originating-ip: [163.33.239.181] MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Billy McFall > Sent: Tuesday, March 7, 2017 2:30 PM > To: Thomas Monjalon > Cc: Lu, Wenzhuo ; olivier.matz@6wind.com; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed > buffers in Tx ring > > Thomas, > > Thanks for your comments. See inline. > > On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon > > wrote: > > > 2017-01-27 13:37, Billy McFall: > > > --- a/doc/guides/nics/features/default.ini > > > +++ b/doc/guides/nics/features/default.ini > > > @@ -55,6 +55,7 @@ FW version = > > > EEPROM dump = > > > Registers dump = > > > Multiprocess aware = > > > +Free TX ring buffers = > > > > I'm afraid this wording will be confusing, because every drivers free > > their buffers :) What about "Free Tx mbuf on demand" ? > > > > > I definitely like your wording of the feature better than mine. All the > existing features were under 20 characters and I was trying to stay under > that. Hi Billy, "Free Tx mbuf on demand" looks clearer to me as well. You will probably have to modify doc/guides/conf.py to support labels longer than 20 characters. Like the following, or better still a global variable for feature width. $ git diff John diff --git a/doc/guides/conf.py b/doc/guides/conf.py index 34c62de..3f3ce00 100644 --- a/doc/guides/conf.py +++ b/doc/guides/conf.py @@ -300,7 +300,7 @@ def print_table_body(outfile, num_cols, ini_files, ini_data, default_features): def print_table_row(outfile, feature, line): """ Print a single row of the table with fixed formatting. """ line = line.rstrip() - print(' {:<20}{}'.format(feature, line), file=outfile) + print(' {:<25}{}'.format(feature, line), file=outfile) def print_table_divider(outfile, num_cols): @@ -309,7 +309,7 @@ def print_table_divider(outfile, num_cols): column_dividers = ['='] * num_cols line += ' '.join(column_dividers) - feature = '=' * 20 + feature = '=' * 25 print_table_row(outfile, feature, line)