From patchwork Tue Dec 12 12:52:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 32158 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8234C199AE; Tue, 12 Dec 2017 13:53:41 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0059.outbound.protection.outlook.com [104.47.0.59]) by dpdk.org (Postfix) with ESMTP id 4381F1D8E; Tue, 12 Dec 2017 13:53:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uPBz4kQ4kPep7J73JWGQaBwL80R7/TaTbcqaCgXvlVw=; b=a+8HomCWe0YSg8730PlrxnYKRXav4iw596OVmVQ6ItFec/fJYFFo14bIPBWF3KSrrgervehDoAP3dmpJOsjyPhwX5YwdCN17QefCvsg5lgT5nkVp5iuEZqZb5vlQq+MnGt2e/9zPilQFqZxm/Z9qQ5KtnV21bb+TLJK+4WTunGE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by VI1PR05MB3150.eurprd05.prod.outlook.com (2603:10a6:802:1b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Tue, 12 Dec 2017 12:53:31 +0000 From: Shahaf Shuler To: ferruh.yigit@intel.com, jingjing.wu@intel.com Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com, stable@dpdk.org Date: Tue, 12 Dec 2017 14:52:45 +0200 Message-Id: <9c52dd196d2174eed2c9fece80e584e66ac75d7a.1513082773.git.shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: References: <20171123120804.143897-1-shahafs@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: DB6PR1001CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::23) To VI1PR05MB3150.eurprd05.prod.outlook.com (2603:10a6:802:1b::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3ba10926-8527-445e-9715-08d5415f5a16 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307); SRVR:VI1PR05MB3150; X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3150; 3:nd2YbSthBL7tPGQJXvTA3+uJ2OyrwFni0zM+xXsDBUs0cIIki7bm438Wv25blODsMO2qE5Swjpc2x3PbXdAbyRjS0rIEKOqFzbQL4m+019/ITk0Daz0tA/3LuNHt7H3PGWk7ozRJMWULCrrMl+KOSwF8MHO4IneotdLUseS/dBHKjV1NqHsRN3BC9ejvUZmq7omD0NQVucUzc6JxOcX2G1F3PWb7TJamw0zPsTMrakWxXUol8+cRY+0cCeyL71bA; 25:tQGYrYWvTtaPUlGm0MK9V7PUA2F14RRym5NCtre5Iuu1U9gV7/eJ5ritwcbx6YY4pdjUqrBlml2k1ObDjpAd9eh40F1ZaLHqCepzXEh5d5Aie52DDHfmKE7IVuAz1WxGwm2Pel5540xItN5+fizsEa7YDzI1WF2RNZDXxK4mB4EoXjID2YetQzYntn9iItTkv65w2OaiXuA84TpHwoKV28lxSy18C+Ae1OlmnPHH3JTQm2ez8wbJrLlr+GPQKsq5oyCgrALooS+shZ58Xi/SGDiDCglA+tiiW0TXNyWR29uHRtIrCGZ+mJmSL2UBCA1RJ378A2Faz7hOZ7q9PHL+w4nonTPhuz7DQjLlT6aXkrM=; 31:Nfn4kvglXTEjUBtl7c0PszscpQ2dhfHdv8xIazvxmqyQ4dWDnzvHNNmgoQBhrqQxzIduDPPPh/qOGGGJfj6ZA6ifwddzI80xmEq/9IK8WBnMPVCqrehajBrLR6wMeoyhtioHoyp60gHvBUhZO1dH4K5h4+N/AAyJeXrSyc0gDXupan1tdLuV+W6RzmE5n2/+ucJkyIrjJZJfq8uBJ+i7O5KUll/iPvAW0Ybgqb7prq0= X-MS-TrafficTypeDiagnostic: VI1PR05MB3150: X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3150; 20:bvD8HpAvqszIDf0h4vUQ3xQlWv5OdQEA7RVIDSs1+m3/rDS9Pt0IHyfCp5LhvUZhyyqSYtQxjin10JH3rsXf+hbLt4GXVO48JjbRgPyADXJP8W/BEI3MRyEODpwiYcdudscj3IJUW9qGo+XtcbNla/V6xBseiFf8SADD9dOs7orsBfubVtwfkxKS4DeSLVUEIoquedPbS7pqyg6n4ksebnKPUu4QC1v3FY7kNx3GDsBVtJsJb6FjfqskDpstTScdc2wZQh9jXtsxfaG7lmhs3RPY84USEtxmhoZ0Qp+Fjz5mu9wVosCqtVHlWxFYclcj6yZz7inqPorgXrsCagU510KIAB7LeGJDA3vsCR6SOeo/ypXhvkJP3K8pT9mTd16ZF+nR6638U5uk8ZTHs+5jw4pY1m6+eHgxdnaglbOpifIT+y9q1Gx5B0XWVRlAQ9HC4SFq1bB8UiE1o+88AIfA1dmEPhFANkfAsUewtjF1DSTuuZarHMXjw47bO91jKAM9; 4:8ETbC8gVtsbiCaYriv9iUHqUDmJprK6izA7X6XHWzMCJxcy2tzml5z8NfBKvIdMVRFkHqCQtIXbPtXYIHe4kKv1q54xiyPB6wh5JQXOlL6CawiI1yS+KsNGFI9TYCIyXhEJ9iQ0XIZzrPKQrGEHEStWIcIUk3766uAPSGC1fJEoR2SvIYGnqCjFlRqsvCqWjR6CYF2SPtF58MXoic6cEgJ9neWTrWWOYfwOAUjP+9JZKdvL7wVIq+mOqbfL/YfkuCyqCpBkROteyDXJhZfurgGSWliziYgik42MT0y/bQFKWrl618Kd3DgHjYROPqkPj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231023)(6055026)(6041248)(20161123564025)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011); SRVR:VI1PR05MB3150; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB3150; X-Forefront-PRVS: 051900244E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(376002)(199004)(189003)(55016002)(81166006)(106356001)(7736002)(81156014)(47776003)(8676002)(305945005)(105586002)(66066001)(36756003)(4326008)(118296001)(53936002)(16586007)(50466002)(48376002)(7696005)(33026002)(69596002)(52116002)(51416003)(478600001)(5660300001)(16526018)(97736004)(21086003)(316002)(6116002)(76176011)(3846002)(50226002)(6666003)(2906002)(2950100002)(8936002)(86362001)(59450400001)(68736007)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3150; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR05MB3150; 23:aKr+Okx9QIII8OJ+PjKSgsOB87Tcrb3B9rQ9RJAXC?= UsP0venyVGQoL+st31/lT0tUP53UIwaHNtBcLOvjNFXDmBIHI6tepqpVY841skpnGvhtRWKr9rLRs4b8zo63IF2bZe4N3sJ0AMox0l8hFaRJW3J6qGlxWUaDtgSlUZyiDsyu6bqaFecpdkzva30RLEv9UC6ijNwQJ5oGjqXdGG00H5/8Y6AbgeSsd1iQ6QvihurjV6u6YPXMCPIpuzWLIO+hkjlav/xgWXWQhNlib5idGxpPyjkgLTfsGGj7X7ohn9u7SrbSvPNmc2/1BFanpwtvd2jhMgFCi4o+a5wGPmNY7YbdSpJvQb9lQEOi5cngDJtytWpB/homen+w/nP9vHuvcwmS0+0Q1/SyBTDaaid0yIt7Xlkl+Im2VaH4c2AHTXnurp/r+5hBqpwoaq1wjy3xAr+4OzI7b5imyL3xEOVSeC11S/OZT+Pg66AMjK6mjaTWdjzaoTNUt9l0vFMei71C5Jo5ez8W6hSpdHsr3aP5CkyD6VwQ7OfZYjGUiuGtetAUd7BbUZQ82vtbB0m5Dr7TKKoY28yK7d/0lfIe4briLiCWKVO5yun9+32I2Zay9p3i0NNEGzOldSoyzAF0L5Hxm21r5kx16efRPjKCgqo39vmA9Fnwbi88DlmzhtuCtjfBjVkrJpLPXSadQ2U+z1RS6HQyuUmKuJrZ2zM3+4M1rk5qFNPDUwEUNC71Wk/VEMJvpbBAiineDc5hilzRFxEekuNLOKDtFJzo95k4HsRYUx5fszhMnyc++JfG3IZJDoU2ekKro8w1tp77iSDwFrTTp/Ppx5OtGAm9WhwY6o2GrDMq3wIaLIdj2nNr/EIm6xOCoF1FXCs2wxp0qed9obfAUtbXnc8kNegBdktF3NmRz+39Pbez9/aj68y5n8vFRbeEijbwiUytAgEmm03SY6IJorsIv/DgdGypqEE7iTfyGxJU/t7qm+oEa+b0e8mSjGntwU4yj++FXlhIGCeRnvvH8yx5iJEcPW+denDwVXGT4AYucPsEb5zZgnSwGsgLz5T+R+ujSZmGWRw4ZP2P5kPrzXaDBfEd/k3a6FEHqD/rA== X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB3150; 6:0zRiBSuurwUb8k9ji66ZnBksESFH90ocYfHGNbwFyaxrDJvSVkznfuxdKX624Ix8kK087qXDSBvPsm4zk8haqUWl3AxTbM68VCzUcSJqBfX7kxICC2lfuOv3ZB8lBr3exzOCVH7kKQ2FMOvhYJOQeXkUeeOI4QX9YqlXpkkv0fsYwdJbEOj1Z3087oB9baJc3oWEZhb7pPVrz1wz/vhbsqUJVGtlF1VvvHpa7zKRQEZSK6Dar3UK/058AiYtCbcpGDlHB9DRbQbw6bWCvbetl6xdakaMYnDZfPrL9onuR3xcgYhAikBoo2gA2x/aqG0xfd3Aq8lj2rPLh57GTgOj/EXHlNRqiojw7hD1J6L/UTA=; 5:SGU5LNRbFvYkn5CrV4g59K5oqQw28egyF0fZ9RlCc4bVyNz5/DZycpAS04HgG2SDJsa9DNH4tRdWPu6stIoLXp/feqi/uTzpd725nuWRYfa1MMeQ751wJsdMtPlLlu25cs/XD992DyoPFUDXAXIKcTURX28RxCb4fydElft4GzQ=; 24:+C53e5k2Sn2iW3uwgKBfaIn5mKK6h2chnhvWSOe0oYYgLTD1LXpObZa0YPES+4CV1EZFrbbYUOJgropvIVQBvrWmT4jl9rv5zFFPL5Nfru8=; 7:QZtdqh1u46BzQi84Er5mJo0clM5KXxpM3z3QBuD2YFxqpqg42LN1wPGHyiNpQzDjeRLr5Tw+xBoLVOK47FMq5cqks7sTWzkBxkfrjNm6kwzSjpXcnJkpzdJeUUbNaRDeE0wBy9ZtfV7goU71akSBLzGFCYG/vHokZl3kMiO2TAaXKRH8IUYose8TIx3cfWEXEACbFiR9vO1buz9WzUWDCIXNGycqkOGp567hgYh/UxD/S+co5m9yGl2U8JzpLPci SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 12:53:31.9890 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ba10926-8527-445e-9715-08d5415f5a16 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3150 Subject: [dpdk-dev] [PATCH v2 01/10] app/testpmd: fix port configuration print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The print of the port configuration was only according to configuration of the first port. Fixes: f2c5125a686a ("app/testpmd: use default Rx/Tx port configuration") Cc: pablo.de.lara.guarch@intel.com Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler --- app/test-pmd/config.c | 48 +++++++++++++++++++++++++++++----------------- 1 file changed, 30 insertions(+), 18 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index cd2ac11..8a2d30c 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1655,33 +1655,45 @@ struct igb_ring_desc_16_bytes { void rxtx_config_display(void) { - printf(" %s packet forwarding%s - CRC stripping %s - " - "packets/burst=%d\n", cur_fwd_eng->fwd_mode_name, + portid_t pid; + + printf(" %s packet forwarding%s packets/burst=%d\n", + cur_fwd_eng->fwd_mode_name, retry_enabled == 0 ? "" : " with retry", - rx_mode.hw_strip_crc ? "enabled" : "disabled", nb_pkt_per_burst); if (cur_fwd_eng == &tx_only_engine || cur_fwd_eng == &flow_gen_engine) printf(" packet len=%u - nb packet segments=%d\n", (unsigned)tx_pkt_length, (int) tx_pkt_nb_segs); - struct rte_eth_rxconf *rx_conf = &ports[0].rx_conf; - struct rte_eth_txconf *tx_conf = &ports[0].tx_conf; - printf(" nb forwarding cores=%d - nb forwarding ports=%d\n", nb_fwd_lcores, nb_fwd_ports); - printf(" RX queues=%d - RX desc=%d - RX free threshold=%d\n", - nb_rxq, nb_rxd, rx_conf->rx_free_thresh); - printf(" RX threshold registers: pthresh=%d hthresh=%d wthresh=%d\n", - rx_conf->rx_thresh.pthresh, rx_conf->rx_thresh.hthresh, - rx_conf->rx_thresh.wthresh); - printf(" TX queues=%d - TX desc=%d - TX free threshold=%d\n", - nb_txq, nb_txd, tx_conf->tx_free_thresh); - printf(" TX threshold registers: pthresh=%d hthresh=%d wthresh=%d\n", - tx_conf->tx_thresh.pthresh, tx_conf->tx_thresh.hthresh, - tx_conf->tx_thresh.wthresh); - printf(" TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"\n", - tx_conf->tx_rs_thresh, tx_conf->txq_flags); + + RTE_ETH_FOREACH_DEV(pid) { + struct rte_eth_rxconf *rx_conf = &ports[pid].rx_conf; + struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf; + + printf(" port %d:\n", (unsigned int)pid); + printf(" CRC stripping %s\n", + ports[pid].dev_conf.rxmode.hw_strip_crc ? + "enabled" : "disabled"); + printf(" RX queues=%d - RX desc=%d - RX free threshold=%d\n", + nb_rxq, nb_rxd, rx_conf->rx_free_thresh); + printf(" RX threshold registers: pthresh=%d hthresh=%d " + " wthresh=%d\n", + rx_conf->rx_thresh.pthresh, + rx_conf->rx_thresh.hthresh, + rx_conf->rx_thresh.wthresh); + printf(" TX queues=%d - TX desc=%d - TX free threshold=%d\n", + nb_txq, nb_txd, tx_conf->tx_free_thresh); + printf(" TX threshold registers: pthresh=%d hthresh=%d " + " wthresh=%d\n", + tx_conf->tx_thresh.pthresh, + tx_conf->tx_thresh.hthresh, + tx_conf->tx_thresh.wthresh); + printf(" TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"\n", + tx_conf->tx_rs_thresh, tx_conf->txq_flags); + } } void