From patchwork Sat Mar 9 14:03:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 51003 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 806A22C39; Sat, 9 Mar 2019 15:03:29 +0100 (CET) Received: from NAM05-CO1-obe.outbound.protection.outlook.com (mail-eopbgr720043.outbound.protection.outlook.com [40.107.72.43]) by dpdk.org (Postfix) with ESMTP id A52CD27D; Sat, 9 Mar 2019 15:03:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wABkk6GVQI7y28vBO2rYuZ8oKyYJ+NjFDgT7aPKXxmg=; b=ZlM8qDz4x0vwqQKlw8UgAZ0rP4jIddto+4qKNCy8NJ3awbCVx1aj5jQrSl2sNNDDxUkouKi/b2u0m//MzM0IjBZQyZZ38KeUOqW3kRiyjIUdnWeSqsasZj4kIkxBOAxDmpw7M7pPalKLjqMUmBPjrq6FoGE8IIVr1NtAdMuiOP4= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB2892.namprd11.prod.outlook.com (20.177.216.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Sat, 9 Mar 2019 14:03:24 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::d145:a1f4:ed34:e31b]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::d145:a1f4:ed34:e31b%3]) with mapi id 15.20.1665.020; Sat, 9 Mar 2019 14:03:24 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh , "stable@dpdk.org" Thread-Topic: [PATCH v2 01/10] net/atlantic: fix negative error codes Thread-Index: AQHU1oDchocMPEhf+0WG/FcDpnc/cA== Date: Sat, 9 Mar 2019 14:03:24 +0000 Message-ID: <8b5751022a766644ba6abff9be929ffdd73e01cb.1552138867.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR05CA0278.eurprd05.prod.outlook.com (2603:10a6:3:fc::30) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 629f374c-8223-4aa1-3c58-08d6a497fec1 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB2892; x-ms-traffictypediagnostic: DM6PR11MB2892: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB2892; 23:6ob4RhVGCzjORlqQVExvzkCmYRdzBk95kUt3jQ9?= =?iso-8859-1?q?+255hvcgSWaHHcBavbzQ3kSC2?= =?iso-8859-1?q?5b5sKC5owb67muOoWFf3BdwtT3Rd/JaZ2Qtjddwj6jWij4Q0hIH?= =?iso-8859-1?q?XrKbuX/O9/bQV059YBZ1O5ijZkq+wF97R2Q7YUR/KqZQH+8Aw2h?= =?iso-8859-1?q?q4FxzPRgPbuDlHhwNZaq7oR8stiv93oRk/NMOpVgBiO5jk73kIQ?= =?iso-8859-1?q?960EQPm+MnvIloMKX+1uJY0cWvXakOZJgmOZ3axjjcSnMzP233A?= =?iso-8859-1?q?zIPCIaY9fOtcDYKeCwG2Qfr3cEXDXN9iDCiTeqf40oxX5qKgjAM?= =?iso-8859-1?q?ut2MLw+DD+k9lCpKa+LSwzZqCrKr+3naX1Re13iuNxQCp2lIYt7?= =?iso-8859-1?q?U1UP1V36AUBNnUzXZ6qTjC1KUFrLsNMUTPy5338QaT/Eb2QZGcS?= =?iso-8859-1?q?YOyGtPD+EuoblQtuwqwo1Y1ZIUexiQj+5u55CHorJIvW5if7wDa?= =?iso-8859-1?q?do1Hh4yV28fK1b75v8/3yfuyjCnMdqSrgQKBt+16w1672tKphPH?= =?iso-8859-1?q?DqUvKMuI7dKAyFf/AI9n6F+HIozA8b1Kam7781k/JfB2LrBGp8E?= =?iso-8859-1?q?9vwXFNM+O5lNI9MjnGDrMPxsm3BjvraX6U1QA9jL/TBZlJ0wS3A?= =?iso-8859-1?q?4qspP99k+FurGuqOrCQqiBehLoqh8r+Tg62O54/3aGcj2ed8jFu?= =?iso-8859-1?q?HLQXrsTKJ0hCZL44+8jr9Da7FeUtuRuQGzLs+cJ/8vgtabQKjAK?= =?iso-8859-1?q?RDpe8/DQNbmfSmLo2PkpHyu6LAa1Dn9uQg4JKJGD7KupR/p1g8B?= =?iso-8859-1?q?GvfeyoUSqMgDIIsZCOBTKs7oDQRDSyt3NvFEcQSJ/5sJGM6mIqU?= =?iso-8859-1?q?zHxxJvBcnPDv+LpkDMc+3eV6oc0JSbDTOqtwpF0aUSYFfDf3wzZ?= =?iso-8859-1?q?3nZFfm/ZIQgbYWQE4/rqPWgRZD4IhLQ/V3x6qeDmZjEyi8xoyyO?= =?iso-8859-1?q?KOYmCBknWMk71bJ+GqQ1zp2HmsmgSDc6CT4io3eIh+mTAp8dD4W?= =?iso-8859-1?q?ClEYPP7AVKRueQdwodueSr7BgFB6qFtBHFPn0YZhE+CT8y8l2vY?= =?iso-8859-1?q?ybPOxuZZ9NOfG1FfzbxA6vJeIKzn9yn+2JtPwIocSsGR0+WwMDj?= =?iso-8859-1?q?5Oa3aw2Hd3Uc4invxiHNya3Oe4M1lTQyktUgPGTacBU65oDQRGx?= =?iso-8859-1?q?jZ+RqMeM2D+l7m8UcstbRyHQVAxaHMWAd1NNP/7J8VP95NlIyT8?= =?iso-8859-1?q?c9famMlubmEhDogXEDlKOioqGrKpBRlI99OFUCqpYDItd3FjMXT?= =?iso-8859-1?q?CMMkKlCRpg7w8lPZ1v0pDygVk81u62kLb+RceWP0BuhzN5b0LA9?= =?iso-8859-1?q?MUqaep8p2k5f13iEy01Mh7Ayg/lc2FYukcev/royHwkhDR/Tudc?= =?iso-8859-1?q?xgIwkwiImfcwNF3RzQkm4Rx326B/VdKJZiwNadb85B1IKtOg=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0971922F40 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(366004)(39850400004)(136003)(346002)(199004)(189003)(106356001)(5660300002)(6116002)(26005)(4326008)(99286004)(52116002)(2906002)(3846002)(76176011)(2351001)(105586002)(14454004)(102836004)(97736004)(476003)(68736007)(44832011)(386003)(186003)(486006)(11346002)(446003)(2616005)(6506007)(450100002)(25786009)(2501003)(86362001)(305945005)(7736002)(72206003)(8676002)(6486002)(256004)(118296001)(316002)(8936002)(66066001)(6436002)(81156014)(1730700003)(4744005)(53936002)(5640700003)(81166006)(50226002)(71190400001)(6916009)(54906003)(36756003)(71200400001)(478600001)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB2892; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: u92Ax0LPwMY+dzwPc4t6UUHo8c7rm6k+2ACslO7HDmRHXRIvsdnFzltIVawEqRBmG+y4PbEqFLpxkJORhlwVTJfUwPJEcVNDt61LmtA7QjUu1FA+nr2LiWbCGES9gvsien+gsoyi3DWg3p6N4nmPQVAbrXWlMwskqwfFhVRfSurcOHluniCUsdAvey341wq6XAxtFMK52c1Q/g+LgxbzBpcO1xAl249Kzk0zHco/jttdDcantq7RpwDrsVYYx0mBIOMBMeuHSL3CT5vt8A808xEK1JSGXa2PTJLsKwxPC1NlkVsVF39UXfzzKd48ash3piIL6cdXnwZXe6PF5eVYSFlZjh0qexNq3qR4n5MKcM/qzB6Gs9KQ+Q0NRs6L/8aeXh0dgIUT66ryr4pUJCmtXFWEgSnNYTDV8oT40lsB1Xw= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 629f374c-8223-4aa1-3c58-08d6a497fec1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2019 14:03:24.4630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2892 Subject: [dpdk-dev] [PATCH v2 01/10] net/atlantic: fix negative error codes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" These are just convention breakage on rte_errno, no real harm from that. Cc: stable@dpdk.org Signed-off-by: Igor Russkikh Fixes: 2b1472d7150c ("net/atlantic: implement Tx path") --- drivers/net/atlantic/atl_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index 40c913795c79..aea58c0d5b83 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b/drivers/net/atlantic/atl_rxtx.c @@ -812,12 +812,12 @@ atl_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, ol_flags = m->ol_flags; if (m->nb_segs > AQ_HW_MAX_SEGS_SIZE) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return i; } if (ol_flags & ATL_TX_OFFLOAD_NOTSUP_MASK) { - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return i; }