From patchwork Wed Jan 10 09:09:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 33373 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C678C1B1E2; Wed, 10 Jan 2018 10:10:09 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr60051.outbound.protection.outlook.com [40.107.6.51]) by dpdk.org (Postfix) with ESMTP id BF1591B1D9 for ; Wed, 10 Jan 2018 10:10:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5zNjgoXC5YNA/W/svJVsYcCWuXZyV/2Zs7NUw7oSgZc=; b=nNmTP34xqG4kDkGdGaTN7clF4lkDkZz/RU+xfQOO/xImvi6Jwf/APjjhBKHRVlMqFDFuE0526AAo71Sg0K1XPsV7VZGWb8xNiZV030yRr5PHacjuTRmkQ84dZadT6sMWqxnPo624TvI+MdZLJIq3zqjqJYN54eRzyt4Z8uEojRk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (82.166.227.17) by AM4PR05MB3137.eurprd05.prod.outlook.com (2603:10a6:205:3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 10 Jan 2018 09:10:02 +0000 From: Shahaf Shuler To: jingjing.wu@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com Cc: dev@dpdk.org Date: Wed, 10 Jan 2018 11:09:16 +0200 Message-Id: <85ee571f041bc7e6354cffecec30aec14ce40e3a.1515575134.git.shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: References: <20171123120804.143897-1-shahafs@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [82.166.227.17] X-ClientProxiedBy: VI1PR0202CA0030.eurprd02.prod.outlook.com (2603:10a6:803:14::43) To AM4PR05MB3137.eurprd05.prod.outlook.com (2603:10a6:205:3::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: bfcd5679-35ff-4efe-1e2a-08d55809ef51 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM4PR05MB3137; X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3137; 3:SzY4Y29lriGxa6WchWZac3EObGe3vGUOHlFebvCmjHNx2+xo9WD9Bu7C7zTk//Y/8yrvxZm3YfVoB3J0uLNHhhPdAbr3flAqd4NDufhP20TcjQJajpukLWjYMZY9D21WoqIVce7HbQvuBQRoDdFRRuTl0xuq5K7J2VPan+rATiGM9eFZLhA1jb11FBJMtkIlixyZhrqL/q9XYyvVtu7BFNe9g1GxyZRjgW2ExobRr63+Z+ZVYk8tfejwV/OddbzK; 25:h6S5FY1pxXJJq3gD9AgL5kdwntRHCBOgGNs51QTfofwVIxRNQpj9nl4IvBo9ZaBTt6uKbeG/rJ1TI/OeVqb+5MRHVyi00YF85LCILSE28PUsjIkca47Wlu8/HJC4/+jcCSser1gzI4r8cgr4+3QJL1OIGzkc9gyM35o35HPpD0HeyyEdgWDmiayA8EDtFeTif70n+zZ5wgiYYkMGIyrJpherrwGstB96AC+UeQYyJSW20z7mFQHTWGe5CQMneK/vbXfC5wmmS9lbrwW2rIGalRSrEzoyLzg2DfvvgfCUA+JZ5JjDVYzlCGAILd9OwF0MsqBC6T8Gxfj5UUVKZNQbDg==; 31:FowaFil3RNj3ZksY5EGJJDxuKwDjKGGO+6E4qFdTHlJsAV1lpWlAOjZEbSlc2XFYVwcvCaRc6Ts9pkKIBRxysmK48JFyOJH5N21d6XTkECd3U9NBkK8N6L9U4k8IL/Qg/V01js6HhL9ZuBZ6paCnUt7wiYEdiFoRqQPSZuRXdu+bswbvzERklRiqLo8SCYDjpk1iZJMyKYuAPdj1PB5rzq+t7n1bLTLrlo7y6VUvCtM= X-MS-TrafficTypeDiagnostic: AM4PR05MB3137: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3137; 20:kYjVu3+84hg93PZsA0XLTiRUh3M7WQZltsbXr6lZxrmUIpzgfUHRhQB9WW/0X8/mYuOyzuAWZhkKoRUcGccABSJagj5Iu3kGMfobxShVNh4hFH4FVEQnZ+SZO18qaqu/hHWgj4tVQTzpAlAHuhSZejcetSOsRwdlVmixMVjBJSFXjDGcDcaXN4yxUPPujYMtDWiTp0lrTR7uv5qGGNlas/C0WD9aPr1/xI0pH0nUAiLQiiHdajeUkLKHZ0aa5p2/awiDtFLpyuozikodym6RgeieocIVS7/YjBgM4OUzRltGRATkqXvuwtdNYy9/O6JNvDBmCl6FFd9xPH6hUMqYdH7y+CGEpoZs1ZRB2Pj/iAXG8vz2/uHTYQwMh2rlxBe2oGLYa7Jwg0Ys+IXrixKPQZfSna8g8DR6b0BW7dk/Xa5K2oisW27VtOhzzVACjSmk9D87dHrCQS5SuYQEXpIDjxa6E2F8TEBc9nF8sKsdbfv6Vjtx+PqLhXsF8B895wS5; 4:bbywiZ/4oAncHdLK9vx+UEMnS4z09kAQFYffElWUo52js5XreTQXB0QjUm/AdZimttFjWjIT0UVNGpAQGKvBIOGfSYlnoGUlD3uhTBqhM/3/D0uys1v7ebL6M1ju4nNQB0/s+EQwV8ABdXWdwc1SUSGIzYlOabD/QaNgI7bBSp6/J9j24jtfgX+iZ1l2y2JfYbBJWAoRV22r3ZvBt+DAYSftNgzh9M+ydKF4HN37/ugwQ30abJdl0lhfFJQTEe2FVqjQXi6IU4Ouw9rcJsftRuae6BJiPtKsebPFHVFL9FYQFYvo8bn0CvHJT+8s40Dl X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231023)(944501075)(6055026)(6041268)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM4PR05MB3137; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM4PR05MB3137; X-Forefront-PRVS: 0548586081 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(396003)(366004)(39380400002)(346002)(199004)(189003)(6666003)(478600001)(2950100002)(5660300001)(8936002)(50226002)(8676002)(81156014)(68736007)(86362001)(81166006)(575784001)(118296001)(305945005)(7736002)(55016002)(2906002)(21086003)(6116002)(3846002)(106356001)(105586002)(59450400001)(316002)(50466002)(69596002)(386003)(16586007)(36756003)(4326008)(52116002)(76176011)(51416003)(7696005)(97736004)(16526018)(47776003)(53936002)(25786009)(48376002)(33026002)(66066001)(129583001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3137; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM4PR05MB3137; 23:ORSwHL15npf7vcuQBxarkWnyqnh2OiOPWGJg2gqL8?= 4Rw+n6aI/RQi2BrxOUG4WkHM0OAcPT3UWfQtYam6l+CZvognybkWdL/td2SoeNSxWZf+CV6aXb9WKDWri1g0I74ZrJ0jGz0Z7BI2YCGDDuH8To7I1hdlSM6VEXH0fM2/ihuI6rzwkg5SXltUGdxT3sHY37Wefqcln8sb26p1MjwdTnl7dQiBZued7yHeRbSXOmFKnBkrHnY+BQET6zuZuePIQuGt/xmV2G3S4e6xG1lvGut/7ifTNTY77M6ykS3Fb7Bg5FJUsCVeNyHiq5OFzQO3IpyptRKZgBdAtLl4Ydy7NlEYsq4NWHju7TLBmAGN//l/+i994Ho1ns1aUpnUdBDk0AEg7BINYxeaNd+9i5GlYnc2AGRyuXpWbkicDClcKLBY49m9quka50ZKhjiM6RRoIuCx9F92zFVJ3F7XsFOCXyza3uvlMV8AdlhzUqm5wIzbK56cbueOABPrNY2XDNGA+L54kYg+fbwkAofjt0vjlwm+FVC2JBc76YWKejYLvOB1P0100TXzPJXA8NhbU3bk91DkfkzesEL5rxzIIO4xL/tkJm09EOQ1zcW3R1dtpY+fKgJhB0Muwnj6gBsEIOneFf2/A4Br+UsrWDauTCOeqAl/JQKvmCZy5+EUoPXbFG60/F2BF1upJWGqsGGfvevtqxYjxHXYCJ7buhOIec5GkdjEt7Qe54lTwkgGkk/jYWfIEl2dB74vofZWBgLl4U4maeZKJGheWcS80o75Y+7HPCR2MuFw4F2DHr5rcakJfbc7Zro+RyRRMwjczOSlBhOc2KGN/IU4EoSzLBxyIrTxB/2RYtgCuBzej28i46xDjH9lwsQZp9akwa8udPRdfELyxmur1p+RZTLyYSdUi3Sx7a8y3Au/QqeMQjfpZl+ee7GSKzqU14jw/ViAdyfNzJgMpLZMa5tgAt+o8ib4OZUm7wBGFLaLus5Vn9tpHOWJARaVmc3XNP3T9CMYb5oI1+bt9OGrkHEJ5C0M5XWaN6p7Gj6X+Jm6xwlbfbUZNOyBuKYwCJ5KVqIq44M/ZtLO+szmjgjgvYEj1ps/GSedCMxXMdld14CjnC1MhsA1mXwwVcyjfFOhKlCCgqxZahnkL0tvxzWkfbQqbnsKxS0pvb4ssq0flLUyzxiqt66XWHXa6M= X-Microsoft-Exchange-Diagnostics: 1; AM4PR05MB3137; 6:5T2UujIUgDLa8YClhO7wiZvQfWiB7xcuCkn4496EhYWBxQshr8i58ZpHBrT1XGoUp3qI6uE5KfC4VfID/FgoBWTSYAC+2Z/HiNHsKX9F5ibqa0H69dIyX0jjxyPiRd1YliLJOmMI+xqulogOYyNoJt1e827/asB/YWc0PlomP4N9uR/HrtU28F0jyjuRj7Z/Pzg1y4znhfZIOHqdgB9fY4ADXT1duRa0uYRx0TCbeczE8fdlYEVxkEXVQIM7zpaMWc6lJPfYdi9pRaPYp7y45OsDhYaWl+zS1LBqtnlngqsT3NCRLtPGA4ZYzAYVmA9881cbMmEDQfzvAXjiTzG6GEAZbwMkLkrrXzWNQQQ9PiI=; 5:H0zp+GveVH/sHTl+48KyASXcB3hWpl+A88SxF1Z9zG7d/V9EuohWGE/UwArwXuxGVAUz52vVSEx9kpmlIYfguWE642Tx5rv8Oe4n/q41CSPIEaWkzSWZSiIpC5Dwg/M0nmmamFyjT4EiklIdv1b6iVoTuptkBVzFDH3oE1jMFT8=; 24:H0FVSspNXoxMInuUC7reaBehmjgJ2B0dfFwmTuJ0SYk5PvrHHRRHMSEaY9oj25RM8Mma3yXph3BJ9sldTWzNO/mMsvjSKEjsVng4qNQtEoA=; 7:oFVh0YbY5+ceaBefpRWSWcJKAVW2ecQLxqeksDFdoJvBY4/S1F2qeOuBCSpEa/HXiuwIpo88BGl0A8lWExXcRxCMalPLrTV7ImwBrDsbM5CyCmzOoNHVp4uex8xzCdjxy6pDD0pzf/rj5/hY7RfiJknESjIot03BLwpi9MrJgNiuhcAHS7L97RU3ze9iP+Wg4ockIXmAyNSy8vBlrmXIr+srAS2Jp+8jfmpMUlbPcQ/6ojKdcAK/siSwlttd+1G1 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 09:10:02.8313 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bfcd5679-35ff-4efe-1e2a-08d55809ef51 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3137 Subject: [dpdk-dev] [PATCH v4 08/11] app/testpmd: remove txqflags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since testpmd is now using the new Ethdev offloads API and there is a way configure each of the tx offloads from CLI or command line, there is no need for the txqflags configuration anymore. Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro Acked-by: Wenzhuo Lu --- app/test-pmd/cmdline.c | 69 ------------------------ app/test-pmd/config.c | 7 +-- app/test-pmd/parameters.c | 14 +---- app/test-pmd/testpmd.c | 8 --- app/test-pmd/testpmd.h | 1 - doc/guides/testpmd_app_ug/run_app.rst | 12 ----- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 ---- 7 files changed, 3 insertions(+), 119 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 858482174..b4ef1d0eb 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3092,74 +3092,6 @@ cmdline_parse_inst_t cmd_set_txsplit = { }, }; -/* *** CONFIG TX QUEUE FLAGS *** */ - -struct cmd_config_txqflags_result { - cmdline_fixed_string_t port; - cmdline_fixed_string_t config; - cmdline_fixed_string_t all; - cmdline_fixed_string_t what; - int32_t hexvalue; -}; - -static void cmd_config_txqflags_parsed(void *parsed_result, - __attribute__((unused)) struct cmdline *cl, - __attribute__((unused)) void *data) -{ - struct cmd_config_txqflags_result *res = parsed_result; - - if (!all_ports_stopped()) { - printf("Please stop all ports first\n"); - return; - } - - if (strcmp(res->what, "txqflags")) { - printf("Unknown parameter\n"); - return; - } - - if (res->hexvalue >= 0) { - txq_flags = res->hexvalue; - } else { - printf("txqflags must be >= 0\n"); - return; - } - - init_port_config(); - - cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1); -} - -cmdline_parse_token_string_t cmd_config_txqflags_port = - TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, port, - "port"); -cmdline_parse_token_string_t cmd_config_txqflags_config = - TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, config, - "config"); -cmdline_parse_token_string_t cmd_config_txqflags_all = - TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, all, - "all"); -cmdline_parse_token_string_t cmd_config_txqflags_what = - TOKEN_STRING_INITIALIZER(struct cmd_config_txqflags_result, what, - "txqflags"); -cmdline_parse_token_num_t cmd_config_txqflags_value = - TOKEN_NUM_INITIALIZER(struct cmd_config_txqflags_result, - hexvalue, INT32); - -cmdline_parse_inst_t cmd_config_txqflags = { - .f = cmd_config_txqflags_parsed, - .data = NULL, - .help_str = "port config all txqflags ", - .tokens = { - (void *)&cmd_config_txqflags_port, - (void *)&cmd_config_txqflags_config, - (void *)&cmd_config_txqflags_all, - (void *)&cmd_config_txqflags_what, - (void *)&cmd_config_txqflags_value, - NULL, - }, -}; - /* *** ADD/REMOVE ALL VLAN IDENTIFIERS TO/FROM A PORT VLAN RX FILTER *** */ struct cmd_rx_vlan_filter_all_result { cmdline_fixed_string_t rx_vlan; @@ -15709,7 +15641,6 @@ cmdline_parse_ctx_t main_ctx[] = { (cmdline_parse_inst_t *)&cmd_config_rx_mode_flag, (cmdline_parse_inst_t *)&cmd_config_rss, (cmdline_parse_inst_t *)&cmd_config_rxtx_queue, - (cmdline_parse_inst_t *)&cmd_config_txqflags, (cmdline_parse_inst_t *)&cmd_config_rss_reta, (cmdline_parse_inst_t *)&cmd_showport_reta, (cmdline_parse_inst_t *)&cmd_config_burst, diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 29115e255..faccb84ca 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -417,7 +417,6 @@ tx_queue_infos_display(portid_t port_id, uint16_t queue_id) printf("\nTX writeback threshold: %hhu", qinfo.conf.tx_thresh.wthresh); printf("\nTX RS threshold: %hu", qinfo.conf.tx_rs_thresh); printf("\nTX free threshold: %hu", qinfo.conf.tx_free_thresh); - printf("\nTX flags: %#x", qinfo.conf.txq_flags); printf("\nTX deferred start: %s", (qinfo.conf.tx_deferred_start != 0) ? "on" : "off"); printf("\nNumber of TXDs: %hu", qinfo.nb_desc); @@ -1714,10 +1713,8 @@ rxtx_config_display(void) tx_conf->tx_thresh.pthresh, tx_conf->tx_thresh.hthresh, tx_conf->tx_thresh.wthresh); - printf(" TX RS bit threshold=%d - TXQ flags=0x%"PRIx32"" - " - TXQ offloads=0x%"PRIx64"\n", - tx_conf->tx_rs_thresh, tx_conf->txq_flags, - tx_conf->offloads); + printf(" TX RS bit threshold=%d - TXQ offloads=0x%"PRIx64"\n", + tx_conf->tx_rs_thresh, tx_conf->offloads); } } diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 58889420f..fa547df66 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -99,7 +99,7 @@ usage(char* progname) "--rss-ip | --rss-udp | " "--rxpt= | --rxht= | --rxwt= | --rxfreet= | " "--txpt= | --txht= | --txwt= | --txfreet= | " - "--txrst= | --txqflags= | --tx-offloads ]\n", + "--txrst= | --tx-offloads ]\n", progname); #ifdef RTE_LIBRTE_CMDLINE printf(" --interactive: run in interactive mode.\n"); @@ -192,8 +192,6 @@ usage(char* progname) "(0 <= N <= value of txd).\n"); printf(" --txrst=N: set the transmit RS bit threshold of TX rings to N " "(0 <= N <= value of txd).\n"); - printf(" --txqflags=0xXXXXXXXX: hexadecimal bitmask of TX queue flags " - "(0 <= N <= 0x7FFFFFFF).\n"); printf(" --tx-queue-stats-mapping=(port,queue,mapping)[,(port,queue,mapping]: " "tx queues statistics counters mapping " "(0 <= mapping <= %d).\n", RTE_ETHDEV_QUEUE_STAT_CNTRS - 1); @@ -632,7 +630,6 @@ launch_args_parse(int argc, char** argv) { "txwt", 1, 0, 0 }, { "txfreet", 1, 0, 0 }, { "txrst", 1, 0, 0 }, - { "txqflags", 1, 0, 0 }, { "rxpt", 1, 0, 0 }, { "rxht", 1, 0, 0 }, { "rxwt", 1, 0, 0 }, @@ -1006,15 +1003,6 @@ launch_args_parse(int argc, char** argv) else rte_exit(EXIT_FAILURE, "txrst must be >= 0\n"); } - if (!strcmp(lgopts[opt_idx].name, "txqflags")) { - char *end = NULL; - n = strtoul(optarg, &end, 16); - if (n >= 0) - txq_flags = (int32_t)n; - else - rte_exit(EXIT_FAILURE, - "txqflags must be >= 0\n"); - } if (!strcmp(lgopts[opt_idx].name, "rxd")) { n = atoi(optarg); if (n > 0) { diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 806548196..91dcb31c0 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -259,11 +259,6 @@ int16_t tx_free_thresh = RTE_PMD_PARAM_UNSET; int16_t tx_rs_thresh = RTE_PMD_PARAM_UNSET; /* - * Configurable value of TX queue flags. - */ -int32_t txq_flags = RTE_PMD_PARAM_UNSET; - -/* * Receive Side Scaling (RSS) configuration. */ uint64_t rss_hf = ETH_RSS_IP; /* RSS IP by default. */ @@ -2084,9 +2079,6 @@ rxtx_port_config(struct rte_port *port) if (tx_free_thresh != RTE_PMD_PARAM_UNSET) port->tx_conf.tx_free_thresh = tx_free_thresh; - - if (txq_flags != RTE_PMD_PARAM_UNSET) - port->tx_conf.txq_flags = txq_flags; } void diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 3e63edfa1..c9af41cfa 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -409,7 +409,6 @@ extern int16_t rx_free_thresh; extern int8_t rx_drop_en; extern int16_t tx_free_thresh; extern int16_t tx_rs_thresh; -extern int32_t txq_flags; extern uint8_t dcb_config; extern uint8_t dcb_test; diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index fface6f58..be9a2cdd1 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/doc/guides/testpmd_app_ug/run_app.rst @@ -447,18 +447,6 @@ The commandline options are: Set the transmit RS bit threshold of TX rings to N, where 0 <= N <= value of ``--txd``. The default value is 0. -* ``--txqflags=0xXXXXXXXX`` - - Set the hexadecimal bitmask of TX queue flags, where 0 <= N <= 0x7FFFFFFF. - The default value is 0. - - .. note:: - - When using hardware offload functions such as vlan or checksum - add ``txqflags=0`` to force the full-featured TX code path. - In some PMDs this may already be the default. - - * ``--rx-queue-stats-mapping=(port,queue,mapping)[,(port,queue,mapping)]`` Set the RX queues statistics counters mapping 0 <= mapping <= 15. diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 2b00be81c..7d3a7ae93 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -354,8 +354,6 @@ The available information categories are: also modify the default hierarchy or specify the new hierarchy through CLI for implementing QoS scheduler. Requires ``CONFIG_RTE_LIBRTE_PMD_SOFTNIC=y`` ``CONFIG_RTE_LIBRTE_SCHED=y``. -Note: TX timestamping is only available in the "Full Featured" TX path. To force ``testpmd`` into this mode set ``--txqflags=0``. - Example:: testpmd> set fwd rxonly @@ -1681,15 +1679,6 @@ RX scatter mode is off by default. The ``on`` option is equivalent to the ``--enable-scatter`` command-line option. -port config - TX queue flags -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - -Set a hexadecimal bitmap of TX queue flags for all ports:: - - testpmd> port config all txqflags value - -This command is equivalent to the ``--txqflags`` command-line option. - port config - RX Checksum ~~~~~~~~~~~~~~~~~~~~~~~~~