memalloc: check for contiguousness in external segments
Checks
Commit Message
For IOVA as VA mode, we assume that memory is contiguous. However,
for external segments that assumption may not necessarily hold.
Fix the code to not assume that external memory segments are
contiguous even in IOVA as VA mode.
Fixes: 5282bb1c3695 ("mem: allow memseg lists to be marked as external")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/common/eal_common_memalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
14/11/2018 15:51, Anatoly Burakov:
> For IOVA as VA mode, we assume that memory is contiguous. However,
> for external segments that assumption may not necessarily hold.
> Fix the code to not assume that external memory segments are
> contiguous even in IOVA as VA mode.
>
> Fixes: 5282bb1c3695 ("mem: allow memseg lists to be marked as external")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
14/11/2018 15:51, Anatoly Burakov:
> For IOVA as VA mode, we assume that memory is contiguous. However,
> for external segments that assumption may not necessarily hold.
> Fix the code to not assume that external memory segments are
> contiguous even in IOVA as VA mode.
>
> Fixes: 5282bb1c3695 ("mem: allow memseg lists to be marked as external")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
@@ -77,7 +77,7 @@ eal_memalloc_is_contig(const struct rte_memseg_list *msl, void *start,
const struct rte_memseg *ms;
/* for IOVA_VA, it's always contiguous */
- if (rte_eal_iova_mode() == RTE_IOVA_VA)
+ if (rte_eal_iova_mode() == RTE_IOVA_VA && !msl->external)
return true;
/* for legacy memory, it's always contiguous */