[dpdk-dev,memnic,2/7] pmd: remove needless assignment
Commit Message
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
---
pmd/pmd_memnic.c | 2 --
1 file changed, 2 deletions(-)
Comments
2014-09-11 07:47, Hiroshi Shimamoto:
> Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.
Is it increasing the performances?
> Subject: Re: [dpdk-dev] [memnic PATCH 2/7] pmd: remove needless assignment
>
> 2014-09-11 07:47, Hiroshi Shimamoto:
> > Because these assignment are done in rte_pktmbuf_alloc(), get rid of them.
>
> Is it increasing the performances?
I hadn't tried to test, because I don't think it can be noticed.
Just clean up, removing a few redundant instructions.
thanks,
Hiroshi
>
> --
> Thomas
@@ -308,8 +308,6 @@ static uint16_t memnic_recv_pkts(void *rx_queue,
rte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len);
mb->pkt.in_port = q->port_id;
- mb->pkt.nb_segs = 1;
- mb->pkt.next = NULL;
mb->pkt.pkt_len = p->len;
mb->pkt.data_len = p->len;
rx_pkts[nr] = mb;