From patchwork Mon Sep 5 06:52:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre Pfister X-Patchwork-Id: 15610 X-Patchwork-Delegate: yuanhan.liu@linux.intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id A2B67567B; Mon, 5 Sep 2016 08:52:28 +0200 (CEST) Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) by dpdk.org (Postfix) with ESMTP id BFBEA5597 for ; Mon, 5 Sep 2016 08:52:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=952; q=dns/txt; s=iport; t=1473058346; x=1474267946; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=lV025E5+jNvCYP5n6uXOorw/q012jkh4RFZe34oSNno=; b=kSpGGEXYVJ6yAOhxBtXaR8c1rIfHHGVsoAbo+s2AsoCNU6J8F0ynxzo1 Id3yFXwA+dhvzR9JW/Gj0DDsFwaECfoglqboGY2Yu9EWupV9uC4gTQO/n csNqMvg62CPD8X2O/QAaOpsc3xE5+p2BZ1UPeNdgi2jOQH3LaBigfjHmG g=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AcAQBxFc1X/5RdJa1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBgy0BAQEBAR6BUweNJ6h3gg+CAoYcAoE3OBQBAgEBAQEBAQFeJ4RiAQEEOj8?= =?us-ascii?q?QAgEINhAyJQIEDgWISr1+AQEBAQEBAQEBAQEBAQEBAQEBAQEBHIYvgXgIgk6EQ?= =?us-ascii?q?IMtgi8BBJlTAY81j1mQRQEeNoRHcIVvfwEBAQ?= X-IronPort-AV: E=Sophos;i="5.30,285,1470700800"; d="scan'208";a="319432062" Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2016 06:52:25 +0000 Received: from XCH-ALN-019.cisco.com (xch-aln-019.cisco.com [173.36.7.29]) by rcdn-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id u856qPBF022863 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 5 Sep 2016 06:52:25 GMT Received: from xch-aln-017.cisco.com (173.36.7.27) by XCH-ALN-019.cisco.com (173.36.7.29) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 5 Sep 2016 01:52:24 -0500 Received: from xch-aln-017.cisco.com ([173.36.7.27]) by XCH-ALN-017.cisco.com ([173.36.7.27]) with mapi id 15.00.1210.000; Mon, 5 Sep 2016 01:52:24 -0500 From: "Pierre Pfister (ppfister)" To: Yuanhan Liu CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] virtio: enable indirect descriptors feature Thread-Index: AQHSB0IOrzJOSdc14Uq+Oycz95cY8w== Date: Mon, 5 Sep 2016 06:52:24 +0000 Message-ID: <6EFF45F1-172E-4470-B4D7-AED90474DE50@cisco.com> References: <516F65D3-4706-4CC5-916B-6ECD29CBE177@cisco.com> <20160905022028.GF30752@yliu-dev.sh.intel.com> In-Reply-To: <20160905022028.GF30752@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.228.42.60] Content-ID: <576A0A1D4128D04E85977CED934BC17F@emea.cisco.com> MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] virtio: enable indirect descriptors feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Indirect descriptors support was disabled by commit 4a92b67151be11, presumably by accident as it was correctly supported. This patch simply adds VIRTIO_RING_F_INDIRECT_DESC back to the supported features bit mask, hence enabling the use of indirect descriptors when the feature is negociated with the device. Signed-off-by: Pierre Pfister Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.h | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 (Apple Git-66) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 2ecec6e..31c91a5 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virtio_ethdev.h @@ -63,6 +63,7 @@ 1u << VIRTIO_NET_F_CTRL_RX | \ 1u << VIRTIO_NET_F_CTRL_VLAN | \ 1u << VIRTIO_NET_F_MRG_RXBUF | \ + 1u << VIRTIO_RING_F_INDIRECT_DESC | \ 1ULL << VIRTIO_F_VERSION_1) /*