From patchwork Wed Jan 3 08:21:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?546L5b+X5YWL?= X-Patchwork-Id: 32848 X-Patchwork-Delegate: yuanhan.liu@linux.intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA8281B1B1; Wed, 3 Jan 2018 09:21:29 +0100 (CET) Received: from smtp.jd.com (smtp.jd.com [58.83.206.59]) by dpdk.org (Postfix) with ESMTP id 55B231B173 for ; Wed, 3 Jan 2018 09:21:27 +0100 (CET) Received: from HUB06.360buyAD.local (172.17.27.42) by HUB03.360buyAD.local (172.17.27.17) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 3 Jan 2018 16:21:27 +0800 Received: from MBX05.360buyAD.local ([fe80::7043:229a:8a1b:2ced]) by hub06.360buyAD.local ([fe80::a522:2f79:88c6:4981%15]) with mapi id 14.03.0382.000; Wed, 3 Jan 2018 16:21:27 +0800 From: =?utf-8?b?546L5b+X5YWL?= To: Tiwei Bie CC: "dev@dpdk.org" , "bluca@debian.org" , "yliu@fridaylinux.org" Thread-Topic: net/virtio: fix vector Rx break caused by rxq flushing Thread-Index: AdOApPV0Gq72PaRJSH2kZjTbP+YFywAOvMCAAOLhsnA= Date: Wed, 3 Jan 2018 08:21:26 +0000 Message-ID: <6DAF063A35010343823807B082E5681F41D84163@mbx05.360buyAD.local> References: <6DAF063A35010343823807B082E5681F41D839EF@mbx05.360buyAD.local> <20171230040209.b73z42ymlh4emjxe@debian-xvivbkq.sh.intel.com> In-Reply-To: <20171230040209.b73z42ymlh4emjxe@debian-xvivbkq.sh.intel.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.17.27.83] MIME-Version: 1.0 Subject: Re: [dpdk-dev] net/virtio: fix vector Rx break caused by rxq flushing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tiwei, Thanks for your help and info. I have another question about your previous fix below. You mentioned that " Otherwise it will lead to incorrect packet collection for port state." Do you mean port statistics? Or such packets may leads to issue, like more TCP restransmission? Thanks. commit d8227497ec5c3de75fe378e09fc9673ae097fa73 Author: Tiwei Bie Date: Fri Oct 20 10:09:28 2017 +0800 net/virtio: flush Rx queues on start After starting a device, the driver shouldn't deliver the packets that already existed before the device is started to applications. Otherwise it will lead to incorrect packet collection for port state. This patch fixes this issue by flushing the Rx queues when starting the device. Br, Wang Zhike -----Original Message----- From: Tiwei Bie [mailto:tiwei.bie@intel.com] Sent: Saturday, December 30, 2017 12:02 PM To: 王志克 Cc: dev@dpdk.org; bluca@debian.org; yliu@fridaylinux.org Subject: Re: net/virtio: fix vector Rx break caused by rxq flushing Hi Zhike, On Fri, Dec 29, 2017 at 01:02:04PM +0000, 王志克 wrote: > Hi tiwei, > > Can you please provide a patch for 16.11.4? Thanks. > Normally, most commits in the stable tree are backported from the commits in the mainline tree which contains below Cc line: Cc: stable@dpdk.org This patch also contains such line. So after this patch is applied to the mainline tree, it will be backported. If you need the fix right now, you can download the latest patch (which has been applied to dpdk-next-virtio tree) from here: https://dpdk.org/dev/patchwork/patch/32061/ It can be applied to DPDK 16.11.4 with the patch command. After the patching, one small change is needed to get it work: Besides, I'm not sure whether you are aware of this or not. But just FYI, when you want to use the vector Rx of virtio PMD, you need to be aware of the fact that the current implementation of vector Rx doesn't really follow the virtio spec. You can find more details in below link: http://dpdk.org/ml/archives/dev/2017-December/084101.html Best regards, Tiwei Bie diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c index 7fd8604..0e24194 100644 --- a/drivers/net/virtio/virtqueue.c +++ b/drivers/net/virtio/virtqueue.c @@ -88,7 +88,7 @@ virtqueue_rxvq_flush(struct virtqueue *vq) for (i = 0; i < nb_used; i++) { used_idx = vq->vq_used_cons_idx & (vq->vq_nentries - 1); uep = &vq->vq_ring.used->ring[used_idx]; - if (hw->use_simple_rx) { + if (hw->use_simple_rxtx) { desc_idx = used_idx; rte_pktmbuf_free(vq->sw_ring[desc_idx]); vq->vq_free_cnt++; @@ -104,7 +104,7 @@ virtqueue_rxvq_flush(struct virtqueue *vq) vq->vq_used_cons_idx++; } - if (hw->use_simple_rx) { + if (hw->use_simple_rxtx) { while (vq->vq_free_cnt >= RTE_VIRTIO_VPMD_RX_REARM_THRESH) { virtio_rxq_rearm_vec(rxq); if (virtqueue_kick_prepare(vq))