From patchwork Tue May 1 09:58:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shahaf Shuler X-Patchwork-Id: 39195 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F2BD1E35; Tue, 1 May 2018 11:59:03 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0069.outbound.protection.outlook.com [104.47.2.69]) by dpdk.org (Postfix) with ESMTP id 45A8BDED for ; Tue, 1 May 2018 11:59:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=e5qLkgRjsLUOzZmWyYvB5SLy+sw6LzS4WNmWi60Dd6E=; b=Hi8uhXMjPD8cUM0Ktt4/iTA+YkCIo5nt/PRpu0ML6U/jzS2XcxLcEWyd96V8Y9pz34fmBSY1DRDXPiTqG7dwm9cYDkhbmporNdSB1nC5NvTDfsgHsjXU3AEBqHmJj/VCQtVAq/eOHL+iU5M3zI/t/wfQR04djR0+K988d0fMR7k= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; Received: from mellanox.com (141.226.120.58) by DB7PR05MB4426.eurprd05.prod.outlook.com (2603:10a6:5:1b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.20; Tue, 1 May 2018 09:58:59 +0000 From: Shahaf Shuler To: nelio.laranjeiro@6wind.com, adrien.mazarguil@6wind.com, yskoh@mellanox.com Cc: dev@dpdk.org Date: Tue, 1 May 2018 12:58:48 +0300 Message-Id: <421987dcb5779584a1c880a0a74c0eb245cbbfb2.1525168586.git.shahafs@mellanox.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180429180308.85361-1-shahafs@mellanox.com> References: <20180429180308.85361-1-shahafs@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [141.226.120.58] X-ClientProxiedBy: AM0PR0102CA0072.eurprd01.prod.exchangelabs.com (2603:10a6:208::49) To DB7PR05MB4426.eurprd05.prod.outlook.com (2603:10a6:5:1b::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4426; X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 3:3Er+JCzV/cO/DxprXIkTVXnkv+0bNX+1T0i858s9QBqTJujskqyoDxrYOKG7dP0Pnq9x1mSbTcg+7pEZs12hL7zhCvqy+vijNUaMj2o9tSwenk35bw7IOVw536yMP92Bmxn4liveXwGDU+fGs3xQ/qMNu3Wa92ld1cDYPTrNKMUFAtFK3FHEwCJCtkewjLNeHX2kTcmRIojuZOe5JnNNocKRQgAJOF3t/VlD2AQ06qvEuDXLfR1fRKfX6wNDWUCH; 25:H+ZfnHV/XOlX+XAueoSglf3oAfDlCGmnYA+sKygie8SABK5vz1K7XtFsBpeaZxPb/xvPqBSUZOpR4VG5JUYJCpCWgoAJebTH19kUZn7He5OsUmlixgq8nPI4v6LMtYUMoTJG1JPf+yY+P5eVrj6rCaRLWJ5q5FRztBvlhJRwASSx9YunmNixKuQR+2D46lqXhX5wmmZtRg17Po5hNnBhWJeRle/48dHgJOCa1VE/Qo71QFYRSR6FMWgxKcz43uWoJfPPb5e+b1Y8/ysg/aVw/p6OXKqS7yrnSSMHrS4kMmJ2D3He2nbnzMF1c39LoaJZsZhxdLv0riwGgBLVBKZvKQ==; 31:0H2vvY1gT4jrC97TLdtzorL0CkgDCLJoqlkDfSuLm2kUSH+ZJkgFUMr2xl9KF5ow9bbpM7LPeiB7ojiWKie8izTzQr1ef9A9dMepjY96lCLqORqgyUB+OthhmwB6cxL6hFxrdrFH921dMT5LtigDG+ZM8XdSAYRQuI7OgwRIyJuG43aCwfm4Apbw4o269ST1x907XhmuP01IL0fu7VizctTvvV1Bv2D5g87iVRtYjok= X-MS-TrafficTypeDiagnostic: DB7PR05MB4426: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 20:ayG4KugINpyJ9WgRs0oX/LirUbRO5f3CFhqF5O9hKy7S/Pf/4uQtmh11p7UVXR5iKOsJmuTMawRrdA6QRAWjDGfEgc5XpvnP4bLdI2TJP+zvfLLDsNWJ0SP7a0RSI+ChwYgqRAEaTPZLJgp3bgwOM5SgjmuVUetNy/IVHS/975Oa/MK+T8sQO6XsSzJ8Ty4f3X+b615bVkig5yQy+YARmJkqFu0EU4P2+EU2V7SjFmq/gqBtW5fZ6AD2dFqO5zaMPrC1lzNAzicTW9Hz2HAFjMb7ggdM4st7ldty1JgxLJCScL/pRvykHyb0f+/f2ZIPELb42ktpC+VrwT2fICsm/8h88ivSuu/4qY1QJqzX3DsQIEFvzt/1vndXIBGBy6h0wx9vOMlfOiOLqcpurRA+7MECJ5uIdNae56qPS2dWeaTguRicZyBzW+xEGS7Mg9my8VuvL7DqKt5rVcnB5mWeCKxAv8G+KkJysIiFBHO9KVelhzboh6rtyx/g4A1I+xJq; 4:Tee3H3mVOrlD2cxQ0RTItJ7kLuGdnlr+1atDsGp6UNj3+VViisXobI68jZTq9ZQNjJyTLMBAxPLdZM3KDeeVk50N8wEa3jtcyr5pJx8fDXd/sNQH5z7wbR4693D/GFAkW3y05fhZLAo1AXFC+GxUQEfHNRa9Rki1OsamphUE/QP5nmGfzBGbErIWZ3+v6XqhU2VfyIEmDAZs/nxN654yKd+5I/RZdMDHvmdI+xoXgpTAq+xYHblgDhQTL5q5jyQeghbPOYVVdHXKZGGeWHmc9Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(10201501046)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:DB7PR05MB4426; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4426; X-Forefront-PRVS: 06592CCE58 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(956004)(11346002)(2616005)(6116002)(3846002)(305945005)(68736007)(48376002)(53936002)(446003)(69596002)(486006)(476003)(86362001)(16586007)(5660300001)(316002)(66066001)(47776003)(7736002)(6666003)(6636002)(81156014)(8676002)(81166006)(2906002)(26005)(50466002)(25786009)(7696005)(59450400001)(186003)(36756003)(52116002)(118296001)(55016002)(16526019)(51416003)(386003)(76176011)(478600001)(4326008)(105586002)(106356001)(97736004)(50226002)(8936002)(21086003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4426; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB7PR05MB4426; 23:SfnvcitJb8drdED2iOFf1WOW0vQI6zb3Geh3gWM+d?= g6vpvOGHB4cWfTC01o2gLUuu8tKqYYn2odnU8EEDdrwTf6aSK7h5TkmCX8MY0OVnxkCRBfoSZDmk73HpPszabaLJ5eL2okeG1jcGBeBVknl4PjGpzgQcYy05NmpOvGaDogC1YUmXkXtKMG25xA4dOESSbIpIE3obtHtfmNq8RzeSc5qYXXPcB7M3VEZfaRX54PdYIUwQM9Qi4hqKdcwmrMvxppSvEhfjQEStrOmKWk6q0kZwv426cb41a56RKzo1zsGKZnHGfscZ7g9fMaZQmBhx2LnprlgNMKyV0/4EU443/aDLL6xS4xhc1CGhpPQt9vNuZau1wSBV6M1GM3uPVfNdv3Glq8Xl1f6hifuKrDkLp7lT6nA2Chg8tJCovtK3oNDyWNA53WqKXtesmU9Re/+QbtivMucDz9rb2TZkHXroVC+gQZ5Nz5vJxiiGJcGbqi90HdaZ2uwa7G2K6H73u9fKycW0yXLc+w+tezfyClvpcNCcdDzqclcZ9nmYtMrEQnBQqRaEMfEJ+GTKIzMab+JVmXbAs0u6481ME0EHekWHEmk1xuzKhOQmWH+Jiztf1ds8vbU+/PjwNztBfF+Ee00hv2q1mUlaaMo312h97MAA0fNw82sivUFcOSWmkUIVq/UvVNS4jZSYyobn54CUINskg24g2or8dnjPJxfQzDgCC+P5hHp0V/JvkEJ4c5Wn4zmPUN7FgMXq2MB0M3e5Zzd/MNAK8VeE3X0eRJqDQC2S1+s7HpLTA3/1KRRkVrjZ7jVachtmBIdhUcmF/+8TqaTRHDcgIB9kl55n1pE8hMslckaxkCAJl71a3kGoR5syvyjz+rD9jM/mx6wSNY6LqCtHwthLDwcmcP75eadoCCiKcTnAu3v9GFs8Ibom4sTDQxTUG59d5EdP79wiH+MUSIXsaPIdn52Bb8w032ITcuQZn6cMI7Mzyag31f85xBUVyV/xCuIlnjWxSx4IJEEq6DiUep/kQ+FgJ3d9jjxo3K0WZoXb9YhlD6KkR7D6EJbNcP7WcFRFZdH8nzDm3y1faIBLbnazEGanyLa1qZfISSGIl84dEoRuN3C4kYDERKy1UETTyhN3/wXFvj8Q9mXD1Eye6gnou5nD8My9VMNzSbP3Sk0m2r3h5v5/OKZmthDGUFZXbjjhtzuB5gg5kjLIzwiNpkin3ifwenvAg+/bvwrpr0775n1wu1BH9RG/ECL8lg= X-Microsoft-Antispam-Message-Info: UUYrVa3TbpWXwZzgJwTjQ+YjJSNZrU9dNTss1eSwrSON1olZvyoOInG1J/or4MoyY33QGjDiReQ+5ahy6iYTiXdLjTWNkgE7kIMCzGTUK4wMuTSrIShGH2dmrRao6V9+m5+t+PyVH8RitmNjjGY6TywrcFD4A4f8PdUyHe3eAYvyXCTZ7G8YCUorVbihQhU5 X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 6:9wcpJ8QQqGTqkxTvxcFahvwGGmxCdArFjTlAZt3zZX1mFspDDPr6+wd+b6eMHLgjofKr705wtqiRLT7cCL92I4BMhAJW92l5ptoYi66RRyojebRDqPHpBjyxg4pf4eigstlmtrA6EhQInPEO0D+c+f5pcmSc3ddlcX87O3UlRzthlBqan9XXd7kIKm4jvbM0x7GQtaKBlF7Vxatk7q9YJudJiEmaUQRlnK+ILO4Hi4aTl9KUqgt0tKt3mw3kLhddyqoMj0qJBQ1i7A2uuZ/HcjP7vY/LyqAv4ISf2dEJ0u90qT9gKW+gDyX1/t/Q6AVJ2Fk9lZ7hGQ7/wNPEXQeCLH07tcSzKit2p/D0dttNiums+hn21rDvTN/0G8eZx9GpJKYHh2FwF2QUBBnA9H7ubQTdQW0sONBcjXGIlvi+zP2Vp64hPKIrzU5xV/3CjD0nnZ3mcuYNi0Z6GVB4HND81g==; 5:/vMrNpkvrGIoQRcJWK0olDfRs9nBM+hpKnFcxUmZAE/rHm5D0bv8kgreqboG4ibxCXMIVQZwQo8iOMBfrM/wP8y90m9TyuRBeppHfZEpEXU9s+tindplHFYlxHVwKr6G9XlB8wMAGvipoGhLIsjEG5wgSsYgTJ892WbBdJzJAF0=; 24:yK+aSF2/+CXlQkbJmu/l2lgyNj/b7GpuMo1lnl663J13I4+aERNHz7wf2Wjl7o9dpGrqNURBDUQ8MeLT0+ku/56YFRO5AICfBgIR444icQU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB7PR05MB4426; 7:gXZnzX6fEODuJ/reEuSM3mi/OsaufNfOmkEojz+O/NxgDq850cq7DbXeOyyrt5nwDMHwH9hzIZdQQXBGZDqoQ83LRoOhym2tCS1oyDlb0mbd2XW5inmTPIL2wlniEici20HeyzWCbfWypZfdcNQryxk5zUeo0J4U0KHmuj19fcv3iaue4TevgDSFwRMATyEsg7uzoz7l5dEhbEIdcRz91xq9RK1UCFdrIDl7sAEY7eTsBKubTlBCTikUQJAZiflK X-MS-Office365-Filtering-Correlation-Id: eed295be-7093-4cb5-215b-08d5af4a2941 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2018 09:58:59.1899 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eed295be-7093-4cb5-215b-08d5af4a2941 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4426 Subject: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix ethtool link setting call order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" According to ethtool_link_setting API recommendation ETHTOOL_GLINKSETTINGS should be called before ETHTOOL_GSET as the later one deprecated. Fixes: f47ba80080ab ("net/mlx5: remove kernel version check") Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro --- On v2: - no change. -- drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 746b94f734..588d4ba627 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -697,9 +697,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) time_t start_time = time(NULL); do { - ret = mlx5_link_update_unlocked_gset(dev, &dev_link); + ret = mlx5_link_update_unlocked_gs(dev, &dev_link); if (ret) - ret = mlx5_link_update_unlocked_gs(dev, &dev_link); + ret = mlx5_link_update_unlocked_gset(dev, &dev_link); if (ret == 0) break; /* Handle wait to complete situation. */