From patchwork Sat Mar 9 14:03:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 51010 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF0B25699; Sat, 9 Mar 2019 15:03:41 +0100 (CET) Received: from NAM05-CO1-obe.outbound.protection.outlook.com (mail-eopbgr720076.outbound.protection.outlook.com [40.107.72.76]) by dpdk.org (Postfix) with ESMTP id 647184F90 for ; Sat, 9 Mar 2019 15:03:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ipuTH0c4InD4UNeJ540Sdqni4fRPmh8Pjb4kzF/gsGY=; b=YDwioipCNSJB0aAoS89al7PI6xxNbQA/dtCkE9gjKyld679DFx+EdfHiQ8fgWNHXtctDjteWNs+VdCVFRFo4kcQU8nX97hb0uKb9gwbzcCxpCQz4TzMWy89Au94c2LeXIDT0WIJun9nI8xN+pkewP4luJzVedgM1gixpYCOs95E= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB2892.namprd11.prod.outlook.com (20.177.216.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Sat, 9 Mar 2019 14:03:38 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::d145:a1f4:ed34:e31b]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::d145:a1f4:ed34:e31b%3]) with mapi id 15.20.1665.020; Sat, 9 Mar 2019 14:03:38 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH v2 08/10] net/atlantic: eliminate excessive log levels on Rx/Tx Thread-Index: AQHU1oDkRmKDEPs+NUWxzcTn2zmPxg== Date: Sat, 9 Mar 2019 14:03:38 +0000 Message-ID: <41721f486b1a4c6feb0d0c4a4ce92a65f9af209b.1552138867.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR05CA0278.eurprd05.prod.outlook.com (2603:10a6:3:fc::30) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d974867a-83ae-49ca-188a-08d6a49806e6 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB2892; x-ms-traffictypediagnostic: DM6PR11MB2892: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB2892; 23:CWUV7vhTijLBZkiS9TjaMEVY3ZsmStIRQJLU24T?= =?iso-8859-1?q?MvRfjNvlYyGJwC2RFBGwru3gq?= =?iso-8859-1?q?vLBC4CdGkACT90Kz7PM/XI5awcSUhirSv5kE8UYoYxeiRUeHeGu?= =?iso-8859-1?q?1lK7cQx8GxZppXllCICboW6861MdovlevOvFm7nNohPEKVM738z?= =?iso-8859-1?q?3mESHpCJq+F6zMGQBUaexUOpygllmtuqOE7SoUDz3cy1wLyqy26?= =?iso-8859-1?q?EoJHkbjniTqdXyvVd+MJG8GEKbejZLUarrdQAakgSh2SfLVeQzU?= =?iso-8859-1?q?zNQuvQatSlbXDVPkYUYG6akFeswDsCYLk0dz3QjPhnOyAhU+6Q9?= =?iso-8859-1?q?jomSOXfTLGu4lePScOFaOT1WjGaWszHeJRXALbOBOSBE/pmZ/ID?= =?iso-8859-1?q?umD5crSz8IzQmuQAAvzmI1jOoperNhIVgeoWKe8zrrkjRtAlq/x?= =?iso-8859-1?q?X6b/RCyqRgIXU1I+JNnlPjQAnm7HuU3iJ6a1CW4FF72Cm9uSxBP?= =?iso-8859-1?q?Y1uG14uAcLREbxOcmHLYNGR6FHIHX+Prv7UN/rqIujh6RVyhKxg?= =?iso-8859-1?q?X/Zf7Z7Ci1lbDfxo0m1MwkTnoMoQuMtnpskSVOyv4cCLN7ll6lM?= =?iso-8859-1?q?Z4vmY8xhFpp9EdvZTUBCDPvnnV882T3s15nY8xEdXP3aBDPCv3/?= =?iso-8859-1?q?sLtBvMqNo3CNY2UzXC2GoMORZnVd+qRDEaCsV/agVbsLQ/qUVwZ?= =?iso-8859-1?q?98ONQACYNJ61a7nIZWoeVsOineyOQVY7k2c+uRu8XeyJGWI3RJT?= =?iso-8859-1?q?QxQbAsxzU3oR6vX+oZ7sfQ/7/2AwWHa1A5nN8ZEt1kL6VfAXzse?= =?iso-8859-1?q?Lg9cl0vbl0pRjOOIyYVcD2bdIqODx95Jg17LJHtiX4sxAA6hwnp?= =?iso-8859-1?q?IcXDMwbjB0opqxyvih7QuDaODcwcBED5sn+KPpInvJ3E0kWjGqY?= =?iso-8859-1?q?v8BN69AHyA09BEY4FSv8/8a0tUardhqJGd2j3qJHAN3MuZJTsYp?= =?iso-8859-1?q?4+tEsgfrvPiIZz72XGUFJ4D9ETn6NLUatRWzXcFvBc7NfILUeDE?= =?iso-8859-1?q?ynAKf2SQq60IcVMD5G/ms3LJ9BI7M1AmEB3Kuyq34tmcXua1F4O?= =?iso-8859-1?q?zla2PMcYQn+RkL3TpmvA8xFlKsXzpgK2WEMECErCBupfjB5/oIU?= =?iso-8859-1?q?clHinVSQzAFn/HrDQPBeALEVXoKSXqYN2gqdHjr2KzV69xIJNZu?= =?iso-8859-1?q?UFndD1D4HhLe33W/BM7i++c3+gbPJp5XuuR8z+IPb8JCwW/UXFc?= =?iso-8859-1?q?/koaNJ/zVg1R4wGduAygkPihbHTR50zRz/eB7LLHR3t0pmq0NWP?= =?iso-8859-1?q?aDg/CPP1aBAoky7qkpWuxDmC54nPC+zjjtVkyvgTgX4F7LPyUu2?= =?iso-8859-1?q?4Gk8Yver0MIjSZRYv58ZMvwgdiVXaNA5TIAPZZp/VfRfYFBSCio?= =?iso-8859-1?q?N43J44o33Dh2DzmHjTrSdIyNzBg=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0971922F40 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(366004)(39850400004)(136003)(346002)(199004)(189003)(106356001)(5660300002)(6116002)(26005)(4326008)(99286004)(52116002)(2906002)(3846002)(76176011)(107886003)(2351001)(105586002)(14454004)(102836004)(97736004)(476003)(68736007)(44832011)(386003)(186003)(486006)(11346002)(446003)(2616005)(6506007)(25786009)(2501003)(86362001)(305945005)(7736002)(72206003)(8676002)(6486002)(256004)(118296001)(316002)(8936002)(66066001)(6436002)(81156014)(1730700003)(53936002)(5640700003)(81166006)(50226002)(71190400001)(6916009)(54906003)(36756003)(71200400001)(478600001)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB2892; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AfyZt+7Ky5fifqP3Z5vQJqSL1uH3U+3delV9W8wDO1YXxmRGGTensg1lGXMRV4CGvExXgzZxAzv9qCIF0zNT+VsUOy2J/gwvG4Z6Sq59V8CgP9GpTFfwZPxKAHEiMrnM0Dnry4Dwte1tLM1DA+cBVVEZxGNZLdvwGnL9kduMbqr1FY79j+aHrqZ5BR7YEGoTkgJ+t2xBjNDkeOLx7pD4V1B/4M5Zl7UvVDuV+UiafBurN9p2JYFvTMagiKOjX/A3OYFBCfRhepdluXmdGoqn5qsgsJRglPfYZgf7lv9Bcw6iE4d49a9khVCae9oEfB2yQMYWo7SCP03Cval2PxYV8oLDISD4C9WII2o7QFvNVnldG6FHW3hiaAB2V+Fxe9/6Z7C+PXZTsObLMv6UUzXnszafFKR5c2VqOkN8T/5xr8g= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d974867a-83ae-49ca-188a-08d6a49806e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2019 14:03:38.0553 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2892 Subject: [dpdk-dev] [PATCH v2 08/10] net/atlantic: eliminate excessive log levels on Rx/Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Default rxtx logging used ERR level, that caused logger to always trigger. That may cause perf degradation even if logger was not enabled but compiled in. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_rxtx.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index aea58c0d5b83..f1519594adad 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b/drivers/net/atlantic/atl_rxtx.c @@ -946,7 +946,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) break; } - PMD_RX_LOG(ERR, "port_id=%u queue_id=%u tail=%u " + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u tail=%u " "eop=0x%x pkt_len=%u hash=0x%x hash_type=0x%x", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id, @@ -981,7 +981,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) while (true) { new_mbuf = rte_mbuf_raw_alloc(rxq->mb_pool); if (new_mbuf == NULL) { - PMD_RX_LOG(ERR, + PMD_RX_LOG(DEBUG, "RX mbuf alloc failed port_id=%u " "queue_id=%u", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id); @@ -1084,7 +1084,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) adapter->sw_stats.q_ibytes[rxq->queue_id] += rx_mbuf_first->pkt_len; - PMD_RX_LOG(ERR, "add mbuf segs=%d pkt_len=%d", + PMD_RX_LOG(DEBUG, "add mbuf segs=%d pkt_len=%d", rx_mbuf_first->nb_segs, rx_mbuf_first->pkt_len); } @@ -1104,7 +1104,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) */ nb_hold = (uint16_t)(nb_hold + rxq->nb_rx_hold); if (nb_hold > rxq->rx_free_thresh) { - PMD_RX_LOG(ERR, "port_id=%u queue_id=%u rx_tail=%u " + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u rx_tail=%u " "nb_hold=%u nb_rx=%u", (unsigned int)rxq->port_id, (unsigned int)rxq->queue_id, (unsigned int)tail, (unsigned int)nb_hold, @@ -1129,8 +1129,6 @@ atl_xmit_cleanup(struct atl_tx_queue *txq) struct hw_atl_txd_s *txd; int to_clean = 0; - PMD_INIT_FUNC_TRACE(); - if (txq != NULL) { sw_ring = txq->sw_ring; int head = txq->tx_head; @@ -1181,11 +1179,7 @@ atl_tso_setup(struct rte_mbuf *tx_pkt, union hw_atl_txc_s *txc) uint32_t tx_cmd = 0; uint64_t ol_flags = tx_pkt->ol_flags; - PMD_INIT_FUNC_TRACE(); - if (ol_flags & PKT_TX_TCP_SEG) { - PMD_DRV_LOG(DEBUG, "xmit TSO pkt"); - tx_cmd |= tx_desc_cmd_lso | tx_desc_cmd_l4cs; txc->cmd = 0x4; @@ -1240,8 +1234,6 @@ atl_xmit_pkt(struct aq_hw_s *hw, struct atl_tx_queue *txq, u32 tx_cmd = 0U; int desc_count = 0; - PMD_INIT_FUNC_TRACE(); - tail = txq->tx_tail; txc = (union hw_atl_txc_s *)&txq->hw_ring[tail];