From patchwork Tue Feb 28 08:33:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 20936 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id CAA822C2B; Tue, 28 Feb 2017 09:33:31 +0100 (CET) Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id DCDA92A5E for ; Tue, 28 Feb 2017 09:33:28 +0100 (CET) Received: by mail-wr0-f175.google.com with SMTP id u48so3616208wrc.0 for ; Tue, 28 Feb 2017 00:33:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=2zHWfUwfxgT43kqkAM3Djh0nJlIUeuhNz2L6sgaFeS8=; b=PX5BaJjg1rqXS7Jlzan69LHkvn5vR7ghNff9VMckNvjmWV2OSFjEuJmvtDWyasiYDJ /NzXsXgiKeAvpZbRHuNgSH+uNXFgtghWPfp3G6Rsd82cyu9nhIvZyZR7fhiv8bqJDeUz iSPeeiup+zXZ1bVHAXg8uYbt1V00SsA2f+xcIOuv4h1rxs6U5wyLrhl5n1s56nUanRE1 MniEx7rvUL5vjyw+q81SZ2Jjoe/l5uSB63guporl1hXcd08kraULIMh+edzlaFm7ieS7 5E3IIQjHaSIlcRSzyBZVl5rXZUaiZdXAAng7RbwNkqwc29XvsRcuKgBbkN6RvAWA9jQI h0zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2zHWfUwfxgT43kqkAM3Djh0nJlIUeuhNz2L6sgaFeS8=; b=qLAL+ulOgeTtd9RnXdkmjZ23H0n6ZPrNIq4N3V9Lw8NFJrrPl+lSX1/vEpj0TUqLDu X5mCiGTl0MnSZTs/QS6bObwC7pvgU16LMH89QdYC4/qR3Bo3a+nqtp4wht775pBYZ1uu It84U1m6f7p25psQ5Fx6t/XWcSvJHxINw8KoCOnTWNhLi47/PEGRiqFo0YZ7jzvtNJ8g 0n0qrGfzkoU0Q9ntep9Ko3yEL1niQwfz7QRY8ZSBgVpI0bOyyqZdl6n+AvUn6VtmgnCE ZeOhDC77n1VDdk5gwdQiyvPBdI4m/XzqhEN8oITMSexNFLYaOJL7+fvOQVuYEmFPGoaG S5lA== X-Gm-Message-State: AMke39ly9rBSNStX7evHBfkDAhcMvIBd+PBRGbW7OqdSaMrrP23gO5Bsm6pg19jgRT08PqJF X-Received: by 10.223.160.14 with SMTP id k14mr1175799wrk.69.1488270808330; Tue, 28 Feb 2017 00:33:28 -0800 (PST) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id w127sm1613918wmg.30.2017.02.28.00.33.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Feb 2017 00:33:27 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil , stable@dpdk.org Date: Tue, 28 Feb 2017 09:33:08 +0100 Message-Id: <38bffaf86edf94efd9d271feb251460e46ef5597.1488270759.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH] net/mlx5: fix a wrong error handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The returned error code was wrongly handled causing the PMD to refuse to start. Fixes: 91572d2a0b1a ("net/mlx5: fix startup when flow cannot be applied") CC: stable@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_trigger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 683b57c..0acbf28 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -87,7 +87,7 @@ mlx5_dev_start(struct rte_eth_dev *dev) if (dev->data->dev_conf.fdir_conf.mode != RTE_FDIR_MODE_NONE) priv_fdir_enable(priv); err = priv_flow_start(priv); - if (!err) { + if (err) { priv->started = 0; ERROR("%p: an error occurred while configuring flows:" " %s",