From patchwork Thu Oct 12 12:19:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 30279 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B019B1B348; Thu, 12 Oct 2017 14:20:56 +0200 (CEST) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 5757A1B310 for ; Thu, 12 Oct 2017 14:20:43 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id t69so12678827wmt.2 for ; Thu, 12 Oct 2017 05:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SrUwn90CYUH0d7lRJoTtqzkGZ9inO2wzNguVoPliDf0=; b=NWZQNbcUQT+wo0xPZPCSJRP+J2LbkOFpn2Bsi4bRmljq/UKaBpbvNR3GlcePmIeIKB /6litkKRKeKmfCzLfTtkkyySn8K6v24b24aHcZ1xkNLBm634BjOVVCZkxEgcmVo3SnF2 EabgH9BGuM2FOiLZoNzRvUi8f4X4gMRHHCLZTLXdk8NLDj14chbPjSaB7Rs/fQMTpEgd SZtGGVCU5qasHofwKVM1cOxfVOyMhXGmdnGjnYCJnbyXr8v6H44EUs49CqEyVfaGiO83 CB/s/zglqC68nkSeIoljQWL6JVlmzISW3LJHWJqy55NkBKnJZ67CoLs5roHJPJ0uKHAR bISQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SrUwn90CYUH0d7lRJoTtqzkGZ9inO2wzNguVoPliDf0=; b=ElfUvoaqPHTCP/4lwIEEUsLwBLt4LLthj6OsltjXH2AOvmpg3YEYGIh7mlEY23PLrL gJyKmvdnYF+b3oiSUjBLcdReZcWlxPgNhgTkKEJeidGkwyy3m6aIWC2mO4IRV27YsTPK JWf+vT/Q9iupiW1voEqwLiZfjZexAmirLOkBqjLIsxBn6vLJ0YVhiV+4z5E2+e+3WByL ItGhl9qCWKE3gNyVhPvypvLb2tHa5dfI3nHCYPpFW0PMDL76uhX0uMrf9FMP0MsD2byN Ae4owo0jbxyUiGbd05Ynlhg+kxGdG2va5M8MgYqP4kxH2S3YwEOiu5YF2XHo7Wj9Kiub usoQ== X-Gm-Message-State: AMCzsaWXDCPv/uDyoeEbdJzkZ0DVgDeBooG+X2zkIEknElpMQds74gmR NweF+Z8TFKE3WF6SKbm9sdg7oQ== X-Google-Smtp-Source: AOwi7QCUNpf+PkXDFGjd9/8LbhBBXB0AbQm10iQ8ya2NT3oWTQ08L2nRSPcjY2O9eqNUtshFRqtv9Q== X-Received: by 10.28.1.199 with SMTP id 190mr1853959wmb.51.1507810842977; Thu, 12 Oct 2017 05:20:42 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u18sm18134933wrg.94.2017.10.12.05.20.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 05:20:42 -0700 (PDT) From: Adrien Mazarguil To: Ferruh Yigit Cc: Nelio Laranjeiro , dev@dpdk.org Date: Thu, 12 Oct 2017 14:19:42 +0200 Message-Id: <36a1ee107ea18a513acd5822231724de6286f29a.1507809961.git.adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 28/29] net/mlx4: disable UDP support in RSS flow rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When part of the RSS hash calculation, UDP packets are discarded (not received on any queue) likely due to an issue with the kernel implementation. Temporarily disable UDP RSS support until this issue is resolved. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/mlx4_flow.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 2b60d76..4c498f0 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -133,9 +133,11 @@ mlx4_conv_rss_hf(uint64_t rss_hf) [TCP] = (ETH_RSS_NONFRAG_IPV4_TCP | ETH_RSS_NONFRAG_IPV6_TCP | ETH_RSS_IPV6_TCP_EX), - [UDP] = (ETH_RSS_NONFRAG_IPV4_UDP | - ETH_RSS_NONFRAG_IPV6_UDP | - ETH_RSS_IPV6_UDP_EX), + /* + * UDP support is temporarily disabled due to an + * implementation issue in the kernel. + */ + [UDP] = 0, }; const uint64_t out[RTE_DIM(in)] = { [IPV4] = IBV_RX_HASH_SRC_IPV4 | IBV_RX_HASH_DST_IPV4, @@ -753,10 +755,8 @@ mlx4_flow_prepare(struct priv *priv, .rss_key = mlx4_rss_hash_key_default, .rss_key_len = MLX4_RSS_HASH_KEY_SIZE, .rss_hf = (ETH_RSS_IPV4 | - ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV4_TCP | ETH_RSS_IPV6 | - ETH_RSS_NONFRAG_IPV6_UDP | ETH_RSS_NONFRAG_IPV6_TCP), }; /* Sanity checks. */