crypto/cnxk: fix uninitialized scalar variable

Message ID 20250515080632.1676-1-gmuthukrishn@marvell.com (mailing list archive)
State Accepted
Delegated to: akhil goyal
Headers
Series crypto/cnxk: fix uninitialized scalar variable |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/loongarch-compilation success Compilation OK RETEST #1
ci/loongarch-unit-testing success Unit Testing PASS RETEST #1
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing warning Testing issues
ci/iol-compile-arm64-testing success Testing PASS
ci/aws-unit-testing success Unit Testing PASS

Commit Message

Gowrishankar Muthukrishnan May 15, 2025, 8:06 a.m. UTC
This change fixes an uninitialized local variable as reported
in coverity issue 445390.

Coverity-issue: 445390
Fixes: a8ebe94f8cc ("crypto/cnxk: support EdDSA")
Cc: stable@dpdk.org

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
 drivers/crypto/cnxk/cnxk_ae.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Gowrishankar Muthukrishnan May 15, 2025, 11:39 a.m. UTC | #1
Dispatcher unit test failed which is unrelated to this patch and looks like infrastructure issue.

Recheck-request: loongarch-unit-testing

--
Gowrishankar

> This change fixes an uninitialized local variable as reported in coverity issue
> 445390.
> 
> Coverity-issue: 445390
> Fixes: a8ebe94f8cc ("crypto/cnxk: support EdDSA")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
  
Akhil Goyal May 21, 2025, 9:20 a.m. UTC | #2
> > This change fixes an uninitialized local variable as reported in coverity issue
> > 445390.
> >
> > Coverity-issue: 445390
> > Fixes: a8ebe94f8cc ("crypto/cnxk: support EdDSA")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>

Acked-by: Akhil Goyal <gakhil@marvell.com>

Applied to dpdk-next-crypto
Thanks.
  

Patch

diff --git a/drivers/crypto/cnxk/cnxk_ae.h b/drivers/crypto/cnxk/cnxk_ae.h
index 75d6a536ae..8508ab8736 100644
--- a/drivers/crypto/cnxk/cnxk_ae.h
+++ b/drivers/crypto/cnxk/cnxk_ae.h
@@ -191,7 +191,7 @@  static __rte_always_inline int
 cnxk_ae_fill_ec_params(struct cnxk_ae_sess *sess, struct rte_crypto_asym_xform *xform)
 {
 	struct roc_ae_ec_ctx *ec = &sess->ec_ctx;
-	union cpt_inst_w4 w4;
+	union cpt_inst_w4 w4 = {0};
 
 	switch (xform->ec.curve_id) {
 	case RTE_CRYPTO_EC_GROUP_SECP192R1: